diff mbox series

configure: Update --help output for --with-multilib-list

Message ID YUR+V12w21G0HHfz@redhat.com
State Committed
Headers
Series configure: Update --help output for --with-multilib-list |

Commit Message

Jonathan Wakely Sept. 17, 2021, 11:39 a.m. UTC 
  The list of architectures that support the option is incomplete.

gcc/ChangeLog:

	* configure.ac: Fix --with-multilib-list description.
	* configure: Regenerate.

OK for trunk?
commit 630dc3085cbd87a224129177870103e2c4fbf22a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Sep 17 12:34:22 2021

    configure: Update --help output for --with-multilib-list
    
    The list of architectures that support the option is incomplete.
    
    gcc/ChangeLog:
    
            * configure.ac: Fix --with-multilib-list description.
            * configure: Regenerate.

Comments

Jim Wilson Sept. 22, 2021, 10:19 p.m. UTC | #1 
On Fri, Sep 17, 2021 at 4:39 AM Jonathan Wakely via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:

> The list of architectures that support the option is incomplete.
>
> gcc/ChangeLog:
>
>         * configure.ac: Fix --with-multilib-list description.
>         * configure: Regenerate.
>
> OK for trunk?
>

Looks like or1k has --with-multilib-list support also.  I'd suggest adding
that to the list also.  Ok with that change..

Jim
Jonathan Wakely Sept. 23, 2021, 10:36 a.m. UTC | #2 
On Wed, 22 Sept 2021 at 23:19, Jim Wilson wrote:

> On Fri, Sep 17, 2021 at 4:39 AM Jonathan Wakely via Gcc-patches <
> gcc-patches@gcc.gnu.org> wrote:
>
>> The list of architectures that support the option is incomplete.
>>
>> gcc/ChangeLog:
>>
>>         * configure.ac: Fix --with-multilib-list description.
>>         * configure: Regenerate.
>>
>> OK for trunk?
>>
>
> Looks like or1k has --with-multilib-list support also.  I'd suggest adding
> that to the list also.  Ok with that change..
>

Thanks, pushed as r12-3840.

I think doc/install.texi should be updated too then, because that's where I
got the list of targets that support it. OR1K isn't there.
Jonathan Wakely Sept. 23, 2021, 10:43 a.m. UTC | #3 
On Thu, 23 Sept 2021 at 11:36, Jonathan Wakely wrote:

> On Wed, 22 Sept 2021 at 23:19, Jim Wilson wrote:
>
>> On Fri, Sep 17, 2021 at 4:39 AM Jonathan Wakely via Gcc-patches <
>> gcc-patches@gcc.gnu.org> wrote:
>>
>>> The list of architectures that support the option is incomplete.
>>>
>>> gcc/ChangeLog:
>>>
>>>         * configure.ac: Fix --with-multilib-list description.
>>>         * configure: Regenerate.
>>>
>>> OK for trunk?
>>>
>>
>> Looks like or1k has --with-multilib-list support also.  I'd suggest
>> adding that to the list also.  Ok with that change..
>>
>
> Thanks, pushed as r12-3840.
>
> I think doc/install.texi should be updated too then, because that's where
> I got the list of targets that support it. OR1K isn't there.
>

And it's not just as simple as adding or1k*-*-* because it needs to list
"the accepted values and meaning" for or1k. The accepted values are:

mcmov | msext | msfimm | \
mror | mrori | \
mhard-float | mdouble-float | munordered-float | msoft-float | \
mhard-div | mhard-mul | \
msoft-div | msoft-mul )
diff mbox series

Patch

diff --git a/gcc/configure.ac b/gcc/configure.ac
index fadd34dbbb6..838d2d6d122 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1169,7 +1169,7 @@  if test "x$enable_offload_defaulted" = xyes; then
 fi
 
 AC_ARG_WITH(multilib-list,
-[AS_HELP_STRING([--with-multilib-list], [select multilibs (AArch64, SH and x86-64 only)])],
+[AS_HELP_STRING([--with-multilib-list], [select multilibs (AArch64, ARM, RISC-V, SH and x86-64 only)])],
 :,
 with_multilib_list=default)