[v2] NEWS: Mention renamed libresolv symbols moved into libc

Message ID 874kcnn6d7.fsf@oldenburg.str.redhat.com
State Committed
Headers
Series [v2] NEWS: Mention renamed libresolv symbols moved into libc |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Florian Weimer July 21, 2021, 1:28 p.m. UTC
  ---
 NEWS | 7 +++++++
 1 file changed, 7 insertions(+)
  

Comments

Carlos O'Donell July 29, 2021, 2:23 a.m. UTC | #1
On 7/21/21 9:28 AM, Florian Weimer via Libc-alpha wrote:
> ---
>  NEWS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/NEWS b/NEWS
> index 4df348cce5..8f80a35bbe 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -107,6 +107,13 @@ Deprecated and removed features, and other changes affecting compatibility:
>    ns_format_ttl, ns_makecanon, ns_parse_ttl, ns_samedomain, ns_samename,
>    ns_sprintrr, ns_sprintrrf, ns_subdomain have been deprecated.
>  
> +* The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok,
> +  __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery,
> +  __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok,
> +  __res_query, __res_querydomain, __res_search, __res_send formerly in
> +  libresolv have been renamed and no longer have a __ prefix.  They are
> +  now available in libc.

This needs a reason statement. The previous paragraph has a good example
of this e.g. "Various rarely-used functions ... have been deprecated."

We need a reason here like:

* Various symbols previously defined in libresolv have been moved to libc
  in order to prepare for libresolv moving entirely into libc (see earlier
  entry for merging libraries into libc). ...

Looking forward to a v2.

> +
>  * The pthread cancellation handler is now installed with SA_RESTART and
>    pthread_cancel will always send the internal SIGCANCEL on a cancellation
>    request.  It should not be visible to application since the cancellation
>
  

Patch

diff --git a/NEWS b/NEWS
index 4df348cce5..8f80a35bbe 100644
--- a/NEWS
+++ b/NEWS
@@ -107,6 +107,13 @@  Deprecated and removed features, and other changes affecting compatibility:
   ns_format_ttl, ns_makecanon, ns_parse_ttl, ns_samedomain, ns_samename,
   ns_sprintrr, ns_sprintrrf, ns_subdomain have been deprecated.
 
+* The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok,
+  __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery,
+  __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok,
+  __res_query, __res_querydomain, __res_search, __res_send formerly in
+  libresolv have been renamed and no longer have a __ prefix.  They are
+  now available in libc.
+
 * The pthread cancellation handler is now installed with SA_RESTART and
   pthread_cancel will always send the internal SIGCANCEL on a cancellation
   request.  It should not be visible to application since the cancellation