diff mbox series

[v3] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]

Message ID 20210728074225.3949333-1-siddhesh@sourceware.org
State Committed
Commit 4aedc25f55eda50010f2932fdb0a533db6f89f61
Headers
Series [v3] __cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524] |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit fail Patch series failed to apply

Commit Message

Siddhesh Poyarekar July 28, 2021, 7:42 a.m. UTC 
  Abort in the unlikely event that allocation fails when trying to
register a TLS destructor.
---
 stdlib/cxa_thread_atexit_impl.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Florian Weimer July 28, 2021, 7:46 a.m. UTC | #1 
* Siddhesh Poyarekar:

> Abort in the unlikely event that allocation fails when trying to
> register a TLS destructor.

Okay, thanks.

Florian
diff mbox series

Patch

diff --git a/stdlib/cxa_thread_atexit_impl.c b/stdlib/cxa_thread_atexit_impl.c
index 577ed30931..fa6901a3a6 100644
--- a/stdlib/cxa_thread_atexit_impl.c
+++ b/stdlib/cxa_thread_atexit_impl.c
@@ -72,6 +72,7 @@ 
    is not very different from a case where __call_tls_dtors is called after
    _dl_close_worker on the DSO and hence is an accepted execution.  */
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <ldsodefs.h>
 
@@ -104,6 +105,9 @@  __cxa_thread_atexit_impl (dtor_func func, void *obj, void *dso_symbol)
 
   /* Prepend.  */
   struct dtor_list *new = calloc (1, sizeof (struct dtor_list));
+  if (__glibc_unlikely (new == NULL))
+    __libc_fatal ("Fatal glibc error: failed to register TLS destructor: "
+		  "out of memory\n");
   new->func = func;
   new->obj = obj;
   new->next = tls_dtor_list;