diff mbox series

Remove obsolete comments/name from acos-inputs, since slow path was removed.

Message ID 20210726124326.2365779-1-Paul.Zimmermann@inria.fr
State Committed
Commit 4165dd2e9562a586865f3032a91958cec40c4692
Delegated to: Paul Zimmermann
Headers
Series Remove obsolete comments/name from acos-inputs, since slow path was removed. |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Paul Zimmermann July 26, 2021, 12:43 p.m. UTC 
  ---
 benchtests/acos-inputs | 3 ---
 1 file changed, 3 deletions(-)

Comments

Siddhesh Poyarekar July 26, 2021, 1:02 p.m. UTC | #1 
On 7/26/21 6:13 PM, Paul Zimmermann wrote:
> ---

LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

>   benchtests/acos-inputs | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/benchtests/acos-inputs b/benchtests/acos-inputs
> index c90dba57ca..540f88dd09 100644
> --- a/benchtests/acos-inputs
> +++ b/benchtests/acos-inputs
> @@ -2701,9 +2701,6 @@
>   0x1.eb1881275a5fap-1
>   0x1.e5a3c6b686c17p-1
>   -0x1.5abd34f01cc55p-25
> -# acos multiple precision fallback.
> -# Implemented in __cos32 in sysdeps/ieee754/dbl-64/sincos32.c
> -## name: slow
>   0x1.91744378d312fp-25
>   0x1.e31933dfcae5ep-6
>   0x1.560a94c69898dp-28
>
Paul Zimmermann July 26, 2021, 1:28 p.m. UTC | #2 
thanks Siddhesh, I'll commit after the 2.34 release (and propose similar
patches for other functions where the slow path was removed).

Paul

> From: Siddhesh Poyarekar <siddhesh@gotplt.org>
> Date: Mon, 26 Jul 2021 18:32:01 +0530
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
>  Thunderbird/78.11.0
> 
> On 7/26/21 6:13 PM, Paul Zimmermann wrote:
> > ---
> 
> LGTM.
> 
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
> 
> >   benchtests/acos-inputs | 3 ---
> >   1 file changed, 3 deletions(-)
> > 
> > diff --git a/benchtests/acos-inputs b/benchtests/acos-inputs
> > index c90dba57ca..540f88dd09 100644
> > --- a/benchtests/acos-inputs
> > +++ b/benchtests/acos-inputs
> > @@ -2701,9 +2701,6 @@
> >   0x1.eb1881275a5fap-1
> >   0x1.e5a3c6b686c17p-1
> >   -0x1.5abd34f01cc55p-25
> > -# acos multiple precision fallback.
> > -# Implemented in __cos32 in sysdeps/ieee754/dbl-64/sincos32.c
> > -## name: slow
> >   0x1.91744378d312fp-25
> >   0x1.e31933dfcae5ep-6
> >   0x1.560a94c69898dp-28
> > 
> 
>
Siddhesh Poyarekar July 26, 2021, 2:45 p.m. UTC | #3 
On 7/26/21 6:58 PM, Paul Zimmermann wrote:
> thanks Siddhesh, I'll commit after the 2.34 release (and propose similar
> patches for other functions where the slow path was removed).

This should be safe for 2.34 too since it doesn't touch any library 
code.  What do you think Carlos?

Siddhesh
diff mbox series

Patch

diff --git a/benchtests/acos-inputs b/benchtests/acos-inputs
index c90dba57ca..540f88dd09 100644
--- a/benchtests/acos-inputs
+++ b/benchtests/acos-inputs
@@ -2701,9 +2701,6 @@ 
 0x1.eb1881275a5fap-1
 0x1.e5a3c6b686c17p-1
 -0x1.5abd34f01cc55p-25
-# acos multiple precision fallback.
-# Implemented in __cos32 in sysdeps/ieee754/dbl-64/sincos32.c
-## name: slow
 0x1.91744378d312fp-25
 0x1.e31933dfcae5ep-6
 0x1.560a94c69898dp-28