Message ID | 20210503212206.1699908-1-lamm@linux.ibm.com |
---|---|
State | Committed |
Commit | 709e3709a02636fb9ce79fad727b09140989864c |
Delegated to: | Carlos O'Donell |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00F233950436; Mon, 3 May 2021 21:22:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00F233950436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620076933; bh=p0jvG9jraHTAYtReXXkLs6oM6xy0xvBEeveZ0e2Alf4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=SrqaabMd4aYGh2zJwpuvKIHQGNs8H9A2iVcATd3Hk9RrouSNK/TejfpLcDZq2LF8b ZQpJQ/XB5/zbhJ1+/0JSotFvqnsLj/xsvO8DZI3oLtGaDtvw1W/0IOm8Xq362q46gg xRa4Ra1Buqvv1G4p4vY0gqNes/BJMGWizk7k3psY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 997B0393BC37 for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 997B0393BC37 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 143L3I6A092610 for <libc-alpha@sourceware.org>; Mon, 3 May 2021 17:22:10 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com with ESMTP id 38arfert7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <libc-alpha@sourceware.org>; Mon, 03 May 2021 17:22:10 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 143LDTTR004251 for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:09 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma03wdc.us.ibm.com with ESMTP id 388xma0wvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <libc-alpha@sourceware.org>; Mon, 03 May 2021 21:22:09 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 143LM8ZL36045304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:09 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C8B9A78060 for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:08 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63BD67805F for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:08 +0000 (GMT) Received: from localhost (unknown [9.85.154.44]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP for <libc-alpha@sourceware.org>; Mon, 3 May 2021 21:22:08 +0000 (GMT) To: libc-alpha@sourceware.org Subject: [PATCH] testrun.sh: Improve --help message Date: Mon, 3 May 2021 18:22:06 -0300 Message-Id: <20210503212206.1699908-1-lamm@linux.ibm.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mlsqjM7yT40Btu5nmDJLbhL8wV_QhO1R X-Proofpoint-GUID: mlsqjM7yT40Btu5nmDJLbhL8wV_QhO1R X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-03_19:2021-05-03, 2021-05-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=793 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105030145 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: "Lucas A. M. Magalhaes via Libc-alpha" <libc-alpha@sourceware.org> Reply-To: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
testrun.sh: Improve --help message
|
|
Commit Message
Lucas A. M. Magalhaes
May 3, 2021, 9:22 p.m. UTC
The testrun.sh --help message was missing the "container" option. Besides just adding the missing option I decide to rewrite it in the same layout as other tools. --- Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Comments
On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote: > The testrun.sh --help message was missing the "container" option. > Besides just adding the missing option I decide to rewrite it in the > same layout as other tools. LGTM. Reviewed-by: Carlos O'Donell <carlos@redhat.com> > --- > Makefile | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 50f99ca611..242d36de91 100644 > --- a/Makefile > +++ b/Makefile > @@ -144,8 +144,13 @@ builddir=`dirname "$$0"` > GCONV_PATH="$${builddir}/iconvdata" > > usage () { > - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1 > - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1 > +cat << EOF > +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...] > + > + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or > + container. The container will run within support/test-container. > +EOF > + > exit 1 > } > >
Hi Carlos. Can you push this for me? Quoting Carlos O'Donell (2021-05-10 10:39:57) > On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote: > > The testrun.sh --help message was missing the "container" option. > > Besides just adding the missing option I decide to rewrite it in the > > same layout as other tools. > > LGTM. > > Reviewed-by: Carlos O'Donell <carlos@redhat.com> > > > --- > > Makefile | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 50f99ca611..242d36de91 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -144,8 +144,13 @@ builddir=`dirname "$$0"` > > GCONV_PATH="$${builddir}/iconvdata" > > > > usage () { > > - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1 > > - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1 > > +cat << EOF > > +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...] > > + > > + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or > > + container. The container will run within support/test-container. > > +EOF > > + > > exit 1 > > } > > > > > > > -- > Cheers, > Carlos. >
On 5/11/21 5:49 PM, Lucas A. M. Magalhaes via Libc-alpha wrote: > Hi Carlos. Can you push this for me? > I've pushed this now. Siddhesh
diff --git a/Makefile b/Makefile index 50f99ca611..242d36de91 100644 --- a/Makefile +++ b/Makefile @@ -144,8 +144,13 @@ builddir=`dirname "$$0"` GCONV_PATH="$${builddir}/iconvdata" usage () { - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1 - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1 +cat << EOF +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...] + + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or + container. The container will run within support/test-container. +EOF + exit 1 }