Message ID | 20210408085827.5369-1-szabolcs.nagy@arm.com |
---|---|
State | Committed |
Commit | 2d690bbb17f0eed223af74966d7ff012a713dd29 |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A4343944433; Thu, 8 Apr 2021 08:58:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A4343944433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617872333; bh=PLfYb+htzWsynthVTqE55uMS2rJ+qWqCmwZwNMzSKqs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZqHEslrFcIvIGHO21blWRgt7kwLIpiZ9E7JiNxa9mVdfpnabw/qVL406GaQ83eM9t GEqTGyCc1LB6CgcCOTCGzQe7/9fTdWfUquTz6GhrKIhNgVCfwwi1JDc0glTxSoSMJl Y/abm2I4Q/3QxQSupuDNJJv2vU989c7gs/txcNnk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by sourceware.org (Postfix) with ESMTPS id 519B93942001 for <libc-alpha@sourceware.org>; Thu, 8 Apr 2021 08:58:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 519B93942001 Received: from AS8PR04CA0172.eurprd04.prod.outlook.com (2603:10a6:20b:331::27) by AM0PR08MB5346.eurprd08.prod.outlook.com (2603:10a6:208:18b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 08:58:48 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::f5) by AS8PR04CA0172.outlook.office365.com (2603:10a6:20b:331::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 08:58:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 08:58:48 +0000 Received: ("Tessian outbound 34291f7cb530:v90"); Thu, 08 Apr 2021 08:58:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: bbb593bd65d462e9 X-CR-MTA-TID: 64aa7808 Received: from 174875370f41.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1336AB2-31FE-4DC7-AF62-251A434215F1.1; Thu, 08 Apr 2021 08:58:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 174875370f41.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Apr 2021 08:58:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+Igi2tQrbSIthMh6uR5h9L5uTNhAO/Z+cz7kEOKC6MO+co8IluXolFkKOIM/hNEWlSgyWIM88OrBKDEXSQbdcYU5/jgrgsMV1y6UDu96QwW4iHNMNGysjey0noFFswPPQ2GGVnP7jW0gZD87ag/KiPhET1lZ3tb1ujOW81Pd8SvhxHRauaWSwoKBwRG/Zbc7tvCgXlwPz8r47mvxp/U8WinOzt9l6WNFKPUKUifopzsobZ2NZy1FeU+9IBNpFeaB+MV4kIFzxNZQdUs7BrtRv2ofxZJOaY5jgj2NHbv/SgWKojdHQ/8JOScCyyxjhHjYhpslFvB/P/Cwu2g7JqWWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLfYb+htzWsynthVTqE55uMS2rJ+qWqCmwZwNMzSKqs=; b=Rl0gx7s9yDla6KIGZWTDvl6dwlT9CF2GihdfpGUs/cSNR4C+tqoJYM1fxof28cHbPCnfjXGlbqfv0apS31OBYPWCRfSFgtygWySwnwyv15BmijrTuCRXM7OJP8OD/XxTqd1vyXmohTHmpaMyAcUfS7qQs4Z6yBvoajwzMEZzKFbmGpMTKN0GyiCOd+GYjPLEvuYbcfSilwJ8qjQJ28bh8hzCdBf8Yl/Qeoc479G40ZLONUbkWG17FK4v6E4pKlSTMkzwcCsHIqihk/+kSJNU3exIo71sUZD7HKiM/iDz+1Ldb6YkAVf+lRLIn1ixPOiWTiuZl7Mx88AfRNDtBvI9ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PAXPR08MB6333.eurprd08.prod.outlook.com (2603:10a6:102:12c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 08:58:39 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4020.017; Thu, 8 Apr 2021 08:58:38 +0000 To: libc-alpha@sourceware.org Subject: [COMMITTED] arm: update libm test ulps Date: Thu, 8 Apr 2021 09:58:27 +0100 Message-Id: <20210408085827.5369-1-szabolcs.nagy@arm.com> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: SN7PR04CA0214.namprd04.prod.outlook.com (2603:10b6:806:127::9) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.54) by SN7PR04CA0214.namprd04.prod.outlook.com (2603:10b6:806:127::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Thu, 8 Apr 2021 08:58:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83a2ec5a-c8ba-4d1a-0817-08d8fa6c85f4 X-MS-TrafficTypeDiagnostic: PAXPR08MB6333:|AM0PR08MB5346: X-Microsoft-Antispam-PRVS: <AM0PR08MB5346A4290630E602EAEFD678ED749@AM0PR08MB5346.eurprd08.prod.outlook.com> x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 80dBh9gif6qA/mtP8f+zBsPFmNENRdAexOZuNT1/Ruk8h3oVwhkjWyfrJof1dKlgQYFA2pI3mAlgo/wuI1hXcFbq98n6uHQrzjUXRWu0QZ0O413VXtC0XH7m6g7q3OY+QCMI3pz0ASej2VEpjr6C78DxnycuLBRphD+BnLZeVhal8OoP8GaQhxZBd5NemoLMpjKoLzf2qMK3kjZ6LXWax+Nl7TPQts9sOzIFco5lOaBvXMWM+pGX2wDMWkWLjy8dfYHY/7AUxXfG+ox6H5Wh8AOakQGQ6C3fZY7O3x0OCUpN6v7xI4i1sLG7sxiznvIf+v+jsT7XLBcbOjBIzKzXNoncG6l9QJVQ10tXSSWp1uTPVPoWx83hWHl9SrLO5Px27cAD8BukmowTqaUe7Yf3D9T9a/ZYVXlSZNZuk2xZKelb/V9nVekpnYNRjKIxDt5aaRmUD+yywEbgP6IMXNKCjWor6NWo8fRmCIsydaFqh+sI2fo2V/Ra+frZKoY1ZptdkK8oNaIbPmidnn2qFZ7qQcztKgFs+PkyWhODNxzGRAlhcHqz9Oucsz/smgeetOOHX/FzhX0ZakIihOH7miPLH0hmywMqJ13ijpjAWL01YDCVxjU71C+blWT/wjAyjnvnwok/J/iDuGTgFq2wdDoNy29R1AJ4xSfJcknw/Gbh/1GN/qjldYyzbLFWMB+OUDIutIGCGFyABfS3i1G++m+b/0lTWP5HAiKQU4bzOyeVSVo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(478600001)(38350700001)(16526019)(1076003)(316002)(186003)(38100700001)(26005)(15650500001)(6506007)(5660300002)(52116002)(66556008)(69590400012)(6916009)(2616005)(66946007)(8936002)(86362001)(956004)(66476007)(8676002)(6666004)(83380400001)(6486002)(36756003)(2906002)(6512007)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: XZze4AWihYLhs+aH0Y20iA32TJbqR/NFBXIyJVXim0AYUp/gionCYhxBru9At8i+nZVKwZ1bw6sew4h6to9NXsOJFWDtf2KUDfJ3SDofxMFqE68+bRxTDZlcUsrx8bcddpPxfaJH62mh65ewY5zmjnz4fW5KqswpMzIm8yARLi6iPsd7qt249hjf8EQXeqP6jWk93CZIVZosq9+Af8K/WAWTS3sFO3ZoPMuost2yRgGOxVVkAT7sLZe5ObmdvtYoBLZSJliFBMkISM78L8Gil155n7t0U80fk2wiR4XH+o6ytSUxeC4Vqa7SwRErdqsXZQrfURw/v4QSWGRSFG9cuWBL5mohhDNjR/02zCjHZVS06tyBR52taqEmLT2eX3EOE4zKN4dT4Wg/SW7jFqxn45+mjxqKOPLegz4aDUsLguwSoWUtSdKKQY3oKul0xZi6DGb46SRLr3rITRcGSUN1s7tmE0IdH/iEJcpDZuwf5zRzzVMKDJt/4EhSdN19VoX3rT9+j4eI8RNX5gROJRL1JxyRK+mUJFf3kjSZwR+HFhdtK/hca+A6PZBjy/rCFp168rIIBUzTEF8QxN8/K6+Dhz5yvC3AqQKonuxTla4U7ukaxt33JgxghZPDWD60JK9Nqc0q4Nid1cJr0YBBHZhe+Y9/2vvpnlGN9khqMguKDJQNPkat+kmYZVfLbxkLkUENvth6EMyDVBJZ3TjIcsNNiNYKpaRIR1n/PgSHGe6oGaDpmzh8tYgrfB7nx9XCiiAUxKrJM+6DHQOvV50uPfjBl+9Ycls4+GXbAqESCbIw1C/7hVtQSYx+4uqcazZMKlDb7QYQ6I9YEIOk/xmYRc7hAwPTmEPajdYeV2fzuEJTh10AZ6LtF0E4BxzkNvOzuExDkZjHw+ylo0kG99hsN0El14HEymYoRykj2V0nLQzxCwzlo5WIMDq1t9hpbTIebSn5UZCbUcUAXv5TqpZS+0IY8CHZ8oT24wyFjSj+eQ0HBzf5LmJ02UVMOVelQQB8fIyxE9vJRScGiKcDYdNeTfsNj9zQ4zC1tSholaIw+G/AxHntiDj1Ft9K0urjoVsf6O+7Srj3fa6Od6jbayU+tEjiDu2RCrwY00iS2pcNAknK+qH3DT/JUqRdlV7OJaPtPruEdBLAFdGmrO9vou+VSEec2syfAs3FNnvxNkK5ASV9xylUIsHs04UrXoyJXgBXUNwLm4WFOs/tgMPlwFbR4SuFvW6jEOPlEWYD/dNYW2fhCpsGfv3dWio/wHfWzr9eHYDyD+rLhoogwTA6WeKHFTcJjkGr7/ONaEodt3v+wUkZ8Ic3LjA2zgrWcuVYqDfGWuQl X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6333 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 04833bdb-32b6-4e90-34f7-08d8fa6c8005 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RCPCP1S7hveXD48SHAYTEFr/5GnXahHewz4zKx5O+qBCNn0NxMpt8KuHlBKliEzuPVMqLE/h57IjzZTSE/mrBwdFM4K4IsCFQh6FbN/I5nJhPvLjq/+mwEyjRFdjP/nVJP5mhtXlEowMzZq/NDacVGlSPw+XrbR3TCSvIjzF8bxvGhXYZ4oBiK20vDpxx62CR075qMsVrAYfZC2XQKe4gBfhxeXltHEAjX5jnb+aOznnhmwT8Q78bm1s7NC/19H/ypIEshVAeIx9hZ0d0xRV0sx6w4rQb3jGy41DpQ1Q1CqArEdPuf2Ua2UcZMDLYTKnc96NY2zhWFi+HBCIf8X6Wp+SjDm0wQs2SDT43fxm05n34vK9AeRSTI0DXY5XO4pQFmaFKmW309SjJsb7cFJj88xppqm6phSMbn0hwh/nrb5Sw7zg2aLrioL5mjXwQ0gNImF62y2PlGbnvRJNiE03AWWToiDuO/J+UIyeIipweVRi4sSVvMh7JI07k++sH1ZrIlU4yv+fvkHAgPL8JUBbHqJeTdtbe9HHWiNScfNBviqFWOX2M90/+rjh3FLBTctEzE8x6DxTnWdUdgQCQWxXM2V1A2/40KvDvaO6WfWGo4AfreUWdfreEFieNOn/4EYOtEUxknD20SU1jO4AK5SyO1+7h3FHOHLOh/BnxP0AFSWm6HCilQI6JStfWgawrB54 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966006)(36840700001)(6512007)(336012)(36860700001)(44832011)(6506007)(86362001)(83380400001)(82310400003)(2906002)(16526019)(8936002)(186003)(6916009)(1076003)(2616005)(956004)(70206006)(81166007)(47076005)(36756003)(26005)(316002)(15650500001)(70586007)(82740400003)(69590400012)(5660300002)(8676002)(356005)(6666004)(478600001)(6486002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 08:58:48.2417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83a2ec5a-c8ba-4d1a-0817-08d8fa6c85f4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5346 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Szabolcs Nagy <szabolcs.nagy@arm.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
[COMMITTED] arm: update libm test ulps
|
|
Commit Message
Szabolcs Nagy
April 8, 2021, 8:58 a.m. UTC
Updated after commits 9acda61d94acc5348c2330f2519a14d1a4a37e73 and 43576de04afc6a0896a3ecc094e1581069a0652a. --- sysdeps/arm/libm-test-ulps | 50 +++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 25 deletions(-)
Comments
On 4/8/21 1:58 AM, Szabolcs Nagy via Libc-alpha wrote: > Updated after commits 9acda61d94acc5348c2330f2519a14d1a4a37e73 > and 43576de04afc6a0896a3ecc094e1581069a0652a. Is there a better way for this to be done at the time of original change other than running the tests on all affected architectures. arches always seem to be chasing these kind of changes ... > --- > sysdeps/arm/libm-test-ulps | 50 +++++++++++++++++++------------------- > 1 file changed, 25 insertions(+), 25 deletions(-) > > diff --git a/sysdeps/arm/libm-test-ulps b/sysdeps/arm/libm-test-ulps > index cdb635ee3d..f7e6046da4 100644 > --- a/sysdeps/arm/libm-test-ulps > +++ b/sysdeps/arm/libm-test-ulps > @@ -851,35 +851,35 @@ double: 1 > > Function: "j0": > double: 2 > -float: 8 > +float: 9 > > Function: "j0_downward": > -double: 2 > -float: 4 > +double: 5 > +float: 9 [snip]
The 04/11/2021 18:04, Vineet Gupta wrote: > On 4/8/21 1:58 AM, Szabolcs Nagy via Libc-alpha wrote: > > Updated after commits 9acda61d94acc5348c2330f2519a14d1a4a37e73 > > and 43576de04afc6a0896a3ecc094e1581069a0652a. > > Is there a better way for this to be done at the time of original change > other than running the tests on all affected architectures. arches > always seem to be chasing these kind of changes ... i think there are only small variations between targets for float and double, so the ulp error limits for those could be shared (unless a target has its own implementation with different quality requirement for some reason). long double is more target specific. i think the tests could be organised such that each sysdeps/ieee754/* directory has its own ulp limits file and the target picks up the right one. and libmvec needs target specific ulp limits. i don't know how hard it would be to implement this.
On 13/04/2021 06:52, Szabolcs Nagy wrote: > The 04/11/2021 18:04, Vineet Gupta wrote: >> On 4/8/21 1:58 AM, Szabolcs Nagy via Libc-alpha wrote: >>> Updated after commits 9acda61d94acc5348c2330f2519a14d1a4a37e73 >>> and 43576de04afc6a0896a3ecc094e1581069a0652a. >> >> Is there a better way for this to be done at the time of original change >> other than running the tests on all affected architectures. arches >> always seem to be chasing these kind of changes ... > > i think there are only small variations between targets for > float and double, so the ulp error limits for those could be > shared (unless a target has its own implementation with > different quality requirement for some reason). > > long double is more target specific. i think the tests could > be organised such that each sysdeps/ieee754/* directory has > its own ulp limits file and the target picks up the right one. > > and libmvec needs target specific ulp limits. > > i don't know how hard it would be to implement this. > The math/libm-test-support.c imposes maximum ulp limits depending of the underling type: 228 if (testing_ibm128) 229 /* The documented accuracy of IBM long double division is 3ulp 230 (see libgcc/config/rs6000/ibm-ldouble-format), so do not 231 require better accuracy for libm functions that are exactly 232 defined for other formats. */ 233 max_valid_error = exact ? 3 : 16; 234 else 235 max_valid_error = exact ? 0 : 9; And if I recall correctly there was a suggestion to consolidate and/or remove the ulps file altogether and use the maximum valid error as the threshold to report regressions. The only drawback I see of moving towards it is each architecture won't see if some change has degraded the function precision. But I tend to agree that using per-architecture ulp files do not add much, since arch maintainer tend todig into the precision issues only when it is higher the the tests threshold.
On Tue, 13 Apr 2021, Adhemerval Zanella via Libc-alpha wrote: > The math/libm-test-support.c imposes maximum ulp limits depending of > the underling type: > > 228 if (testing_ibm128) > 229 /* The documented accuracy of IBM long double division is 3ulp > 230 (see libgcc/config/rs6000/ibm-ldouble-format), so do not > 231 require better accuracy for libm functions that are exactly > 232 defined for other formats. */ > 233 max_valid_error = exact ? 3 : 16; > 234 else > 235 max_valid_error = exact ? 0 : 9; > > And if I recall correctly there was a suggestion to consolidate and/or > remove the ulps file altogether and use the maximum valid error as the > threshold to report regressions. The only drawback I see of moving > towards it is each architecture won't see if some change has degraded > the function precision. And for some of the higher ulps values it might be good to improve the precision, which suggests having at least per-format if not per-architecture empirical bounds for each function.
diff --git a/sysdeps/arm/libm-test-ulps b/sysdeps/arm/libm-test-ulps index cdb635ee3d..f7e6046da4 100644 --- a/sysdeps/arm/libm-test-ulps +++ b/sysdeps/arm/libm-test-ulps @@ -851,35 +851,35 @@ double: 1 Function: "j0": double: 2 -float: 8 +float: 9 Function: "j0_downward": -double: 2 -float: 4 +double: 5 +float: 9 Function: "j0_towardzero": -double: 4 -float: 5 +double: 6 +float: 9 Function: "j0_upward": -double: 4 -float: 5 +double: 9 +float: 9 Function: "j1": -double: 2 +double: 4 float: 9 Function: "j1_downward": -double: 3 -float: 5 +double: 5 +float: 8 Function: "j1_towardzero": -double: 3 -float: 2 +double: 4 +float: 8 Function: "j1_upward": -double: 3 -float: 5 +double: 9 +float: 9 Function: "jn": double: 4 @@ -1074,7 +1074,7 @@ double: 9 float: 8 Function: "tgamma_downward": -double: 8 +double: 9 float: 7 Function: "tgamma_towardzero": @@ -1087,35 +1087,35 @@ float: 8 Function: "y0": double: 3 -float: 8 +float: 9 Function: "y0_downward": double: 3 -float: 6 +float: 9 Function: "y0_towardzero": -double: 3 -float: 3 +double: 4 +float: 9 Function: "y0_upward": double: 3 -float: 6 +float: 9 Function: "y1": double: 3 -float: 2 +float: 9 Function: "y1_downward": -double: 3 -float: 2 +double: 6 +float: 9 Function: "y1_towardzero": double: 3 -float: 2 +float: 9 Function: "y1_upward": double: 7 -float: 2 +float: 9 Function: "yn": double: 3