tst: Provide test for sched_rr_get_interval
Commit Message
This change adds new test to assess sched_rr_get_interval's
functionality.
To be more specific - following use cases are checked:
- If the read interval is correct
- If the proper ABI is used - to check if adjacent data is not
overwritten
---
posix/Makefile | 2 +-
posix/tst-sched_rr_get_interval.c | 53 +++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 posix/tst-sched_rr_get_interval.c
Comments
Dear Community,
> This change adds new test to assess sched_rr_get_interval's
> functionality.
>
> To be more specific - following use cases are checked:
> - If the read interval is correct
> - If the proper ABI is used - to check if adjacent data is not
> overwritten
Gentle ping on this patch...
> ---
> posix/Makefile | 2 +-
> posix/tst-sched_rr_get_interval.c | 53
> +++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+), 1
> deletion(-) create mode 100644 posix/tst-sched_rr_get_interval.c
>
> diff --git a/posix/Makefile b/posix/Makefile
> index 956ef7d397..7ef8525500 100644
> --- a/posix/Makefile
> +++ b/posix/Makefile
> @@ -102,7 +102,7 @@ tests := test-errno tstgetopt
> testfnm runtests runptests \ tst-sysconf-empty-chroot
> tst-glob_symlinks tst-fexecve \ tst-glob-tilde test-ssize-max
> tst-spawn4 bug-regex37 \ bug-regex38 tst-regcomp-truncated
> tst-spawn-chdir \
> - tst-wordexp-nocmd
> + tst-wordexp-nocmd tst-sched_rr_get_interval
> tests-internal := bug-regex5 bug-regex20 bug-regex33 \
> tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
> tst-glob_lstat_compat tst-spawn4-compat
> diff --git a/posix/tst-sched_rr_get_interval.c
> b/posix/tst-sched_rr_get_interval.c new file mode 100644
> index 0000000000..5b15b9dd09
> --- /dev/null
> +++ b/posix/tst-sched_rr_get_interval.c
> @@ -0,0 +1,53 @@
> +/* Test for sched_rr_get_interval
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be
> useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <time.h>
> +#include <sched.h>
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> + struct timespec ts[2] = { { -1, -1 }, { -1, -1 } };
> + const struct sched_param param = {
> + .sched_priority = sched_get_priority_max (SCHED_RR) - 10,
> + };
> + int result = sched_setscheduler (0, SCHED_RR, ¶m);
> +
> + if (result != 0)
> + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n");
> +
> + result = sched_rr_get_interval (0, ts);
> + if (result != 0)
> + FAIL_EXIT1 ("*** sched_rr_get_interval error: %m\n");
> +
> + /* Check if returned time values are correct. */
> + if (ts[0].tv_sec < 0)
> + FAIL_EXIT1 ("*** Wrong value read tv_sec: %ld\n", ts[0].tv_sec);
> +
> + if (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000)
> + FAIL_EXIT1 ("*** Wrong value read tv_nsec: %ld\n",
> ts[0].tv_nsec); +
> + /* Check if adjacent memory is not overwritten. */
> + if (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1)
> + FAIL_EXIT1 ("*** sched_rr_get_interval caused overwrite!\n");
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On 25/01/2021 07:10, Lukasz Majewski wrote:
> This change adds new test to assess sched_rr_get_interval's
> functionality.
>
> To be more specific - following use cases are checked:
> - If the read interval is correct
> - If the proper ABI is used - to check if adjacent data is not
> overwritten
> ---
> posix/Makefile | 2 +-
> posix/tst-sched_rr_get_interval.c | 53 +++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+), 1 deletion(-)
> create mode 100644 posix/tst-sched_rr_get_interval.c
>
> diff --git a/posix/Makefile b/posix/Makefile
> index 956ef7d397..7ef8525500 100644
> --- a/posix/Makefile
> +++ b/posix/Makefile
> @@ -102,7 +102,7 @@ tests := test-errno tstgetopt testfnm runtests runptests \
> tst-sysconf-empty-chroot tst-glob_symlinks tst-fexecve \
> tst-glob-tilde test-ssize-max tst-spawn4 bug-regex37 \
> bug-regex38 tst-regcomp-truncated tst-spawn-chdir \
> - tst-wordexp-nocmd
> + tst-wordexp-nocmd tst-sched_rr_get_interval
> tests-internal := bug-regex5 bug-regex20 bug-regex33 \
> tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
> tst-glob_lstat_compat tst-spawn4-compat
I think this test should be on xtests instead of returning FAIL_UNSUPPORTED
for a failed sched_setscheduler (SCHED_RR). The unsupported is misleading
here.
> diff --git a/posix/tst-sched_rr_get_interval.c b/posix/tst-sched_rr_get_interval.c
> new file mode 100644
> index 0000000000..5b15b9dd09
> --- /dev/null
> +++ b/posix/tst-sched_rr_get_interval.c
> @@ -0,0 +1,53 @@
> +/* Test for sched_rr_get_interval
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <time.h>
> +#include <sched.h>
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> + struct timespec ts[2] = { { -1, -1 }, { -1, -1 } };
> + const struct sched_param param = {
> + .sched_priority = sched_get_priority_max (SCHED_RR) - 10,
> + };
> + int result = sched_setscheduler (0, SCHED_RR, ¶m);
> +
> + if (result != 0)
> + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n");
> +
> + result = sched_rr_get_interval (0, ts);
> + if (result != 0)
> + FAIL_EXIT1 ("*** sched_rr_get_interval error: %m\n");
I would simplify to just:
TEST_COMPARE (sched_rr_get_internal (0, ts), 0);
(the macros already dumps enough information to debug the issue).
> +
> + /* Check if returned time values are correct. */
> + if (ts[0].tv_sec < 0)
> + FAIL_EXIT1 ("*** Wrong value read tv_sec: %ld\n", ts[0].tv_sec);
TEST_VERIFY_EXIT (ts[0].tv_sec < 0);
> +
> + if (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000)
> + FAIL_EXIT1 ("*** Wrong value read tv_nsec: %ld\n", ts[0].tv_nsec);
TEST_VERIFY_EXIT (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000);
> +
> + /* Check if adjacent memory is not overwritten. */
> + if (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1)
> + FAIL_EXIT1 ("*** sched_rr_get_interval caused overwrite!\n");
TEST_VERIFY_EXIT (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1);
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
>
@@ -102,7 +102,7 @@ tests := test-errno tstgetopt testfnm runtests runptests \
tst-sysconf-empty-chroot tst-glob_symlinks tst-fexecve \
tst-glob-tilde test-ssize-max tst-spawn4 bug-regex37 \
bug-regex38 tst-regcomp-truncated tst-spawn-chdir \
- tst-wordexp-nocmd
+ tst-wordexp-nocmd tst-sched_rr_get_interval
tests-internal := bug-regex5 bug-regex20 bug-regex33 \
tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
tst-glob_lstat_compat tst-spawn4-compat
new file mode 100644
@@ -0,0 +1,53 @@
+/* Test for sched_rr_get_interval
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <time.h>
+#include <sched.h>
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+ struct timespec ts[2] = { { -1, -1 }, { -1, -1 } };
+ const struct sched_param param = {
+ .sched_priority = sched_get_priority_max (SCHED_RR) - 10,
+ };
+ int result = sched_setscheduler (0, SCHED_RR, ¶m);
+
+ if (result != 0)
+ FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n");
+
+ result = sched_rr_get_interval (0, ts);
+ if (result != 0)
+ FAIL_EXIT1 ("*** sched_rr_get_interval error: %m\n");
+
+ /* Check if returned time values are correct. */
+ if (ts[0].tv_sec < 0)
+ FAIL_EXIT1 ("*** Wrong value read tv_sec: %ld\n", ts[0].tv_sec);
+
+ if (ts[0].tv_nsec < 0 || ts[0].tv_nsec >= 1000000000)
+ FAIL_EXIT1 ("*** Wrong value read tv_nsec: %ld\n", ts[0].tv_nsec);
+
+ /* Check if adjacent memory is not overwritten. */
+ if (ts[1].tv_sec != -1 || ts[1].tv_nsec != -1)
+ FAIL_EXIT1 ("*** sched_rr_get_interval caused overwrite!\n");
+
+ return 0;
+}
+
+#include <support/test-driver.c>