| Message ID | cover.1604946656.git.fweimer@redhat.com |
|---|---|
| Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 715BB3870890; Mon, 9 Nov 2020 18:40:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 715BB3870890 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1604947221; bh=/6hm7YDWOBzkOa8M7I/0QtxWMhqLj9zj1/vt2s6v7nk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jznWA/+VxatBDhmqKBqipkTbzZ6CRSbCqFx8WrQMq+Vuh9eEn0HjOx0d3lnI3fZF9 tHT1T0pDN1AsMxS6G39t4vHn6NAbKwXKbnnokD0sARKQkZZ5I6N6KdT1Z9a03NRyKO 2XvaWQ80HzypMbYs9cOtcOyA5nBItGiZj8AdW+WE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E5E31385780C for <libc-alpha@sourceware.org>; Mon, 9 Nov 2020 18:40:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5E31385780C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-T8Pbk2h7PLS3hjhe1qBqSQ-1; Mon, 09 Nov 2020 13:40:14 -0500 X-MC-Unique: T8Pbk2h7PLS3hjhe1qBqSQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E422F1009E3E for <libc-alpha@sourceware.org>; Mon, 9 Nov 2020 18:40:12 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-222.ams2.redhat.com [10.36.113.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B8846EF53 for <libc-alpha@sourceware.org>; Mon, 9 Nov 2020 18:40:12 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH v4 00/11] glibc-hwcaps support Message-Id: <cover.1604946656.git.fweimer@redhat.com> Date: Mon, 09 Nov 2020 19:40:10 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Florian Weimer <fweimer@redhat.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
| Series |
glibc-hwcaps support
|
|
Message
Florian Weimer
Nov. 9, 2020, 6:40 p.m. UTC
This patch series incorporates Adhemerval's feedback. It picks up the suggestion for introducing enum opt_format in ldconfig. It also fixes a a ldconfig bug (wrong size in xmalloc call) uncovered by testing on i686-linux-gnu. I have dropped the s390x patch until I have located a suitable machine on which to test it. We also need to discuss how to achieve GCC alignment there. Patch order is different than before because both the x86_64 and powerpc64le patches contain tests now, including a test that runs the ld.so-based test without special options in the container, to check for ld.so.cache support. The powerpc64le patch aligns the subdirectory selection with GCC. I feel like this series has a reasonable level of test coverage. It does not test all possible permutations (ld.so option combinations and ld.so.cache contents), but I hope that's okay. (Not sure if this actually v4, I sort of lost count.) Thanks, Florian Florian Weimer (11): support: Add support_copy_file elf: Introduce enum opt_format in the ldconfig implementation elf: Add glibc-hwcaps support for LD_LIBRARY_PATH elf: Add endianness markup to ld.so.cache elf: Add extension mechanism to ld.so.cache elf: Implement a string table for ldconfig, with tail merging elf: Implement tail merging of strings in ldconfig elf: Process glibc-hwcaps subdirectories in ldconfig elf: Add glibc-hwcaps subdirectory support to ld.so cache processing x86_64: Add glibc-hwcaps support powerpc64le: Add glibc-hwcaps support elf/Makefile | 90 +++- elf/cache.c | 413 +++++++++++++++--- elf/dl-cache.c | 202 ++++++++- elf/dl-hwcaps-subdirs.c | 29 ++ elf/dl-hwcaps.c | 216 ++++++++- elf/dl-hwcaps.h | 124 ++++++ elf/dl-hwcaps_split.c | 77 ++++ elf/dl-load.c | 7 +- elf/dl-main.h | 11 +- elf/dl-support.c | 5 +- elf/dl-usage.c | 68 ++- elf/ldconfig.c | 164 +++++-- elf/markermodMARKER-VALUE.c | 29 ++ elf/rtld.c | 18 + elf/stringtable.c | 209 +++++++++ elf/stringtable.h | 64 +++ elf/stringtable_free.c | 33 ++ elf/tst-dl-hwcaps_split.c | 139 ++++++ elf/tst-glibc-hwcaps-cache.c | 45 ++ .../etc/ld.so.conf | 2 + elf/tst-glibc-hwcaps-cache.root/postclean.req | 0 elf/tst-glibc-hwcaps-cache.script | 18 + elf/tst-glibc-hwcaps-mask.c | 31 ++ elf/tst-glibc-hwcaps-prepend-cache.c | 133 ++++++ .../postclean.req | 0 elf/tst-glibc-hwcaps-prepend.c | 32 ++ elf/tst-glibc-hwcaps.c | 28 ++ elf/tst-stringtable.c | 141 ++++++ support/Makefile | 1 + support/support.h | 5 + support/support_copy_file.c | 43 ++ sysdeps/generic/dl-cache.h | 233 +++++++++- sysdeps/generic/ldconfig.h | 27 +- sysdeps/generic/ldsodefs.h | 20 +- sysdeps/powerpc/powerpc64/le/Makefile | 28 ++ .../powerpc/powerpc64/le/dl-hwcaps-subdirs.c | 46 ++ .../powerpc/powerpc64/le/tst-glibc-hwcaps.c | 54 +++ sysdeps/x86_64/Makefile | 39 ++ sysdeps/x86_64/dl-hwcaps-subdirs.c | 66 +++ sysdeps/x86_64/tst-glibc-hwcaps.c | 76 ++++ 40 files changed, 2839 insertions(+), 127 deletions(-) create mode 100644 elf/dl-hwcaps-subdirs.c create mode 100644 elf/dl-hwcaps_split.c create mode 100644 elf/markermodMARKER-VALUE.c create mode 100644 elf/stringtable.c create mode 100644 elf/stringtable.h create mode 100644 elf/stringtable_free.c create mode 100644 elf/tst-dl-hwcaps_split.c create mode 100644 elf/tst-glibc-hwcaps-cache.c create mode 100644 elf/tst-glibc-hwcaps-cache.root/etc/ld.so.conf create mode 100644 elf/tst-glibc-hwcaps-cache.root/postclean.req create mode 100644 elf/tst-glibc-hwcaps-cache.script create mode 100644 elf/tst-glibc-hwcaps-mask.c create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.c create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.root/postclean.req create mode 100644 elf/tst-glibc-hwcaps-prepend.c create mode 100644 elf/tst-glibc-hwcaps.c create mode 100644 elf/tst-stringtable.c create mode 100644 support/support_copy_file.c create mode 100644 sysdeps/powerpc/powerpc64/le/dl-hwcaps-subdirs.c create mode 100644 sysdeps/powerpc/powerpc64/le/tst-glibc-hwcaps.c create mode 100644 sysdeps/x86_64/dl-hwcaps-subdirs.c create mode 100644 sysdeps/x86_64/tst-glibc-hwcaps.c
Comments
On Mon, 09 Nov 2020 19:40:10 +0100 Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote: > This patch series incorporates Adhemerval's feedback. It picks up the > suggestion for introducing enum opt_format in ldconfig. > > It also fixes a a ldconfig bug (wrong size in xmalloc call) uncovered by > testing on i686-linux-gnu. > > I have dropped the s390x patch until I have located a suitable machine > on which to test it. We also need to discuss how to achieve GCC > alignment there. Florian, what kind of machine do you need? Dan > Patch order is different than before because both the x86_64 and > powerpc64le patches contain tests now, including a test that runs the > ld.so-based test without special options in the container, to check for > ld.so.cache support. > > The powerpc64le patch aligns the subdirectory selection with GCC. > > I feel like this series has a reasonable level of test coverage. It > does not test all possible permutations (ld.so option combinations and > ld.so.cache contents), but I hope that's okay. > > (Not sure if this actually v4, I sort of lost count.) > > Thanks, > Florian > > Florian Weimer (11): > support: Add support_copy_file > elf: Introduce enum opt_format in the ldconfig implementation > elf: Add glibc-hwcaps support for LD_LIBRARY_PATH > elf: Add endianness markup to ld.so.cache > elf: Add extension mechanism to ld.so.cache > elf: Implement a string table for ldconfig, with tail merging > elf: Implement tail merging of strings in ldconfig > elf: Process glibc-hwcaps subdirectories in ldconfig > elf: Add glibc-hwcaps subdirectory support to ld.so cache processing > x86_64: Add glibc-hwcaps support > powerpc64le: Add glibc-hwcaps support > > elf/Makefile | 90 +++- > elf/cache.c | 413 +++++++++++++++--- > elf/dl-cache.c | 202 ++++++++- > elf/dl-hwcaps-subdirs.c | 29 ++ > elf/dl-hwcaps.c | 216 ++++++++- > elf/dl-hwcaps.h | 124 ++++++ > elf/dl-hwcaps_split.c | 77 ++++ > elf/dl-load.c | 7 +- > elf/dl-main.h | 11 +- > elf/dl-support.c | 5 +- > elf/dl-usage.c | 68 ++- > elf/ldconfig.c | 164 +++++-- > elf/markermodMARKER-VALUE.c | 29 ++ > elf/rtld.c | 18 + > elf/stringtable.c | 209 +++++++++ > elf/stringtable.h | 64 +++ > elf/stringtable_free.c | 33 ++ > elf/tst-dl-hwcaps_split.c | 139 ++++++ > elf/tst-glibc-hwcaps-cache.c | 45 ++ > .../etc/ld.so.conf | 2 + > elf/tst-glibc-hwcaps-cache.root/postclean.req | 0 > elf/tst-glibc-hwcaps-cache.script | 18 + > elf/tst-glibc-hwcaps-mask.c | 31 ++ > elf/tst-glibc-hwcaps-prepend-cache.c | 133 ++++++ > .../postclean.req | 0 > elf/tst-glibc-hwcaps-prepend.c | 32 ++ > elf/tst-glibc-hwcaps.c | 28 ++ > elf/tst-stringtable.c | 141 ++++++ > support/Makefile | 1 + > support/support.h | 5 + > support/support_copy_file.c | 43 ++ > sysdeps/generic/dl-cache.h | 233 +++++++++- > sysdeps/generic/ldconfig.h | 27 +- > sysdeps/generic/ldsodefs.h | 20 +- > sysdeps/powerpc/powerpc64/le/Makefile | 28 ++ > .../powerpc/powerpc64/le/dl-hwcaps-subdirs.c | 46 ++ > .../powerpc/powerpc64/le/tst-glibc-hwcaps.c | 54 +++ > sysdeps/x86_64/Makefile | 39 ++ > sysdeps/x86_64/dl-hwcaps-subdirs.c | 66 +++ > sysdeps/x86_64/tst-glibc-hwcaps.c | 76 ++++ > 40 files changed, 2839 insertions(+), 127 deletions(-) > create mode 100644 elf/dl-hwcaps-subdirs.c > create mode 100644 elf/dl-hwcaps_split.c > create mode 100644 elf/markermodMARKER-VALUE.c > create mode 100644 elf/stringtable.c > create mode 100644 elf/stringtable.h > create mode 100644 elf/stringtable_free.c > create mode 100644 elf/tst-dl-hwcaps_split.c > create mode 100644 elf/tst-glibc-hwcaps-cache.c > create mode 100644 elf/tst-glibc-hwcaps-cache.root/etc/ld.so.conf > create mode 100644 elf/tst-glibc-hwcaps-cache.root/postclean.req > create mode 100644 elf/tst-glibc-hwcaps-cache.script > create mode 100644 elf/tst-glibc-hwcaps-mask.c > create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.c > create mode 100644 elf/tst-glibc-hwcaps-prepend-cache.root/postclean.req > create mode 100644 elf/tst-glibc-hwcaps-prepend.c > create mode 100644 elf/tst-glibc-hwcaps.c > create mode 100644 elf/tst-stringtable.c > create mode 100644 support/support_copy_file.c > create mode 100644 sysdeps/powerpc/powerpc64/le/dl-hwcaps-subdirs.c > create mode 100644 sysdeps/powerpc/powerpc64/le/tst-glibc-hwcaps.c > create mode 100644 sysdeps/x86_64/dl-hwcaps-subdirs.c > create mode 100644 sysdeps/x86_64/tst-glibc-hwcaps.c > > -- > Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, > Commercial register: Amtsgericht Muenchen, HRB 153243, > Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill >
* Dan Horák: >> I have dropped the s390x patch until I have located a suitable machine >> on which to test it. We also need to discuss how to achieve GCC >> alignment there. > > Florian, what kind of machine do you need? z15 with unrestricted user namespaces. z/VM vs KVM should not matter (but it would be nice to test with a typical z/VM setup too). Thanks, Florian
* Florian Weimer via Libc-alpha: > Florian Weimer (11): > support: Add support_copy_file > elf: Introduce enum opt_format in the ldconfig implementation > elf: Add glibc-hwcaps support for LD_LIBRARY_PATH > elf: Add endianness markup to ld.so.cache > elf: Add extension mechanism to ld.so.cache > elf: Implement a string table for ldconfig, with tail merging > elf: Implement tail merging of strings in ldconfig > elf: Process glibc-hwcaps subdirectories in ldconfig > elf: Add glibc-hwcaps subdirectory support to ld.so cache processing > x86_64: Add glibc-hwcaps support > powerpc64le: Add glibc-hwcaps support Ping. I'd like to move this forward. Thanks, Florian
On Wed, Nov 25, 2020 at 7:47 AM Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote: > > * Florian Weimer via Libc-alpha: > > > Florian Weimer (11): > > support: Add support_copy_file > > elf: Introduce enum opt_format in the ldconfig implementation > > elf: Add glibc-hwcaps support for LD_LIBRARY_PATH > > elf: Add endianness markup to ld.so.cache > > elf: Add extension mechanism to ld.so.cache > > elf: Implement a string table for ldconfig, with tail merging > > elf: Implement tail merging of strings in ldconfig > > elf: Process glibc-hwcaps subdirectories in ldconfig > > elf: Add glibc-hwcaps subdirectory support to ld.so cache processing > > x86_64: Add glibc-hwcaps support > > powerpc64le: Add glibc-hwcaps support > > Ping. I'd like to move this forward. > x86_64 bits look good to me. Thanks.
On 25/11/2020 12:46, Florian Weimer via Libc-alpha wrote: > * Florian Weimer via Libc-alpha: > >> Florian Weimer (11): >> support: Add support_copy_file >> elf: Introduce enum opt_format in the ldconfig implementation >> elf: Add glibc-hwcaps support for LD_LIBRARY_PATH >> elf: Add endianness markup to ld.so.cache >> elf: Add extension mechanism to ld.so.cache >> elf: Implement a string table for ldconfig, with tail merging >> elf: Implement tail merging of strings in ldconfig >> elf: Process glibc-hwcaps subdirectories in ldconfig >> elf: Add glibc-hwcaps subdirectory support to ld.so cache processing >> x86_64: Add glibc-hwcaps support >> powerpc64le: Add glibc-hwcaps support > > Ping. I'd like to move this forward. I will try to review this fully until the end this week.