diff mbox series

[v3,06/19] sysv/linux: riscv: Fix dl-cache.h indentation

Message ID	780c989c666abbabca7e13123fe876a3eaa73aef.1594568655.git.alistair.francis@wdc.com
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F209385703D IronPort-SDR: N49KVxPU1uv3K4DYbLeW1zT+PTqeNVUQzrqkuPga9HrPZ4AxzXQeaG5/qHUjvzhzAmzPOmvj4r wosgUeYko5l6AAyM+MBU4Kfja6DKhbag+Y0K8meXNr0bvqQ6VvJDGLrkGJsmhNhcVZPWCCiMUi zo8G9mXWOQ6DUAi0meJizatsUBEFbXZ+mGlqPSa0MAVpRYAsebw6IgEJsoj+gfl+m2CRAhNjir XmLne2qp99GAuma4VDkfiYsrJEIfd3Er7AP+a9ReKm3/92JYYbWfEj4xdi+tYmlUYvlYBz4fmF yeY= IronPort-SDR: gvoKmhF4vkKH1oC20/+tcdq95HIJGiMX2xnrEWhdBTwgi2bbt+D0DcyWurJkm6lOc/6B8RXMRT YEQWQtKkGWr2YhkQVRBSrTNOl1MgnKCds= IronPort-SDR: zUWCxh1mzzRRxOWPSopG7YmAsygU+MGhbwFkkDbYT6vahMz8tsE7Mb4KH8W4CkgvolsjZsXy8x zbUXU+dp4kpQ== WDCIronportException: Internal To: libc-alpha@sourceware.org Subject: [PATCH v3 06/19] sysv/linux: riscv: Fix dl-cache.h indentation Date: Sun, 12 Jul 2020 08:47:36 -0700 Message-Id: <780c989c666abbabca7e13123fe876a3eaa73aef.1594568655.git.alistair.francis@wdc.com> In-Reply-To: <cover.1594568655.git.alistair.francis@wdc.com> References: <cover.1594568655.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alistair Francis <alistair.francis@wdc.com> Cc: alistair.francis@wdc.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org>
Series	glibc port for 32-bit RISC-V (RV32) \| [v3,00/19] glibc port for 32-bit RISC-V (RV32) [v3,01/19] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 [v3,02/19] RISC-V: Cleanup some of the sysdep.h code [v3,03/19] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port [v3,04/19] RISC-V: Add support for 32-bit vDSO calls [v3,05/19] RISC-V: Support dynamic loader for the 32-bit [v3,06/19] sysv/linux: riscv: Fix dl-cache.h indentation [v3,07/19] RISC-V: Add path of library directories for the 32-bit [v3,08/19] RISC-V: Add arch-syscall.h for RV32 [v3,09/19] RISC-V: nptl: update default pthread-offsets.h [v3,10/19] RISC-V: Support the 32-bit ABI implementation [v3,11/19] RISC-V: Hard float support for 32-bit [v3,12/19] RISC-V: Add ABI lists [v3,13/19] RISC-V: Add the RV32 libm-test-ulps [v3,14/19] RISC-V: Fix llrint and llround missing exceptions on RV32 [v3,15/19] RISC-V: Build Infastructure for 32-bit [v3,16/19] riscv32: Specify the arch_minimum_kernel as 5.4 [v3,17/19] RISC-V: Add rv32 path to RTLDLIST in ldd [v3,18/19] Documentation for the RISC-V 32-bit port [v3,19/19] Add RISC-V 32-bit target to build-many-glibcs.py

Commit Message

Alistair Francis July 12, 2020, 3:47 p.m. UTC

  Replace 8 spaces with a tabi and extend the line length in preperation
for the next patch. No functional changes.
---
 sysdeps/unix/sysv/linux/riscv/dl-cache.h | 62 ++++++++++++------------
 1 file changed, 31 insertions(+), 31 deletions(-)

Comments

Maciej W. Rozycki July 16, 2020, 6:31 a.m. UTC | #1

On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote:

> Replace 8 spaces with a tabi and extend the line length in preperation
> for the next patch. No functional changes.

 I don't think this change is needed; there was nothing wrong with the 
original formatting except for this line:

> -  do							    		\

which has a couple of spaces embedded between tabs, and which I haven't 
considered worth fixing on this occassion (there's another such line 
earlier in this file too).  The new version extends beyond 80 columns 
though, and does not follow the GNU coding standard WRT indentation.

 Please drop it then.

  Maciej

diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/riscv/dl-cache.h b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
index c297dfe84f..b3cda4ef9f 100644
--- a/sysdeps/unix/sysv/linux/riscv/dl-cache.h
+++ b/sysdeps/unix/sysv/linux/riscv/dl-cache.h
@@ -38,37 +38,37 @@ 
    so this will add all of those paths.
 
    According to Joseph Myers:
-       My reasoning for that would be: generic autoconf-configured (etc.)
-       software may only know about using the lib directory, so you want the
-       lib directory to be searched regardless of the ABI - but it's also
-       useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
-       architectures and have that automatically imply /usr/local/lib64/lp64d
-       etc. so that libraries can be found that come from software that does
-       use the ABI-specific directories.  */
-#define add_system_dir(dir) 						\
-  do							    		\
-    {									\
-      size_t len = strlen (dir);					\
-      char path[len + 9];						\
-      memcpy (path, dir, len + 1);					\
-      if (len >= 12 && ! memcmp(path + len - 12, "/lib64/lp64d", 12))	\
-	{								\
-	  len -= 8;							\
-	  path[len] = '\0';						\
-	}								\
-      if (len >= 11 && ! memcmp(path + len - 11, "/lib64/lp64", 11))	\
-	{								\
-	  len -= 7;							\
-	  path[len] = '\0';						\
-	}								\
-      add_dir (path);							\
-      if (len >= 4 && ! memcmp(path + len - 4, "/lib", 4))		\
-	{								\
-	  memcpy (path + len, "64/lp64d", 9);				\
-	  add_dir (path);						\
-	  memcpy (path + len, "64/lp64", 8);				\
-	  add_dir (path);						\
-	}								\
+	 My reasoning for that would be: generic autoconf-configured (etc.)
+	 software may only know about using the lib directory, so you want the
+	 lib directory to be searched regardless of the ABI - but it's also
+	 useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all
+	 architectures and have that automatically imply /usr/local/lib64/lp64d
+	 etc. so that libraries can be found that come from software that does
+	 use the ABI-specific directories.  */
+#define add_system_dir(dir) 									\
+  do							    					\
+    {												\
+	size_t len = strlen (dir);								\
+	char path[len + 9];									\
+	memcpy (path, dir, len + 1);								\
+	if (len >= 12 && ! memcmp(path + len - 12, "/lib64/lp64d", 12))				\
+	{											\
+	  len -= 8;										\
+	  path[len] = '\0';									\
+	}											\
+	if (len >= 11 && ! memcmp(path + len - 11, "/lib64/lp64", 11))				\
+	{											\
+	  len -= 7;										\
+	  path[len] = '\0';									\
+	}											\
+	add_dir (path);										\
+	if (len >= 4 && ! memcmp(path + len - 4, "/lib", 4))					\
+	{											\
+	  memcpy (path + len, "64/lp64d", 9);							\
+	  add_dir (path);									\
+	  memcpy (path + len, "64/lp64", 8);							\
+	  add_dir (path);									\
+	}											\
     } while (0)