Message ID | 91a2de374c9ae48869743324f4a0edc185f63161.1594568655.git.alistair.francis@wdc.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C91AF385EC57; Sun, 12 Jul 2020 15:57:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C91AF385EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594569431; bh=3NlbLel7a5wF4Xfmzy4I5tvGAIThOwog34wlnkOrykU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r8Fbh8XpuMgYYAe5H0qS3CC4MEUEpRRAur8IVJlOL428Fl90wiPfDKVYYFx1dk8tP GuJTk4sXRPTiGkvNoutMoU4uTTnAsEQG4NNhCth4Q6jik051l2PwFwhzhDqCRr/XqK t2nEc5UXEI/z9CYgxDNFnmtVWWBNbmdESEEK4S8A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by sourceware.org (Postfix) with ESMTPS id C4DAC3858D37 for <libc-alpha@sourceware.org>; Sun, 12 Jul 2020 15:57:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C4DAC3858D37 IronPort-SDR: YmoFbsQymFVgKCtCz6v2g6uvpnN1HSQolCYb5/wHE05bkmVsP6x1lDWssIY3lXTbw2sunuegrx 4sIIMxqxAQXUG/7Nyg3J3L6fPtw8EjjtfjcJNwcHMyo5N0BWigd9hy1Z9V+IsN7jlGHV6pvQux LjrX67Q8vY1u+3RRLICl7vl5DRjyjCFPNA/RNcXv3EQ+Sb6U0o8Aw+pynoXER8103rT4qYrwXu ii8uA6wW3G3IF9iizIoaLzwR5xh8KY8Rfbbrwfh0pfmHH9vPuezA96g66RiJLG5yqdnWYNQUF0 EGU= X-IronPort-AV: E=Sophos;i="5.75,344,1589212800"; d="scan'208";a="146561177" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 12 Jul 2020 23:56:58 +0800 IronPort-SDR: f9XPGLVA1f+5hdYiZ877UEQ1PS5udKhifD4elqurZofdGevIYasxcOpE8eG5GNECV7s4ra4UMx 5QcpC9P+IIzDPyjq2YlhVGrpi7Lakq8yc= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2020 08:45:27 -0700 IronPort-SDR: TpYwsUwI2Tl5ALshBlIJLsXEfsuoAmqGYkeiRLoncPd2zGP9Z+0VX0ga1fWFBjw481VqBRrVQT 2ARaToyi1oyg== WDCIronportException: Internal Received: from usa002626.ad.shared (HELO risc6-mainframe.hgst.com) ([10.86.57.178]) by uls-op-cesaip02.wdc.com with ESMTP; 12 Jul 2020 08:56:56 -0700 To: libc-alpha@sourceware.org Subject: [PATCH v3 02/19] RISC-V: Cleanup some of the sysdep.h code Date: Sun, 12 Jul 2020 08:47:26 -0700 Message-Id: <91a2de374c9ae48869743324f4a0edc185f63161.1594568655.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <cover.1594568655.git.alistair.francis@wdc.com> References: <cover.1594568655.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alistair Francis <alistair.francis@wdc.com> Cc: alistair.francis@wdc.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
glibc port for 32-bit RISC-V (RV32)
|
|
Commit Message
Alistair Francis
July 12, 2020, 3:47 p.m. UTC
--- sysdeps/unix/sysv/linux/riscv/sysdep.h | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)
Comments
On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > --- > sysdeps/unix/sysv/linux/riscv/sysdep.h | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) Please try to have at least a little explanation for posterity with non-mechanical changes like this, e.g.: Remove a duplicate inclusion of <sysdeps/unix/sysdep.h> which is already pulled via <sysdeps/unix/sysv/linux/generic/sysdep.h>, and the inclusion of <errno.h> whose definition of `__set_errno' is not needed here. It's not always easy for the reader to reproduce an environment needed to bring the observations that have lead to the conclusion a given change is the right one to make; they shouldn't have to anyway. > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > index 83e4adf6a2..429686cebe 100644 > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > @@ -107,19 +107,7 @@ > # undef ret_ERRVAL > # define ret_ERRVAL ret > > -#endif /* __ASSEMBLER__ */ > - > -/* In order to get __set_errno() definition in INLINE_SYSCALL. */ > -#ifndef __ASSEMBLER__ > -# include <errno.h> > -#endif > - > -#include <sysdeps/unix/sysdep.h> > - > -#undef SYS_ify > -#define SYS_ify(syscall_name) __NR_##syscall_name This redefinition actually has to stay; sorry to be unclear about it. I can see you have readded it with 03/19, but having things broken even for the duration of a single commit will interfere with bisection. Please place it after the common inclusions at the top of this file. Maciej
On Wed, Jul 15, 2020 at 6:07 PM Maciej W. Rozycki via Libc-alpha <libc-alpha@sourceware.org> wrote: > > On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > > > --- > > sysdeps/unix/sysv/linux/riscv/sysdep.h | 14 +------------- > > 1 file changed, 1 insertion(+), 13 deletions(-) > > Please try to have at least a little explanation for posterity with > non-mechanical changes like this, e.g.: > > Remove a duplicate inclusion of <sysdeps/unix/sysdep.h> which is already > pulled via <sysdeps/unix/sysv/linux/generic/sysdep.h>, and the inclusion > of <errno.h> whose definition of `__set_errno' is not needed here. Added! > > It's not always easy for the reader to reproduce an environment needed to > bring the observations that have lead to the conclusion a given change is > the right one to make; they shouldn't have to anyway. > > > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > index 83e4adf6a2..429686cebe 100644 > > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > @@ -107,19 +107,7 @@ > > # undef ret_ERRVAL > > # define ret_ERRVAL ret > > > > -#endif /* __ASSEMBLER__ */ > > - > > -/* In order to get __set_errno() definition in INLINE_SYSCALL. */ > > -#ifndef __ASSEMBLER__ > > -# include <errno.h> > > -#endif > > - > > -#include <sysdeps/unix/sysdep.h> > > - > > -#undef SYS_ify > > -#define SYS_ify(syscall_name) __NR_##syscall_name > > This redefinition actually has to stay; sorry to be unclear about it. I > can see you have readded it with 03/19, but having things broken even for > the duration of a single commit will interfere with bisection. > > Please place it after the common inclusions at the top of this file. Fixed. Alistair > > Maciej
diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h index 83e4adf6a2..429686cebe 100644 --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h @@ -107,19 +107,7 @@ # undef ret_ERRVAL # define ret_ERRVAL ret -#endif /* __ASSEMBLER__ */ - -/* In order to get __set_errno() definition in INLINE_SYSCALL. */ -#ifndef __ASSEMBLER__ -# include <errno.h> -#endif - -#include <sysdeps/unix/sysdep.h> - -#undef SYS_ify -#define SYS_ify(syscall_name) __NR_##syscall_name - -#ifndef __ASSEMBLER__ +#else # define VDSO_NAME "LINUX_4.15" # define VDSO_HASH 182943605