diff mbox series

abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h

Message ID 20200609113827.204571-1-maennich@google.com
State Committed
Headers
Series abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h |

Commit Message

Matthias Männich June 9, 2020, 11:38 a.m. UTC 
  Definitions from those headers are not actually used. Yet the includes
create unnecessary dependencies.

	* tools/abipkgdiff.cc: Drop unused includes.

Signed-off-by: Matthias Maennich <maennich@google.com>
---
 tools/abipkgdiff.cc | 2 --
 1 file changed, 2 deletions(-)

Comments

Giuliano Procida June 9, 2020, 5:43 p.m. UTC | #1 
Hi.

On Tue, 9 Jun 2020 at 12:38, Matthias Maennich <maennich@google.com> wrote:
>
> Definitions from those headers are not actually used. Yet the includes
> create unnecessary dependencies.
>
>         * tools/abipkgdiff.cc: Drop unused includes.
>

Reviewed-by: Giuliano Procida <gprocida@google.com>

> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
>  tools/abipkgdiff.cc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
> index 7d946e72b3c8..445e2406830b 100644
> --- a/tools/abipkgdiff.cc
> +++ b/tools/abipkgdiff.cc
> @@ -72,8 +72,6 @@
>  #include <assert.h>
>  #include <fcntl.h>
>  #include <sys/stat.h>
> -#include <elf.h>
> -#include <elfutils/libdw.h>
>
>  // If fts.h is included before config.h, its indirect inclusions may
>  // not give us the right LFS aliases of these functions, so map them
> --
> 2.27.0.278.ge193c7cf3a9-goog
>
Dodji Seketeli June 15, 2020, 7:57 a.m. UTC | #2 
Matthias Maennich <maennich@google.com> a écrit:

> Definitions from those headers are not actually used. Yet the includes
> create unnecessary dependencies.
>
> 	* tools/abipkgdiff.cc: Drop unused includes.
>
> Signed-off-by: Matthias Maennich <maennich@google.com>

Applied to master, thanks!

Cheers,
diff mbox series

Patch

diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
index 7d946e72b3c8..445e2406830b 100644
--- a/tools/abipkgdiff.cc
+++ b/tools/abipkgdiff.cc
@@ -72,8 +72,6 @@ 
 #include <assert.h>
 #include <fcntl.h>
 #include <sys/stat.h>
-#include <elf.h>
-#include <elfutils/libdw.h>
 
 // If fts.h is included before config.h, its indirect inclusions may
 // not give us the right LFS aliases of these functions, so map them