Message ID | 20200609113827.204571-1-maennich@google.com |
---|---|
State | Committed |
Headers |
Return-Path: <libabigail-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E9974383F857; Tue, 9 Jun 2020 11:38:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9974383F857 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591702724; bh=cG1lAD71kVmYF9rY2Y+DtKr+0Y84E1rnJrceUmIAkXc=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:Cc:From; b=sQq2bP8XHMMb9aiVU2fw09t1YH8BhQulwZWLimwQqMDEisfJQ9Yz1ikPu88E8vg4G UPD36wATxPropdEv3RmshaXHv4W/3IhlBNUBu+6E5aKrj/MTyu45RuXNtt5brAnq2t 6eM4YdQBAQvN9yFwY4Th8on50aDPXkmU/ewvHlTI= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id 6B2D2383F857 for <libabigail@sourceware.org>; Tue, 9 Jun 2020 11:38:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B2D2383F857 Received: by mail-yb1-xb49.google.com with SMTP id f130so24626098yba.9 for <libabigail@sourceware.org>; Tue, 09 Jun 2020 04:38:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=cG1lAD71kVmYF9rY2Y+DtKr+0Y84E1rnJrceUmIAkXc=; b=JXSeM8ZrVenji0ZuziM7h1t0rSkKzhFk1aZUWbbUqfx3aiXE27wdTVxknYwh9m7LJy tLvExZvqDhz0QWO7e4gxXDRNmpGMAOZgQHiTZKooj0f+ML+LELJ8xrrFn+g6ZiMv1Uq2 07FipcYsYCrzv6bQwm9Eqy7kb3RzMxxwYqUfJwvfSQhbQgYeivUN1f4caQxAmzZy3JyV 65kfbl9Rg58+NZPxLPuym8Ii0/FXpfGfmK5WJ6u125Dw8YkefBna4o6TKP7pCD0PC09z LicwMQCefsCjHkugIolxTR7y9U4TBVU9SJjYaPqSHaL5ndo6fh5/8wHJzopF4MnvGtcV JHaA== X-Gm-Message-State: AOAM5338UdjHp0+y4CF0EY2LIvoUIjj9CRLQaajRXYN1YdAhObDg/Mre 8g+R6JsUfV02EEDTQxHZ5fGAWCGSZxiCHwNXnYi2bn9doXDY1/OBCkFADwan7ZGT/yh3nrW5uta qDdH4GE24RcqoEWRVoPLNpeYui3y81eRG8eR6D4/BQbe1mfXeQ9V/PP97nFEmXs6ZuKoRGOY= X-Google-Smtp-Source: ABdhPJxxZT0ScP3D7TFdrq2DcQ16wpLwmj6CbeM9JF4OFOse4IXDfz0rZ6uYRk+8K09EtFT5pg3ugMH3SNN6BQ== X-Received: by 2002:a25:5f43:: with SMTP id h3mr6027541ybm.248.1591702719768; Tue, 09 Jun 2020 04:38:39 -0700 (PDT) Date: Tue, 9 Jun 2020 13:38:27 +0200 Message-Id: <20200609113827.204571-1-maennich@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog Subject: [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h To: libabigail@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-24.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>, <mailto:libabigail-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libabigail/> List-Help: <mailto:libabigail-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>, <mailto:libabigail-request@sourceware.org?subject=subscribe> From: Matthias Maennich via Libabigail <libabigail@sourceware.org> Reply-To: Matthias Maennich <maennich@google.com> Cc: maennich@google.com, gprocida@google.com, kernel-team@android.com Errors-To: libabigail-bounces@sourceware.org Sender: "Libabigail" <libabigail-bounces@sourceware.org> |
Series |
abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h
|
|
Commit Message
Matthias Männich
June 9, 2020, 11:38 a.m. UTC
Definitions from those headers are not actually used. Yet the includes
create unnecessary dependencies.
* tools/abipkgdiff.cc: Drop unused includes.
Signed-off-by: Matthias Maennich <maennich@google.com>
---
tools/abipkgdiff.cc | 2 --
1 file changed, 2 deletions(-)
Comments
Hi. On Tue, 9 Jun 2020 at 12:38, Matthias Maennich <maennich@google.com> wrote: > > Definitions from those headers are not actually used. Yet the includes > create unnecessary dependencies. > > * tools/abipkgdiff.cc: Drop unused includes. > Reviewed-by: Giuliano Procida <gprocida@google.com> > Signed-off-by: Matthias Maennich <maennich@google.com> > --- > tools/abipkgdiff.cc | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc > index 7d946e72b3c8..445e2406830b 100644 > --- a/tools/abipkgdiff.cc > +++ b/tools/abipkgdiff.cc > @@ -72,8 +72,6 @@ > #include <assert.h> > #include <fcntl.h> > #include <sys/stat.h> > -#include <elf.h> > -#include <elfutils/libdw.h> > > // If fts.h is included before config.h, its indirect inclusions may > // not give us the right LFS aliases of these functions, so map them > -- > 2.27.0.278.ge193c7cf3a9-goog >
Matthias Maennich <maennich@google.com> a écrit: > Definitions from those headers are not actually used. Yet the includes > create unnecessary dependencies. > > * tools/abipkgdiff.cc: Drop unused includes. > > Signed-off-by: Matthias Maennich <maennich@google.com> Applied to master, thanks! Cheers,
diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc index 7d946e72b3c8..445e2406830b 100644 --- a/tools/abipkgdiff.cc +++ b/tools/abipkgdiff.cc @@ -72,8 +72,6 @@ #include <assert.h> #include <fcntl.h> #include <sys/stat.h> -#include <elf.h> -#include <elfutils/libdw.h> // If fts.h is included before config.h, its indirect inclusions may // not give us the right LFS aliases of these functions, so map them