Message ID | CALkY8p8m=_f0fqkWmZ2cpxvXa+ePCfnMLng4QdU-ABtiOb9zHg@mail.gmail.com |
---|---|
State | Committed |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 041E73840C20; Sat, 9 May 2020 20:03:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 041E73840C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1589054582; bh=IODsU0AwH4ntZVDRI6mDTrAtdgVu9QNGxRm63qau82U=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wYGDTG1vBYpKyIoHPMYEaPIKNNN8ly6NIqMFDY1Huh6OzEmLcRXGSzukxD2lfshlC RSndxOUva7HHYS81SW8d+DKQZy+A09no/Tds5/aNkWyWIM4eSCVivr915FwsqMReyW ZfjnHY8OFOwG3le/i41ZQ2R8wod7vPMWBTgQptvc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id 2996E3858D35 for <libc-alpha@sourceware.org>; Sat, 9 May 2020 20:02:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2996E3858D35 Received: by mail-wr1-x443.google.com with SMTP id l11so59483wru.0 for <libc-alpha@sourceware.org>; Sat, 09 May 2020 13:02:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IODsU0AwH4ntZVDRI6mDTrAtdgVu9QNGxRm63qau82U=; b=PUy4wTpdACTxh9kS8up5ExqYN2va1T2ESULl9eBgssN9GNkXcmyhplUEeu6t07Q0FT IOcCcO22NB5foBhWgHmZYc2tAeB1cdXnPElB3Y18KeI7TSH2WNZdk6E+E9ofyLToeaSN Tjd+gJAGyWK1kMFLO17an1xs0E32ra48lbTZ1SO0z+jI/IPjc//b+bTsIBRs384+8bQI +rhWFLTz+6RTDxQCCkwxRX28GYsTmTRSV/vljEoZd3PLaQCXOkNxUYNsBvKSKFZb9Pae 4rWG551OpbqA/TlfDOJtN1EkKwGlmfoObQD1P8Ub727M6nken9Iv2Y3ag18saC4h1ms9 XBcQ== X-Gm-Message-State: AGi0PuY3acM4aIALXburWdKZ0rwOojE6RDw2RSOXLXcJhEHXp8jaxjFm My/ZD4GrdhM19/nlkmi/8FDwbaWaC4ujWrutyTtTwBu2geA= X-Google-Smtp-Source: APiQypLpz4T8DVna9fgyNa2s2FZcd2+8m5MebaDZqUJ+xUSNWxqwrdCJpUsD9O9Xg0mFWnbcORx20vjwqvZitPzMOx0= X-Received: by 2002:a5d:6691:: with SMTP id l17mr9654234wru.127.1589054577956; Sat, 09 May 2020 13:02:57 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 10 May 2020 01:32:46 +0530 Message-ID: <CALkY8p8m=_f0fqkWmZ2cpxvXa+ePCfnMLng4QdU-ABtiOb9zHg@mail.gmail.com> Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child [BZ #23990] To: libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Girish Joshi via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Girish Joshi <girish946@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
build: Used FAIL_EXIT1 () on failure to exec child [BZ #23990]
|
|
Commit Message
Girish Joshi
May 9, 2020, 8:02 p.m. UTC
From 9c3e8d18343e29aa1f65d1403d4c3878dd2b9865 Mon Sep 17 00:00:00 2001
From: Girish Joshi <girish946@gmail.com>
Date: Sun, 10 May 2020 01:22:04 +0530
Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child [BZ
#23990]
---
support/test-container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Girish Joshi
Comments
* Girish Joshi via Libc-alpha: > diff --git a/support/test-container.c b/support/test-container.c > index afc23db148..1423320b8a 100644 > --- a/support/test-container.c > +++ b/support/test-container.c > @@ -392,7 +392,7 @@ recursive_remove (char *path) > /* "rm" would have already printed a suitable error message. */ > if (! WIFEXITED (status) > || WEXITSTATUS (status) != 0) > - exit (1); > + FAIL_EXIT1 ("failed to exec child"); > break; > } Sorry, this patch arrived corrupted on the list. The error message is not correct because the child process returned an error status. This can mean that execvp failed, or something else. It would also make sense to add the status value to the error message. Thanks, Florian
Thanks Florian for the review. > Sorry, this patch arrived corrupted on the list. > > The error message is not correct because the child process returned an > error status. This can mean that execvp failed, or something else. It > would also make sense to add the status value to the error message. > Reposting the patch with corrected error message. Please let me know if it works. From f1cc58ee37ded9a6bb3f5764143c6ea8c3572741 Mon Sep 17 00:00:00 2001 From: Girish Joshi <girish946@gmail.com> Date: Sun, 10 May 2020 01:22:04 +0530 Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child BZ #23990 --- support/test-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/test-container.c b/support/test-container.c index afc23db148..e9109f9e3d 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -392,7 +392,7 @@ recursive_remove (char *path) /* "rm" would have already printed a suitable error message. */ if (! WIFEXITED (status) || WEXITSTATUS (status) != 0) - exit (1); + FAIL_EXIT1 ("exec child returned status: %d", status); break; }
Thanks Florian for the review. > Sorry, this patch arrived corrupted on the list. > > The error message is not correct because the child process returned an > error status. This can mean that execvp failed, or something else. It > would also make sense to add the status value to the error message. > > Thanks, > Florian > Reposting the patch with corrected error message. Please let me know if it works. From f1cc58ee37ded9a6bb3f5764143c6ea8c3572741 Mon Sep 17 00:00:00 2001 From: Girish Joshi <girish946@gmail.com> Date: Sun, 10 May 2020 01:22:04 +0530 Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child BZ #23990 --- support/test-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/test-container.c b/support/test-container.c index afc23db148..e9109f9e3d 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -392,7 +392,7 @@ recursive_remove (char *path) /* "rm" would have already printed a suitable error message. */ if (! WIFEXITED (status) || WEXITSTATUS (status) != 0) - exit (1); + FAIL_EXIT1 ("exec child returned status: %d", status); break; } -- 2.21.3 Thanks. Girish Joshi
On 23/05/2020 07:05, Girish Joshi via Libc-alpha wrote: > Thanks Florian for the review. > >> Sorry, this patch arrived corrupted on the list. >> >> The error message is not correct because the child process returned an >> error status. This can mean that execvp failed, or something else. It >> would also make sense to add the status value to the error message. >> >> Thanks, >> Florian >> > > Reposting the patch with corrected error message. > Please let me know if it works. > > From f1cc58ee37ded9a6bb3f5764143c6ea8c3572741 Mon Sep 17 00:00:00 2001 > From: Girish Joshi <girish946@gmail.com> > Date: Sun, 10 May 2020 01:22:04 +0530 > Subject: [PATCH] build: Used FAIL_EXIT1 () on failure to exec child BZ #23990 LGTM, thanks. I will push it upstream for you. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > > --- > support/test-container.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/test-container.c b/support/test-container.c > index afc23db148..e9109f9e3d 100644 > --- a/support/test-container.c > +++ b/support/test-container.c > @@ -392,7 +392,7 @@ recursive_remove (char *path) > /* "rm" would have already printed a suitable error message. */ > if (! WIFEXITED (status) > || WEXITSTATUS (status) != 0) > - exit (1); > + FAIL_EXIT1 ("exec child returned status: %d", status); > > break; > } > -- > 2.21.3 > > Thanks. > > Girish Joshi >
> LGTM, thanks. > > I will push it upstream for you. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Thanks Adhemerval. Girish Joshi
diff --git a/support/test-container.c b/support/test-container.c index afc23db148..1423320b8a 100644 --- a/support/test-container.c +++ b/support/test-container.c @@ -392,7 +392,7 @@ recursive_remove (char *path) /* "rm" would have already printed a suitable error message. */ if (! WIFEXITED (status) || WEXITSTATUS (status) != 0) - exit (1); + FAIL_EXIT1 ("failed to exec child"); break; } -- 2.21.3