diff mbox series

[v4,02/15] Document ^_^ regex in generate_from_strings.

Message ID	20200504123416.243214-3-gprocida@google.com
State	Committed
Headers	From: gprocida@google.com (Giuliano Procida) Date: Mon, 4 May 2020 13:34:03 +0100 Subject: [PATCH v4 02/15] Document ^_^ regex in generate_from_strings. In-Reply-To: <20200504123416.243214-1-gprocida@google.com> References: <20200424092132.150547-1-gprocida@google.com> <20200504123416.243214-1-gprocida@google.com> Message-ID: <20200504123416.243214-3-gprocida@google.com>
Series	Simplify regex and suppression parsing. \| [v4,00/15] Simplify regex and suppression parsing. [v4,01/15] Tidy #includes in a few files. [v4,02/15] Document ^_^ regex in generate_from_strings. [v4,03/15] Escape names used in symbol whitelisting regex. [v4,04/15] abg-suppression.cc: More uniform variable naming. [v4,05/15] diff suppression: Fix handling of change kinds. [v4,06/15] Add POSIX regex wrapper functions. [v4,07/15] Use regex::compile wrapper instead of regcomp. [v4,08/15] Use regex::match wrapper instead of regexec. [v4,09/15] Refactor read_parameter_spec_from_string logic. [v4,10/15] Compile suppression regexes earlier. [v4,11/15] Reduce direct access to suppression priv_ members. [v4,12/15] Move match methods from priv to suppression_base. [v4,13/15] Remove suppression type priv class methods. [v4,14/15] abg-suppression.cc: More consistent regex matching. [v4,15/15] abg-tools-utils.cc: Assert generated regexes OK.

Commit Message

Giuliano Procida May 4, 2020, 12:34 p.m. UTC

  Following review of the change to simplify generation of symbol
whitelist regexes, this commit clarifies the purpose of the ^_^ regex
as one which will not match any string.

	* src/abg-regex.cc (generate_from_strings): Document ^_^
	regex.

Signed-off-by: Giuliano Procida <gprocida@google.com>
---
 src/abg-regex.cc | 1 +
 1 file changed, 1 insertion(+)

Comments

Matthias Männich May 4, 2020, 12:49 p.m. UTC | #1

On Mon, May 04, 2020 at 01:34:03PM +0100, Giuliano Procida wrote:
>Following review of the change to simplify generation of symbol
>whitelist regexes, this commit clarifies the purpose of the ^_^ regex
>as one which will not match any string.
>
>	* src/abg-regex.cc (generate_from_strings): Document ^_^
>	regex.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> src/abg-regex.cc | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/abg-regex.cc b/src/abg-regex.cc
>index cf0663a2..0451d111 100644
>--- a/src/abg-regex.cc
>+++ b/src/abg-regex.cc
>@@ -69,6 +69,7 @@ std::string
> generate_from_strings(const std::vector<std::string>& strs)
> {
>   if (strs.empty())
>+    // This cute-looking regex does not match any string.
>     return "^_^";
>   std::ostringstream os;
>   std::vector<std::string>::const_iterator i = strs.begin();
>-- 
>2.26.2.526.g744177e7f7-goog
>

Dodji Seketeli May 11, 2020, 1:32 p.m. UTC | #2

Giuliano Procida <gprocida@google.com> a ?crit:

[...]

>  generate_from_strings(const std::vector<std::string>& strs)
>  {
>    if (strs.empty())
> +    // This cute-looking regex does not match any string.
>      return "^_^";

Cute-looking, indeed :-)

> Following review of the change to simplify generation of symbol
> whitelist regexes, this commit clarifies the purpose of the ^_^ regex
> as one which will not match any string.
>
> 	* src/abg-regex.cc (generate_from_strings): Document ^_^
> 	regex.

Applied to master, thanks!

Cheers,

diff mbox series

Patch

diff --git a/src/abg-regex.cc b/src/abg-regex.cc
index cf0663a2..0451d111 100644
--- a/src/abg-regex.cc
+++ b/src/abg-regex.cc
@@ -69,6 +69,7 @@  std::string
 generate_from_strings(const std::vector<std::string>& strs)
 {
   if (strs.empty())
+    // This cute-looking regex does not match any string.
     return "^_^";
   std::ostringstream os;
   std::vector<std::string>::const_iterator i = strs.begin();