From patchwork Wed May 11 19:54:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 53821 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9BB97383642E for ; Wed, 11 May 2022 19:56:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BB97383642E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652298967; bh=aBrO61I2MBsIk23tJxTRk14eVbt2yNamYRRLUw6KmKg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VmQpDHJqk/HKh7bFFhuPuQnS5u5GI7aIC16AgUfBAa9rwiu9YAfW2sIhJFCazaZya i83BzBGRN1M7oQhjy8aubqo0fOkXGf0AXqhiwLWFn+3s7X4qDhmWWMDREAKAuueGW8 hqhAhwrtEyxWgbqQtFP/IKsHPj+2FtuETBvJR8pI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 8BE1C3839C66 for ; Wed, 11 May 2022 19:55:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BE1C3839C66 Received: by mail-ot1-x333.google.com with SMTP id m15-20020a9d608f000000b00606a788887aso1201784otj.0 for ; Wed, 11 May 2022 12:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aBrO61I2MBsIk23tJxTRk14eVbt2yNamYRRLUw6KmKg=; b=D2SeOUgwGw7bPFIH+yh5omXyMWxSDcbUB0ixGmvwA2cDllaAuGWGkSj/VlKsTd9TlM CuzQttWPaSrAWKHZ3HXLQSXd1qzX4wPCNtn3AyRBzOeiuAYz1ark1TRNVYOffimNLjyf apzjpcp6SakPF3bChlGv2ux8H83976UNabzqaj7LdYJc+STAiml3if/eTDPNG/7IpluB UUB0vP9gaIGfyauPSMXn7HN5RmaDfm2q04FeYc14whWZEfToIeGHMWm4G+5IJIaAHU1m f3AUOHs8QdatFdeR6bS9FhM/MtGf8Kcsl2T0OzF2j4JOja9i3XbR8nqUj0d69tYkCUEH NoKA== X-Gm-Message-State: AOAM530Lbg/HBEDS9Zk5IdfAy3121YdIUAXvT+hAtrAdFuzySebpUhh3 /Dqcfze2VDtmUuc21Gg5EdIFz50nExSJpg== X-Google-Smtp-Source: ABdhPJwSGeEj5UNGXxvXoQvG/fE+GdsU+yTM21nZq95wKAyk4K7GysfsUU71PefbG1bjafAop+gi8Q== X-Received: by 2002:a05:6830:44a3:b0:606:5e61:79db with SMTP id r35-20020a05683044a300b006065e6179dbmr10677030otv.238.1652298905567; Wed, 11 May 2022 12:55:05 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b]) by smtp.gmail.com with ESMTPSA id k22-20020a05687015d600b000edde90fac9sm886322oad.53.2022.05.11.12.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:55:04 -0700 (PDT) To: libc-alpha@sourceware.org, Fangrui Song Subject: [PATCH 1/4] Add declare_object_symbol_alias for assembly codes (BZ #28128) Date: Wed, 11 May 2022 16:54:54 -0300 Message-Id: <20220511195457.410681-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220511195457.410681-1-adhemerval.zanella@linaro.org> References: <20220511195457.410681-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" From: "H.J. Lu" There are 2 problems in: #define declare_symbol_alias(symbol, original, type, size) \ declare_symbol_alias_1 (symbol, original, type, size) #ifdef __ASSEMBLER__ # define declare_symbol_alias_1(symbol, original, type, size) \ strong_alias (original, symbol); \ .type C_SYMBOL_NAME (symbol), %##type; \ .size C_SYMBOL_NAME (symbol), size 1. .type and .size are substituted by arguments. 2. %##type is expanded to "% type" due to the GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101613 But assembler doesn't support "% type". Workaround BZ #28128 by 1. Don't define declare_symbol_alias for assembly codes. 2. Define declare_object_symbol_alias for assembly codes. --- include/libc-symbols.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/include/libc-symbols.h b/include/libc-symbols.h index 662bd118b1..4bb3d8c7ba 100644 --- a/include/libc-symbols.h +++ b/include/libc-symbols.h @@ -324,14 +324,16 @@ for linking") This is only necessary when defining something in assembly, or playing funny alias games where the size should be other than what the compiler thinks it is. */ -#define declare_symbol_alias(symbol, original, type, size) \ - declare_symbol_alias_1 (symbol, original, type, size) #ifdef __ASSEMBLER__ -# define declare_symbol_alias_1(symbol, original, type, size) \ - strong_alias (original, symbol); \ - .type C_SYMBOL_NAME (symbol), %##type; \ - .size C_SYMBOL_NAME (symbol), size +# define declare_object_symbol_alias(symbol, original, size) \ + declare_object_symbol_alias_1 (symbol, original, size) +# define declare_object_symbol_alias_1(symbol, original, s_size) \ + strong_alias (original, symbol) ASM_LINE_SEP \ + .type C_SYMBOL_NAME (symbol), %object ASM_LINE_SEP \ + .size C_SYMBOL_NAME (symbol), s_size ASM_LINE_SEP #else /* Not __ASSEMBLER__. */ +# define declare_symbol_alias(symbol, original, type, size) \ + declare_symbol_alias_1 (symbol, original, type, size) # define declare_symbol_alias_1(symbol, original, type, size) \ asm (".globl " __SYMBOL_PREFIX #symbol \ "\n\t" declare_symbol_alias_1_alias (symbol, original) \ From patchwork Wed May 11 19:54:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 53822 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90F333836427 for ; Wed, 11 May 2022 19:56:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90F333836427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652299009; bh=mmUMEe6vnxsQwsXBDfMJjmqhjQPQJW/UVHIu38AJw5I=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NGyfgBSNkG8bQPegPlRpPCLyGv6IoFCNLNqClOKsTQd3WOXVQKPDQkcDU+7fbcJF3 5pFCDuFT1jSdzkHurCqZr3pNVIcA0j400Ry3Sio3iyhZ8oQqrxp0vP98zW5LIssJu9 l1k3Ks9UoTkeYzG/+vH9/1p5MBuZUFuXfxGEE3Cs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 7BC2D3836403 for ; Wed, 11 May 2022 19:55:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BC2D3836403 Received: by mail-ot1-x32c.google.com with SMTP id i25-20020a9d6259000000b00605df9afea7so1200953otk.1 for ; Wed, 11 May 2022 12:55:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mmUMEe6vnxsQwsXBDfMJjmqhjQPQJW/UVHIu38AJw5I=; b=V75YIzSq96XyldORa6894TiMvIZHtJxatuZcmTUXlLE89mwkC7dLdfpoVTRpJsKarp W8wr63a5rFhVqGZpkLxLb6EWEn19XfdWTVrBspOLKepGb47oPA0xNZhYp6IiowGochAD afYQwS85yQNMJw0lllxTRVPjYjBz+sdaPvsOZqvZAYElUGqSTxqWsA90A4X0XSc3NyeJ PLA/eQJ5eG/0ZMhmYTsa49bQhN36UrE7dR7Px52mGsb9YHZOQsa68KVi4clin6ojwZuX kAPF0ssgX4cNaKTxUAFj6x4A2olTSiH1v5aN4prp8RLyxb38Oeq3XYfk8cbFk/1OOCFl fz+Q== X-Gm-Message-State: AOAM531kUJGrPxRXzOkeOFRDT0fFytEfQFCUrnDblxwLrN3f94BXuo+X 7gaWlx5xFo0zWiquFIxQ6o7Ii+oTxLACnw== X-Google-Smtp-Source: ABdhPJwyUqlK7HGmZax/3PfnL6lX+ieMdXx8Y4UjxN2RUTHkQbgh50hmf6vveMaQOAQqz4RUt/ac1g== X-Received: by 2002:a9d:5d16:0:b0:5ce:127a:1c42 with SMTP id b22-20020a9d5d16000000b005ce127a1c42mr10095207oti.350.1652298907386; Wed, 11 May 2022 12:55:07 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b]) by smtp.gmail.com with ESMTPSA id k22-20020a05687015d600b000edde90fac9sm886322oad.53.2022.05.11.12.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:55:06 -0700 (PDT) To: libc-alpha@sourceware.org, Fangrui Song Subject: [PATCH 2/4] stdio: Remove the usage of $(fno-unit-at-a-time) for errlist.c Date: Wed, 11 May 2022 16:54:55 -0300 Message-Id: <20220511195457.410681-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220511195457.410681-1-adhemerval.zanella@linaro.org> References: <20220511195457.410681-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The errlist.c is build with -fno-toplevel-reorder to avoid compiler to reorder the compat assembly directives due a static linker issue [1] (fixed on 2.39). This patch removes the compiler flags by split the compat symbol generation in two phases. First the _sys_errlist_internal internal without any compat symbol directive is preprocessed to generate an assembly source code. This generate assembly is then used as input on a platform agnostic errlist-data.S which then creates the compat definitions. This prevents compiler to move any compat directive prior the _sys_errlist_internal definition itself. Checked on a make check run-built-tests=no on all affected ABIs. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=29012 --- include/stdio.h | 1 + stdio-common/Makefile | 17 +++++++++- stdio-common/err_map.h | 24 +++++++++++++ stdio-common/errlist-compat-data.h | 1 + stdio-common/errlist-compat.c | 1 - stdio-common/errlist-data-gen.c | 34 +++++++++++++++++++ stdio-common/errlist-data.S | 7 ++++ stdio-common/errlist.c | 20 +++-------- sysdeps/mach/hurd/{errlist.c => err_map.h} | 9 +++-- ...errlist-compat.c => errlist-compat-data.h} | 0 ...errlist-compat.c => errlist-compat-data.h} | 0 sysdeps/unix/sysv/linux/errlist-compat.h | 33 +++++++++++------- ...errlist-compat.c => errlist-compat-data.h} | 0 ...errlist-compat.c => errlist-compat-data.h} | 0 ...errlist-compat.c => errlist-compat-data.h} | 0 15 files changed, 115 insertions(+), 32 deletions(-) create mode 100644 stdio-common/err_map.h create mode 100644 stdio-common/errlist-compat-data.h delete mode 100644 stdio-common/errlist-compat.c create mode 100644 stdio-common/errlist-data-gen.c create mode 100644 stdio-common/errlist-data.S rename sysdeps/mach/hurd/{errlist.c => err_map.h} (83%) rename sysdeps/unix/sysv/linux/alpha/{errlist-compat.c => errlist-compat-data.h} (100%) rename sysdeps/unix/sysv/linux/{errlist-compat.c => errlist-compat-data.h} (100%) rename sysdeps/unix/sysv/linux/hppa/{errlist-compat.c => errlist-compat-data.h} (100%) rename sysdeps/unix/sysv/linux/mips/{errlist-compat.c => errlist-compat-data.h} (100%) rename sysdeps/unix/sysv/linux/sparc/{errlist-compat.c => errlist-compat-data.h} (100%) diff --git a/include/stdio.h b/include/stdio.h index 23b7fd288c..a6f7fd43cb 100644 --- a/include/stdio.h +++ b/include/stdio.h @@ -180,6 +180,7 @@ int __vfxprintf (FILE *__fp, const char *__fmt, __gnuc_va_list, attribute_hidden; extern const char *const _sys_errlist_internal[] attribute_hidden; +extern const size_t _sys_errlist_internal_len attribute_hidden; extern const char *__get_errlist (int) attribute_hidden; extern const char *__get_errname (int) attribute_hidden; diff --git a/stdio-common/Makefile b/stdio-common/Makefile index a1603e82fe..087acb82b6 100644 --- a/stdio-common/Makefile +++ b/stdio-common/Makefile @@ -88,6 +88,7 @@ routines := \ aux := \ errlist \ + errlist-data \ errname \ fxprintf \ printf-parsemb \ @@ -211,6 +212,10 @@ tests := \ xbug \ # tests +generated += \ + errlist-data-aux.os \ + errlist-data-aux.o \ + # generated test-srcs = tst-unbputc tst-printf tst-printfsz-islongdouble @@ -246,6 +251,17 @@ tests-special += $(objpfx)tst-errno-manual.out include ../Rules +$(objpfx)errlist-data-aux.os: errlist-data-gen.c + $(make-target-directory) + $(compile-command.c) $(no-stack-protector) -S + +$(objpfx)errlist-data-aux.o: errlist-data-gen.c + $(make-target-directory) + $(compile-command.c) $(no-stack-protector) -S + +$(objpfx)errlist-data.os: $(objpfx)errlist-data-aux.os +$(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.o + ifeq ($(run-built-tests),yes) LOCALES := \ de_DE.ISO-8859-1 \ @@ -334,7 +350,6 @@ CFLAGS-isoc99_vfscanf.c += -fexceptions CFLAGS-isoc99_vscanf.c += -fexceptions CFLAGS-isoc99_fscanf.c += -fexceptions CFLAGS-isoc99_scanf.c += -fexceptions -CFLAGS-errlist.c += $(fno-unit-at-a-time) CFLAGS-siglist.c += $(fno-unit-at-a-time) # scanf14a.c and scanf16a.c test a deprecated extension which is no diff --git a/stdio-common/err_map.h b/stdio-common/err_map.h new file mode 100644 index 0000000000..6cc3aa3375 --- /dev/null +++ b/stdio-common/err_map.h @@ -0,0 +1,24 @@ +/* Internal errno names mapping definition. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _ERR_MAP_H +#define _ERR_MAP_H + +#define ERR_MAP(n) (n) + +#endif diff --git a/stdio-common/errlist-compat-data.h b/stdio-common/errlist-compat-data.h new file mode 100644 index 0000000000..7c89c9a5a4 --- /dev/null +++ b/stdio-common/errlist-compat-data.h @@ -0,0 +1 @@ +/* Empty */ diff --git a/stdio-common/errlist-compat.c b/stdio-common/errlist-compat.c deleted file mode 100644 index 6e25b021ab..0000000000 --- a/stdio-common/errlist-compat.c +++ /dev/null @@ -1 +0,0 @@ -/* Empty. */ diff --git a/stdio-common/errlist-data-gen.c b/stdio-common/errlist-data-gen.c new file mode 100644 index 0000000000..db4f50e6db --- /dev/null +++ b/stdio-common/errlist-data-gen.c @@ -0,0 +1,34 @@ +/* Internal errno names mapping definition. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include + +const char *const _sys_errlist_internal[] = + { +#define _S(n, str) [ERR_MAP(n)] = str, +#include +#undef _S + }; +const size_t _sys_errlist_internal_len = array_length (_sys_errlist_internal); + +/* Include to get the definitions for sys_nerr/_sys_nerr. */ +#include diff --git a/stdio-common/errlist-data.S b/stdio-common/errlist-data.S new file mode 100644 index 0000000000..a9856c5080 --- /dev/null +++ b/stdio-common/errlist-data.S @@ -0,0 +1,7 @@ +#ifdef SHARED +# include "errlist-data-aux.os" +#else +# include "errlist-data-aux.o" +#endif + +#include diff --git a/stdio-common/errlist.c b/stdio-common/errlist.c index 1c09a31a7a..4c0a0a218d 100644 --- a/stdio-common/errlist.c +++ b/stdio-common/errlist.c @@ -16,29 +16,17 @@ License along with the GNU C Library; if not, see . */ -#include +#include +#include #include #include -#include - -#ifndef ERR_MAP -# define ERR_MAP(n) n -#endif - -const char *const _sys_errlist_internal[] = - { -#define _S(n, str) [ERR_MAP(n)] = str, -#include -#undef _S - }; +#include const char * __get_errlist (int errnum) { int mapped = ERR_MAP (errnum); - if (mapped >= 0 && mapped < array_length (_sys_errlist_internal)) + if (mapped >= 0 && mapped < _sys_errlist_internal_len) return _sys_errlist_internal[mapped]; return NULL; } - -#include diff --git a/sysdeps/mach/hurd/errlist.c b/sysdeps/mach/hurd/err_map.h similarity index 83% rename from sysdeps/mach/hurd/errlist.c rename to sysdeps/mach/hurd/err_map.h index 2d782ffc67..22d21ca9f1 100644 --- a/sysdeps/mach/hurd/errlist.c +++ b/sysdeps/mach/hurd/err_map.h @@ -1,4 +1,5 @@ -/* Copyright (C) 1998-2022 Free Software Foundation, Inc. +/* Internal errno names mapping definition. Hurd version. + Copyright (C) 2022 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -15,7 +16,11 @@ License along with the GNU C Library; if not, see . */ +#ifndef _ERR_MAP_H +#define _ERR_MAP_H + #include #define ERR_MAP(value) err_get_code (value) -#include + +#endif diff --git a/sysdeps/unix/sysv/linux/alpha/errlist-compat.c b/sysdeps/unix/sysv/linux/alpha/errlist-compat-data.h similarity index 100% rename from sysdeps/unix/sysv/linux/alpha/errlist-compat.c rename to sysdeps/unix/sysv/linux/alpha/errlist-compat-data.h diff --git a/sysdeps/unix/sysv/linux/errlist-compat.c b/sysdeps/unix/sysv/linux/errlist-compat-data.h similarity index 100% rename from sysdeps/unix/sysv/linux/errlist-compat.c rename to sysdeps/unix/sysv/linux/errlist-compat-data.h diff --git a/sysdeps/unix/sysv/linux/errlist-compat.h b/sysdeps/unix/sysv/linux/errlist-compat.h index a09b38f243..33008863f8 100644 --- a/sysdeps/unix/sysv/linux/errlist-compat.h +++ b/sysdeps/unix/sysv/linux/errlist-compat.h @@ -20,6 +20,7 @@ #define _ERRLIST_COMPAT_H #include +#include /* Define new compat symbols for symbols _sys_errlist, sys_errlist, _sys_nerr, and sys_nerr for version VERSION with NUMBERERR times number of @@ -27,17 +28,25 @@ Both _sys_errlist and sys_errlist alias to _sys_errlist_internal symbol (defined on errlist.c) while _sys_nerr and sys_nerr created new variable with the expected size. */ -#define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \ - const int __##VERSION##_sys_nerr = NUMBERERR; \ - strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr); \ - declare_symbol_alias (__ ## VERSION ## _sys_errlist, _sys_errlist_internal,\ - object, NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)); \ - declare_symbol_alias (__ ## VERSION ## __sys_errlist, \ - _sys_errlist_internal, object, \ - NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)); \ - compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION); \ - compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION); \ - compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION); \ - compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION);\ +#ifdef __ASSEMBLER__ +# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \ + declare_object_symbol_alias (__ ## VERSION ## _sys_errlist, \ + _sys_errlist_internal, \ + NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)) \ + ASM_LINE_SEP \ + declare_object_symbol_alias (__ ## VERSION ## __sys_errlist, \ + _sys_errlist_internal, \ + NUMBERERR * (ULONG_WIDTH / UCHAR_WIDTH)) \ + ASM_LINE_SEP \ + compat_symbol (libc, __## VERSION ## _sys_errlist, sys_errlist, VERSION) \ + ASM_LINE_SEP \ + compat_symbol (libc, __## VERSION ## __sys_errlist, _sys_errlist, VERSION) +#else +# define DEFINE_COMPAT_ERRLIST(NUMBERERR, VERSION) \ + const int __##VERSION##_sys_nerr = NUMBERERR; \ + strong_alias (__##VERSION##_sys_nerr, __##VERSION##__sys_nerr); \ + compat_symbol (libc, __## VERSION ## _sys_nerr, sys_nerr, VERSION); \ + compat_symbol (libc, __## VERSION ## __sys_nerr, _sys_nerr, VERSION); +#endif #endif diff --git a/sysdeps/unix/sysv/linux/hppa/errlist-compat.c b/sysdeps/unix/sysv/linux/hppa/errlist-compat-data.h similarity index 100% rename from sysdeps/unix/sysv/linux/hppa/errlist-compat.c rename to sysdeps/unix/sysv/linux/hppa/errlist-compat-data.h diff --git a/sysdeps/unix/sysv/linux/mips/errlist-compat.c b/sysdeps/unix/sysv/linux/mips/errlist-compat-data.h similarity index 100% rename from sysdeps/unix/sysv/linux/mips/errlist-compat.c rename to sysdeps/unix/sysv/linux/mips/errlist-compat-data.h diff --git a/sysdeps/unix/sysv/linux/sparc/errlist-compat.c b/sysdeps/unix/sysv/linux/sparc/errlist-compat-data.h similarity index 100% rename from sysdeps/unix/sysv/linux/sparc/errlist-compat.c rename to sysdeps/unix/sysv/linux/sparc/errlist-compat-data.h From patchwork Wed May 11 19:54:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 53823 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C62A3836427 for ; Wed, 11 May 2022 19:57:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C62A3836427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652299056; bh=KizOQ6DewSQwNdP2yEnOUAJF7CSc/MQwromnrTl8PDo=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=dZevbAVIMI3xZa2rozNGRNLzFAE6eSlvWuzwo2C+Py3xe2gzW3/VBxCbXGL1uCiFQ HEN0EkMiL0tbyy9KvPNlsQUr/KnRg+qZTP1cnbmsVXzWEOy7I40Na5A4SMswCvCCjC TEegP0irCHAQ2cEZfDV9ZqpB+3PRaCdvZ2FMKO6Y= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 3937A3836430 for ; Wed, 11 May 2022 19:55:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3937A3836430 Received: by mail-oi1-x22f.google.com with SMTP id y63so3969351oia.7 for ; Wed, 11 May 2022 12:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KizOQ6DewSQwNdP2yEnOUAJF7CSc/MQwromnrTl8PDo=; b=fBv/1R+ZbLZZJ8InTTiReaN1nLm5H2QRWBhz95Z7B6InIKJ700NGwa2nmwaIj2V/1J 8Amq5qDkWXjzlQhuhpCI5enqozOs219GWIU8YkedkOUUusg+nSMpWVhkeI6ELIV6YPRD uSj/2tBBCavQfJsOHxoozGNikiceLAbzulkeljFAPf19zMtzUIPQwQHEH+DPhBI2V35u GaS4ySUdOQaZC/ioGtZVBsdQ8OANdCQkoUsyiU8oD5w9uKFYE2rM7FLkqqAUWIhP2bDx Z9ubprIrhs/VQBSj4kUv5Pb6WErniJOX+yAc+yIqQNzxJEyMSMt7K8DK0ABweX9lATQF 912Q== X-Gm-Message-State: AOAM531NKQSIxHTKVBAdVi6qa7J5xAxP7JdlcptSxZNUkiDz9iD9ABY3 SS37Y02qwfHF8u6hkzGqWyPF/9gJUj+dbA== X-Google-Smtp-Source: ABdhPJxUgqlfMmppeVVV6qEHRKsPYwDzq4F+o5NSfZDU1r4F68q/oZMsxXzTZ8wadFAdbnzufTYlFg== X-Received: by 2002:a05:6808:1892:b0:327:fc9c:94de with SMTP id bi18-20020a056808189200b00327fc9c94demr3378471oib.143.1652298909061; Wed, 11 May 2022 12:55:09 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b]) by smtp.gmail.com with ESMTPSA id k22-20020a05687015d600b000edde90fac9sm886322oad.53.2022.05.11.12.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:55:08 -0700 (PDT) To: libc-alpha@sourceware.org, Fangrui Song Subject: [PATCH 3/4] stdio: Remove the usage of $(fno-unit-at-a-time) for siglist.c Date: Wed, 11 May 2022 16:54:56 -0300 Message-Id: <20220511195457.410681-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220511195457.410681-1-adhemerval.zanella@linaro.org> References: <20220511195457.410681-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The siglist.c is build with -fno-toplevel-reorder to avoid compiler to reorder the compat assembly directives due a static linker issue [1] (fixed on 2.39). This patch removes the compiler flags by split the compat symbol generation in two phases. First the __sys_siglist and __sys_sigabbrev without any compat symbol directive is preprocessed to generate an assembly source code. This generate assembly is then used as input on a platform agnostic siglist.S which then creates the compat definitions. This prevents compiler to move any compat directive prior the _sys_errlist_internal definition itself. Checked on a make check run-built-tests=no on all affected ABIs. --- include/signal.h | 6 ++--- stdio-common/Makefile | 14 +++++++++- stdio-common/{siglist.c => siglist-gen.c} | 4 --- stdio-common/siglist.S | 7 +++++ ...{siglist-compat.h => siglist-compat-def.h} | 27 ++++++++++--------- sysdeps/generic/siglist-compat.c | 1 - .../{siglist-compat.c => siglist-compat.h} | 7 +++-- .../{siglist-compat.c => siglist-compat.h} | 7 +++-- 8 files changed, 47 insertions(+), 26 deletions(-) rename stdio-common/{siglist.c => siglist-gen.c} (92%) create mode 100644 stdio-common/siglist.S rename sysdeps/generic/{siglist-compat.h => siglist-compat-def.h} (69%) delete mode 100644 sysdeps/generic/siglist-compat.c rename sysdeps/mach/hurd/{siglist-compat.c => siglist-compat.h} (86%) rename sysdeps/unix/sysv/linux/{siglist-compat.c => siglist-compat.h} (87%) diff --git a/include/signal.h b/include/signal.h index 2a278697c1..73f18dddd7 100644 --- a/include/signal.h +++ b/include/signal.h @@ -14,10 +14,8 @@ libc_hidden_proto (__sigpause) libc_hidden_proto (raise) libc_hidden_proto (__libc_current_sigrtmin) libc_hidden_proto (__libc_current_sigrtmax) -extern const char * const __sys_siglist[_NSIG]; -libc_hidden_proto (__sys_siglist) -extern const char * const __sys_sigabbrev[_NSIG]; -libc_hidden_proto (__sys_sigabbrev) +extern const char * const __sys_siglist[_NSIG] attribute_hidden; +extern const char * const __sys_sigabbrev[_NSIG] attribute_hidden; /* Now define the internal interfaces. */ extern __sighandler_t __bsd_signal (int __sig, __sighandler_t __handler); diff --git a/stdio-common/Makefile b/stdio-common/Makefile index 087acb82b6..98872d9f88 100644 --- a/stdio-common/Makefile +++ b/stdio-common/Makefile @@ -215,6 +215,8 @@ tests := \ generated += \ errlist-data-aux.os \ errlist-data-aux.o \ + siglist-aux.os \ + siglist-aux.o \ # generated test-srcs = tst-unbputc tst-printf tst-printfsz-islongdouble @@ -262,6 +264,17 @@ $(objpfx)errlist-data-aux.o: errlist-data-gen.c $(objpfx)errlist-data.os: $(objpfx)errlist-data-aux.os $(objpfx)errlist-data.o: $(objpfx)errlist-data-aux.o +$(objpfx)siglist-aux.os: siglist-gen.c + $(make-target-directory) + $(compile-command.c) $(no-stack-protector) -S + +$(objpfx)siglist-aux.o: siglist-gen.c + $(make-target-directory) + $(compile-command.c) $(no-stack-protector) -S + +$(objpfx)siglist.os: $(objpfx)siglist-aux.os +$(objpfx)siglist.o: $(objpfx)siglist-aux.o + ifeq ($(run-built-tests),yes) LOCALES := \ de_DE.ISO-8859-1 \ @@ -350,7 +363,6 @@ CFLAGS-isoc99_vfscanf.c += -fexceptions CFLAGS-isoc99_vscanf.c += -fexceptions CFLAGS-isoc99_fscanf.c += -fexceptions CFLAGS-isoc99_scanf.c += -fexceptions -CFLAGS-siglist.c += $(fno-unit-at-a-time) # scanf14a.c and scanf16a.c test a deprecated extension which is no # longer visible under most conformance levels; see the source files diff --git a/stdio-common/siglist.c b/stdio-common/siglist-gen.c similarity index 92% rename from stdio-common/siglist.c rename to stdio-common/siglist-gen.c index bb88d5300f..95441b707d 100644 --- a/stdio-common/siglist.c +++ b/stdio-common/siglist-gen.c @@ -26,7 +26,6 @@ const char *const __sys_siglist[NSIG] = #include #undef init_sig }; -libc_hidden_def (__sys_siglist) const char *const __sys_sigabbrev[NSIG] = { @@ -34,6 +33,3 @@ const char *const __sys_sigabbrev[NSIG] = #include #undef init_sig }; -libc_hidden_def (__sys_sigabbrev) - -#include diff --git a/stdio-common/siglist.S b/stdio-common/siglist.S new file mode 100644 index 0000000000..327f105e6f --- /dev/null +++ b/stdio-common/siglist.S @@ -0,0 +1,7 @@ +#ifdef SHARED +# include "siglist-aux.os" +#else +# include "siglist-aux.o" +#endif + +#include diff --git a/sysdeps/generic/siglist-compat.h b/sysdeps/generic/siglist-compat-def.h similarity index 69% rename from sysdeps/generic/siglist-compat.h rename to sysdeps/generic/siglist-compat-def.h index 05a0d63855..f5a1840dc3 100644 --- a/sysdeps/generic/siglist-compat.h +++ b/sysdeps/generic/siglist-compat-def.h @@ -28,20 +28,23 @@ sys_sigabbrev alias to __sys_sigabbrev. Both target alias are define in siglist.c. */ #define DEFINE_COMPAT_SIGLIST(NUMBERSIG, VERSION) \ - declare_symbol_alias (__ ## VERSION ## _sys_siglist, \ - __sys_siglist, \ - object, NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)); \ - declare_symbol_alias (__ ## VERSION ## sys_siglist, \ - __sys_siglist, \ - object, NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)); \ - declare_symbol_alias (__ ## VERSION ## _sys_sigabbrev, \ - __sys_sigabbrev, \ - object, NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)); \ + declare_object_symbol_alias (__ ## VERSION ## _sys_siglist, \ + __sys_siglist, \ + NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)) \ + ASM_LINE_SEP \ + declare_object_symbol_alias (__ ## VERSION ## sys_siglist, \ + __sys_siglist, \ + NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)) \ + ASM_LINE_SEP \ + declare_object_symbol_alias (__ ## VERSION ## _sys_sigabbrev, \ + __sys_sigabbrev, \ + NUMBERSIG * (ULONG_WIDTH / UCHAR_WIDTH)) \ + ASM_LINE_SEP \ compat_symbol (libc, __## VERSION ## _sys_siglist, _sys_siglist, \ - VERSION); \ + VERSION) ASM_LINE_SEP \ compat_symbol (libc, __## VERSION ## sys_siglist, sys_siglist, \ - VERSION); \ + VERSION) ASM_LINE_SEP \ compat_symbol (libc, __## VERSION ## _sys_sigabbrev, sys_sigabbrev, \ - VERSION); \ + VERSION) #endif diff --git a/sysdeps/generic/siglist-compat.c b/sysdeps/generic/siglist-compat.c deleted file mode 100644 index 6e25b021ab..0000000000 --- a/sysdeps/generic/siglist-compat.c +++ /dev/null @@ -1 +0,0 @@ -/* Empty. */ diff --git a/sysdeps/mach/hurd/siglist-compat.c b/sysdeps/mach/hurd/siglist-compat.h similarity index 86% rename from sysdeps/mach/hurd/siglist-compat.c rename to sysdeps/mach/hurd/siglist-compat.h index 5334b0885b..17bb0401aa 100644 --- a/sysdeps/mach/hurd/siglist-compat.c +++ b/sysdeps/mach/hurd/siglist-compat.h @@ -16,12 +16,15 @@ License along with the GNU C Library; if not, see . */ -#include +#include +/* To get _NSIG definition. */ +#define _SIGNAL_H +#include #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_1) DEFINE_COMPAT_SIGLIST (33, GLIBC_2_0) #endif #if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_32) -DEFINE_COMPAT_SIGLIST (NSIG, GLIBC_2_1) +DEFINE_COMPAT_SIGLIST (_NSIG, GLIBC_2_1) #endif diff --git a/sysdeps/unix/sysv/linux/siglist-compat.c b/sysdeps/unix/sysv/linux/siglist-compat.h similarity index 87% rename from sysdeps/unix/sysv/linux/siglist-compat.c rename to sysdeps/unix/sysv/linux/siglist-compat.h index cbc77289c0..2a9801276d 100644 --- a/sysdeps/unix/sysv/linux/siglist-compat.c +++ b/sysdeps/unix/sysv/linux/siglist-compat.h @@ -16,7 +16,10 @@ License along with the GNU C Library; if not, see . */ -#include +#include +/* To get _NSIG definition. */ +#define _SIGNAL_H +#include #if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_1) DEFINE_COMPAT_SIGLIST (32, GLIBC_2_0) @@ -27,5 +30,5 @@ DEFINE_COMPAT_SIGLIST (64, GLIBC_2_1) #endif #if SHLIB_COMPAT (libc, GLIBC_2_3_3, GLIBC_2_32) -DEFINE_COMPAT_SIGLIST (NSIG, GLIBC_2_3_3) +DEFINE_COMPAT_SIGLIST (_NSIG, GLIBC_2_3_3) #endif From patchwork Wed May 11 19:54:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 53824 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E3613836438 for ; Wed, 11 May 2022 19:58:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E3613836438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652299098; bh=bnA6YvgBx5P1WNGG7r+HMNDuy1BIDFMdrOsEhmxyM24=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wWxSoYY43hJwM5XafoBfm8BrCVPtwlMyURMdlu3h5ltjDkiTp+sKIqHRRte4s9e5t gL8UoWC7wfoQcusYYOXJ2atZ8mhn8eFPBxl38Q/UHFKzg6tos7RJ/nI3gNASgImMu5 dhDmomQ8qMZa7KMpdsP/tpP49zr21ydkQK/BcTn8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id E00C93836432 for ; Wed, 11 May 2022 19:55:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E00C93836432 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-e2fa360f6dso4156750fac.2 for ; Wed, 11 May 2022 12:55:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bnA6YvgBx5P1WNGG7r+HMNDuy1BIDFMdrOsEhmxyM24=; b=1unJyEA4Ai5G0223b9bW7grh+OlYx3FKr7gws6YRU0t55u8bLFChOlkjzSF66edOmu aHjLOSKWtO3FRjbedwvvknbseGWWvCQ8bVFwu1H46GS8SfDPJNOsg2m80yvv/i6j2lma wtAqWCGnwI4XmHf+LPwASWbUWTuwn7Iz8MFNPPbXoo8cbUNQVKbwJgEJ+d6xdJnlTzIz Fb8XlwgkoosYU0mYqOr7bq8UisyFBmlzP3sAVOVys4gRPsPGebaNCqmNOE0xAEOLCyP1 qM2WWvUp+Gw81Mpm0VuGtywtIzGx45A6J7S+SvliBXYWDlxrqyOtn4W8Fte0j4br5xMb TLHA== X-Gm-Message-State: AOAM5309jciGpr8AkQD5/jmbFtwBMm5ooXHADjSr+MpmxicWMuAeHvkw VU+MMwDHhtfiB64CBbCuZyWDl/IwolISIg== X-Google-Smtp-Source: ABdhPJyBT6h4MZn0M4yCwwqIUkZ2rZqFISBiMys8svUppS28tlVu1tA3TY+XbRX6kQWRLAdxUO6kpQ== X-Received: by 2002:a05:6870:ab0d:b0:ee:1743:116e with SMTP id gu13-20020a056870ab0d00b000ee1743116emr3824165oab.286.1652298910880; Wed, 11 May 2022 12:55:10 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b]) by smtp.gmail.com with ESMTPSA id k22-20020a05687015d600b000edde90fac9sm886322oad.53.2022.05.11.12.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 12:55:10 -0700 (PDT) To: libc-alpha@sourceware.org, Fangrui Song Subject: [PATCH 4/4] Remove configure fno_unit_at_a_time Date: Wed, 11 May 2022 16:54:57 -0300 Message-Id: <20220511195457.410681-5-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220511195457.410681-1-adhemerval.zanella@linaro.org> References: <20220511195457.410681-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Since it is not used any longer. --- config.make.in | 1 - configure | 32 -------------------------------- configure.ac | 19 ------------------- 3 files changed, 52 deletions(-) diff --git a/config.make.in b/config.make.in index fff4c78dd0..d7c416cbea 100644 --- a/config.make.in +++ b/config.make.in @@ -68,7 +68,6 @@ have-selinux = @have_selinux@ have-libaudit = @have_libaudit@ have-libcap = @have_libcap@ have-cc-with-libunwind = @libc_cv_cc_with_libunwind@ -fno-unit-at-a-time = @fno_unit_at_a_time@ bind-now = @bindnow@ use-default-link = @use_default_link@ have-cxx-thread_local = @libc_cv_cxx_thread_local@ diff --git a/configure b/configure index 716dc041b6..ff2c406b3b 100755 --- a/configure +++ b/configure @@ -620,7 +620,6 @@ libc_cv_cc_loop_to_function libc_cv_cc_submachine libc_cv_cc_nofma libc_cv_mtls_dialect_gnu2 -fno_unit_at_a_time libc_cv_has_glob_dat libc_cv_fpie libc_cv_z_execstack @@ -6226,37 +6225,6 @@ fi $as_echo "$libc_cv_has_glob_dat" >&6; } -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fno-toplevel-reorder -fno-section-anchors" >&5 -$as_echo_n "checking for -fno-toplevel-reorder -fno-section-anchors... " >&6; } -if ${libc_cv_fno_toplevel_reorder+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.c <&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; } -then - libc_cv_fno_toplevel_reorder=yes -else - libc_cv_fno_toplevel_reorder=no -fi -rm -f conftest* -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_fno_toplevel_reorder" >&5 -$as_echo "$libc_cv_fno_toplevel_reorder" >&6; } -if test $libc_cv_fno_toplevel_reorder = yes; then - fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" -else - fno_unit_at_a_time=-fno-unit-at-a-time -fi - - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -mtls-dialect=gnu2" >&5 $as_echo_n "checking for -mtls-dialect=gnu2... " >&6; } if ${libc_cv_mtls_dialect_gnu2+:} false; then : diff --git a/configure.ac b/configure.ac index d08ad4d64e..eb5bc6a131 100644 --- a/configure.ac +++ b/configure.ac @@ -1383,25 +1383,6 @@ fi rm -f conftest*]) AC_SUBST(libc_cv_has_glob_dat) -AC_CACHE_CHECK(for -fno-toplevel-reorder -fno-section-anchors, libc_cv_fno_toplevel_reorder, [dnl -cat > conftest.c <&AS_MESSAGE_LOG_FD]) -then - libc_cv_fno_toplevel_reorder=yes -else - libc_cv_fno_toplevel_reorder=no -fi -rm -f conftest*]) -if test $libc_cv_fno_toplevel_reorder = yes; then - fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" -else - fno_unit_at_a_time=-fno-unit-at-a-time -fi -AC_SUBST(fno_unit_at_a_time) - AC_CACHE_CHECK([for -mtls-dialect=gnu2], libc_cv_mtls_dialect_gnu2, [dnl cat > conftest.c <