From patchwork Tue Apr 5 09:46:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Coldrick X-Patchwork-Id: 52635 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0F3D3857418 for ; Tue, 5 Apr 2022 09:47:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0F3D3857418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649152047; bh=Cp6zCzxOjjXAKPJaf9Hh0NDnk+FLFgusedxqyzITjfY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=KjE6S+XpHQCHQP9TJc6I1D/GeIIuAN/+/K+WqHTI84VGH8Ii/CBt5ew0aN/wsdMKx W8JXEPt1vbFPbE08Gdic6wxEBhjv5SGqugbPN1qXassmMDaHDGu3My7Lj3Q2e40QF+ Nn0k1r6IH37HaRyrPt02gCsTEvTMHmts1Ja+yyUw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk [78.40.148.184]) by sourceware.org (Postfix) with ESMTPS id 983833858D37 for ; Tue, 5 Apr 2022 09:47:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 983833858D37 Received: from host86-178-246-183.range86-178.btcentralplus.com ([86.178.246.183] helo=menegroth.lan) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1nbfmC-0008Bh-VX; Tue, 05 Apr 2022 10:47:05 +0100 To: libc-alpha@sourceware.org Subject: [PATCH] manual: Avoid name collision in libm ULP table [BZ #28956] Date: Tue, 5 Apr 2022 10:46:54 +0100 Message-Id: <20220405094654.111306-1-thomas.coldrick@codethink.co.uk> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_COUK, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Coldrick via Libc-alpha From: Tom Coldrick Reply-To: Tom Coldrick Cc: Tom Coldrick Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The 32-bit and 64-bit variants of RISC-V share the same name - "RISC-V" - when generating the libm error table for the info pages. This collision, and the way how the table is generated, mean that the values in the final table for "RISC-V" may be either for the 32- or 64-bit variant, with no indication as to which. As an additional side-effect, this makes the build non-reproducible, as the error table generated is dependent upon the host filesystem implementation. To solve this issue, the libm-test-ulps-name files for both variants have been modified to include their word size, so as to remove the collision and provide more accurate information in the table. An alternative proposed was to merge the two variants' ULP values into a single file, but this would mean that information about error values is lost, as the two variants are not identical. Some differences are considerable, notably the values for the exp() function are large. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell --- sysdeps/riscv/rv32/rvd/libm-test-ulps-name | 2 +- sysdeps/riscv/rv64/rvd/libm-test-ulps-name | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name index 827fcdca19..6d2816082e 100644 --- a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name +++ b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name @@ -1 +1 @@ -RISC-V +RISC-V 32-bit diff --git a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name index 827fcdca19..9cb50380df 100644 --- a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name +++ b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name @@ -1 +1 @@ -RISC-V +RISC-V 64-bit