From patchwork Wed Mar 16 15:43:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 52008 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D227385380D for ; Wed, 16 Mar 2022 15:44:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D227385380D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1647445453; bh=UbC+72sozl+aBHjMGFACl1gm5/B00JTflUD1JAxwHHs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=tZPwhkSgefV1ae36LEqd/aG2hn1wNbuHRJSOrcFtefEuenJd8kHMyFX2+2UcJ5gsW LppfB8/R+N0PWt3JdERLGIjYWAb60l/pGQ4hTlC3lJeNeWsrwOTo0A5+xlz3yzz6u1 X8AI6vpCqnUryJ7Xq9rjcD3IjFdLZS2H7sOdhEeg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 161A43858D1E for ; Wed, 16 Mar 2022 15:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 161A43858D1E Received: by mail-pj1-x102f.google.com with SMTP id mr5-20020a17090b238500b001c67366ae93so515639pjb.4 for ; Wed, 16 Mar 2022 08:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=UbC+72sozl+aBHjMGFACl1gm5/B00JTflUD1JAxwHHs=; b=hdTWkV8gJ693m8eIAwQjY78qChTr8eo8NH1LV72pEz+oQa4EeAOYYyIgvoI5zl393j AcJYp9mGn7S2eIzHB7MBXMx0Nmvr+Ekwdc5f8R/kRSeOTOTWk1Lcx9em90xMDbgEJOIB bdjZWhlYXakbp4+Jbyu7OZWtrMXLQOlrOxqerElYEICwluJpn0DG+5yIq7ePVjeS18mS MOrHPZI31QMZEOQF3bgIhurHPlwPBIIzUSFVWxwZg+ORTTOmLnDAQcEGIO0jjDLPVM3c J9174Z0/UhNkjlYGROWqeO6qbRivpSaMYqbBwk18CCpetIZN6tBAaXXyQ89YA3zGN3bh XSxw== X-Gm-Message-State: AOAM533mwzB1Jm9n2zGNx3YEonjUmPakBIIaxABADX/9DA3wnAR3V/yn 9MfjsfixdYxh2aYcNJVLQx9SZm424LY= X-Google-Smtp-Source: ABdhPJxffx5ScMoi3PrW8W4V0r88wm63PzZwCkN5FFIGS9OWWbw9D05R8FCZ3rOUZWyco1rBTXzj8g== X-Received: by 2002:a17:90a:db96:b0:1bf:a7c9:9571 with SMTP id h22-20020a17090adb9600b001bfa7c99571mr306102pjv.173.1647445429994; Wed, 16 Mar 2022 08:43:49 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.58.35.176]) by smtp.gmail.com with ESMTPSA id l10-20020a056a00140a00b004c55d0dcbd1sm3597941pfu.120.2022.03.16.08.43.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 08:43:49 -0700 (PDT) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 558ECC00EC for ; Wed, 16 Mar 2022 08:43:48 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] benchtests: Use "=" instead of ":=" [BZ #28970] Date: Wed, 16 Mar 2022 08:43:48 -0700 Message-Id: <20220316154348.250262-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches to bench and benchset. This fixes BZ #28970. Reviewed-by: Sunil K Pandey --- benchtests/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/benchtests/Makefile b/benchtests/Makefile index d513b29903..8dfca592fd 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o extra-objs += $(bench-extra-objs) others-extras = $(bench-extra-objs) -binaries-bench := $(addprefix $(objpfx)bench-,$(bench)) +# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more +# benches. +binaries-bench = $(addprefix $(objpfx)bench-,$(bench)) extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench))) -binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset)) +binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset)) extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset))) binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc)) extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))