From patchwork Sat Feb 5 09:10:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 50825 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D37163858412 for ; Sat, 5 Feb 2022 09:11:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D37163858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644052274; bh=PhQdNzZaF18mdOqLB7y4dUU6MYoKRxOaqUItBEnEiwA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XFhc0evq3yMkdchl8qYg43AyDvcfF1KiKtFsv2fm9LYqmCbLzD59jAzZEnoN+WaD4 M0WfnKyruH+JB+0OqSfY45EQa9OQOXxJYGe0R+w57J6U6NZneQIdkRq1KPQuXHAG6/ ldo9rgxPPaxuHrL/EdvlDXr0ivPT/O+/Ya1IoKW0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 846393858D28 for ; Sat, 5 Feb 2022 09:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 846393858D28 Received: by mail-io1-xd29.google.com with SMTP id n17so10352657iod.4 for ; Sat, 05 Feb 2022 01:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PhQdNzZaF18mdOqLB7y4dUU6MYoKRxOaqUItBEnEiwA=; b=cJmOvyFap5BZPn5I/nXfSJFJip1/FrAfeDTHKfi75eqkbVFpMif0+0Usm9vUmrgyP/ ozRgBtirxBJfWdRNqvfTkcGBlP4EGEL14PjeU8x2/GltU57fs6vpXlklx+mHd8MbMOoo N0qNqG+qM7bb2SJ1qF2ABZPnC6TEoK3NO0KhAu/+EVqqtNffEXVVAS/AwzGqHASaeXJ5 Ef9ugncBjiwK4ELBJ+t3TKAO5PflO7RK2JquGdBaq08zZgcoTqN4fUu+kZ4ekhiheMBX ZNdJzFquYEg0PKY92KcIt48+5IEhhT6QkS/kwyrNz/rt3oAs+DceErtKIGAUzkCeQGtd Qivw== X-Gm-Message-State: AOAM530OUiG+N1JGwfC6rTf6oYgEA3UdqT/owtyMYFdIr8C/zBwUBKyE m6eXqxqud3CYa+f49v0vz2cPgXOQKKo= X-Google-Smtp-Source: ABdhPJwsAVDkmd+OYAgfJxwGUgtOsKOUdH/1XYPSJrZbqvMJawm/iy5UZ1Q6IRNYd5q8zCgvURcXxw== X-Received: by 2002:a05:6638:dd0:: with SMTP id m16mr1556824jaj.42.1644052252709; Sat, 05 Feb 2022 01:10:52 -0800 (PST) Received: from localhost.localdomain (node-17-161.flex.volo.net. [76.191.17.161]) by smtp.googlemail.com with ESMTPSA id i10sm2197628ilv.86.2022.02.05.01.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Feb 2022 01:10:52 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c Date: Sat, 5 Feb 2022 03:10:44 -0600 Message-Id: <20220205091044.2014455-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" One buf allocation is sufficient. Calling `alloc_bufs' in the loop just adds unnecessary syscall overhead. Reviewed-by: H.J. Lu --- benchtests/bench-memset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c index beba3fbe46..e1e2d5f176 100644 --- a/benchtests/bench-memset.c +++ b/benchtests/bench-memset.c @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len) FOR_EACH_IMPL (impl, 0) { do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len); - alloc_bufs (); } json_array_end (json_ctx); @@ -88,8 +87,9 @@ test_main (void) size_t i; int c = 0; - test_init (); + test_init (); + alloc_bufs (); json_init (&json_ctx, 0, stdout); json_document_begin (&json_ctx);