From patchwork Mon Jul 6 19:45:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 39928 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A543A3857C79; Mon, 6 Jul 2020 19:45:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A543A3857C79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594064717; bh=X+gBlgId7LIUA9X4RvWNcHJWgwU7JYPmO9cSyFFgm/0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wrFiUaoa2WypDce9VKmAF61jfazqt8IkRdbkV0i1D2iqeJKz47uRNpj6+SW/l4kKo OVobL9iIbfkOoY7CCFpxcb7rzWbFxCWcHE9gfRNtSgNkg1nNfOEkTxco/4ocktNLDA IyyxNyPdVvYDTfbXkDKbuJiEHh/jQaEFTLq3l2is= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id E29713858D37 for ; Mon, 6 Jul 2020 19:45:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E29713858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-121-EW-oFA70PseFdo_um0y4hA-1; Mon, 06 Jul 2020 15:45:13 -0400 X-MC-Unique: EW-oFA70PseFdo_um0y4hA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14E4A107ACCD for ; Mon, 6 Jul 2020 19:45:13 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-118.ams2.redhat.com [10.36.112.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64C3510013D9; Mon, 6 Jul 2020 19:45:09 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] elf: Do not signal LA_ACT_CONSISTENT for an empty namespace [BZ #26076] Date: Mon, 06 Jul 2020 21:45:08 +0200 Message-ID: <8736641l8b.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The auditing interface identifies namespaces by their first loaded module. Once the namespace is empty, it is no longer possible to signal LA_ACT_CONSISTENT for it because the first loaded module is already gone at that point. Tested on i686-linux-gnu and x86_64-linux-gnu. Reviewed-by: Carlos O'Donell --- elf/dl-close.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/elf/dl-close.c b/elf/dl-close.c index 73b2817bbf..8e146ecee1 100644 --- a/elf/dl-close.c +++ b/elf/dl-close.c @@ -781,8 +781,14 @@ _dl_close_worker (struct link_map *map, bool force) if (__glibc_unlikely (do_audit)) { struct link_map *head = ns->_ns_loaded; - /* Do not call the functions for any auditing object. */ - if (head->l_auditing == 0) + /* If head is NULL, the namespace has become empty, and the + audit interface does not give us a way to signal + LA_ACT_CONSISTENT for it because the first loaded module is + used to identify the namespace. + + Furthermore, do not notify auditors of the cleanup of a + failed audit module loading attempt. */ + if (head != NULL && head->l_auditing == 0) { struct audit_ifaces *afct = GLRO(dl_audit); for (unsigned int cnt = 0; cnt < GLRO(dl_naudit); ++cnt)