From patchwork Thu Jun 25 02:34:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hughes X-Patchwork-Id: 39793 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D77B73892441; Thu, 25 Jun 2020 02:34:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D77B73892441 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1593052478; bh=Ru2zub0F5x4ImPB70/2befMmLtjiPO+sNyYSFtYCtDI=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=LmB3Fd1Wwf+ahmb+FWqOQ6uLmLiqhYy8gpqmDUlPo4bE3vpJYHG8/X91G8b2TLS+y gRZNDNehsA+vA5c1+pEqoWCZXcD2w8P1kP0qzI2iMqDGM9licptXglQmxscSxIwQjz wnvNf4J5f1lHWR/H/QcMsUh+Xe1cLQwSbRH+KMpc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id A7FBF388A808 for ; Thu, 25 Jun 2020 02:34:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A7FBF388A808 Received: by mail-wr1-x429.google.com with SMTP id j94so4259432wrj.0 for ; Wed, 24 Jun 2020 19:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EY/DYa4cT8EbHq3CgT4ZeWokPcg7y9T6gutNfe739xw=; b=FQoFKOYJZKD8Fpuvq548Rb4EJPfBg3AcYv4r5UH1Yo7+Q+nD7uQBKOUzrz3pMLa9sj zYMT8On6awYGqniHtKFcYUHIQGzfJ2qfscH5ZQcO0uXRkS4iszljO7xIvwAWj+OeG17m O9ENOZbPKlOALNasvt1XeIryRuiMRNd57GMSEh9VOCPVUCaup51eE8Lhe6sN5WmgL+eq ea4weRKTWwafApMd9P5rq8eIpQ24b8C5oOiF/EJbnNV98JivDnrzS0VMMs3wGyqThUS+ 5RcOjm01WMuFAEJRcWHoOooHJ/p3kWmucGbi25kkD6AO3pBqIYkKrkUz7ktCx82fcr19 znyw== X-Gm-Message-State: AOAM530QMBBAog95+Fcn6gcbgJmkV75dFWVxpUjLCKKr8M7dBgR88Ei8 /rslnR+QR0989/Ug866v+GWUAHI2whRmMZS79/iMMK7b2Rg= X-Google-Smtp-Source: ABdhPJwiw0xT9iEUWtYZyl8sTA4ieQkxaHUPCuc6aiVdfR+8O1FbVDNnAbDvcTUF4tzK1JBztiz0eKgwP3r9O0vDE3U= X-Received: by 2002:a5d:6052:: with SMTP id j18mr33011727wrt.387.1593052474498; Wed, 24 Jun 2020 19:34:34 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 24 Jun 2020 22:34:23 -0400 Message-ID: Subject: [PATCH] Add inhibit_stack_protector to ifuncmain9 [BZ #25680] To: libc-alpha@sourceware.org X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Hughes via Libc-alpha From: David Hughes Reply-To: David Hughes Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Enabling --enable-stack-protector=all causes the following tests to fail: FAIL: elf/ifuncmain9picstatic FAIL: elf/ifuncmain9static Nick Alcock (who committed the stack protector code) marked the IFUNC resolvers with inhibit_stack_protector when he done the original work and suggested doing so again @ BZ #25680. This patch adds inhibit_stack_protector to ifuncmain9. After patch is applied, --enable-stack-protector=all does not fail the above tests. ChangeLog: 2020-06-24 Dave Hughes COMMIT: d3dfcedb2fffe54a9a9a75068f74c1f1dfb82fdf Add inhibit_stack_protector to ifuncmain9 to fix failing tests BZ #25680 * elf/ifuncmain9.c: added inhibit_stack_protector to ifunc resolver. --- elf/ifuncmain9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c index 0d3429341c..1c9ba89839 100644 --- a/elf/ifuncmain9.c +++ b/elf/ifuncmain9.c @@ -43,6 +43,7 @@ implementation (void) } static __typeof__ (implementation) * +inhibit_stack_protector resolver (void) { ++resolver_called;