From patchwork Thu Nov 18 03:01:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 47865 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0D923858404 for ; Thu, 18 Nov 2021 03:01:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0D923858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637204507; bh=kDkS4Bl4AmAatNQ27zGOrXROMtjfDYgZL3ewBmZv1zg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=PyovqMdnZ/ipxVZvStcTdS09Do5dxl/hHCour8GxNoYABKAxdpUCpv9YY39uLWSSV MlOL1j51wgveb6Dcb4K+GOWFEJJUzNaGrLkMAfONLOXNHfOomRRvOLJExkedzsDc7t KHWF6bQi9hI0JTsLNxa/tgHRwS2j8l5L6lD+JHSk= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 685093858C2C for ; Thu, 18 Nov 2021 03:01:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 685093858C2C Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AI1YEnW000708 for ; Thu, 18 Nov 2021 03:01:40 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd205cq2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AI30J0A126762 for ; Thu, 18 Nov 2021 03:01:38 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by userp3030.oracle.com with ESMTP id 3ca2fys2t0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnOBDDgiU+x9AEM3m9AHnpQGBysbN/4j/in+NmMLW+COTsE3u4OPXl8q2INVPZkO4yMXu/j4QcDX7DEOldyldE9mDkMAaeJBGedJRh/SO2vwSu7Mq7iSwQbzXg1Q9V+WWhGrpraNhLacaHuPOt4D3KN3KJjDZ+b/ts0wlJpjPscI1UamafPVqrGQ5xRjA3qFevySVFGVPQ9AkVRzQTomwmOBpvEDIkQWqVG+eT5ZeHNPj6nKx0yTAs60aOqSQSGgBYP/w6WQGj+GuqEULm0x1dBJWbumjpYsm5prdg3Y9Ydf8SMyRrpE73TqCrj0hErpkX4R/rJjwZ7d56i2Lk99fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kDkS4Bl4AmAatNQ27zGOrXROMtjfDYgZL3ewBmZv1zg=; b=TbsHBIoryGvEGw6xNolEI8I2/UrKbvRk66vscUjuKKdnVOUxNw52lJn6EmQoR4dm2+/n7kll8iCcu5x4fpPUbA9S8SxN63sGU+ydRxm7pXoVsCbeosXAaU9D/hjZ62f5h1cH9sl9b6YGe3xXja9ceE+DTvILdTQYwgBDjlDndRpTGyoNaayKOEN9WcP/VB4dIDgv9JSATVpAfeK9+MLMFCRMu0LgdAz4gMz6cs9q3R+WnJPhgRK8iwIKnNaTtcXYUugI4OmqT+/h8uG6q4wQ7PJZ6qdU35s2yn5HtfNUQZAsvYwhZC1M8Ljeuyh0ClYEjPrhdIkrmfDUoO5Ifn6cIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3982.namprd10.prod.outlook.com (2603:10b6:208:1bc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 18 Nov 2021 03:01:36 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 03:01:36 +0000 To: libabigail@sourceware.org Subject: [PATCH 1/3] ctf-reader: Use argument by reference reading the context Date: Wed, 17 Nov 2021 21:01:14 -0600 Message-Id: <20211118030116.564632-2-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> References: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) To BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) MIME-Version: 1.0 Received: from sali.us.oracle.com (2606:b400:8004:44::13) by BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.17 via Frontend Transport; Thu, 18 Nov 2021 03:01:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4582086b-5dea-4477-05d6-08d9aa3fbc2e X-MS-TrafficTypeDiagnostic: MN2PR10MB3982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PWzRlFwsWApONrUvjtI3ihI8smuvR12Cv33OSc1Lq9+Lt8a44rythVHhAR8kGZN2P/sGb61IL7qMQOTMqwSxRNge2dm+6oyrIY5AQZdPwNtFaW6nrtM9VaYj2EY62+A/KtVMJkYuPhh121Tfsk94YG8zMGQvEYfxQD4ojETqzZoEfHjYjJzVZIdezVEXnQ1y02F+HHNiSCBORB8hiLcVUKaWp7Jvaqj1rw2Rg5mzAoBciVVYmclVe6XdQAiSbeAOV3uRjkJDmh33Bcykmrb8MW34UvySCnF8bXs8KG1gJD0aLyKFYKwehjxjwm31mZyi5+EzBySg6rO/5WVUUmtH7BfzxTRAi+RHEScHh/pJZz4NBaQ3uXuQOCOjlrisxGEhLXQThM937kFT6E4WZP7RoT6YVtz/q5tFuda0dF0Jq0GxeyNfd24NXNinfUhdlMB2vXxKaDWf0Fx7Dn0Fd1FvzYlJ3F/QBzVlO6UVHZLhKH3Q8CFihkUUspenuNPx+NvTqs8KCZcBbTqetfqztRzT4PGbVz9aRUecKI0NmgnakoLdLeFe579/F1FGAJb53xHywX3QraK4rRNp0CWbcVfjvz10rAcSYwc4x+3Ec8OOxM2pMQ0EsNCQuA7pf1xDZEsWqaLvAsOyf1qsuRkiREa7jA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(6666004)(508600001)(7696005)(186003)(6916009)(66556008)(52116002)(316002)(2616005)(8676002)(2906002)(66946007)(66476007)(103116003)(6486002)(38100700002)(107886003)(86362001)(8936002)(4326008)(83380400001)(36756003)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DjMEG9kwrOZ1e/FetP7QT84/Zgrk2CFpF4QbuiI+30YPau+YVn/perUwurYNW/qMkiVo8AOmnbuP1LK++yeLabKvlRIIMrZfYKQF3CjXY2Z7p+XBGIXAXKzjDjh2VuJMTOn5EVrO46SqXA6XjB8lOrUq2EK/h4pyW9EmD1KgRGcYfZEVxu9Bt+G6BN8HgDV4QiAZBkxELXxRFvbwBI/p+K3UfcPvt4K2OSITyyis+xa3na90ysWHm0/pfVtuWBORGYMXTwqkGCVD+RYsxUdVYU35DeTLrH1VLX1RjZUT54r8IcTYrc1oEIY4ZAHaaYGbA6nfWbKVr/dz4OFQUGRYRTciYH7C0QhX6k3D/uiqDQQDqj/vcc9WSfAwoZjRCBskHz9WaZD4UNuPTMVyksTZJnlQFK2B7sZLjZy1jr++RVdugsnLs06z4M2S4OuZAFOVmITjVMv/gSNJI7ZOLTV5e1VtAsJshTwt9LbwEW3p7Ex3X7S82quWSDy0UcRoR1Sr2lKpXXBrpAXqhBkxy3ROHNlRdSaFygLt86FTD2bphOIZSGKIvP7YOPyLrEFwqa/t4z1Z2r71t/OjFAj+oJDbwZiBfZpqC+t2GxCSpsnfPveUEu91tPEqemWAgI5KIwJXOoWINOgFBq9QaDUHvyW02wX27OvrbZtmat4KKrM1Rmz8xMCAjkUG/FpQ634FhEwImXq7iB1PQrbCStZQCMn2x1PctBVmLvV8cgAWCoSSX2zcB5EwDKD2JV9Z3g8OH2o5yksi94xUKQv5dOgZOAkMZwpKfEyWua2FBJccEksdFiDvzryUclPN7ik6rclKCpy9rwnDreb6t6WUA18IXYD0thIjUGlBZjZEffV7Q8NSkktWeM7VnR1RZMcN/RQnRkNeN9PnGxbl60xqB0TOzd4t4z+7j70BH8RFFBiZIc73cUyKNYhJVc5iNB3TMiTrgn2xP8VrMOE3OTqI1hqFf51QP7V2hvFyQ50BeVAE1C0Ml1dQqU6QBv3jmD+L0nr+V1EznFGhm+jBBPuoSYohGkllvnDaciQRNpZjlm4YSUh+FPxlotWvwhAkPxhPn4xCwFfmL/w+LD9DosXNRcnk/9dMkhWQrepBWYWjCbixbdYI3ZAwa1AxMGhQtRBNazlqaZ1p9xAK6d6ynler8iyyBbW9AZq35bBfuopgjLqpjCHYiIGEJrE2RqufvAsVfvxW+SPkqTtsSlXcEbk1BL3pD+JXgRWBBmv7XossF50IDx0ytCjKJUsFEdVU5VdDKD6KZn6EPNMCjmJIo1x0CPZ/8xjv/4TRwgF+I/2dGHoxT0L3KzEMxYQuok11oGWm9SskFhaFwFTFAAvMva83XC6UmmJE34ZTxSlnLDQa873h6nmVNDOjTLwdNX2NlaJHJTjW3fu1B/y15iqHYRWVjUwITtdSQJ96NdCp+LmMxYhjJd+cPakG9gOKGKYp9tg4qT124a0uazbTpYGgbBbbLKWDA9lRSXQbG+DiJ0XgbY66Gpdo2RvleUgdM2roZ9EisifWukkYWRhODep35r/LPOVOgLJAbOQMrqCnb+89hG4MnzUCFgvLLUzTDvDvNAAvbrcECf63t0lB0YBMKIUlIQywJUUIC0zWgZO9xyq0mgltmVjkvTAI8XJLxBit1HfcTzazA1BNI56xLh11iDfFLsCgl1K0VsQRDJEG76VQsOZ6zHe1+KQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4582086b-5dea-4477-05d6-08d9aa3fbc2e X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 03:01:36.8349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v+2R3SB8sxzQ3ueM4Xu9wrJpN9Vjgq+KXgjQlyBTVkILkm2Pm9xxE9u7hFjtVNguC794gDGhJ9C+BOzqAaAqd1oC62aEwSRfUbZuVcewfvU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3982 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180016 X-Proofpoint-ORIG-GUID: Z3N1w__RrqtdY81uGCHvIejxEH0uIcaV X-Proofpoint-GUID: Z3N1w__RrqtdY81uGCHvIejxEH0uIcaV X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" * src/abg-ctf-reader.cc (read_context): Use const argument pass by reference. (create_read_context): Likewise. --- include/abg-ctf-reader.h | 8 ++++---- src/abg-ctf-reader.cc | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h index c0d8bb2b..56b2bf91 100644 --- a/include/abg-ctf-reader.h +++ b/include/abg-ctf-reader.h @@ -25,10 +25,10 @@ namespace ctf_reader { class read_context; -read_context *create_read_context (std::string elf_path, - ir::environment *env); -corpus_sptr read_corpus (read_context *ctxt, - elf_reader::status& status); +read_context *create_read_context(const std::string& elf_path, + ir::environment *env); +corpus_sptr read_corpus(read_context *ctxt, + elf_reader::status& status); } // end namespace ctf_reader } // end namespace abigail diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 0370c8aa..2c2c204d 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -102,7 +102,7 @@ public: /// Constructor. /// /// @param elf_path the path to the ELF file. - read_context(string elf_path, ir::environment *env) + read_context(const string& elf_path, ir::environment *env) { types_map.clear(); filename = elf_path; @@ -1060,7 +1060,8 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp) /// @param env a libabigail IR environment. read_context * -create_read_context(std::string elf_path, ir::environment *env) +create_read_context(const std::string& elf_path, + ir::environment *env) { return new read_context(elf_path, env); } From patchwork Thu Nov 18 03:01:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 47866 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC7033858402 for ; Thu, 18 Nov 2021 03:01:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC7033858402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637204511; bh=oEsOMi5RVHyvhy42/eFhj+VClfJbco0y1PebV8fViI8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=PaRxxh8GT6F+TyrmJ7UveQLyZ1juPEPQQSHMXJ4stagC/cCJrnWA/Ar4+VRGdWTQ1 omySWy0Qbax6kenE/CksOo6FKpH2bL9iv7eUNeX82hZTWCZjZIbkiDh0OrDazqzLUg ysDep5sXisUYE8AzNzyYUKDQVAbGbG7Ohm7Hqxjs= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 2F1E63858406 for ; Thu, 18 Nov 2021 03:01:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F1E63858406 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AI1YAlf020985 for ; Thu, 18 Nov 2021 03:01:40 GMT Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd4qykc2a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:40 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AI30iuf028236 for ; Thu, 18 Nov 2021 03:01:39 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by aserp3020.oracle.com with ESMTP id 3ca567whb8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msLq323EktMNHKKE5GkVpxlf92274WWSDKM6LJung7YykoMmMJ2t1zP3fKzCsA8xQxmv9+6KN1xMLeRchR9RzC6HgRNfFoUIyaaviBL2S2BnSJQHkU9yf+jIMzjly+c8/ujene7DiwnVpA+mlsWrTq6Lf9KFcVRMVMpjsVeV8BE2T98yu0dQAK1piuI7YKUZtErcLWuKtNbM/XaSZWU6pG54JSHvJRVx2yKr5KtwDKao8p/O++a10xj2T2DzLmVjLAR8fS9/dFLjZp/CEg916Z7hp0jo07xoK8XJbBCw5QE8dur5Gvi8KmjJsCOaxF0MGgq6PwRqf57WXWUkkqwTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oEsOMi5RVHyvhy42/eFhj+VClfJbco0y1PebV8fViI8=; b=fp5HELaTaoD2lOtAq0vGlEpmEn9r7qVhZEejQLV+HVaK2CNabTBSoUlAX5kHHR/wbOWZlK+p9pGu7Y96KaBujbJy1OJxPKUjLYkXVf5zyF9JvJd11WwOmDO0sat52dhkAfpNZ1by8wvxl6jqZVY2qU6zUCF4XgjVkw76Cpjb44c6sNSRDyMLfXKpphE23iKQk2aJFgxjfq/PU0j9+Dh5e5fAQskR/A0CiC8L1OZCuG9zSKlo5xPjytL3M/AlAFUEz+xMKm6P/inFRGdrL1QWtjNKqJa+p3YqJGWCTsuRY2dYUc20dUTeauzghSiUr7Kr3WyknMHCenRxDG1ZNbJwSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3982.namprd10.prod.outlook.com (2603:10b6:208:1bc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 18 Nov 2021 03:01:38 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 03:01:38 +0000 To: libabigail@sourceware.org Subject: [PATCH 2/3] ctf-reader: Use smart pointers in create_read_context Date: Wed, 17 Nov 2021 21:01:15 -0600 Message-Id: <20211118030116.564632-3-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> References: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) To BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) MIME-Version: 1.0 Received: from sali.us.oracle.com (2606:b400:8004:44::13) by BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.17 via Frontend Transport; Thu, 18 Nov 2021 03:01:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a24b067-467b-44de-43d0-08d9aa3fbd18 X-MS-TrafficTypeDiagnostic: MN2PR10MB3982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:639; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VuOTeqFMiLXovT0SiGOfmmqnRBXobiPQY7Ywj/fp0+SckOhpE1uSHcuBpEsjoS0M3mXoYo0M9kB+zxXs2uyMEZ+BVjGAZer2SiDyG6Ak+Nzk4US9PsfglZ4V18MUUyDnFzO3wGOuLvYq4zGPsvrBlf9+KBVfX5aQJCwp68jJI8BYFv2ge+x3IyUyt9mwSDemCMwGLxU8HsrDQogIYO7YTt3ChgS79jq++ptKzDr5Ezy/cjaK3VjTSTKSrpCt2wOQpgCbiJ9efupoKY3f9VXyqgw//Ljl9c4JMLfo9X8h5yKUbbhts7pXF2F6UTYNLEm6MJN108qOAwqxaDAIrSZQ0qLbeiu3lYDEVTd4tu+bnoFClj1K0fe1SF4cU2Q8esy+dA9SHNIWs9t+I5u7j5HRbhvCJios6jAwCN618sgvZPZIZZ/szGXR3WgoaHnDV/r6Z1v6uyXWVip1SXW+IdVSemeeIUNElIAOs5D9523U42aqQkHMIsLy374pYHHFQXdwV1UZR+q0kZqHCFMQGKPgBfxfwA1VVNInnmsicQyXW2FV/iaMK8Z8vUCrFO8rOkfmGoSv8UIoUkm2GgrDRP0mtOt7HYgTTdSmAT5p1SA/TESTQT0qtjyehtCoL0MxA1HcAC7uDFfIeKtccSeqtATuYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(6666004)(508600001)(7696005)(186003)(6916009)(66556008)(52116002)(316002)(2616005)(8676002)(2906002)(66946007)(66476007)(103116003)(6486002)(38100700002)(107886003)(86362001)(8936002)(4326008)(83380400001)(36756003)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 603VMnXma3e/Rd9/MMp5ea/jvYnUYVsJJNpSFV4fCCbod6ix2WQ0JJUym0TsoBJny05LZHIMGh/qiR+cubME2O9fKqSnROPe1TW916w8FY5ehjKy9ArC/u0LLOxOo2h9tSy9B62UpNp+uecIrBahuBRWHZIfm3T4GmgtVHMlqONcViNKGmh+jrljKqD783DQpQZJA7CDOenY+bIllevTGR4Oe8oxhM1OPEemkFae59ogfPnCMSmPJxiw5AoyGBYGxo3SEKQ7KcYTPM2s099IBtnTxCGvMdboEXTEZ0/mVcgNSwieNcgmO4iTA2ndc89vr4BM3dSNxaH3QpL+xHWMOnULiZORLGEIsCB/ONeDHWjgxNiJdpqMGmenKv6MKBXU8RZQkojPp/b0ULTHsv5fV8pN6WGAFEu81sO6pENQQImQN+5Rject5wGKRbL2yE57EaWQ1ivKO8a9y28VfVvXlgVcUWbeFKhlFmcPM5U1xRVSDsAtSrIsQdiwNjis43GfEvpU1U03cvIU19FCqlUkseU9NAWXnLS2aLjxbiVvR1pVI6JMOz8k0pibv4qSPPtvhlQIU1tEQhGQ8H66eBpYvbPfyZX2/rTww6C38hK1EKx5a3fa/QxgYRhGbaIh6O+4hMcMKmMgcLBMwFUIbyAmAg9oxJcIrf4lgBrH8vLFHDPSbPJ8xoVC/H/9PygOKNP8QajQ7QIoBhOGq/AJIO0Z/BkuiEGGqoEqj3aUIQXCawk/LIvsAZdsMQSaZ6apAR1IKuMFOqSCTN7QAa7obapiFxXNgctm+gbw6YlKCeR08Juxbr7SIX/ikI0G2G0N5DPQjKUwqwShsMfCGr+5fDoMu0AaWov4k9L5fzzCPAfYa2gSYAXUNi14TBXE3QPMjecbbm0m+qjbRJmErlP/N2qUJ68uF+NduBMwd1Efa/EYGrIaIgXVObh6VapS8nYgBt0BN571eYrtBnd7WJ++DeGbKxOTRa1nq+rBXHCR7XvaqNE3O36Yh2iGuLCBJMiLflGKYEJdLZwsSOySYvCN6ksMUTvTA7is7F2DHZo8hhFykUzdA3TyAqDBsYNVkuaJzfNzdEVROCuULTsIV5toIWJDQuvvZ+tgCjAa5AJfN29wDErdd61lnKn9oWEd8KrHVHMkaf2WyIUL+BI0zG6MAMujqBYZMwQYKco0N58ru1+6YGz7PZn9qNYXdiu8TuVxfhmHLePnX8ljA5UPlQtzk6AOcToeN9jwxVBhfjoj632Aj5mv9qzoVigIKhLGSoDP6E8xzGXW0YIiEVaa0n/6dYbnETkzRFkrRH07I5ys8EDZ4HCj/mStzgsolYgO713hXqVd9i/4HKnnJislKPr1ZgdSxzMVy9vQwnz89ROQT4Nx1QoVcsr29H8SLJsDe6ZBffMffemcCh6X+maIDPEIAxQJ+mQSn3Q8rmX1mEw78HJe/AXIdUNUqUU0hSuzTv+9H4UUaKb9NM6tnTYvw1JsA/Xcbol5STVutjTzd8ES+kpMDXAXmTFUgnWbwK/dNi3LTGTIVlt7FkJZSM1p1ojQ5Nj4mTMNXPgxRg8ZB2a91VTMI7Mt/bWKsVKz435ViN8JKA0Pm0LlH6O+gAMRLt42PvozejaU4x6XXBK/acpFflDWDS8cKW1ScNapmCbd1Gg9UYNZ51iHpqnP8jDvPnSm2cm9hXRdRN8g3WWftVip33IPhRk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a24b067-467b-44de-43d0-08d9aa3fbd18 X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 03:01:38.3580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s4SU1KrEHiBd6ZW9mO3ILv244Rtyx8XGKKrGIAbVUiaXlMdAk8A/Zp4ehxMmQX6PUB+eVBieCSNqBYN+oQqo8g0C2n0TzibxYSybjeNaJTk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3982 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180016 X-Proofpoint-ORIG-GUID: E2CCw6VFVVlH5ed50k-rSLJGAfXiFROL X-Proofpoint-GUID: E2CCw6VFVVlH5ed50k-rSLJGAfXiFROL X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" * include/abg-ctf-reader.h (read_context_sptr): New typedef. (create_read_context): Use smart pointer as return value. * src/abg-ctf-reader.cc: Likewise. * tools/abidiff.cc (main): Use read_context_sptr. * tools/abilint.cc: Likewise. --- include/abg-ctf-reader.h | 7 +++++-- src/abg-ctf-reader.cc | 5 +++-- tools/abidiff.cc | 18 ++++++++++-------- tools/abilint.cc | 8 ++++---- 4 files changed, 22 insertions(+), 16 deletions(-) diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h index 56b2bf91..c527c2ff 100644 --- a/include/abg-ctf-reader.h +++ b/include/abg-ctf-reader.h @@ -25,8 +25,11 @@ namespace ctf_reader { class read_context; -read_context *create_read_context(const std::string& elf_path, - ir::environment *env); +typedef shared_ptr read_context_sptr; + +read_context_sptr +create_read_context(const std::string& elf_path, + ir::environment *env); corpus_sptr read_corpus(read_context *ctxt, elf_reader::status& status); diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc index 2c2c204d..3e17e049 100644 --- a/src/abg-ctf-reader.cc +++ b/src/abg-ctf-reader.cc @@ -1059,11 +1059,12 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp) /// @param elf_path the patch of some ELF file. /// @param env a libabigail IR environment. -read_context * +read_context_sptr create_read_context(const std::string& elf_path, ir::environment *env) { - return new read_context(elf_path, env); + read_context_sptr result(new read_context(elf_path, env)); + return result; } /// Read the CTF information from some source described by a given diff --git a/tools/abidiff.cc b/tools/abidiff.cc index f145f4f1..30959616 100644 --- a/tools/abidiff.cc +++ b/tools/abidiff.cc @@ -1169,12 +1169,13 @@ main(int argc, char* argv[]) #ifdef WITH_CTF if (opts.use_ctf) { - abigail::ctf_reader::read_context *ctxt - = abigail::ctf_reader::create_read_context (opts.file1, - env.get()); + abigail::ctf_reader::read_context_sptr ctxt + = abigail::ctf_reader::create_read_context(opts.file1, + env.get()); assert (ctxt); - c1 = abigail::ctf_reader::read_corpus (ctxt, c1_status); + c1 = abigail::ctf_reader::read_corpus(ctxt.get(), + c1_status); } else #endif @@ -1252,12 +1253,13 @@ main(int argc, char* argv[]) #ifdef WITH_CTF if (opts.use_ctf) { - abigail::ctf_reader::read_context *ctxt - = abigail::ctf_reader::create_read_context (opts.file2, - env.get()); + abigail::ctf_reader::read_context_sptr ctxt + = abigail::ctf_reader::create_read_context(opts.file2, + env.get()); assert (ctxt); - c2 = abigail::ctf_reader::read_corpus (ctxt, c2_status); + c2 = abigail::ctf_reader::read_corpus (ctxt.get(), + c2_status); } else #endif diff --git a/tools/abilint.cc b/tools/abilint.cc index 49643b66..2e9bae49 100644 --- a/tools/abilint.cc +++ b/tools/abilint.cc @@ -370,12 +370,12 @@ main(int argc, char* argv[]) #ifdef WITH_CTF if (opts.use_ctf) { - abigail::ctf_reader::read_context *ctxt - = abigail::ctf_reader::create_read_context (opts.file_path, - env.get()); + abigail::ctf_reader::read_context_sptr ctxt + = abigail::ctf_reader::create_read_context(opts.file_path, + env.get()); assert (ctxt); - corp = abigail::ctf_reader::read_corpus (ctxt, s); + corp = abigail::ctf_reader::read_corpus (ctxt.get(), s); } else #endif From patchwork Thu Nov 18 03:01:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guillermo E. Martinez" X-Patchwork-Id: 47867 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25A00385843D for ; Thu, 18 Nov 2021 03:01:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25A00385843D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637204514; bh=nUxggkM1Jtklp5SCLltUjuil1wo45gakV/Q1wkdetKI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=RO68CPZ30kRrwbBGQgCxA5r1o9RFRYyq+3IO2IU2zL1WARWNOdQs84VG/zhDdTiT3 Jn5g414oJuKoFDHyqCKUBjbJqcVJ2Cc/aLdrGt00CBEhsltipC5Ujp8Q7xTk4/lHml UV7UcSb5B3AI6xRJycMFkyK0vyTwv/uMJhfbFu4A= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B31933858406 for ; Thu, 18 Nov 2021 03:01:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B31933858406 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AI1Y9Mt019269 for ; Thu, 18 Nov 2021 03:01:42 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd2w8v4ct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:42 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AI30T4i003404 for ; Thu, 18 Nov 2021 03:01:41 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by aserp3030.oracle.com with ESMTP id 3ccccr2p4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Nov 2021 03:01:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ggp4v6NY0Or+3g2FrA3Jh83kCkm8ablcO7nm+lBS/oLicKCoh4S2Ll8XTrBBS+j+EteVHFd7SlXnIbJBetvXYQRw31uUBeJS63pkWOQNGpo5PcKsivLu7BZLYtoEIx3551xgtim//PIY9JU3vWr+cq1+P4K1fM7ZZJwIFSnNWWoGcB38fTznpqWZIMRBkWwRuhG1OJn1uEeuQOsESS/KUFlIVeUVsE+DP1Q82YRJLHGRk2hZVNCyYygJmXdznGlIpjFoQFSPpXsIu5KXtVeMDxU8Fbwdfrktgtd9WI4y0Pd4/OdzYoN1MCq6BKdHYQmnlno+hGKsjezfJkbHknsnYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUxggkM1Jtklp5SCLltUjuil1wo45gakV/Q1wkdetKI=; b=YQBn/iz1bVHLXAMimJm2A2uUBMvKm2cT9wqrkEXo487xnPsufHdSoNuOGyySbalaN4gNpLttDsA95ho+zyx2bA9TkjXiKXZgDnw25O/Cum6C/eWxL7Ha8B5sXxi6jbNOnbLzJbIOEQfopGvOFiMaeTKx/k62JH0hD/tndI35Bc3xpHnwRQuOp42n+skXlf1WkJxmt3MCAT+8RoMvwZ4rp7ZVycvTUnQL3jFenv3CZJwUdz+IeND4XL8XkOp8ApTRP3Hf/JsrjNN4rEvFL20Npa2QqqqqlgMd+ih6Xf2zpyVng5nOcVObuu3zTDIDz0wgl1Bbr8gncxPzOtcCP896QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by MN2PR10MB3982.namprd10.prod.outlook.com (2603:10b6:208:1bc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 18 Nov 2021 03:01:39 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 03:01:39 +0000 To: libabigail@sourceware.org Subject: [PATCH 3/3] ctf-reader: Use ABG_ASSERT instead of assert Date: Wed, 17 Nov 2021 21:01:16 -0600 Message-Id: <20211118030116.564632-4-guillermo.e.martinez@oracle.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> References: <20211118030116.564632-1-guillermo.e.martinez@oracle.com> X-ClientProxiedBy: BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) To BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) MIME-Version: 1.0 Received: from sali.us.oracle.com (2606:b400:8004:44::13) by BYAPR05CA0099.namprd05.prod.outlook.com (2603:10b6:a03:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.17 via Frontend Transport; Thu, 18 Nov 2021 03:01:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62e98b3b-689b-4878-b8bf-08d9aa3fbdd8 X-MS-TrafficTypeDiagnostic: MN2PR10MB3982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MKL+fKfiWyyP8LAO3SlFXkKqIyl6gOVESbcJYb7f728R6w4nyUWPN65Z/KpABbrYcZcr4s9M4uH7w2KOqiX5xf2no5Qxq9HfBfh1G+3u6BypkO44GXBR39s+L1O0qtouxpR/IMUT9aB85o5h8qSebDMFSGVBr54SUS3aqtsdCap659n//1mbL9Fvt0Ks7e32R4eysRcmdWimSTw2VVRy6z3x2YeBBAFYnnuZVXV5oJSVQGWYNQppJVkghjzPks9sxbHPhrn/HuFTAQVd107bGJ/vTNKqJaQh/nA6BoC5MPEpqPF9swaVL9o2KGDgsi15ool7jPPTUDOtshzZYTHjTUDRefkwhHgsHhLqPvxqtk9pi0rNaM8VjoybPtpCCnJHHQ/2ct4R59B5GD03nm8dSiADI8AHwwao8D/z4WemUtYcLSiirDN2BRP76MIod9gd0VyxF6m/VE0+5z6mktOA3pMN7zcR94C7iIF6CBhLsFR3rHuEZHsI+dAKQ5dE+8+C52v6CQuR4IyQ5QoIO5/8a6B1iT1a/wBOccRwH9GQNA+NeKVyYwB9gVt3vidcPTWb+De6SyIDmMa7c5RWUsDN/38DeivKo0c0waWRX/JpUo6Fa64wXIs9FAhx79JcBlolfUw+uzVvBOQv/qJq78405w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(6666004)(508600001)(7696005)(186003)(6916009)(66556008)(52116002)(316002)(2616005)(8676002)(2906002)(66946007)(66476007)(103116003)(6486002)(38100700002)(107886003)(86362001)(8936002)(4326008)(83380400001)(36756003)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xlcCV7kz4atnG+H1zfE92hZOKyd8vuL2vuYKYv/JaTvH4klAt+hzPd5ZDD+/nmntzVeWrRQ2HlNANIGOInCSmloFQbLbDuKmfQlh7psIsMZ887s0MLsVfS4E8M6fGkR+OTTnmn6rQv0DlzPd1C9MuT47zHGUIhUtLnEYCskBUpweM1znPm5wWlxLyn6iST1uVTFUzygxgodDDua8R+55XmEDzoP94njS83wnrCAETXC+0Dn+Pwj9l5E01fJ26+NwU43EfeG3/XZhT2907UTVnaYwGnz6MbYP5FCmeruEqLuMLcfS0khfo/3b4uMJTJM/9bnsByjzgAQ7EpYg9+tQ+qtWBz2s7KxzhM0y7ktBFHeb3J7XPeRMC7RX4wycxS8gFtWdBRXjosUtqR7UrTg8UfH7QnaRJwj7KQSygOUdJgRCMEpLyyUvdXeA+Xj01bGtwcwD/p1Z/xsZ/iZdOFyLHsCGME9WCjnptuxmQdZO5vL8xP+KMcXEeLwaFeS6XllMDPNSXJHHToS2QlgEzS4oYyvbjD5rm5Su5Ep31ohjPFV1kO8Z4/IfVpj6Ec7O5M8+MRdMF+pPzejL8C097nTHFQJc9ihGYlz8nvzRsLczJXzGftGwjeMozPKlYEFiysufUbJwAHWoUq5eB28eOoSBvcl0sGjA8C99N05FCTLXlhEXjf1m5LpzSbNIrqSoUBuN4CgfBdxvOJidB55wpYHKFlJHLzLuCpY3DStRnsVE+ok3GUSKH9qHPg+wDq3paktxo3Sd2ngnj6JL9uz7JJnlkS1I9CeWmx4f9xOtZSzdHVZlx6711CEcyfqsnjkMhazHZi6SZ3m+bjV6p3A3gnR4HWWv8EF637crFfOg4EgImeedCOqRpjf6XlgM4jphTRDeMlev70BSs4bq1hpeKOlsuzzm4vWq+sGlmq1GYJBqV5t/0vF1Rj6l2R/gB+o7JBHdCjrXnfyjLrvI4KV/p3k8HTri1ZmS7T4s2WZnUvu71S7LM2EIEHxlsTFD8/X1opuQTRljV2101o6H6GLOC5ha2UdjJ5iWL8pQdvhcNwvRSofKXYMF/0NX9eEFjk1qtpcFRGLizguDKLV1FK6yFdAgZTeO3zlmuLPbNRwtvEV0jI8Kl8WaatCVj8R8D6fo4Ur9MzcSvzSnlioXfqKdINoyhoQzjaCNnSeqOy8WYUpwxqlkjPD4LuqUVXYTv0K4bBgL4gF2vXrwZthiMpvjGCRCOtH7K/uyfsHeZnM/6f8HI2ENujh9kSTnpE/H5iSxeu9ndKlwrF1H9ZwbHyCw4wIDoMuBLZz5MC/GN29gsmqoTnQxISSsPQGoRFsQywRpxbATGZOpFCb+y2+PRXYW9iM7QGgBvVngwz9IU7EuKqSX0Ay1XHZPvuuBgkJ5ucf6yfJx7oR9YrQ0aAuCwoPjiy+dezlb85Z28HCagMRCxiAR1MQWqW10Aqnn9dV3fNrEM/sk3LzI3L3WP3LUdNdsnooA5YXLPsr9vGhHnGplvCqzrW/4N8N12lZG4zQnjCErHXOWqZ3AS2hS6vrTeW3TBguSHTcfKRFwNqM/EoJQ33PPlLdd5DefEYwzQhdbxpykhXp2W2UN2HqkEQgnHnrV+zJm1dIzklMEtmxluoej9Fu9ieV+yDUomj0OKnTl2RjGJ5INAJbm0K2VfQhx+RE2mBdohHqiqARWN0tIfP4cedzqRT8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62e98b3b-689b-4878-b8bf-08d9aa3fbdd8 X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 03:01:39.6573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SSVLKlxOiTGApOZjfGXo8EAlFDWwlVbGwEwEfbkSCmCJHYnp4vqQcApvDITFpeqG/HJdhgxcwtyMpjAbW9zBy8CIf6wV2mwUF8ddVldaSPY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3982 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=873 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180016 X-Proofpoint-GUID: hP0hnFjezdtjAWfUqlqsYbqQBUFtH2de X-Proofpoint-ORIG-GUID: hP0hnFjezdtjAWfUqlqsYbqQBUFtH2de X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Guillermo E. Martinez via Libabigail" From: "Guillermo E. Martinez" Reply-To: "Guillermo E. Martinez" Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" * tools/abidiff.cc (main): Use ABG_ASSERT. * tools/abilint.cc: Likewise. --- tools/abidiff.cc | 4 ++-- tools/abilint.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/abidiff.cc b/tools/abidiff.cc index 30959616..7f766d16 100644 --- a/tools/abidiff.cc +++ b/tools/abidiff.cc @@ -1173,7 +1173,7 @@ main(int argc, char* argv[]) = abigail::ctf_reader::create_read_context(opts.file1, env.get()); - assert (ctxt); + ABG_ASSERT(ctxt); c1 = abigail::ctf_reader::read_corpus(ctxt.get(), c1_status); } @@ -1257,7 +1257,7 @@ main(int argc, char* argv[]) = abigail::ctf_reader::create_read_context(opts.file2, env.get()); - assert (ctxt); + ABG_ASSERT(ctxt); c2 = abigail::ctf_reader::read_corpus (ctxt.get(), c2_status); } diff --git a/tools/abilint.cc b/tools/abilint.cc index 2e9bae49..e3e8b079 100644 --- a/tools/abilint.cc +++ b/tools/abilint.cc @@ -374,7 +374,7 @@ main(int argc, char* argv[]) = abigail::ctf_reader::create_read_context(opts.file_path, env.get()); - assert (ctxt); + ABG_ASSERT(ctxt); corp = abigail::ctf_reader::read_corpus (ctxt.get(), s); } else