From patchwork Tue Mar 10 16:10:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Girish Joshi X-Patchwork-Id: 38525 Return-Path: X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id A0CD03959CA9 for ; Tue, 10 Mar 2020 16:10:41 +0000 (GMT) Received: by mail-wm1-x32a.google.com with SMTP id a132so2056001wme.1 for ; Tue, 10 Mar 2020 09:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=X5V1M7ohHF8z3Enfnwcu0ERLd1cYDHcRHkga9C21Kkk=; b=Y9attdkCEAU2w4+07RglhMuuhAVuecVBumJComIM1ZfpI/6oOtx2X+8NmgU7YcV3vu zV+P/QdkCbhGFOKYuSXccHnsYeRHBsdO/yX7KSj3nF2BHtpj3Iye68Imqd3FRHWM6Gm1 c7YipIP1XwZ7mbT4nwZRwQO/q/Dv0a2EhSHj/cvXcEgQUD65+booJYMSvq9VgoZ9lAW5 xkDiag1yK5ILxarSkmoGa7g3bxzSviKrM6pDgvVWXpUbjth2BvAltsESMlLBQWUwyXRi dVCsTyAZa1RqqMTUyzlMKMsfO513yz5hG1uJr4t9rLAz9mNFjvJARtVAnfTs52KAKzFG w86A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=X5V1M7ohHF8z3Enfnwcu0ERLd1cYDHcRHkga9C21Kkk=; b=l3PxdAeidOy1nFFMhlcyV+d8TY9Mx0+H/RKLJFG/YJwfA8xQ48hWNqr30HfNezKSEn yscynpTK9lo7yHxrH4vsdmTlLe1aIb+O3aKPi1HpqqDO8dQwzCr4verP51XenYR4nL19 5xtt7qzGb9zZxuhshYvL5RBhCMXyG5rqJF8V4Jcn94pInJyjYgUvWPIhPXvZKH+l38t9 xM3VMGDZDzda5z54JHCrii1hJt9+4ruRVUJf9Ec3/fFurNy6GPc9zCXS7AICCI4veHWL 7Qk8bmX6f2T3Z/uPVRfHrYHylxjfbuxUoG8LuViDzA2mAlFHZzetp8k9279Kw33Qv11F e1/g== X-Gm-Message-State: ANhLgQ3e6G9NsnZ12VE1C2gBAbNe6L49WC2vKMpc5Jg+3eVn2U7rU6A4 HSMOAe2n5Kx3Ciq+/NiO8LifrHujz81/AJjSa6IPfBTN X-Google-Smtp-Source: ADFU+vvRSb4wIPV7nalPH2Gi6EgA5tOMKWZA8YeuNF9Rl+VnnIwQXwI4EW4CylSSwdWYCa0e6eNT3LG2VepoIy46mKk= X-Received: by 2002:a7b:c92e:: with SMTP id h14mr2999353wml.90.1583856640370; Tue, 10 Mar 2020 09:10:40 -0700 (PDT) MIME-Version: 1.0 From: Girish Joshi Date: Tue, 10 Mar 2020 21:40:29 +0530 Message-ID: Subject: [PATCH] manual: Fix backtraces code example [BZ #10441] To: libc-alpha@sourceware.org X-Spam-Status: No, score=-26.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 16:10:43 -0000 >From bd99113d312012bde774a66c36b4894355175661 Mon Sep 17 00:00:00 2001 From: Girish Joshi Date: Tue, 10 Mar 2020 17:15:08 +0530 Subject: [PATCH] manual: Fix backtraces code example [BZ #10441] Validation for pointer returned by backtrace_symbols () added. Type of variables size and i is changed from size_t to int. Variable size is used to collect the result from backtrace () that is an int. i is the loop counter variable so it can be an int. Since, size_t size is changed to int size, in printf %zd is changed to %d. --- manual/examples/execinfo.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/manual/examples/execinfo.c b/manual/examples/execinfo.c index a789b6b5a7..01fd2d2dc2 100644 --- a/manual/examples/execinfo.c +++ b/manual/examples/execinfo.c @@ -24,17 +24,18 @@ void print_trace (void) { void *array[10]; - size_t size; char **strings; - size_t i; + int size, i; size = backtrace (array, 10); strings = backtrace_symbols (array, size); + if (strings) + { - printf ("Obtained %zd stack frames.\n", size); - - for (i = 0; i < size; i++) - printf ("%s\n", strings[i]); + printf ("Obtained %d stack frames.\n", size); + for (i = 0; i < size; i++) + printf ("%s\n", strings[i]); + } free (strings); }