From patchwork Tue Nov 2 20:44:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 46966 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5428F385842B for ; Tue, 2 Nov 2021 20:46:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5428F385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635885981; bh=RBfYbNILwKpb51QHWG00uxeoYyHwmXyRbpeRCdcSzns=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=b0sp2dRySrHM3x3kXovXEBJ7sEhYpCuiUjKxQ44QT5EUEc6ast1hb8joOlf3tRE6H TUMRD4EsdJSvEr0WlanhLRNeSJQzBL1cWhwNDhoKTbTRVCjO/xHQzMAhChKILLErD7 ZhQMElQ73Wr7qVh8gqi4u0wPEbW1DDMo7hTaLS7A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by sourceware.org (Postfix) with ESMTPS id 172A1385840D for ; Tue, 2 Nov 2021 20:46:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 172A1385840D Received: by mail-pf1-x44a.google.com with SMTP id r2-20020a627602000000b00480f8ce37abso113071pfc.8 for ; Tue, 02 Nov 2021 13:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=RBfYbNILwKpb51QHWG00uxeoYyHwmXyRbpeRCdcSzns=; b=kU7rZ88vsJNwb6dUg4lqGlivhAcSxFZTa6KQ7bSqxEy0ebhRTFLL1V+Vp75d8gXYeB futnqEfKgHNV5uppUkvheUnrtaid4RrWc+OLCj8IK1VHkmIuoMP+20izlXU6wWEZ2eZO tw3nbcOabKNlOgIbYgeW5fx+/7vtk07Ht9Jf4WP0HPELSMDdaFy5sQfOIvs8NgerweeN NwRlpd5NV6bBC8+GKXgJaHvjuDj96auZTVTxleZqH7X0JUp5lUAP4eLc0IRhct7EtMx2 NSBBi99z1Hh9j80oyEco0JDAibjB4fOAGUGu40VEHTDxlRugPKLYoaZ7FEFK6e13GkPk +sPw== X-Gm-Message-State: AOAM5339IgSWetx+onFVX0Z2CZTgiKxXYfpMoRW4FBmUFMS4WreGvKuO 89oLMk7dttulKvGmGaR4YE8xRDhl1kO11Z2qKUSeasVsVCDimNhUtiqApIOIV8KibFWDidJoOIN xx945NfBhc5+Wrg2S0HwIz2vcyQpz4mlQ7m6RXwozluJYmaWCeJ7wS7O/SyGKKQsZwM+2 X-Google-Smtp-Source: ABdhPJw1BXRJKmd+cG0mGQqxR475gP5Qbo0FwIF3lT3qW37XnQf10G0nO98wlmLqY788Q9O5bCBvMgiueDOP X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:be09:83e2:3abe:b3eb]) (user=maskray job=sendgmr) by 2002:a63:1cd:: with SMTP id 196mr29382711pgb.39.1635885959000; Tue, 02 Nov 2021 13:45:59 -0700 (PDT) Date: Tue, 2 Nov 2021 13:44:59 -0700 Message-Id: <20211102204459.3405575-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] x86-64: Replace movzx with movzbl To: libc-alpha@sourceware.org, "H.J. Lu" X-Spam-Status: No, score=-19.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Clang cannot assemble movzx in the AT&T dialect mode. ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction movzx (%rsi), %ecx ^~~~ Change movzx to movzbl, which follows the AT&T dialect and is used elsewhere in the file. Reviewed-by: H.J. Lu --- sysdeps/x86_64/strcmp.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S index c7cbe4042a..bfe83abede 100644 --- a/sysdeps/x86_64/strcmp.S +++ b/sysdeps/x86_64/strcmp.S @@ -2229,8 +2229,8 @@ LABEL(strcmp_exitz): .p2align 4 LABEL(Byte0): - movzx (%rsi), %ecx - movzx (%rdi), %eax + movzbl (%rsi), %ecx + movzbl (%rdi), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx