From patchwork Thu Oct 28 21:10:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 46763 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A52DB3857827 for ; Thu, 28 Oct 2021 21:10:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A52DB3857827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635455456; bh=/7CXp3anTl3atUYy3IxBF64hONNHwdgTj7qElYCzH1I=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=X/87nXssITUbyprkGxfnu4pQDBKOEtvrTkahYmWxg8b1tXByDlSZ9OCb6k1s1iijm wXe1L4pZMJRirY53rLnRU1DfCS7L0JXobE3A7cMe2VQjiaA6Xzqv7E4DdDupGzw+5r /EuZdggWhZWtlaWB7W+8SLGdzFwzPJtoFyWsGxnw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 08C133858405 for ; Thu, 28 Oct 2021 21:10:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08C133858405 Received: by mail-io1-xd34.google.com with SMTP id g8so8616175iob.10 for ; Thu, 28 Oct 2021 14:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/7CXp3anTl3atUYy3IxBF64hONNHwdgTj7qElYCzH1I=; b=2nr5Ec8LaRGxgPoht4zMKIk3nLROWBiwzUg1dOxFIcYRLOX8/2Ji9OnuxsvQwxrBdd 6Iv4IieU8PMV7Q8Q7TtNT4vKkj+H1f1817EXmhcvJKWJS/7Oqrkm2t+CYMyn+ahPxo1M fxuzB5Y18zEiTxBhbI4wG1Lp2yQ0A49YRJgg49Xfz0GgYxRJWdiwOyFc93CeKEWLtoqO DC3HH6UU3MEZFwflkoaHPn5oqcB5oc93efLBGdNc9tbqKSssdKoM9uuxIzz5sRyWBdAP i07k90obm74a90wtaeenpso2c5ZeQKlJvO2KnKgkRRmp+ye4zRNtlHvG23lhslA2YNYK mnqw== X-Gm-Message-State: AOAM5333/oSGK3jiyOPBOupEnNUqDGlD14NsN6ZFc/vcekCdyQgKDWKx PAOOjLxnvuxgm2ogITypzpiNezdxxqs= X-Google-Smtp-Source: ABdhPJwO1h1k9nKT/YFfPaouuKZJd2JeoEZTN+Kmm/RP4NHGXw2sRi93cop53I1ODDind3hz6il3rQ== X-Received: by 2002:a05:6638:2385:: with SMTP id q5mr5080159jat.17.1635455433497; Thu, 28 Oct 2021 14:10:33 -0700 (PDT) Received: from localhost.localdomain (mobile-130-126-255-38.near.illinois.edu. [130.126.255.38]) by smtp.googlemail.com with ESMTPSA id w16sm2233326iov.55.2021.10.28.14.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 14:10:32 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2] x86_64: Add memcmpeq.S to fix disable-multi-arch build Date: Thu, 28 Oct 2021 16:10:26 -0500 Message-Id: <20211028211026.2430103-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211028194738.82344-1-goldstein.w.n@gmail.com> References: <20211028194738.82344-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The following commit: commit cf4fd28ea453d1a9cec93939bc88b58ccef5437a Author: Noah Goldstein Date: Tue Oct 26 19:43:18 2021 -0500 Broke --disable-multi-arch build for x86_64 because x86_64/memcmpeq.S was not defined outside of multiarch and the alias for __memcmpeq in x86_64/memcmp.S was removed. This commit fixes that issue by adding x86_64/memcmpeq.S. make xcheck passes on x86_64 with and without --disable-multi-arch Reviewed-by: H.J. Lu --- sysdeps/x86_64/memcmpeq.S | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 sysdeps/x86_64/memcmpeq.S diff --git a/sysdeps/x86_64/memcmpeq.S b/sysdeps/x86_64/memcmpeq.S new file mode 100644 index 0000000000..db1756915d --- /dev/null +++ b/sysdeps/x86_64/memcmpeq.S @@ -0,0 +1,21 @@ +/* __memcmpeq optimized with SSE2. + Copyright (C) 2017-2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define memcmp __memcmpeq +#define USE_AS_MEMCMPEQ 1 +#include "multiarch/memcmp-sse2.S"