From patchwork Tue Apr 23 16:56:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Kamath1 X-Patchwork-Id: 88927 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 023FB384B112 for ; Tue, 23 Apr 2024 16:57:21 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 669DE385840D for ; Tue, 23 Apr 2024 16:56:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 669DE385840D Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 669DE385840D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=148.163.156.1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713891416; cv=pass; b=ctcxqd9jnLLZ+cimQiEZx39KsaTtSkfmCwdpTEOnILt+VoaTi5ds8sI2QFqQexxvI5y5/0mq8lWMq5Rx0gBpSWL/2Pb/Gq9NKMCZMCDqAMEwQYG8CXhlX67lZ2mdIlShXxrpbhURpDgIoSkAmWxn6XFgcqYwLp+kt6txJJkS0NQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713891416; c=relaxed/simple; bh=ipjGFWdcq7mFZndJNvlh6QjIuyv4VeRtuQYspmhNqnU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=s272eOYvYKrECq4+tk1HeoM3M7tJwTeYEH8sRGFDkjgt9Wr4g+VIOSkVK4T0vdNELDn+Hl9JhUBiNH1mrTgGqCeQEkFatD0TkX+d+bH75kgL0tyteBFs6PHYyn98CPjFoBH/A7v4t0mNxbVRdXBDfJKS6WVRAPneSuqWoDbY188= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43NGnH1M008120; Tue, 23 Apr 2024 16:56:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : subject : date : message-id : content-type : mime-version; s=pp1; bh=3vpEWcOtEB3ErrUDIXNuilj5rvRwBR5arpdUbt60hcA=; b=GYoBvhn6p+sGb3EjXliqIBUxlq1XazdWPMZb8eJ0ggYM9Xh0Gqxw6+AJrZ76Svr/F5gB PQF4S1QXMjhmbqZZqxTNnrBxbK5XGV78GnyKQIjV+b46bl3sVLGQx/wP7jQAUYvwKQ+r ScdxYN2Jbv3BA0XUIjQaynn0iOGl3eVTjhBFwh4pKh9W84V0oTVqZWbvRx09GnhhykWU QKhAIGQFKW05asFpsxmYaWZ5x7D3U2PokMeholjym2uaHqAFWOvV8OTCiIQQsVzEfGCj 7XDmRgasTmZMYW5ec01Ar9mUjgL/ov2Bd49naUtEgoMdrQmIPrSUbC31//OlJrmeNrqJ Dw== Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xpgh20211-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 16:56:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDlQC2perykoSR16ocZP4FF17SPfcxxdCXKEXFKIh7PzpcuAsGHcydZQlANoICBx8cPs695qfwpg/EF2nBUBx9w90AVV0eN1nD2Bfn/oiEvOEl6hoS4HWA+fX5kQPlYza9XC82CkswfG3yqQRBfKm0Z6yVhmTvvrFvBHDQ6YKKveSdzbWgUGRtoE1qT2N2nZyE2SXlOT7JH6V8hGVAj1+KmmYMN9HxBw6gRPXlrTghqSYqBhN1bJTX/H+Ys0BHXlJt86bqIQJwCx6a2W6gKFf2RgyQbhUOdw/aI/q2UV/6I+d/Ihk5AavgiN5tyWi6HGpXlHpqJOKfaobBtlcppAlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vpEWcOtEB3ErrUDIXNuilj5rvRwBR5arpdUbt60hcA=; b=Nsy5TG8PUqUni38r60ZDoFwd7xmw/rTzXTRwDpMEDHlMMvJZrji9r3IA1UJJaQQPK0j1RL+HIxbH5a5jcUK/hsSXnKqLzz+8lE5BadLgcx/azzeuZEIzXcP8Mxm8R0CEEWbB1TKXRN5Lgcm3Y5TAFHR5d1wx/qNQyHhunfgjm0QumE2WXnuaC3Q4i0I9o+SOPBvtRcAStg/g/ZISuZUvYsw+ikY6GTBrj8dIndmz/i38w+KY0z0LreHQnOmOgIKedbwaX3LPG/RZnOdLEnzcHzRTNk06pyz9t3FhxoDXuaRJuy7vm1ZlDjIgSF823PbAP96Hf3UG6iXb0xEIlNw4sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ibm.com; dmarc=pass action=none header.from=ibm.com; dkim=pass header.d=ibm.com; arc=none Received: from CH2PR15MB3544.namprd15.prod.outlook.com (2603:10b6:610:5::26) by PH7PR15MB5765.namprd15.prod.outlook.com (2603:10b6:510:276::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 16:56:49 +0000 Received: from CH2PR15MB3544.namprd15.prod.outlook.com ([fe80::86ba:f8f8:c478:6919]) by CH2PR15MB3544.namprd15.prod.outlook.com ([fe80::86ba:f8f8:c478:6919%3]) with mapi id 15.20.7472.044; Tue, 23 Apr 2024 16:56:46 +0000 From: Aditya Kamath1 To: Tom Tromey , Ulrich Weigand , Aditya Kamath1 via Gdb-patches Subject: [PATCH] Add gdb.threads/thread_events.exp to run in AIX as well Thread-Topic: [PATCH] Add gdb.threads/thread_events.exp to run in AIX as well Thread-Index: AQHalMpGuj6zBcNUFUW1UctTudgz1w== Date: Tue, 23 Apr 2024 16:56:46 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR15MB3544:EE_|PH7PR15MB5765:EE_ x-ms-office365-filtering-correlation-id: c056d6fa-62f4-41c5-a294-08dc63b65c56 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dCiOAgQwmV1+rti6eGvTyrkqBK8pbdKPbaGqPi41diQxs2wYcJkv9idLttouI9xOV1Zi8r5sVMqaxhWfMDXA/s6fysS5hp3ZguDuEWYMz7zrHf27OL25cB3EdtoKPSBPjsI7AxSp+NK47VBInHR3IWyPOZHf1Yh7Fpndwyp1U2lB5I/rWxgcAKYgo9uIZS1A5BtlmwnvDoQL5AboNZyAo46DzGH+SCmhrlov43QNqrCW4A77HDmU3QRG0qvKGL2IkepM5lYkN1XkAUWLuX/X3rAixjhZI17+weffL0KRs0rrvrjgdG+yYM8Ofi9j+r8EXTVL67MMsi7HKsVpNM6gUWNUhPhJ8nuTgn7g+krLbMluAMeXXGk5WPpIfyG+3XUrE564g8kPIZ+OYgLkh0Zafji74FzCye8CLnPkylsHFFwNSvKBHVj3c4ghmpuf/8GNAatJ+5D0e8RjwjmSyMk5IGOmC2c3ERK6V4GPN12wN+01C0/kENQPJleNrMZTGNvNpUeCSRxACoqF/bzLpy4HP5qkav5W8LRgSc0pwted90JORzZdDduLWnVQEE02oadNeBrTelxbETpyuXiME7yz3ASsOFkVu9DmAODT6lqOE3jWWplU69IZitmj9HRTAQxGyTDMUSA370KpQwuAadaUPtMB6cIvyAKv/osNvsyoQiThD/SKQnPBmyR+DRuV5NVudGWpGKctJ9GYowxj98UpFrN91vSjn1CKnh9z4Js9XREBGKV5RotOm9cCYKRXDzCcFcJzS11g8Iga9LjruzkZhtyh4RwpydU7YoR1MWrCRNDoVBwKy1Jqf5pVSHtnudnsQ09OqKqHP+flOO9AQW3739sXtUqTRtEzasOpnbCeRe+amYJzqB3DzeaeN7DID1LFwdOz7KTUBgEQloXdNkdldveHo5WNW2CmE5mmhm14BXvQQ1bvZkJlhg27WACxHFxfxdfyInNqOkLtfxN1kAFAnFBRqwWMnzHLYSmDyMEGVMw0FMPEGcLUBHS4ywZ3WgIhYlrDbiwE0+qWcET4w250U00WR2RRE5M05y6gHDQVOlNTcDA0q4wIwRA2tUMoiAZp6qWNIITDjtQFRnX9q+WplxBHR7FsnxiKZPGcoT0/9GWlWlUQqJdcVt1SC9WCBlQ+5RPhaSdzedCXmOvsNVy4IaHB+qKcL/f/oa00jWpXgXc6utJnhiHCdSRCN75piUdtHX+wOMtltz7MF18nEC+vGu3lYEIAi2AKSOfxmkyup22RN81Slf7qjIHwsYDf2Ih1YZ5xc8AkBbzAl9PTzaon4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR15MB3544.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: j/qzTOlv64F/cR/SRDObik/B3ZhWkHjmHH/LFRkKD7iGfnGAbKIz6cnYGAplQisxxq2JHc45J0qJ7ujc/+jH587qct7GmoDDwYd4jKQO3KCaYjFolwWEVc1nMqrMWgsHcYZYyZOBCBOK0ZSv7/4mcEDL67ltIujxM89fiDnbo1WPvJtjFouPN0CRlzVcHb90m+CJdCwKWYQ5/V19fUrF8mXvZwcl+sreSEGPnnoacMGVL4QBL4tORKyACEkEYZoT9XC4gUX1azUcRDNucRPv2GCdFc7g+ZBSfbFc6juiFA1Wkt8QCLW9boDGtzk13yhKE5Q4mnag4Ghx+hBNy/7S62nP9RKBHc+841R3aioRGnQz+IrjLtNUOnUEiLztTOoHIcPHxmdAeegvn9DaBkQ3iyNMrb5sli/H3TUaQhpGuD5axES+ONQ999INv+VgqKoclJ6LO21psp1IkHDPtTTCGwesYXslyFO8Ybwiqa16GoCwnbLWhUyY+I26a9/lmzSVN2c9r6mYmM7wQ80Xkc2pWUMeDNkmm+zxqK3hK0iqQVLCaPYpw0C3kx0eUsA31TntkP8z6pv7wRGEof2WVOnxQlp6mliYzMVMyzAgg/QAMXf9wAbnZhxh4EPfIdLHoyqHXCUfpiRy1IZQ+vZBU0myD990LRSPF2urag1f+D2XvPXLVaN37aAcq0xm145gY2n8SCVwHR6ZCp9E664qSEhJe+AKAoxtzx271pHdJri5OEXrZ8CfX8fPL0oAd5GbS2JrdNfeGoO4qx9MRDkSxvxD5lcf38wvhA4G9LIEneP3BSJGcU7quEFXT6FZ2xKpdnVPSqaTppTEi+KQRg7ZB/tdCO7HR+rrWpnM1HjXMNRMEg6SS+Dwj0nESycd6o5k046lCxOZXHsUJM7EImiJmRxX0O/Bx67DM5TDelbXCK826TZfqiV7BmQHxBfYu/3gBBwjhwnWK3Yt3T/GhvF3hKzKzNP0gaig2tu9whK9ZqGwBp/CJdaVcEz4L98H1dLnZMM5sn23DpUaUKXRG9ZILx7Q5/anjwso0qGrhvh66NCOVBztnrKCgnNNWaPr2rZNeo9wYTRC8kp2nSkkR7mlCda1ZxEnrqBIxbGlCxa4+npbWWWq8PnnG8KrlCGRZQPcO9ETxu16RPVXnwltjE23qkgBR37nmAOCB91Vl3AZTOsaZcOiPEFvA7irWoBMINMC1OaTW1ETJBOP3VbwmBPT6H4wgFZIRh8irlYi6j/Y6c3HxNXQ3CuHSRjPW2R7+r3auKIbSf4TcKkgcFAN3eTPyHhSv/FQg6ZIHBoxWQYpeZykIlh//PMrZ+OSlVB4NSGN/dvO0A7cTdUmI7YoSNGSzvqWMj8HvlAG5q5wi9KOJa/65hgJjWIphxUT7vZThxeMAzt/eLvz0t/P9djAnaFVyIhOhk6H/WVd4cGjhdVzrKhUoOCOrXiWu/EYDfQkI3jAusPA3Wlgu5Tc8WG/v+jXvOqVDxKScPg+getwalwbjOQteeArReyhSbcghUq74JGrTY9/EmmvTbMMXjAx+d4OWd3UFiay5/Ca2UI+QalJPXLvQKbwow/xdXlpSmcpi3llbHac3mSpLdWnaRsIjjAT0PUQEBrF6YzCbNVMSk4Ptg5vPJZD9fEQFSgzMdkea+ReQLW3ctDM4PRMxHlOgmwb2W43UA== X-OriginatorOrg: ibm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR15MB3544.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c056d6fa-62f4-41c5-a294-08dc63b65c56 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 16:56:46.3969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ups8BZr5V7Kutg1huWUIUoRXiDHhJBAhW48J4gqGND8j5JaH7v4PyZlf0AOLFdvxMigB7qcWJ4IoQmgdGUZtOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR15MB5765 X-Proofpoint-GUID: 67GfEfqzxycMHfzuoigkk1LD4eiZ9Qs_ X-Proofpoint-ORIG-GUID: 67GfEfqzxycMHfzuoigkk1LD4eiZ9Qs_ X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-23_14,2024-04-23_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404230038 X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Respected Tom, Ulrich and community members, Hi, Please find attached a patch pasted below this email. The gdb.threads/thread_events.exp is a very good testcase that should run in AIX as well. Currently it is not. This test case is a nice test for the issue we are resolving here. [https://sourceware.org/pipermail/gdb-patches/2024-April/208104.html]. I was looking around for a test like this and just figured this out. Since this was not running on AIX we had to write our own to test to solve that issue. Would the community mind if AIX runs this test case as well?? Instead of contributing a new one, this one tests what we are looking for perfectly. So this test has one failure in AIX. === gdb Summary === # of expected passes 10 # of unexpected failures 1 I can tell you why this happened. Reading symbols from testsuite/gdb.threads/thread_events... (gdb) b main Breakpoint 1 at 0x100007dc: file gdb.threads/thread_events.c, line 41. (gdb) b threadfunc Breakpoint 2 at 0x10000718: file gdb.threads/thread_events.c, line 27. (gdb) b after_join_func Breakpoint 3 at 0x10000778: file gdb.threads/thread_events.c, line 34. (gdb) r Starting program: /current_gdb/binutils-gdb/gdb/testsuite/gdb.threads/thread_events Breakpoint 1, main (argc=1, argv=0x2ff22950) at gdb.threads/thread_events.c:41 41 if (pthread_create (&thread, NULL, threadfunc, NULL) != 0) (gdb) c Continuing. [New Thread 258 (tid 30540187)] [Switching to Thread 258 (tid 30540187)] Thread 2 hit Breakpoint 2, threadfunc (arg=0x0) at gdb.threads/thread_events.c:27 27 printf ("in threadfunc\n"); (gdb) c Continuing. in threadfunc [Switching to Thread 1 (tid 31326575)] Thread 1 hit Breakpoint 3, after_join_func () at gdb.threads/thread_events.c:34 34 printf ("finished\n"); (gdb) info threads Id Target Id Frame * 1 Thread 1 (tid 31326575) ([running]) after_join_func () at gdb.threads/thread_events.c:34 2 Thread 258 (tid 30540187) ([unknown]) The last part of the test case is the problem actually. We did not handle unknown state in sync_threadlists (). The thread 258 completed its execution and we did not catch the same. Also, we are not handling unknown state as of now in aix-thread.c. We only handle PST_TERM. Which is the reason for the one failure. Anyway, I will fix it in the other thread. Let me know what you think. Kindly apply this patch if it is okay. Have a nice day ahead. Thanks and regards, Aditya. # cat patches/0001-Add-gdb.threads-thread_events.exp-to-run-in-AIX-as-w.patch From 73dac7610d2ecf3120dc06542a88ff6dc555da71 Mon Sep 17 00:00:00 2001 From: Aditya Vidyadhar Kamath Aditya.Kamath1@ibm.com Date: Mon, 22 Apr 2024 10:32:13 -0500 Subject: [PATCH] Add gdb.threads/thread_events.exp to run in AIX as well --- gdb/testsuite/gdb.threads/thread_events.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.41.0 diff --git a/gdb/testsuite/gdb.threads/thread_events.exp b/gdb/testsuite/gdb.threads/thread_events.exp index 100205e5f58..11a89139384 100644 --- a/gdb/testsuite/gdb.threads/thread_events.exp +++ b/gdb/testsuite/gdb.threads/thread_events.exp @@ -23,7 +23,8 @@ # This test has only been verified with Linux targets, and would need # to be generalized to support other targets -if {![istarget *-*-linux*]} { + +if {!([istarget *-*-linux*] || [istarget *-*-aix*])} { return }