From patchwork Mon Apr 15 15:36:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 88499 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D25B3858C41 for ; Mon, 15 Apr 2024 15:37:22 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 94BC33858D32 for ; Mon, 15 Apr 2024 15:36:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94BC33858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94BC33858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713195420; cv=none; b=VSpNz+5QGWBCG/YLM5cC+BJLj6GB2fmcVJt2qtz+qLDRgIYc1w1AeHA6OwAotO8Kdlt5vFdY+h96DUwqNAWi+uaVx+zh5aG1fjzvkqFPeaHPaaoEfwaPhDHOQZfYbLtdeHcoxkc2QTs2KApYf5SyysaylREICPuYsz8/N8GEnEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713195420; c=relaxed/simple; bh=eGKDtInyi/3HyDRMAm5y16fRYxZOp8SWW7PkZ5H61zA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kvRqaYetVLpFGhyp0iRIl/5jSRTkGt3I3XJVt9neml9kaLTECwcgkXSeSlmUfidt1XXMspPLqV4q2g2ZO/uT4K+AGPJbxpHTV4ZSeNXkIlogeKRffhtwkMiLNr76vb/T2BKMeDE5sxkQJZEnSgFCaj3zauexUAZyx2ZNCR/GUlU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-369e3c29aedso15411365ab.1 for ; Mon, 15 Apr 2024 08:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713195416; x=1713800216; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aLooFmRD+1HaGjQvWDWNpOwCGwoHDHUvs1EsL+reffs=; b=UmzGZoguWx+mPA8R49ZJvwrx3/34vbGYpEyExBpGVJlzLtqcYDqa+WF1Aps0JDqAIP IPkr5gtYIZ2unzAB5nJqokh4v08sJPiEUKSoeLRIoY3kfm0aiojUtq5TQXG9ZOSi7jak 9Q1DWDn83lXSikh2MAYN2lGMuE3cveZX34fZyLl3uzRn0hEABqsU2OfKL6AQqsoZVovQ lzayJ78RkDUKjMFMqS5sHxk0DhVhp4ojtEda0BZgQ1OlHU2u7yy0vSfyz+N7WzEHsf4S yQNLm3W81q6jTGUaDzV50OLrRgv3evV9duZrheUHqTPV/mBvCAymssIbdqgZnHVM2+to X2vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713195416; x=1713800216; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aLooFmRD+1HaGjQvWDWNpOwCGwoHDHUvs1EsL+reffs=; b=gJThmC1RKuUXskBqR7FxbfBZqLe21Pgt81EvIj4XPeFTQdkR8d7ebcYLVX9D7/MVCO UhfZf+LO3e5TaLtfU8qinZgP5HUbjOIoeB3GcR4/6vKhdAbEkBuyeZ9wwHZ3B9eYT5DG O2XOTMaOzQMLDBYXcSfvuF2KSeIN3hayvtxVMMd8bTI03pSkhm9ysgs6Fx9xwSSxWX28 ut0pigRvO+P4HfMyIdKYRjKcGCJiiCQPGLZzpxJFhLCcSS0Fq+6piLUp4kmbvcerJz3U E+FNzZ2O3qUKqr14Z0Yp7deo3iTTMo9mv9GfZ8BmBHaasJiWr2P5Ld98DsIX8kLSzIm2 Etyg== X-Gm-Message-State: AOJu0YxkFA6QGblowM9Tf4ZmhAwwwMyOOLiT1Y+v9uVEx5C4w6qAuKgo cC/ogcV7XDKPXVGvHZhw3oGb8x4Xayh3ptIOgIHAXnBwVGCCG7aI3wr3TjzZBcCjgGNYQ4Rvs84 = X-Google-Smtp-Source: AGHT+IEOoYeeeKsGFfZO5K0v6qx/cHmn/s9O4vuR8HJXmA7t8PruExUxMuQPCQYk9cv3TlItU0dwug== X-Received: by 2002:a05:6602:2805:b0:7d6:9dcc:9ea2 with SMTP id d5-20020a056602280500b007d69dcc9ea2mr9813544ioe.0.1713195415764; Mon, 15 Apr 2024 08:36:55 -0700 (PDT) Received: from localhost.localdomain (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id ca22-20020a0566381c1600b00482943539a3sm3147063jab.56.2024.04.15.08.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 08:36:55 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Change printf attribute to fix clang build Date: Mon, 15 Apr 2024 09:36:48 -0600 Message-ID: <20240415153648.2270383-1-tromey@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org commit e8cd90f0 ("Rewrite gdb_bfd_error_handler") broke the clang build. The problem here is that print_error_callback isn't marked as being printf-like, but it calls string_file::vprintf, triggering: ../../binutils-gdb/gdb/gdb_bfd.c:1202:18: error: format string is not a string literal [-Werror,-Wformat-nonliteral] This patch applies the attribute to this function. It also removes the attribute from gdb_bfd_error_handler, because that function is no longer really printf-like. --- gdb/gdb_bfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 0120dd034fa..1462aaf0f89 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -1192,7 +1192,7 @@ increment_bfd_error_count (const std::string &str) /* A print callback for bfd_print_error. */ -static int +static int ATTRIBUTE_PRINTF (2, 0) print_error_callback (void *stream, const char *fmt, ...) { string_file *file = (string_file *) stream; @@ -1208,7 +1208,7 @@ print_error_callback (void *stream, const char *fmt, ...) messages which have been printed once already. This is done on a per-inferior basis. */ -static void ATTRIBUTE_PRINTF (1, 0) +static void gdb_bfd_error_handler (const char *fmt, va_list ap) { string_file output;