From patchwork Sat Apr 6 17:03:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88132 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E3FA13858C53 for ; Sat, 6 Apr 2024 17:04:28 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4B16D3858C53 for ; Sat, 6 Apr 2024 17:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B16D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B16D3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423006; cv=none; b=hVUNrBAYxgYNq81lQirsWdA9jZj3Ds/6dCzDVI/H5Pstvr6Dax8y6+EhAwBGdRVHwmMDr9okaURvKehMT7dw7FCkZSYfVw2rCrT6H7Yeix03QWi3DF70Wd74RP354C6sxgOpz3Ib2vIF3ru+fhDnzVt8I48Hh5qM8YyW03DMEyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423006; c=relaxed/simple; bh=Bz5nS2p/Cd/qgne2owoGb9RgYAYKxp8uvCJm2LlHTTs=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=bTlRmvBuisVo/LPaTnejd3HC03fE5C/t/f+brgvuL9TN68Th9RpHTAIJ7QNpmJcsESPUuqpzeTUWWBJOnMvJibzv/vjpkAoM0B2kZWlE/V9f/uxYTL06CKLjaaiJQ+0lAaSuSiWm9EUx8tVuruSvgqmc5yht57/9eZfE4O3K2pY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=Yh7XFmDrIF5aUzxBmemZhA/h3+SgLAexIrcsQBpvwMTjA2TZv26QLLUD4pGnBW6C6Macge nEgJ9viHW51pr4H1IxlP7CTQAv6LknksTJp4m0/r6mHTzrrOyO+6nhHioTJzHYyBHEltmm V2F3bY71l3OEaYMA8kABDeRRBv91XfE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-gAO6VBetMZykX_0Wd0EDeQ-1; Sat, 06 Apr 2024 13:03:23 -0400 X-MC-Unique: gAO6VBetMZykX_0Wd0EDeQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a5190b1453fso167170466b.2 for ; Sat, 06 Apr 2024 10:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423001; x=1713027801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pvQUAOxkzDJFKXx4dULwEpeooPR78Tg7S79G2SPNYxA=; b=LDOG9mzxNTax3WpXCcxkQpZdDKKfKnwvpCJ/MTOhyL+8g8T17inz23sp8Pa6BYrqhV j4tAa29+ha5QAlBJgNVlmamtE/MJ9cja9CD7m1mhw4AGJcQJmft2+AiwD8gYx1Rl/jOd x4hJbj6zvfQp1z69j2pE6eGke1Atgh09++qesPgF/YU6kH4El8zUPejVAJzxLEm/8qxH A8qPZnNkWTjZujNAaIkQscLSdWnDRtsilCJpTUa3qWqc6wxn+IoIFRAvYIyJFjzFwACX 2/JWHiX3CH8zOGIH+oKbZmSAnc50lMkFtPU3BaxVZbv8vaKQeCka9VsHkHtawoSkiDWX BErA== X-Gm-Message-State: AOJu0YxYnlsie9xVv0RmrvkwGCcK58ijSk6tVkFFJAS76KHeVE1OLtEK 1rfcA0UPR8dqmuadws5DM1K4l73MVEk/elKUZ87SVFSVNkcyh2PcG9l4D6KZaainu5ZP3HY3dvs ljMj3XBq/hMGGt2ttO6OwFyaqoTD45rfRAhYBUBksxsm2gf2HVomataqU8zOs6G/QSkes2+Zb36 9eO3MgNBxMT6OM7iPZ2+EHKTlM8UleK+4ylvg6Mnt+JPY= X-Received: by 2002:a17:906:2488:b0:a46:8daa:436f with SMTP id e8-20020a170906248800b00a468daa436fmr2842596ejb.69.1712423000963; Sat, 06 Apr 2024 10:03:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEEaMPJvWT+3JUVIVLHjYfs+R74QVHOnNTtONpo+J3H+KH55p1/F9NqLUcc4b6AvA78wT2V6g== X-Received: by 2002:a17:906:2488:b0:a46:8daa:436f with SMTP id e8-20020a170906248800b00a468daa436fmr2842582ejb.69.1712423000442; Sat, 06 Apr 2024 10:03:20 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id cw23-20020a170906c79700b00a51bf5932aesm650900ejb.28.2024.04.06.10.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:20 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 1/6] gdb/Makefile: add gcore to the 'all' target dependency list Date: Sat, 6 Apr 2024 18:03:10 +0100 Message-Id: <9c6e7010992178e170fa30092d48d9a37dd2315b.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The gcore script is initially generated by the configure process, just like gdb-gdb.gdb and gdb-gdb.py. However if the gdb/gcore.in input source is modified then 'make all' in the gdb/ directory does not regenerate the gcore script. This is different than the gdb-gdb.gdb and gdb-gdb.py files, if their input is updated then 'make all' will regenerate these files. The difference is that for gdb-gdb.* there is an explicit dependency between the 'all' target and the generated file, this dependency is missing for gcore. This commit adds the dependency. Now, if gcore.in is changed, running 'make all' will regenerate the gcore script. There is no change in _what_ is generated after this commit. --- gdb/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index a9f641c0659..df044288b5e 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1938,7 +1938,7 @@ generated_files = \ # Flags needed to compile Python code PYTHON_CFLAGS = @PYTHON_CFLAGS@ -all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb +all: gdb$(EXEEXT) $(CONFIG_ALL) gdb-gdb.py gdb-gdb.gdb gcore @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=$(SUBDIRS)" subdir_do # Rule for compiling .c files in the top-level gdb directory. From patchwork Sat Apr 6 17:03:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88129 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64EA63858283 for ; Sat, 6 Apr 2024 17:04:04 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 203513858C60 for ; Sat, 6 Apr 2024 17:03:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 203513858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 203513858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423011; cv=none; b=MHD/mus/3BZMuWMoyptaCNqD+uS7Bqbi3DcqbN2kfxvOhPuoP5VPuDwlov9CA0ZbRkH6Y9OJg2qCDELheZAq8gr7AMVLROVHTc3awWwDgb8BXhU7EMMUCWI5q8KXeTv1/QUBuInfwzcZFeDOI+Zf2YausmQrMZ1JWkfzSUVGCnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423011; c=relaxed/simple; bh=X/jgVdQSi3IttcNtCB7JvzBTiOEI4gS1Qj7ZTGnhVRo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=KbKfC+AePxkA4ID3kCEDq8t1mmi20+y7MqQTxgEMPO3qyAAJWWSW5q+AGDtWZW3zxrX4E+LoF02wsF44ecfHQsC6zkg/nkDZMUMdcv9ctPquSA4BGjst5UJ4kUzPVPRgUw5z7IrlmUT7YIEYJxASIRLlSN9o0+Az6aN5PSpVJd8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jXUZhxtMpLmldkBXBladnvQAfpr4TalZ+O3CYtiY58g=; b=YE/Rs83nmIyfOLWN9CmmhyHpuUf7K+nRTLCG0PcYsFmwsKb11xhDhTBz2kSrG26eOFgH0D 6TaQp2Vt7xh4/fiauDCAau/IMdDpSu3m0xcl/j18KP9POAxXe0EfvM2Zq7hpn5vT2I0Izl 4AGZKbQIWK/BcF2/1L+sXGt8V/qH15U= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-mGq3yES0Oa2GfJsckLkr7A-1; Sat, 06 Apr 2024 13:03:25 -0400 X-MC-Unique: mGq3yES0Oa2GfJsckLkr7A-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-516e86ccc45so111381e87.0 for ; Sat, 06 Apr 2024 10:03:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423003; x=1713027803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXUZhxtMpLmldkBXBladnvQAfpr4TalZ+O3CYtiY58g=; b=hG9hPPAq8ryBWepCZG/hyKgr/i9yrfl/f691iMO7hl3j4EBYd95pI4xZxz5rDg2zuI 9fRJmMzPAsu760WcRNhBkPOxzfn1rHsvUANzfVOaYpjFI0q7gy3JRykyNcIUSYkAq9Mc l+GQggdC2QdqrJEk4sgkDCjR5WtYoY+7Jc9QcFywntIiCMREOP1UmpMJeJc3GxSgm9AR msov3qI4v1QyfG3qxyyVoWyDiJ43d42RW9OirP7MSVnzdo/oD2hgyJlsfOt4fLL95PGz dJx4pD0EOLaZdrLOozI7999cwf/aRmOnbVe68qWU0w4KRuZbFqyq87V7vriGbIlF74Fp REmg== X-Gm-Message-State: AOJu0YwWkW2sY4FLhvW861mFzl9We8c9FbGghT7S7ACr51kPq5YQ3xVw oW9xW90lsX/MN53zj0PWjyhgyJi8kkqe7iH9ajqNunna61HD5slyLm3+NtjJEl5rRx1nkxugf1P DgW7mQttuu/yTFwAp81bqZQZ8Qr9F0maiYbVFGcuwFfHrrwXVCREWXjU8EexEVnlr5I0BGSAcIN ZhVBRgNQSmb5T3O+SbxvmH9J0nzhNt+DoFxsxhPh0CDqY= X-Received: by 2002:a19:5e16:0:b0:516:d1f0:fbf7 with SMTP id s22-20020a195e16000000b00516d1f0fbf7mr3934805lfb.42.1712423003467; Sat, 06 Apr 2024 10:03:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdSf5X5beZPVonSIAtidZUU4lzeZV+oOGmF3G5k+qyTacSw8dp7fzgtVzFlGLYYHyB/Oo27Q== X-Received: by 2002:a19:5e16:0:b0:516:d1f0:fbf7 with SMTP id s22-20020a195e16000000b00516d1f0fbf7mr3934784lfb.42.1712423002816; Sat, 06 Apr 2024 10:03:22 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id he41-20020a1709073da900b00a5195ee5d62sm2151117ejc.164.2024.04.06.10.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:21 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 2/6] gdb/Makefile: rewrite dependencies for config.status target Date: Sat, 6 Apr 2024 18:03:11 +0100 Message-Id: <20e8e8749d8119823ce18d23dffd2e47f9ad5791.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed something weird, the rule for the config.status target looks like this: config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ../bfd/development.sh $(SHELL) config.status --recheck What bothered me is that 'configure' is specified as being in $(srcdir), while all of the other files are not, even though those files are in the same $(srcdir) as the configure script. However, I tried touching one of those files, and the config.status rule does trigger! This is thanks to the VPATH variable, which is set to $(srcdir), so make looks in $(srcdir) for any dependencies. However, this inconsistency bothers me. Better, I think, to add the $(srcdir) prefix to each of these files. I also spotted that the configure script also includes the files ../bfd/config.bfd, yet that is missing from the include list, so in this commit I plan to add this as a dependency. The configure script also pulls in two TCL and TK related files: . ${TCL_BIN_DIR}/tclConfig.sh . ${TK_BIN_DIR}/tkConfig.sh However, I don't think ${TCL_BIN_DIR} and ${TK_BIN_DIR} are currently visible in GDB's Makefile, so I'm not planning to add these dependencies at this time. In this commit I add a new variable config_status_deps which holds the list of all the dependencies for config.status, with the $(srcdir) prefix included, and then I use this in the config.status rule. After this commit config.status will regenerate if config.bfd changes, which it wouldn't before, but nothing else changes. --- gdb/Makefile.in | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index df044288b5e..9340becbdc9 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2333,7 +2333,18 @@ nm.h: stamp-nmh ; @true stamp-nmh: config.status $(SHELL) config.status nm.h -config.status: $(srcdir)/configure configure.nat configure.tgt configure.host ../bfd/development.sh +# Files included from config.status or the configure script. When +# these change the configure script doesn't need regenerating, but its +# output (and so that of config.status) might change. +config_status_deps = \ + $(srcdir)/configure \ + $(srcdir)/configure.nat \ + $(srcdir)/configure.tgt \ + $(srcdir)/configure.host \ + $(srcdir)/../bfd/development.sh \ + $(srcdir)/../bfd/config.bfd + +config.status: $(config_status_deps) $(SHELL) config.status --recheck ACLOCAL = aclocal From patchwork Sat Apr 6 17:03:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88130 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C02433858403 for ; Sat, 6 Apr 2024 17:04:05 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 23951385841E for ; Sat, 6 Apr 2024 17:03:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23951385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 23951385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; cv=none; b=THwBnnyoDHWQ6wc06qiCiM3xCYL8rdbc1LMicDc76suZchFsOpP4kwJyx3tRaMmJf5Cw29AnAY1nrnhibezQZ5BYk6ZLmECRx/+Tto5GoZRiCg0y32BR/+c//0bqJYy/iEy4L1XReRDdQVhTKr+1pC5NI5lFr3zX6iFlAGJ24hI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; c=relaxed/simple; bh=q5Ypfshjtbukzyo5yaGWYRKGeSzFDxoYGlooACKlAH4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=AKri7s/FB1EDq8pQoXfWKfIXSJ1sviYUNclhyZtsxoz6wGugjz0jGhUyWBZSimcnpwYYNU1cg6AnUDJtGAKLviYC6MviJdi95moXnffkDJMGywUmsVsya4d8dw0U12jka44+8P/aq2/dVEwKorllLp36LCYrkOrqB0AodI8NImM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=JWwGK2DuAx6DTcbRboL3qaCPSj7z8tmhLBJpBy1yqWeLdUdU47aEHad5eQOEfJA5LOepot E57nyzi11uYH7rfb7BS1l8tJlQu7sgGhD25kOtBRdvJOa1KMrdCGy17rkvsk9BmndsRxBR z8Dk6KMSMEmExUcJ8V9FyPTeUK3dLVM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-jugKsrw-OrSnGEDbaewcYA-1; Sat, 06 Apr 2024 13:03:27 -0400 X-MC-Unique: jugKsrw-OrSnGEDbaewcYA-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a4455ae71fcso204183366b.3 for ; Sat, 06 Apr 2024 10:03:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423005; x=1713027805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=GoXTiMSVSSOnUBAOQQwPwdMPEsRE7AWnJ2Ut2u/inxgCzSiIFIlzfb35s5ztR4VZJM uE/CC9Iaf/l7MU2H0dZfczvAu032s+nbgsvm07e6qV20ELq7jNDwstfE0cKTfs9gFJLP COPBdryvcKDOkrssq1BG4QrfXajyw808z2j3apRbyJOFuBv18YSGTTe8o1xo/QnW6Ysh 9HOH6XRTD4ZlisxnOf7IaJq+1XJ0WBJ8CI+dFfjmPAWptOQQAz3jkCzAe9kBL1Of9NBR 495JUJ5ppOFW6n1QQst3N9i2oCrB4ph+4G0pfsPYkG18Q86LoSqQTcXq4l+7O5ZKKQw/ AEjQ== X-Gm-Message-State: AOJu0Yw6zMGugfxedWn7hivnUFelM6AOlt0r/vsi7UnEHBXnrQ8b1fKU Gkr1X6m2TtScRySsuBzOcOOfeDaKlSJ88w3vhW90tFXAugcII4dP6hCZrh7wgK9p2hgoaBLO5xQ V6J8ZPZ8sc7x3LigZMK95yRQtaIyKlIbvV8g+GYGFX29XN8FYx3+Ghwyk1EGBkFgX0WfUKEDZww I54Ojr5nYkddymE3Vlq0qZbzgcZZ1VLifSvQlH9VjGgUI= X-Received: by 2002:a50:c30c:0:b0:56d:c295:dde3 with SMTP id a12-20020a50c30c000000b0056dc295dde3mr3881770edb.35.1712423004961; Sat, 06 Apr 2024 10:03:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0VPhw2it5UHbPMhAf9zLuncYa+9cHmf0Z+PaZdTptYV5ayMgxBb01LmJt6CEXIaw71UYd4w== X-Received: by 2002:a50:c30c:0:b0:56d:c295:dde3 with SMTP id a12-20020a50c30c000000b0056dc295dde3mr3881752edb.35.1712423004442; Sat, 06 Apr 2024 10:03:24 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id de26-20020a056402309a00b0056c1cca33bfsm2040774edb.6.2024.04.06.10.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:23 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 3/6] gdb/Makefile: add some missing config.status dependencies Date: Sat, 6 Apr 2024 18:03:12 +0100 Message-Id: <7c64e75ac82b176db8bd4572ace865076851c36e.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed that for the build targets jit-reader.h, gcore, gdb-gdb.py, and gdb-gdb.gdb the rules all use the config.status script, but don't have a dependency on the config.status target. This means we might fail to regenerate these targets in a case where config.status, or one of its dependencies changes. Two other targets that use config.status do correctly have a dependency on config.status. Fixed in this commit by adding the missing dependencies. There should be no changes in _what_ is generated after this commit. --- gdb/Makefile.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 9340becbdc9..c1b3144b175 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2313,16 +2313,16 @@ Makefile: Makefile.in config.status run: Makefile ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) -jit-reader.h: $(srcdir)/jit-reader.in +jit-reader.h: $(srcdir)/jit-reader.in config.status $(SHELL) config.status $@ -gcore: $(srcdir)/gcore.in +gcore: $(srcdir)/gcore.in config.status $(SHELL) config.status $@ -gdb-gdb.py: $(srcdir)/gdb-gdb.py.in +gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status $(SHELL) config.status $@ -gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in +gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status $(SHELL) config.status $@ config.h: stamp-h ; @true From patchwork Sat Apr 6 17:03:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88133 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B38F33858289 for ; Sat, 6 Apr 2024 17:04:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CFD653858C5F for ; Sat, 6 Apr 2024 17:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFD653858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CFD653858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; cv=none; b=seLO1YYsmGilDcuwWqlDbctk2xoUZJUZUDh3yxdeqkRE0I/2/PxexrgVpxqX+2NxFAzVa0J3lrr80sgzNOsGNRZHFpPlLdVOjLiaVf1vwoTNNjCsgxeJ4FWGQVez+b0hVvVLnmg6JqRssiffAAqHWXWf4AeGCwbSEIa1AmdWPSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423012; c=relaxed/simple; bh=lZzuZwgjhPs1wga7Ee/pGpJIbGTwgvW8AMHUY+lSaUc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=oWk0LSll6QtOjQfRPMl3Su6XkaNCzZd0HGCuvIpOKKjEAWYzSDqTmlgWrKhhp0vrWunJwFvxSf2djYSWcb6u/j0dRJZ7DMG4730vQDhqW8m4TtIWB9KdQxkCkMkXaXeiwRMo1I6Dtux012ptdfaMAwyY8mSburdXqm2Yc2MjjCU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jm6xj4maMt+PJAfNxk78/KuZGtOT+iw+xRBt9835T/s=; b=RS/ypLPPiCYAN6Opst0R49Dpq14sKHkYaKwfJ+gFZNSdH90FkN5oVZfDSBFNUkPDLkVj0p yM6xVsa1imq3IFrdLyStQ8O55nAGqrj9XwEdtrF31AyQap920JXCIwztiIhhB4lguq/kDN QernKcuBjNHoXDl9WIbtTWRtYeQkNVc= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-yNIwdhKCPh-nLzYRGwagPg-1; Sat, 06 Apr 2024 13:03:29 -0400 X-MC-Unique: yNIwdhKCPh-nLzYRGwagPg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d8744ebae2so7369781fa.1 for ; Sat, 06 Apr 2024 10:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423007; x=1713027807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jm6xj4maMt+PJAfNxk78/KuZGtOT+iw+xRBt9835T/s=; b=YMCoz7xXrJkxm75//kPdH3s4DP3X8ryokvp8MKn7m0FmzyRCnzh7tjXiIIkL1kcxM6 jWdFcvVHIlmjcZ+xaACaajXJhgGwbcaTZUjXDiqOUNxLftU53Qx1Lh2QJ+uVKdpyGiE6 yQBqYmXyH0AZefbhM/OlfmVC60kW33gGU2iKDzv5sQ8xItJ4xJ4kc8qde8KmvoCGfbts W4XJCu2UQDqvncoResbwxDYM1eu/GC2P0l5V5u6hlfQYiddzn2j7RDO40XNwjMxcP1xu S3wiu3qThOwk2hv4ilQTjW3+67t9pPyO2KYTAh6z9D6Fedthsaz6Er5NqMPwEg1mK7ca 7Wpg== X-Gm-Message-State: AOJu0Yz7V11AcnAuACxHh6dOpaGrEZukEGYg612TTq9OgfPKUqZk+6rD q0Gim9P5OReCsC16InZSR6FVNppS/DK9ba74tBZfZCN4tyg+GjPkfUv3on6Mpxdi0nnjdFOiMhj sL0YZ42OQNgV5Qz+Dw6mm3zqJUiAb/vH42/gb9pUqqr+KotrSYtFJKXtuuWnVSyfteGyJJmvvJD QwYBAsG+iUf24RBNq+B+BTRg7+N+qIOY5xlGF7OqlLKk8= X-Received: by 2002:a05:6512:510:b0:516:c766:5b4f with SMTP id o16-20020a056512051000b00516c7665b4fmr2919100lfb.67.1712423007243; Sat, 06 Apr 2024 10:03:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEm4kIe4IM95GQlIOz/1bfD4lUEJj6VVfYq/z4upRs2WGj0lBIhf3BPCFiywkvZxEQ3eTY/DA== X-Received: by 2002:a05:6512:510:b0:516:c766:5b4f with SMTP id o16-20020a056512051000b00516c7665b4fmr2919075lfb.67.1712423006654; Sat, 06 Apr 2024 10:03:26 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id lr12-20020a170906fb8c00b00a4e32ea1c3asm2197285ejb.146.2024.04.06.10.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:25 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 4/6] gdb/Makefile: Print 'GEN' message, and pass SILENT_FLAG more Date: Sat, 6 Apr 2024 18:03:13 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The targets that use config.status to regenerate themselves don't currently follow the silent rules that the rest of GDB's Makefile does. For example, touch the gdb/gcore.in file and then 'make all' in the gdb/ directory prints: /bin/sh config.status gcore config.status: creating gcore In this commit I make use of the silent-rules.mk mechanism for these targets, now we get: GEN gcore Which matches the rest of our Makefile. Obviously, if you pass 'V=1' to the build then you'll get the old output back. There's no change in what is generated after this commit. --- gdb/Makefile.in | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index c1b3144b175..e9a6247c38d 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2307,31 +2307,31 @@ subdir_do: force done Makefile: Makefile.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ .PHONY: run run: Makefile ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) jit-reader.h: $(srcdir)/jit-reader.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gcore: $(srcdir)/gcore.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status - $(SHELL) config.status $@ + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) $@ config.h: stamp-h ; @true stamp-h: $(srcdir)/config.in config.status - $(SHELL) config.status config.h + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) config.h nm.h: stamp-nmh ; @true stamp-nmh: config.status - $(SHELL) config.status nm.h + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) nm.h # Files included from config.status or the configure script. When # these change the configure script doesn't need regenerating, but its @@ -2345,7 +2345,7 @@ config_status_deps = \ $(srcdir)/../bfd/config.bfd config.status: $(config_status_deps) - $(SHELL) config.status --recheck + $(ECHO_GEN) $(SHELL) config.status $(SILENT_FLAG) --recheck ACLOCAL = aclocal From patchwork Sat Apr 6 17:03:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88134 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 519443858C31 for ; Sat, 6 Apr 2024 17:04:43 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6745A3858429 for ; Sat, 6 Apr 2024 17:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6745A3858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6745A3858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; cv=none; b=ta1YhNBiJQYTILSLMZ3zQOe6HdKyQXgVgsdcn99nuU1PQKHR/Ma22nsG3iuHFdXT+CXbcYcze86k18l6IroZYh7PHFYjvS9BTPnI1835DD0PrVX65KmDj37I/Y0elZO9o1imjXkh1xYMNsmOsq4kv8LogwG4XTaX4T49nkn/wAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; c=relaxed/simple; bh=PQ/Td58yCIakTT3310yzj3gkDB2juJfe7zJK/5UYKYE=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SkjTya4RkkiqGm0fvebX009BmYJrrfQQq3a9uFlPI7107xAu2WOdnGGZWvaBD1kjpOSdN/nYQ/br3b2vb5EBIaR1MFBNAHD2ymI7mK8Wr1cyjBiouTxBZ1TONbCvMwhg/+Px0d85O6zdRTLMedbKERlnwvqVdeJ2FSHYsllvu2M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vsNU60J+SXoY4aAMjiZ453MiUlxSfyaK6KqWFpqmdKg=; b=EqmTY0+sLMMTskKtPOfoNXotcMDJqhVLxdnlFEqSPRxnL/Na+uyutyT/KFH6NWDMqQYM2i j1hJ7sRQlxvhtk2UZMqRFoCbVSlcywh1VCxkQC1otBy0SfXfgo2/uL8EfsQLV1+Vb8kDkQ lZqaG9hS+xB75mQ+fXRFHG463yTWtKA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-Dwmj4tMhP6SUk6GLs3rlxw-1; Sat, 06 Apr 2024 13:03:29 -0400 X-MC-Unique: Dwmj4tMhP6SUk6GLs3rlxw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-56e2a11ff78so1105106a12.0 for ; Sat, 06 Apr 2024 10:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423008; x=1713027808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vsNU60J+SXoY4aAMjiZ453MiUlxSfyaK6KqWFpqmdKg=; b=vsqu26yAeDc1xDEsDXRT9pqbqlPOGkq7/wfE1BMEpqWs8cD+ODt/Van+dfyw9EZC7B W2LGZ7oZ7+P+IX4eH5FoSOn7enx/gNNTTliJgWHe9RlFrYco5MZDh4mK7CmJ9faIYMPn rOyTImD4DM2JTiN4Kzl5DpRtrmxnyjxY0jSg8WnhS0ol+nCYlJT7oF0dDCMKuCIZ1gQU Txs7w8kG9F3nXGoPjAJ27afPGAVDcgwriC9K9XR39MBFb+SPGARvddJeqNvtNQYQG3KO vgOSxOcWRYpozbIz/52RlV/GrT68Y6QYtPh0AKkSzyMkGCg6c/5vB1ARngSExpK9abAL iqlQ== X-Gm-Message-State: AOJu0YyxOzdyedzC2WcJBVTaPyXdV2UtXIxDZEq8BGts2Q55uisezPPZ 2h+rSwGrrzpe810hX8HVwDyFxpNmeAEla+ynJ9pDozMw2+WvMkx4kx7neoTQJ+wSX2fYwJ1lg9W x99oeCjNyWSukb448uVdLaxETOUVYij5+P9H84sVveLT9AW4cuI4lfLmfyhZhUbR5KAVPc532cf c3aTJIiz5RwdqcJjFmqtxchDGJdTWfrlrD8Fsb1Bm6Jdg= X-Received: by 2002:a50:d61c:0:b0:56e:33fe:5e88 with SMTP id x28-20020a50d61c000000b0056e33fe5e88mr2955886edi.34.1712423008060; Sat, 06 Apr 2024 10:03:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnJbAUQ5iuzj+Fgw3ODFwuIWfWRZu5zqNC5UNObLaripTGZKDQvZq20IPF7vzCyslo+1sl5g== X-Received: by 2002:a50:d61c:0:b0:56e:33fe:5e88 with SMTP id x28-20020a50d61c000000b0056e33fe5e88mr2955877edi.34.1712423007721; Sat, 06 Apr 2024 10:03:27 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id es18-20020a056402381200b0056a033fa007sm2046961edb.64.2024.04.06.10.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:27 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 5/6] gdb/configure: use AC_MSG_NOTICE not a direct echo call Date: Sat, 6 Apr 2024 18:03:14 +0100 Message-Id: <51e77408f8d95ebdca75e56237b213c0368e996d.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org After the recent commits, I noticed that GDB's configure script would still emit two lines even when run in silent mode. If you touch gdb/Makefile.in and then run 'make all' in the gdb/ build directory you'll see this: GEN config.status enable_sim = no enableval = no Obviously the 'no' might be 'yes' depending on how you actually configured GDB. This is caused by two direct invocations of 'echo' in GDB's configure.ac script. In this commit I replace these calls with use of AC_MSG_NOTICE instead. Now when configure is run with the --silent command line option these lines will not be printed. There should be no changes in the built GDB after this commit. --- gdb/configure | 6 ++++-- gdb/configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/configure b/gdb/configure index d0fd1760b88..ffbc14493e2 100755 --- a/gdb/configure +++ b/gdb/configure @@ -32848,8 +32848,10 @@ fi # # Check whether --enable-sim was given. if test "${enable_sim+set}" = set; then : - enableval=$enable_sim; echo "enable_sim = $enable_sim"; - echo "enableval = ${enableval}"; + enableval=$enable_sim; { $as_echo "$as_me:${as_lineno-$LINENO}: enable_sim = $enable_sim" >&5 +$as_echo "$as_me: enable_sim = $enable_sim" >&6;}; + { $as_echo "$as_me:${as_lineno-$LINENO}: enableval = ${enableval}" >&5 +$as_echo "$as_me: enableval = ${enableval}" >&6;}; case "${enableval}" in yes) ignore_sim=false ;; no) ignore_sim=true ;; diff --git a/gdb/configure.ac b/gdb/configure.ac index aa91bfb3a17..28e750b6b43 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -2032,8 +2032,8 @@ AC_PATH_X # AC_ARG_ENABLE(sim, AS_HELP_STRING([--enable-sim], [link gdb with simulator]), -[echo "enable_sim = $enable_sim"; - echo "enableval = ${enableval}"; +[AC_MSG_NOTICE([enable_sim = $enable_sim]); + AC_MSG_NOTICE([enableval = ${enableval}]); case "${enableval}" in yes) ignore_sim=false ;; no) ignore_sim=true ;; From patchwork Sat Apr 6 17:03:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88131 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A695838449C7 for ; Sat, 6 Apr 2024 17:04:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F25523858435 for ; Sat, 6 Apr 2024 17:03:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F25523858435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F25523858435 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; cv=none; b=dqn09giKvlpJUEAcH+FaryjLh7Gcw5qWj5p6q87zh+ctT7ehji7KGv9p91KK5WQF61L0+vkMPsGibTz52J2jb++St6Qf3ybtRG3BEASAEqhLH3QaLVhfIcd8i3f7fRCwxcPjhsDyCqsfTHrOVk4sc0CzsfK173U9ADwBNwAlakY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; c=relaxed/simple; bh=cOsmv/6vC5SoGbT7Drc/LkReSavEM64bIOEws58o+QQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=GqwW43T3e9vgzAiW7ctE2+afGTAov+N6N36NPOodL1ZZQhhWdW+8DHNuSPbCFlku3sMiSKSwaIM+AJNsuID3n0+pqHVS1Tfqqf4Prfa8iRU3GTiT6XJwENpe4nmRJElR3l9D9oxo9Cid1qZg+0v2sWrXJF8gQYk8YJXmNKpBwV4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W6fICFjL6ESMtcpSxnw1hwZPAjO1RJin6WOXrfkkFBA=; b=QHxZ61E3Lbhrir6XaicLlIpc5Ug2lIlq+USdQWLnrZRMKVj7hwfHUIAcl4ectPQdsxZqRW /i4uh+7DV08SlN8o24XaBNRTYPyfDNYdeWifVdaCgpxbdEbEGemQpf8qdHHNFgMEqpJUXv Y/ir8oSFOn7PJhlrmjwnWslj/16Gm7c= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-BYIHHwHkM06_NIlTaZQCOA-1; Sat, 06 Apr 2024 13:03:31 -0400 X-MC-Unique: BYIHHwHkM06_NIlTaZQCOA-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-56e242ec7ffso1227520a12.3 for ; Sat, 06 Apr 2024 10:03:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423010; x=1713027810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W6fICFjL6ESMtcpSxnw1hwZPAjO1RJin6WOXrfkkFBA=; b=WHedzjdBFU3HL972YQj3IHYCZQqXCsCGUYlTHt9k7lwUqMXnZrroK6pLcsCI9YUxhU uX4NbxV8iK8i4hxJ0ZKsElW/GKWiSoLXXDVM27XdTcidYuZczaNiIUAK7XCNwrx4elXQ BVWLTmVQ7we+tB4ynX5gCFwLz1bthBG8KC6ab/tWVhH+LBkycarJp+T+YRVFH0NyH1cC eNAcyczqYTaiaHxwsvWV2CctF70CZm8l9Mja4p+d2P8LnVMaKb66aP86Ay00nyiz4HQl yR/EVN0I5FKzfK9Yq8HFAzI0MwNQDPCnIfaunrPr8poIOted45EO+BkvE8N4AhiU7n9S a3/Q== X-Gm-Message-State: AOJu0YwubRFSLxK6k4bDA4LEpcrVRNxX8zMyxGZe3yXEd9JBVvyycqRt KIMAiybLBRDcs4YKp9cDhg1CkgsBLdbYY2OVawkq5rEAzLMihQSgngUrZEBGQYRYfeegZfOOwcC e/YIbLX2VFOHlln4YrUY2jlQqp94lPKeOJTlSX/pHreXtWKpoDqdUayQEq4xvXRXanGyfOTxXSM axGtkpJtUKgFEci3u1kk/zaa0/5Ui+0PptXR34hXaQBbA= X-Received: by 2002:a50:8acc:0:b0:56b:9ef8:f630 with SMTP id k12-20020a508acc000000b0056b9ef8f630mr3153637edk.2.1712423009489; Sat, 06 Apr 2024 10:03:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhn1XV5BILz8PwDAvDLE/Z7vRV6VPDDaxPNNoRvhZv5aBNiiR4rUBAad2plodq0/r3oepblw== X-Received: by 2002:a50:8acc:0:b0:56b:9ef8:f630 with SMTP id k12-20020a508acc000000b0056b9ef8f630mr3153627edk.2.1712423009035; Sat, 06 Apr 2024 10:03:29 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id b93-20020a509f66000000b0056e0376286bsm2116883edf.24.2024.04.06.10.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:28 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 6/6] gdb/build: apply silent-rules.mk to the data-directory Makefile.in Date: Sat, 6 Apr 2024 18:03:15 +0100 Message-Id: <97d0a17d1cc2414b98d1dd6bd0344748400b30c4.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This commit makes use of gdb/silent-rules.mk in the data-directory Makefile.in. I've only updated the rules that actually generate things, I've not touched the install or uninstall rules, this matches gdb/Makefile.in. I've not managed to completely silence all of the recipe output, the mkinstalldirs command outputs some diagnostic text which looks like this: GEN stamp-python mkdir -p -- ./python/gdb mkdir -p -- ./python/gdb/command mkdir -p -- ./python/gdb/dap mkdir -p -- ./python/gdb/function mkdir -p -- ./python/gdb/printer I have a patch for mkinstalldirs that fixes this (by adding a new --silent command line flag), but that patch needs to be submitted to automake, then an updated mkinstalldirs sync'd to the gcc repository, and then copied into the binutils-gdb repository... so I'm leaving that for a future project. Then the guild compiler also emits some diagnostic output, which looks like this: GEN stamp-guile mkdir -p -- ./guile/. mkdir -p -- ./guile/gdb wrote `./gdb.go' wrote `gdb/experimental.go' wrote `gdb/iterator.go' wrote `gdb/printing.go' wrote `gdb/support.go' wrote `gdb/types.go' The 'wrote' lines are from the guild compiler. The only way to silence these would be to redirect stdout to /dev/null I think. I did prototype this, but wasn't 100% convinced about that part of the patch, so I've decided to leave that for another day. I did need to add a new SILENT_ECHO variable to silent-rules.mk, this is set to a suitable 'echo' command to use within recipes. When we are in silent mode then I use the 'true' command, while in verbose mode we actually use 'echo'. So, other than the issues outlined above, the output when building the data-directory is now greatly reduced, and more inline with the output when building in the gdb/ directory. There should be no change in what is actually built after this commit. --- gdb/data-directory/Makefile.in | 40 +++++++++++++++++++--------------- gdb/silent-rules.mk | 4 ++++ 2 files changed, 27 insertions(+), 17 deletions(-) diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in index edfa52c2217..720b983ef6c 100644 --- a/gdb/data-directory/Makefile.in +++ b/gdb/data-directory/Makefile.in @@ -36,6 +36,8 @@ exec_prefix = @exec_prefix@ datarootdir = @datarootdir@ datadir = @datadir@ +include $(srcdir)/../silent-rules.mk + SHELL = @SHELL@ LN_S = @LN_S@ @@ -202,7 +204,7 @@ FLAGS_TO_PASS = \ all: stamp-syscalls stamp-python stamp-guile stamp-system-gdbinit %.xml: @MAINTAINER_MODE_TRUE@ %.xml.in apply-defaults.xsl linux-defaults.xml.in - $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_SRCDIR)/apply-defaults.xsl\ + $(ECHO_GEN) $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_SRCDIR)/apply-defaults.xsl \ $(SYSCALLS_SRCDIR)/$@.in .PHONY: syscall-xml @@ -219,16 +221,17 @@ clean-syscall-xml: # For portability's sake, we need to handle systems that don't have # symbolic links. stamp-syscalls: Makefile $(SYSCALLS_FILES) - rm -rf ./$(SYSCALLS_DIR) - mkdir ./$(SYSCALLS_DIR) - files='$(SYSCALLS_FILES)' ; \ + $(ECHO_GEN) + $(SILENCE) rm -rf ./$(SYSCALLS_DIR) + $(SILENCE) mkdir ./$(SYSCALLS_DIR) + $(SILENCE) files='$(SYSCALLS_FILES)' ; \ for file in $$files ; do \ f=$(SYSCALLS_SRCDIR)/$$file ; \ if test -f $$f ; then \ $(INSTALL_DATA) $$f ./$(SYSCALLS_DIR) ; \ fi ; \ done - touch $@ + $(SILENCE) touch $@ .PHONY: clean-syscalls clean-syscalls: @@ -262,8 +265,9 @@ uninstall-syscalls: done stamp-python: Makefile $(PYTHON_FILES) - rm -rf ./$(PYTHON_DIR) - files='$(PYTHON_FILES)' ; \ + $(ECHO_GEN) + $(SILENCE) rm -rf ./$(PYTHON_DIR) + $(SILENCE) files='$(PYTHON_FILES)' ; \ if test "x$$files" != x ; then \ for file in $$files ; do \ dir=`echo "$$file" | sed 's,/[^/]*$$,,'` ; \ @@ -271,7 +275,7 @@ stamp-python: Makefile $(PYTHON_FILES) $(INSTALL_DATA) $(PYTHON_SRCDIR)/$$file ./$(PYTHON_DIR)/$$dir ; \ done ; \ fi - touch $@ + $(SILENCE) touch $@ .PHONY: clean-python clean-python: @@ -305,8 +309,9 @@ uninstall-python: fi stamp-guile: Makefile $(GUILE_SOURCE_FILES) - rm -rf ./$(GUILE_DIR) - if test "x$(GUILE_FILES)" != x ; then \ + $(ECHO_GEN) + $(SILENCE) rm -rf ./$(GUILE_DIR) + $(SILENCE) if test "x$(GUILE_FILES)" != x ; then \ files='$(GUILE_SOURCE_FILES)' ; \ for file in $$files ; do \ dir=`echo "$$file" | sed 's,/[^/]*$$,,'` ; \ @@ -317,11 +322,11 @@ stamp-guile: Makefile $(GUILE_SOURCE_FILES) cd ./$(GUILE_DIR) ; \ for go in $$files ; do \ source="`echo $$go | sed 's/\.go$$/.scm/'`" ; \ - echo $(GUILD) compile $(GUILD_COMPILE_FLAGS) -o "$$go" "$$source" ; \ + $(SILENT_ECHO) $(GUILD) compile $(GUILD_COMPILE_FLAGS) -o "$$go" "$$source" ; \ $(GUILD) compile $(GUILD_COMPILE_FLAGS) -o "$$go" "$$source" || exit 1 ; \ done ; \ fi - touch $@ + $(SILENCE) touch $@ .PHONY: clean-guile clean-guile: @@ -355,16 +360,17 @@ uninstall-guile: fi stamp-system-gdbinit: Makefile $(SYSTEM_GDBINIT_FILES) - rm -rf ./$(SYSTEM_GDBINIT_DIR) - mkdir ./$(SYSTEM_GDBINIT_DIR) - files='$(SYSTEM_GDBINIT_FILES)' ; \ + $(ECHO_GEN) + $(SILENCE) rm -rf ./$(SYSTEM_GDBINIT_DIR) + $(SILENCE) mkdir ./$(SYSTEM_GDBINIT_DIR) + $(SILENCE) files='$(SYSTEM_GDBINIT_FILES)' ; \ for file in $$files ; do \ f=$(SYSTEM_GDBINIT_SRCDIR)/$$file ; \ if test -f $$f ; then \ $(INSTALL_DATA) $$f ./$(SYSTEM_GDBINIT_DIR) ; \ fi ; \ done - touch $@ + $(SILENCE) touch $@ .PHONY: clean-system-gdbinit clean-system-gdbinit: @@ -438,7 +444,7 @@ clean-info: MAKEOVERRIDES= Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status - cd .. && $(SHELL) ./config.status data-directory/Makefile + $(ECHO_GEN) cd .. && $(SHELL) ./config.status $(SILENT_FLAG) data-directory/Makefile # Disable implicit make rules. include $(srcdir)/../disable-implicit-rules.mk diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk index 36791f6683f..43dc2bf3aca 100644 --- a/gdb/silent-rules.mk +++ b/gdb/silent-rules.mk @@ -20,4 +20,8 @@ ECHO_RANLIB = @echo " RANLIB $@"; SILENCE = @ # Silence libtool. SILENT_FLAG = --silent +# Used in shell snippets instead of 'echo'. +SILENT_ECHO = true +else +SILENT_ECHO = echo endif