From patchwork Sat Apr 6 04:46:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 88124 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B92823858C60 for ; Sat, 6 Apr 2024 04:45:30 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01olkn2014.outbound.protection.outlook.com [40.92.64.14]) by sourceware.org (Postfix) with ESMTPS id C6CD63858D1E for ; Sat, 6 Apr 2024 04:45:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6CD63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6CD63858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.64.14 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712378708; cv=pass; b=hVEOWnSua4xw7pgpL120dk2iVih8OPkBmUevaZulJ4/rVAWr+xR0N2qrSYmpgQxqnWFKwFwmdWn6ZljWS7D3u14CuKz+HkNj0z7E7HJIKZDHjk2lYzAjyj3MPb4+fmeaBqPHJjfvnI+IEeXWzQrOcqxjgCcNZ3h/kki42z0qlUc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712378708; c=relaxed/simple; bh=B52vTd+Lb0ZofpmuKi+V7/z1SShVvQYwyP/5lJ0UAus=; h=DKIM-Signature:Message-ID:Date:To:From:Subject:MIME-Version; b=El32vmtdXF5ejKGkTh7M2V9v11HM/yWVBb6sTY7pVYzdQd1WyXRnfSc709hGnS7uJTVittXC29vWlKSh9J/QPVxKWWuWE6nuFVttZyIgMYgFdx1HiH15eX6zOiL5dJywDOTrtih4XHal3nPNBJo1I53TSnLB9csaabcXllzPEH0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqaHfTWOVtlBSsRMqwiAmuHJSdS2OdFyJGZNzGCYgFe7hiubIvcqlZcl/dzVzfzKGGozCIWyNbDZ/7tRXA03gw9O5BcnI16/tSA+HOKvRrWACyHXrkztAY4p3eMTol3WDnl2oJsW9SlW689bAzEs7zFSTU5nkjO0SG5o2ZlDjxVq3J5zPr1JR1R9a9D/dd9JmZ2nlS/78rShb0ETRtMWFfC4O06b0+T7CwPF6y19aUIxqpLOBf7vHCChxwUfy8pkIkIzN4BmsTVaK8Gd9dbLQ38sFpxPRdrsZz6WuWDcMYxDgdt/m7EqTxsYJTC/obfvpLGJQCl3zftTiLMTh+JcBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yisiUh2BYhJY7EDlUc6M4k7h5DwSo3wQWJoPbLP12GI=; b=KNIhhR33ccsXYeRR+n00EHWtZCEDSCG24BLde2VXQIt0QESM0PfWS+RTKFnZWA/wpD6NfHC2aXz3IaWHhq7gUUB/vF+Zr5Qt1q/hqw4unPFbvCy1wmyANfuoUKnGj77WxF2VTTaBDxgZ6HWoSR8otyf0RrxOCy7ebHZxbMd7vu2EEc0sdkD2+n06TDXP353NsvyB239qxc6ZOCdggsWE2Vq8o8i+mSnaI/aeQTHTqZ5lzVpgnyCrNRL8WMo0z5Z+gZR4fU7Xf5T6O5l3SNzJJ9wfcGd8kJ2wJx2vG+gqZnP95fBiOsgl+Eglksusk0NDtWV1Cjezdir2qQspnjOgRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yisiUh2BYhJY7EDlUc6M4k7h5DwSo3wQWJoPbLP12GI=; b=N7iGs+Fu5CCOCe9hyqfWvGzwTRBEvp7GbwjpN4i4Z6ZUR6Nz920jgbV1mlqHsGD3xiOITuzqWXk+jgxlhbDXrPQImNJWRB9Jw3sXzWZnxyYWHOec9tPfcRaYRE8XwlVuBDGOz3AgyAmU5G5O+CdpXFytP+HUuVzyxTv2W01I8e/DKhti2x4jV3cNUJIIs5ZU3Q3WKKB9owYw8XjjcL2D0K3qY7gIo9QVrTfD96oWYw4+y/m1pSQqyWOKqLvWUj9smJbwvVkM0i9X1MoVAoZ9WqWLypxnSp563oRIHtnYj8Y6flzpuLiO3JZvFAArrXjYtXfEIpZUO57IpfzoMNmnSQ== Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AM0P193MB0770.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:16b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Sat, 6 Apr 2024 04:45:05 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::5403:f1ad:efaf:1f71%4]) with mapi id 15.20.7409.042; Sat, 6 Apr 2024 04:45:05 +0000 Message-ID: Date: Sat, 6 Apr 2024 06:46:49 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "gdb-patches@sourceware.org" , Thiago Jung Bauermann From: Bernd Edlinger Subject: [PATCH v2] Fix sporadic XFAILs in gdb.threads/attach-many-short-lived-threads.exp X-TMN: [UfniC8/L/+zmo+Yo/Cdi7zOUhS2DHXSZzWFsYAnBr/89Twn6Gu0fE0HIYUCwUEqy] X-ClientProxiedBy: FR0P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::16) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AM0P193MB0770:EE_ X-MS-Office365-Filtering-Correlation-Id: 40e72639-163a-4d6f-0344-08dc55f452f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VIYI7tbfNVZlEdczG9l6p+UJd7AZXLTkKDuRdEGthOXjM5IB/yqnNaCXCBUg1UGJVJ1yC+4ZDV6XAAn9OSpSKO+/1uG2QoCXTe2FEtVg9mPcFRlHaFQK2vmVvHCfpYFLQrTIgxNZMphGRIOG034ByUWbY59pUtTcOHS74LzwqAHy5IAqBlwnzF7yHIb2048AJzasRFWPiVzIEw39nIzq3njepSfVBVd8BgpJALHCgs3T8Xw6WHTTjrErvbCePFoZEBWyrkRc2ld0dyHVReiuSrx+dO/dR2iokAeZNxWxt8igDSLFNxI6XfEPTDh4oGLbddY143CuzuXOj1M1gZB29w6/a/1ae355LWSdG0LqSfQLOaV+6SjVvXZFezUKp2+2drVWwDQg0pZpT99UL6IbuVneczGPJrDWOhLjBj44gfmNsUXgHjhDFOLvd6Pz7ElnJkTnwX7k/0Hi25buSWoCb6lxwXHjfKiUB5SIDngHSiKuNLD2iDw2WSA4BOD91vF+BlKoEPvCDtgo3q0hZUycONUC8OqIXIXdmEKyGymtwq4Z6qZR1+4Ob0uP1fR+FAyazBSFMH1n8avbrxaFhuiWLUR7fMg24NveM+H7z++06oq066TsiRmuMp9QlPwzsRMb1L3rfnQCOWWDe820tM/q3A0oMfuL62CL7qT078Rmr+g= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?R33n5GtBuUJPCh5XtIKcZMJFtDPD?= =?utf-8?q?NFQ1DLSNAFasLb0KTTBuK5Iu9cHr169inxbnII+NK4/P6hw4mwl9/Ps+HWCg7rq8N?= =?utf-8?q?9cOvtNibK8qRRqiY+BQZxW+YweedGRRstZqMh/SRV8jdx7qZKcV5JsquAdiiZGJHm?= =?utf-8?q?7CyEJMFjVoYkSek0ybAq/P9I8uDaVNV7XvsTBvp+kNdC49xM9XxJS4Uy8+BRc8roe?= =?utf-8?q?ajiIW4+fPBGJztT1dluVw2GiPW+5dFS5ZLtIW7kUSDU1tC12KqRbYiui+Vk32lr6N?= =?utf-8?q?0Impbltky3cnPkY3iwuPhe5F9prJw+m430PDvTUZRvP9CLkU9djsanDOxKPb1ni/4?= =?utf-8?q?3SAmrPqmyJfRVv4x0Ugfx2XrsU7jRJ+jfAAGmiXa+6ppOsIociFq165uvOi243lmd?= =?utf-8?q?AaSc6gPu4W1sLhTAMMnw01X1rcTdtnMyPrmnQGpBLtGD2CRlOgxrn3/xdp1FtdgUx?= =?utf-8?q?psCgNHeXes0GNuZeyDF8GR6jLu+ONnkp+mROcmV+Ky4/TptsiW7czpJURGa43kuuQ?= =?utf-8?q?Bs14is2JnpMEduanozJKhSvkuPxCCsi8p6ttLQpFdm65YqgsUcqN3+A7MAHmWBnW7?= =?utf-8?q?2d1dkzxn7+dUi0LZgCR0vPKYsCNOuNa3jF/H4qvA19MNJ6ww8APF24+NDwyDuNxNj?= =?utf-8?q?Y9bHCq9ENl6PUKtk+MmHUSPI+7rE+GbGDxkNAiW/jpeHBSvZgA5XVFxRpiRQX4qPe?= =?utf-8?q?1Mc1HyvKqJ2OdTXGk+N21W6uEqn3WkIpzBDwN84C74DMe7luH+njmQkf5QgAoXaYH?= =?utf-8?q?VP3fz0z2IoVH16oRBJh7rzTgj+fiOC45V0gCMcieWlifGUYYjTt0OefbDrH/7c2Fu?= =?utf-8?q?iQ8CQTfibq7zomD5+RpDvShKlBVBcWFvvWz8DPIi5dhM3J9D10AUDyrUgQsmRmuET?= =?utf-8?q?5vfAOedxvIAHEUI1flo7lTluHhRtOXdq4/uH1KKFruct5q7Of1N6iaczQ+Odv7kRa?= =?utf-8?q?CZ9JWlVcsBQOCBxECJDwU3SOuJSf7qsGLonqyPDPzNqdmBdGhlVQMt9Yi2rUg765e?= =?utf-8?q?t6t9+gkMbfAXNYl8cXdPLgl2K+4J9uVFr/Fo6VbT1Qfmo4PmTFZaX3W0DS4jRPZuk?= =?utf-8?q?86taIbI+Ar37ssdpOgfjMFIYQ2GA4/eBLt0dQbgzg5IabgocYgTKhgUzwd0lqgd/m?= =?utf-8?q?Kfv1POS+hOqnP8HyWd5TqDhcl/QFGA4/JPQn3T5SeSuOaz4r1L7Hq5mDNsMLYfaLW?= =?utf-8?q?SCgY3+6UaTf4FrBlH3bt6FDmk3kLoKbpiKn4lsEBn8J9bCN1saNjmY6aCimlbKT5n?= =?utf-8?q?IIW6gtVwjdSbpvHl?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 40e72639-163a-4d6f-0344-08dc55f452f8 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2024 04:45:03.6902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0P193MB0770 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This is about random test failures like those: XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: attach (EPERM) XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: attach (EPERM) XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: attach (EPERM) XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: attach (EPERM) XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: attach (EPERM) The reason for this effect is apparently as follows: There is a race condition when gdb tries to attach a thread but the thread exits at the same time. Normally when that happens the return code of ptrace(PTRACE_ATTACH, x) is EPERM, which could also have other reasons. To detect the true reason, we try to open /proc//status which normally fails in that situation, but it may happen that the fopen succeeds, and the thread disappears while reading the content, then the read has the errno=ESRCH, use that as an indication that the thread has exited between fopen and reading of the status file. --- gdb/nat/linux-procfs.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) v2: from kernel code review, it seems the missing "State:" can only happen if the thread disappeared, so no need to look at errno at all here. diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c index e2086952ce6..8d46d5bf289 100644 --- a/gdb/nat/linux-procfs.c +++ b/gdb/nat/linux-procfs.c @@ -157,17 +157,12 @@ linux_proc_pid_is_gone (pid_t pid) enum proc_state state; have_state = linux_proc_pid_get_state (pid, 0, &state); - if (have_state < 0) + if (have_state <= 0) { - /* If we can't open the status file, assume the thread has - disappeared. */ + /* If we can't open the status file or there is no "State:" line, + assume the thread has disappeared. */ return 1; } - else if (have_state == 0) - { - /* No "State:" line, assume thread is alive. */ - return 0; - } else return (state == PROC_STATE_ZOMBIE || state == PROC_STATE_DEAD); }