From patchwork Wed Mar 27 14:30:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87700 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C1CA385E030 for ; Wed, 27 Mar 2024 14:31:09 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1851B3858C98 for ; Wed, 27 Mar 2024 14:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1851B3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1851B3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549842; cv=none; b=jHRJNZPkMDs4cR388pht5iin1jDpGUnU77sx3oZBoldhGzxJ40Nth1+1UXR2Yp0Xsi/rimKN4kxgKO6V2IwugAzrz8byUdJulQpYg+eF5IfznpyjI6P8kztZUYyyUgyIa3C5Q9aATrtB/SN6DHPSR75c4dJvy8NCzdbiMLVE7cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549842; c=relaxed/simple; bh=U5nubrGvYR3u2tyDexyYslpow1OF3hsX+OMbqSb5RTw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=WvkdjVvp7fep4/untQ+1jmxpFtmqCaKgNGvqmk4siKk8qVfAOyXSJx6Zfjz2rfZQg0TDIYf57wcYGkqWhB0GQOTdS83gQQd+JeIctlZbP+qOcy6D57v1eotskkB2OQwLA7aZAx0xuQzmhvc3J75J4QxVfbYMeKf4id2tQUSFsjc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 190E738B16 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DQtZMqqyCyoJYA8KmF4fOv8yq9T2cCI8hsHhggH/sSs=; b=vyMKUPxidgcahm1PK5+B6gNFnVqWENQXcXiUptNpki+MnfeXi6D+Wn7kM4lFLh/3i4wyls UY4muIK87xUraVTinw9w3ZD5/WA2HspPKMrOc/4mHu7jx7WBB0gTB8+vQQK8L7dVFlMPWj xjfB7TxiMtk22+WHY0ZOCDX6JXo9gZ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DQtZMqqyCyoJYA8KmF4fOv8yq9T2cCI8hsHhggH/sSs=; b=Ow6KpfWNtVSGyPXu1yyxFAtA73GPFTlIuyL5gGtr2TVN2WZdYB3KilVa0Fk9ooY82HASbM cpC95g6/oK6ywUDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DQtZMqqyCyoJYA8KmF4fOv8yq9T2cCI8hsHhggH/sSs=; b=vyMKUPxidgcahm1PK5+B6gNFnVqWENQXcXiUptNpki+MnfeXi6D+Wn7kM4lFLh/3i4wyls UY4muIK87xUraVTinw9w3ZD5/WA2HspPKMrOc/4mHu7jx7WBB0gTB8+vQQK8L7dVFlMPWj xjfB7TxiMtk22+WHY0ZOCDX6JXo9gZ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DQtZMqqyCyoJYA8KmF4fOv8yq9T2cCI8hsHhggH/sSs=; b=Ow6KpfWNtVSGyPXu1yyxFAtA73GPFTlIuyL5gGtr2TVN2WZdYB3KilVa0Fk9ooY82HASbM cpC95g6/oK6ywUDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id ECC3D13AB3 for ; Wed, 27 Mar 2024 14:30:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id il1mOI4tBGa/WAAAn2gu4w (envelope-from ) for ; Wed, 27 Mar 2024 14:30:38 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/3] [gdb/tetsuite] Add missing include in gdb.base/ctf-ptype.c Date: Wed, 27 Mar 2024 15:30:36 +0100 Message-Id: <20240327143038.20021-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.87 X-Spamd-Result: default: False [0.87 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; BROKEN_CONTENT_TYPE(1.50)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.83)[99.26%] X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On fedora rawhide, when running test-case gdb.base/ctf-ptype.exp, I get: ... gdb compile failed, ctf-ptype.c: In function 'main': ctf-ptype.c:242:29: error: implicit declaration of function 'malloc' \ [-Wimplicit-function-declaration] 242 | v_char_pointer = (char *) malloc (1); | ^~~~~~ ctf-ptype.c:1:1: note: include '' or provide a declaration of 'malloc' +++ |+#include 1 | /* This test program is part of GDB, the GNU debugger. ... Fix this by adding the missing include. Tested on aarch64-linux. --- gdb/testsuite/gdb.base/ctf-ptype.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) base-commit: 18d2988e5da8919514c76b83e2c0b56e439018bd diff --git a/gdb/testsuite/gdb.base/ctf-ptype.c b/gdb/testsuite/gdb.base/ctf-ptype.c index 4d2df33c53c..ca347893349 100644 --- a/gdb/testsuite/gdb.base/ctf-ptype.c +++ b/gdb/testsuite/gdb.base/ctf-ptype.c @@ -24,6 +24,8 @@ * First the basic C types. */ +#include + #if !defined (__STDC__) && !defined (_AIX) #define signed /**/ #endif @@ -234,9 +236,6 @@ func_type v_func_type; int main () { - /* Ensure that malloc is a pointer type; avoid use of "void" and any include files. */ -/* extern char *malloc();*/ - /* Some of the tests in ptype.exp require invoking malloc, so make sure it is linked in to this program. */ v_char_pointer = (char *) malloc (1); From patchwork Wed Mar 27 14:30:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87702 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71EDB3858286 for ; Wed, 27 Mar 2024 14:31:34 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 48E433858C31 for ; Wed, 27 Mar 2024 14:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48E433858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48E433858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; cv=none; b=ivmmEJNnoFVK++FJPxYql9g+bQwQxv6rD8NnOR93n0jR9vFOZLbMGkw06SCDFrv20ebst7OH51kge0EAMs2HJJhMwht3AgON5+UvbzNfhqz5Vm0rZzJTR7tHC8s52z5hWg+ZwX4VqyEoP4ogEvSbjFS709IME6Xe8JQQpXA3tmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; c=relaxed/simple; bh=Au0s/ykTKuX4PmjLNS8/NGCq1h6/SzekeewfaBZLyCc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=pk4THBF2QCfkXojkNu/UirD30SfK8hO2cR/9fedUhb0TTQtQ8donHclmWEfKqoHPdZnahP6ujtKNzbn4mtJkYueG9NSt6nP90j5BLm/iMmdbjPJUU9uX8CCHyz2I56AWp7HzODWlqVGq6cDQuwkXGGNy4CegV47IY+srnmUD0O4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A4E160567 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdKEMTubInwXNtmp7OMOr+GNnRWpVV6qQX05cA+aOiM=; b=XjATj+ArBGtiWukYeOKGzr/tPbaJOZan412mAByV9e+gWLU1bvaKvIUctvDBJbPhTqtmzi uC/7nrGsposmg/4u+wDLbGgZnO2NRC6PnPX7KqTqkCm8Q5873QaVvmOat1S+7TkLobOOO9 8IYk6zUrGTwBbf3PDUdy/D8iDs5ZjzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdKEMTubInwXNtmp7OMOr+GNnRWpVV6qQX05cA+aOiM=; b=4vs5Sgv86LREZGsjcd1Gbf+CG7+Ic/qWDyQn2f5KmWLg2z0W5sYm5LJgM6S51WSCazmT3+ xDB1hH2yCn3HC1CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdKEMTubInwXNtmp7OMOr+GNnRWpVV6qQX05cA+aOiM=; b=Y7JdHOc8JFeE4q2W6TXUW1LxgZmfMAQi3B3f63sQJs4NNUX5weWV9yXw3KeyGMfLhUm7X6 0dgnV/OGX7B22hcqiGrBjMRarbxOC95mfZadf2RpR/ft7gN6RYnihg4ThumDgtAIw6jhRA AqSv5H1KpGhYoPgfS1orCs5kO3Hwz/c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IdKEMTubInwXNtmp7OMOr+GNnRWpVV6qQX05cA+aOiM=; b=nKVLdCXd9FgW5ltG0ctn4HFcxCAw/jAYDeelNJQqrp0YJ6aBKhoOL9IuHEFtDqK9B/FR7D MqB6qm6/0C+Zp8DA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 144F413AC5 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id qB2gA48tBGa/WAAAn2gu4w (envelope-from ) for ; Wed, 27 Mar 2024 14:30:39 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/3] [gdb/testsuite] Fix missing return type in gdb.linespec/break-asm-file.c Date: Wed, 27 Mar 2024 15:30:37 +0100 Message-Id: <20240327143038.20021-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240327143038.20021-1-tdevries@suse.de> References: <20240327143038.20021-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Score: 1.97 X-Spamd-Bar: + Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Y7JdHOc8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nKVLdCXd X-Spamd-Result: default: False [1.97 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.52)[80.33%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:98:from] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 2A4E160567 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On fedora rawhide, when running test-case gdb.linespec/break-asm-file.exp, I get: ... gdb compile failed, break-asm-file.c:21:8: error: \ return type defaults to 'int' [-Wimplicit-int] 21 | static func() | ^~~~ ... Fix this by adding the missing return type. Tested on aarch64-linux. --- gdb/testsuite/gdb.linespec/break-asm-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.linespec/break-asm-file.c b/gdb/testsuite/gdb.linespec/break-asm-file.c index 5ba964de1a3..7aff7cc70ed 100644 --- a/gdb/testsuite/gdb.linespec/break-asm-file.c +++ b/gdb/testsuite/gdb.linespec/break-asm-file.c @@ -18,7 +18,7 @@ void func3(); void func2(); -static func() +static void func() { } From patchwork Wed Mar 27 14:30:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87701 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A83BC3858407 for ; Wed, 27 Mar 2024 14:31:11 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 3FB623858C55 for ; Wed, 27 Mar 2024 14:30:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FB623858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FB623858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; cv=none; b=D2fFzYCRsVwWyhXNGnYk7muCgzSbS4zNo5vLipesNC26LvmxjampcugZVUtCri7F337bWIBMX/3Sg+/+vwHRmsMQlI+Bv/s+CfGyOuQljULSZEiJKCJ6ya2zFzXQWEQDcTznuEfBsxilH1g2kwiOhQe1NTE74//DTpFJkQk5WKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711549843; c=relaxed/simple; bh=uA9GW6RECjw4b2E5ZOCcbHH4MiJKDMrlad6IKe5mdCk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=DwUeW44FJqZrvc7HX7PX7M3GiaF9Bxgvpph/6MGoepGBN7EyiIcdc4Z+prapcHOQrDEjJouOVJoZfvAWLizSxLYYah4JLs9CbIxFaRSKJzfx3jT3KPjrLFxmj3CktZ91KQg4qNX7SGkeCWl+PHYaQZTUv//H9h4oII4ijvGa6nE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 472EF38B19 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=Ba/cm+Au7dkpQPPk2XoLqi8di+ucGsUm6RZ5jRisJB0SwL0I20WGkpBbIPYcR9BTWX/ucy ZEQGhIBdNp9FF9eIMiN7oH+6/fIaA2/K7274YNWRINOHavpkwpKR/fxjFTc6K5mKolME2q fRZeNM+ngMaHKgd72N4zZE7A833nujE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=DPPmc27rZmaRCBAOs0h86i7c13Sra0P8bzZq6qdtl8wcRKFrEJyUuujL1fppHr/gNJNqum x+cuSkuiUsBj37DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=cBWjrZNZZwXvG3JdzlBnISzAeWTa0Xe9psgDddSL8/n4YdcZ6f6fYgBJVWRjBk5mpszWZJ rCtsAY3e83cOOAd/xmd0fmgDG8h1/tShDX2HIwY7cUhsn7ZSalNqSKYN/d5BdqH+YHroSn 6+3+gQU5kf/IUWN4YzpikOUMO9uce90= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711549839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1j+NsdiyHx0uHkSoJ2LjKPTfDicj1Jka+ZZQdyZCtuc=; b=9A04Mt0y72/5VNerjleovwvy9H3xJ/k39JArIsztNWDaY7LeYFhSWq/uMyleXGaswqrysJ 75Em5c4p4GCANxCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 30A5D13B04 for ; Wed, 27 Mar 2024 14:30:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id YDSJCo8tBGa/WAAAn2gu4w (envelope-from ) for ; Wed, 27 Mar 2024 14:30:39 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 3/3] [gdb/testsuite] Add missing includes in gdb.trace/collection.c Date: Wed, 27 Mar 2024 15:30:38 +0100 Message-Id: <20240327143038.20021-3-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240327143038.20021-1-tdevries@suse.de> References: <20240327143038.20021-1-tdevries@suse.de> MIME-Version: 1.0 X-Spam-Level: X-Spamd-Bar: / Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cBWjrZNZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9A04Mt0y X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [0.83 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.66)[92.85%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: 0.83 X-Rspamd-Queue-Id: 472EF38B19 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On fedora rawhide, with test-case gdb.trace/collection.exp, I get: ... gdb compile failed, collection.c: In function 'strings_test_func': collection.c:227:13: error: implicit declaration of function 'malloc' \ [-Wimplicit-function-declaration] 227 | longloc = malloc(500); | ^~~~~~ collection.c:1:1: note: \ include '' or provide a declaration of 'malloc' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:228:3: error: implicit declaration of function 'strcpy' \ [-Wimplicit-function-declaration] 228 | strcpy(longloc, ... ); | ^~~~~~ collection.c:1:1: note: include '' or provide a declaration of \ 'strcpy' +++ |+#include 1 | /* This testcase is part of GDB, the GNU debugger. collection.c:230:8: error: implicit declaration of function 'strlen' \ [-Wimplicit-function-declaration] 230 | i += strlen (locstr); | ^~~~~~ collection.c:230:8: note: include '' or provide a declaration of \ 'strlen' ... Fix this by adding the missing includes. Tested on aarch64-linux. --- gdb/testsuite/gdb.trace/collection.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.trace/collection.c b/gdb/testsuite/gdb.trace/collection.c index efcc2e389da..8379b7d7eaf 100644 --- a/gdb/testsuite/gdb.trace/collection.c +++ b/gdb/testsuite/gdb.trace/collection.c @@ -19,6 +19,9 @@ * Test program for trace collection */ +#include +#include + /* * Typedefs */