From patchwork Fri Mar 22 17:01:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans X-Patchwork-Id: 87530 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D99623858C32 for ; Fri, 22 Mar 2024 17:04:59 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by sourceware.org (Postfix) with ESMTPS id DF4A43858D28 for ; Fri, 22 Mar 2024 17:04:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF4A43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF4A43858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::643 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711127080; cv=none; b=H+USbq5hKqEvLUQiRXguvoOEL3TXBG1s4ySJyc0+nzHc/lHscPqFmTbVf8GwrFWXRp24B9Shx17YD0cJQ1fO1THQzyePNVflz4z5rDJ1PzuAPNTrCDcqLlQDlYJx+SpNSt9SZJgj46M8+COAxlKLg5SJ2Zeq8B4wHWwLXICoq9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711127080; c=relaxed/simple; bh=CmTKAt4YTxu9vLBvEj0Rg76Kt2nYgL1dE+hPCPHmtJ8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=abF/EZFP+jAw1zCwlbiWb0B6hwsaFcZM7W2Gns+E5Z2RF/C0Tb63mUCem0jXP+7e7mVcJ5zHHuoyBDrcT4Bka3iMUVuq/jjWPJOE2ks73WFnKeJjtqwdNME4/5UA6CTXcBusjieXnLnFfkBetE7M5slDHlRzcv8XHOuU+l5czVE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-a473865ee3aso63622366b.2 for ; Fri, 22 Mar 2024 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711127068; x=1711731868; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WaOnQf6zKghEoeioLk38fTyyLjQHQUjN2KvmF4RyfI4=; b=VK1sLY1oGAw3no5qfYlXmV4+puuK3DhfUiWVTJNHKI42/EupfqVykm7LDTFTJpOoE5 CsjqXynn0RYP5JvUTOk897RJxK4HtPuW8eQtljeKa7lmCLYHVPhy1X8r3E8837csThb6 4pRszKFymo/FaYVBRfb4xYewhD+QPphPTORueIxQmC4dox2sskZUt4RqTVGwP5klcvvk rSf3ABshsHfFWzuzt7oirXZmniIV5dshma5PFuT6GCRU3Ajac5xTSM9wRs0k8R9D0z44 9njitvtYZXfha0aMFuJkxFKj039AlkgCcP/CzeEdUS0fwZJyOQdzPysEDbqZdg3EtFah X5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711127068; x=1711731868; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WaOnQf6zKghEoeioLk38fTyyLjQHQUjN2KvmF4RyfI4=; b=XxC1RJx+M48nPsiLj5OuXKAaRelEusbmAuA+c9Dmr5NT+HE+TBbOmYGbUD3Vx60eeu 1OEHgz5P6q3IhTQnGTXyP1OnTCOVoLVat0+KfVVDuMq9TDuhQRRTugBa1yLsUD0oVGli lnsNg0PEH0RkEaOu2H0UYtSKKtSB7T+zRe0VzlnsgR5Ut1UI8+odprONNvDTwNvERrZG idXtKBmvpS9H+iA09GiNL8dCPVKcD/xP7dAj9/FbZKWa8yIREkpuCbj0phAXVa2SiSlp W+jOKUmHV3VXu6YpLYQIjyE3ao6cd3X8wd0WdgXjs3cWpUUjcCLPNwQA2C4hQP5pUpYs MHNA== X-Gm-Message-State: AOJu0Yz6YUuiAvXMG/c0vU7jEWXsBBpDtOaVCzhGxS1A6lv86/sR5nPq qLypoXpuf+PEhs9TjhoJKJFDG2bhh0hBh9oeLoTc+3joOr+L4nHppLS9JCp9oHo= X-Google-Smtp-Source: AGHT+IHeA3uoJhKNrDqGKQwFtI29RNkLurSTWQn23DI5b0u5XB9Cb7r/zgBtxFU2S04MdQRAq9/M2Q== X-Received: by 2002:a17:906:350e:b0:a47:28a4:361b with SMTP id r14-20020a170906350e00b00a4728a4361bmr227759eja.61.1711127068398; Fri, 22 Mar 2024 10:04:28 -0700 (PDT) Received: from be-Latitude-E6510.home ([2a01:8b82:54fe:b800::4bb]) by smtp.gmail.com with ESMTPSA id gu3-20020a170906f28300b00a44ef54b6b6sm21531ejb.58.2024.03.22.10.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 10:04:28 -0700 (PDT) From: Hans To: gdb-patches@sourceware.org Cc: Hans , Tom Tromey Subject: [PATCH] gdb internal fatal error while opening a binary built with gsplit-dwarf Date: Fri, 22 Mar 2024 18:01:22 +0100 Message-Id: <20240322170122.20010-1-sungdgdhtryrt@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Binaries built with '-gsplit-dwarf' and clang-16 using dwp with dwarf version 5 will crash with a segmentation fault as a result of a missing section read call in read_dwo_str_index(). Without the split dwarf option everything works fine. The error occurs from commit 65067f1c2c842f001017638c4fe53613d6656263 until latest, previous commits work without problems. Steps to reproduce are in the bug description. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31497 Reviewed-by: Tom Tromey --- gdb/dwarf2/read.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 7442094874c..a45bc512724 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -17501,6 +17501,9 @@ read_dwo_str_index (const struct die_reader_specs *reader, ULONGEST str_index) ULONGEST str_offsets_base; if (reader->cu->header.version >= 5) { + struct objfile *objfile = reader->cu->per_objfile->objfile; + reader->dwo_file->sections.str_offsets.read (objfile); + /* We have a DWARF5 CU with a reference to a .debug_str_offsets section, so assume the .debug_str_offsets section is DWARF5 as well, and parse the header. FIXME: Parse the header only once. */