From patchwork Thu Mar 21 07:22:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Orgad Shaneh X-Patchwork-Id: 87435 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 182E93858C35 for ; Thu, 21 Mar 2024 07:24:24 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id D006B3858D1E for ; Thu, 21 Mar 2024 07:24:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D006B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D006B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711005843; cv=none; b=LpGjKHV9eLzVs+OQv2B75O03pE3XnzMsO78E0m15cgwfs9lJq2Yx6ghwG6oOx+kUKLcymY4O9TUd3J+KPRRzb6WfLS3oba6XyfX3dcVDGv7t6RFArRZPtmisxzX4w44yfnHa892FGK+eUwEPNziOI6d4XMxpggjq736LrLVPbHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711005843; c=relaxed/simple; bh=Lw0h7K+QsfjK1Ou3JgaW295TxA7+mmAsQseDvCddx4w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=r8DciK7pSkmNDQndH2pUIOyAyl1ejVvwM5/8qEC5eNFeTSDVFYPL0Jv98+2mQrQ53kOFZKt3IvPj+O6tNVmXcZbK3WKzMV7FeyOP4opFLUlCdzYxeWdG4/L4AX9fLpHlMeWIkiFnwbU0c8+MFJ/m8xYvlI+Bq+MbFtd8IUI7Bj8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4146f3d4145so4446165e9.3 for ; Thu, 21 Mar 2024 00:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711005840; x=1711610640; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRf+PP92yB8HoxHfrmtGJTTyqYH+bnBpLRhAmGv38P8=; b=TqLokglrpWXXnFsMEFI3nBLi+VT79uTWXoh6PLmqVq3GIgNiU1kV3Ukhl9f8IgmgNr yw3v4twg75aZlhbq1AFm6FePaDuDDTDr9gLMgNCmc2mm1UxcC2pE3Zzb97CTcMTEYLj9 nXzVrxpzqkR9jXcIQEP6XpX8mkAldr/3dX1r6uMTt5Cv4csZTXyeRMJuC0on5MTnXRva fEIxMTWYbVicH2jYFo0EKUDJf4U9dVfvkXrrKbAMARIXn0+XwdoTETrbeMPyglORMaCN xCmPmILeG8/PIOQOzoVsj76cvi9M11RPPQE7oo+NkLG2VLQHaV3gI+2nBLB5glMyAzey p6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711005840; x=1711610640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRf+PP92yB8HoxHfrmtGJTTyqYH+bnBpLRhAmGv38P8=; b=sqDWcSnrTZXHcIjqmB2aNQmCje5G4ebeUvQSPCUTX1Cr3oDNVeVMOOT+Q2tB2wG+EO yYJ3uaiOdH4Xz0tzym9Dg0up5C+ov9enDkmLjXHBzNthKSeLPvp4QgLJ4/gM6SymFGQv V6fHWvMowz04gRbD6Gyzcx09gxT9BKSgBDJGRb0fUe0K7AKVdGmiX1Ax6aUt9HaPMHAi 3BCtrlr9gkb62ix4+Yu5QFcLgqAAyC/LCp2xNT7fWvDRhwuGkw+bQTadh5QnEIol2gey CKehZfqJa64DDqz/j3QvNEt1eK8paEXI5sperda2Q5dhxjKg4eARDIu8FAiLIpQvBgxC Z9aw== X-Gm-Message-State: AOJu0YzizEHhlhGQKru1kFpJu2cPFZulk3LmOeLX/UNY7fuixuADsr6G E/3T8QYPyB4WrNbl1b169Z1BICCtbs0GARpzcOGcBJZatn0toita8JcCk+Q+RIQ= X-Google-Smtp-Source: AGHT+IGzOd12rS5/QmkBtx6485LVw8PhmevnVGqxh4p9WPXLbqBVVrlfZ0Ennu37WRsCXT6px9Inwg== X-Received: by 2002:a05:600c:3645:b0:413:f2c6:df3d with SMTP id y5-20020a05600c364500b00413f2c6df3dmr838497wmq.13.1711005839587; Thu, 21 Mar 2024 00:23:59 -0700 (PDT) Received: from DESKTOP-FJHNB5R.corp.audiocodes.com ([95.86.127.241]) by smtp.gmail.com with ESMTPSA id ay19-20020a5d6f13000000b0033e2291fbc0sm16785262wrb.68.2024.03.21.00.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 00:23:59 -0700 (PDT) From: Orgad Shaneh To: gdb-patches@sourceware.org Cc: Jon Turney Subject: [PATCH] Better handling for realpath() failures in windows_make_so() on Cygwin Date: Thu, 21 Mar 2024 09:22:53 +0200 Message-ID: <20240321072349.1160-1-orgads@gmail.com> X-Mailer: git-send-email 2.44.0.windows.1 In-Reply-To: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> References: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> MIME-Version: 1.0 X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: Jon Turney Fix a memory leak which would occur in the case when the result of realpath() is greater than or equal to SO_NAME_MAX_PATH_SIZE. Distinguish between realpath() failing (returning NULL), and returning a path longer than SO_NAME_MAX_PATH_SIZE Warn rather than stopping with an error in those cases. Original patch from Tim Chick. Memory leak fix by Corinna Vinschen. --- gdb/windows-nat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index a90388922e2..29bfad5b060 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -886,13 +886,14 @@ windows_make_so (const char *name, LPVOID load_addr) if (rname && strlen (rname) < SO_NAME_MAX_PATH_SIZE) { so->name = rname; - free (rname); } else { warning (_("dll path for \"%s\" too long or inaccessible"), name); so->name = so->original_name; } + if (rname) + free (rname); } /* Record cygwin1.dll .text start/end. */ size_t len = sizeof ("/cygwin1.dll") - 1;