From patchwork Thu Mar 21 06:53:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Orgad Shaneh X-Patchwork-Id: 87434 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 186063858403 for ; Thu, 21 Mar 2024 06:54:48 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 7B4EF3858D28 for ; Thu, 21 Mar 2024 06:54:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B4EF3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B4EF3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711004070; cv=none; b=Fbt+tz8Q2ZU5aOpamAxMOhRCB5hY2nNyTzsB/rQKztgr47VqruBlyxZ+o8GVJYdOromqtdUfEFYc1eFfwAcnyqC+u+ZzZX+Sfnc+e6HOm1KPfJQn0UNhgfzF9JBF8vca9BTahuChMNTT8OtnPoCx7rTeyJ2z2jD+HpsgPHSdeSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711004070; c=relaxed/simple; bh=fnnfml8joDLtn8f0e1c3tPeNpzMGxLRPfY1M/ihxMdw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=d6R/RucqrVAooOD1oeWFKLMhGFOOzGQ4YEflOFjT32lEXdD6xA3piHxp2bldAezRbZutBaIP6PWpPqiSqizD05Bf6eA9wRnmvR/xsrSsaU+PrHqyaxWuYVQPSsQ9A10jwksFwlbPXWj+egcmy1dywtdbVqtedkCAmyMWBLvd9KQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-33eee0258abso188122f8f.3 for ; Wed, 20 Mar 2024 23:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711004066; x=1711608866; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YXOEa9nznjUKhNZ0gd41GaiPuELWo70/xabr5mHzyYs=; b=ipz7SE/4YfjCL6zdsznNxUF3eIQ/u4nmxmeshm0BkRbCQT5d1Ax7dfWzb/rXpOg2IW LSglZiEYVgqCYPM5JLRjAuoNVZruE5KX2Ktcv7SIHgKYlhaIVedy0KIUB34gXko0Gti6 XG+NtmH6ImrlZdLeKaQnUNSQ1PNM1a6gvKUc8gXZC8e29uqEnEpz9jF2hZhYpTi3n10i utB9iVm4RTqKYXVTDAV8jbim86eL2C+qTBg2AJCXwhiMjzHFyTb1fIWLljCIfjic8Z4w FuN49OqG7YkpzxgLAfTA87ozzS8w5wFgtZJCofnVCkmWJlgfVbeZZl2J25/nJUJfr5wT 4O6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711004066; x=1711608866; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YXOEa9nznjUKhNZ0gd41GaiPuELWo70/xabr5mHzyYs=; b=jYYPCPevoafED0Y6piTzDrMbSFlsf401163HDIVFZkhlQbScWwuR1beZB0yyEaxL2H ybf1bpIUYjooJp6tvGFxl5RqNHgZ8RqxWDJxU0nAHx/lEJhmurreDqjwNw8GyA8twlff kVw0RyRGXuGHBDJLROg44zl26kH6mMeXq4gG6mkHP8mktQ3Fjy2BJBM5bo3TQid9XP3k TXnanxX+vLp5lkjYAkkh/LM5C6vFw6UxAK/a8BkzXIh9ho2YEf7S03tPDT0svA4Rkdob VyWcqlDxyanvNbBcy7pSSBJfFvxY4Dc1z9PAlupNRZJCoY2vKd5vBVikrtOyGh7yYnwl 6XTQ== X-Gm-Message-State: AOJu0Yy05Fg9oC7ixbxSIOanb4YPLuKG2aWP3pV+X87RkSuYs0zIVRWx 5ZgA7Kf8hB4qdpOoUVrshVBzgpDg6iIKSfcbg7qOFpzWGmzMBq0TaDzJ03yZQEY= X-Google-Smtp-Source: AGHT+IGbUFI+Zi4OmPmmHnOYkAgtLC2fFOHWvsoo3O6JarN8itL1LEk7IbtU4Gyy2X7ujsqrZApA1w== X-Received: by 2002:a5d:64ab:0:b0:33e:781e:da57 with SMTP id m11-20020a5d64ab000000b0033e781eda57mr3209503wrp.53.1711004066347; Wed, 20 Mar 2024 23:54:26 -0700 (PDT) Received: from DESKTOP-FJHNB5R.corp.audiocodes.com ([95.86.127.241]) by smtp.gmail.com with ESMTPSA id s15-20020adfeccf000000b0033e9e26a2d0sm16383504wro.37.2024.03.20.23.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 23:54:25 -0700 (PDT) From: Orgad Shaneh X-Google-Original-From: Orgad Shaneh To: gdb-patches@sourceware.org Cc: Jon Turney Subject: [PATCH] Better handling for realpath() failures in windows_make_so() on Cygwin Date: Thu, 21 Mar 2024 08:53:45 +0200 Message-ID: <20240321065417.1125-1-orgad.shaneh@audiocodes.com> X-Mailer: git-send-email 2.44.0.windows.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: Jon Turney Fix a memory leak which would occur in the case when the result of realpath() is greater than or equal to SO_NAME_MAX_PATH_SIZE. Distinguish between realpath() failing (returning NULL), and returning a path longer than SO_NAME_MAX_PATH_SIZE Warn rather than stopping with an error in those cases. Original patch from Tim Chick. Memory leak fix by Corinna Vinschen. --- gdb/windows-nat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index a90388922e2..7dc2bb2a115 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -892,6 +892,10 @@ windows_make_so (const char *name, LPVOID load_addr) { warning (_("dll path for \"%s\" too long or inaccessible"), name); so->name = so->original_name; + if (rname) + { + free (rname); + } } } /* Record cygwin1.dll .text start/end. */