From patchwork Tue Jan 23 21:11:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 84632 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C5F03857725 for ; Tue, 23 Jan 2024 21:12:48 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 08E083858420 for ; Tue, 23 Jan 2024 21:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08E083858420 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aurel32.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08E083858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:bc8:30d7:100::1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706044346; cv=none; b=BEs5MRL4TToPqgM5Dnbl498nfwNUIdyMiH6Mx37ki4c0vcX8e8pomoHthfEo5+iZF2kQ3SnTG9TPWgaUVXCDtwlHtVT9Q+TLQK9e3pG/CZ7mHMRtlNpFGP2o082+AhNWcRykEmXdayM9qPI/NQ0CyGcCKyiRhKNv8131JcW3lCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706044346; c=relaxed/simple; bh=TmELBGgkntHorDjFfMA0cYZkrRZmnaXxzLJLXAM8mNE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sfOEShcxUIz6ERTW3zV6t0AExCHGzjyU4/mRr6tdRTVCAeP3isJZdopiYQk4rOAb+w4Y4u1nt2kgsm1/DRE92QnTs1orYJ8rvYqWBvQUwdBFeWaIcEqOkAheedYNV+lIaQsV5mwERddneddqt4pAmo/w9L4Bn566dlLcaq7KZRM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Content-Type:From:Reply-To:Subject:Content-ID: Content-Description:In-Reply-To:References:X-Debbugs-Cc; bh=XK5yv4INQ/diMeQysA7DMK/THoVj2OLw5i+rGi8Lb6s=; b=TyQQ7MW7wK8rcwFTzPorL4wdUE HPzDohoWxwgof7hmZyC7rNcPkI21b47rEmhwucGCCjO7wB7liLd1/QSGnwMASS3r1CLETpO1t3Hg5 kttC1U85G59UqKGbVaWG4DW0XODToGhLbIlUiCeknz18Yrt6b3wmflTzAC/dJQfe/678L3XgJYo8m BOEsaM5B26oyIkul6xkKXAI374O7dvj65F4/tVHqXonCJKtdwGPlbYUFpEHAgEtxrwzpnZ71RS0yg WwjLVyWOdRQLV2Pp6j+U907xIP9sGRxfQPrPTbb4q0XhLL6kLfcFGqgdY4THl6WiE0+zLC1poNhex EEMw+eBQ==; Received: from ohm.aurel32.net ([2001:bc8:30d7:111::2] helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rSO4D-00EkOc-3A; Tue, 23 Jan 2024 22:12:22 +0100 From: Aurelien Jarno To: libc-alpha@sourceware.org Cc: Aurelien Jarno Subject: [PATCH] tst-epoll: increase waiting time before sending signal to the child Date: Tue, 23 Jan 2024 22:11:28 +0100 Message-ID: <20240123211130.190553-1-aurelien@aurel32.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org When running the testsuite in parallel, for instance running make -j $(nproc) check, from time to time tst-epoll fails with a timeout. It happens because it sometimes takes a bit more than 10ms for the process to get cloned and blocked by the syscall. In that case the signal is sent to early, and the test fails with a timeout. This happens even on fast hosts. This patch increases the waiting time to 100ms to make it more reliable. It corresponds to 20% of the epoll wait time, so there is still some margin on that side. --- sysdeps/unix/sysv/linux/tst-epoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/tst-epoll.c b/sysdeps/unix/sysv/linux/tst-epoll.c index 3b38beae6e..39953c0a08 100644 --- a/sysdeps/unix/sysv/linux/tst-epoll.c +++ b/sysdeps/unix/sysv/linux/tst-epoll.c @@ -98,7 +98,7 @@ test_epoll_basic (epoll_wait_check_t epoll_wait_check) xclose (fds[1][1]); /* Wait some time so child is blocked on the syscall. */ - nanosleep (&(struct timespec) {0, 10000000}, NULL); + nanosleep (&(struct timespec) {0, 100000000}, NULL); TEST_COMPARE (kill (p, SIGUSR1), 0); int e = epoll_wait_check (efd, &event, 1, 500000000, &ss);