From patchwork Sun Dec 24 08:56:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 82814 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E3EFF3858415 for ; Sun, 24 Dec 2023 08:57:55 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E8E913858D3C for ; Sun, 24 Dec 2023 08:56:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8E913858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8E913858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703408184; cv=none; b=cX4e9q/Kc1TtXr6siJmk3hBTXhZBow9dCJr2QRhDgZ2pgKlmqqmLxjgNity0J1QKvyze5T3ez7Pr1+lXOx92Ea+j4PnjbQhEcMmsxgA+bOoq+nZ5Y+t91Z1OWahhdDyr9VmHburN80vVn6aTnyq35eAVXrXaJv+W6f+yG/r4eTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703408184; c=relaxed/simple; bh=i8JXWO5I5g66Q7YXzbmBiIZR2Rd4R3ZrR2twxXh7lwE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=W28dpM7GpyJPiEybIACzwzRueQ/o5zfX5bhwa+bG4RkpcKx0CaMPtZwhUdaYkt6csXs+9ovx+8bLq+60Lcvr+2wMXYzRdMWIC7x+hMmJhOaa0ghOItBUHSnlalF+WdfhteLoHT0EPdAmO0rREMSfMzl6y+5X6hQJ2KpedIA0ZJM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7698B33D0AF; Sun, 24 Dec 2023 08:56:18 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed] sim: sh: fix plds Dz,MACL implementation Date: Sun, 24 Dec 2023 03:56:14 -0500 Message-ID: <20231224085614.24321-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The plds Dz,MACL insn stores the Dz bit into MACL. The current code was storing the "res" variable into Dz and then into MACL, but not setting "res" to anything. Delete that logic and make it match the existing plds Dz,MACH insn. --- sim/sh/gencode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index 9683dc46b86a..8ef3f3e33761 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -2439,7 +2439,7 @@ static op ppi_tab[] = "if (0xa05f >> z & 1)", " RAISE_EXCEPTION (SIGILL);", "else", - " MACL = DSP_R (z) = res;", + " MACL = DSP_R (z);", "return;", }, /* sh4a */