From patchwork Mon Dec 11 17:05:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 81926 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 930A7384771A for ; Mon, 11 Dec 2023 17:06:43 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id C9EEF386188C for ; Mon, 11 Dec 2023 17:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9EEF386188C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9EEF386188C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702314352; cv=none; b=LlwJjLUkjQ1OjWbooPWmEaKTYdcTkkhuf7aH7NmlUadtM0RBsATluZpIkWL3ODKgD8xcoNXXkqas0O4bLWxhcvYIftSJrxMw2e7uQO/Ctbsv7NF0TDPqrEPsaP8gxMn6xszSpBZfzmBy81YHu+v4QAZ/XMR4igiBOoFDCY12/D4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702314352; c=relaxed/simple; bh=0EAM7kQjxrFfJ8F/bbZgoNI1hoyFvkRT8MqSFemGejI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fQ2r0PIQm4F/OX+TS6iYL5j1eFyY10onYuhVvVQYezANJosZxaz0dY2tbvadSs684jM9kgvwZ0wuLhpxfzhfUL6Lz8xbnOaz4AcCFJlhthj5W9zmUdjhaqVGCgUSLPWX8UjuwGXXUWBZoizgFrATHB43t4qY0eBO17LCp3JSiao= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7b6fc474d16so195206639f.1 for ; Mon, 11 Dec 2023 09:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702314350; x=1702919150; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fPvO7MUqTI8mi18C7KXZ+R3X8lhM+cel110fdllWE4o=; b=MPKBdkiqy9qxQ6bqeAlJ7myI1BlJtnzyhkyJ2Fr/pVXABfbkJp9JMgVZl5vMPg2LZv UjCpeQQzTLQwWuWR7aEUtKAce5bioOPS8W/1lHLZqy1U/Fpm9R5lQZAElZXQomiT2Ka1 MAQTofEQEGnvHZOClLzLJjSamtw4yj9xF2J3VW5CsFMFo7YM/JeeRSH9b8NlTVgzMbgX cn3WB3gb2oOpn1FLE5Obv0dDo2Q0G7xJ3CATkdL6n8EBo6zmsa3XxmvKTBra7pX6+C9c 4kQTWiRGkVkBbgPPKKMDPPI1fUHor2053Aj7NvlUx+Q/q2u/KWqtmrT8pzdpdICSEII9 n7ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702314350; x=1702919150; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fPvO7MUqTI8mi18C7KXZ+R3X8lhM+cel110fdllWE4o=; b=CEjqvJpzpGe0nnkFZ5zp9b5Hc2+Wmjikf4g91Ic/vKVvxz7OHxknFVX1PWCwKFKGYa Czihhrd2LIuHDqatUhCRTsDERZ4HQTokodqtXaICyditgzJuKLBGSX96L67mEsTT+dyT HrVipivHOXMaeP17ZfkxigJTDJvE10hfzkqg0NPrMeQCGVdXWow9VXvNo2Mg5J1X6Mvd 0ilLK19TcMwt7zmqnUzyM9iGe3CmqDol9FV3czV46BoxwAL+UP2Kirpvc+UyhTa6XTA4 0vPVKqkoQAPlhY0zH1UGF7DDX/9kdWuZA5q+ojkcgv5VmLJoyC2h48hVrdZEiaTOHRcE JeNA== X-Gm-Message-State: AOJu0YyevDTQzS+sPRJGx9ElFuJjha/8420G+qI6C8emjuFuzaDwrHRR i4OVnB7AlAb8bxKozNH4e/kCnGW7pIHZPFfnUCU= X-Google-Smtp-Source: AGHT+IF5EQLg7GN1+dszKGpTmWCMEw2v2zgb1ETmijGSYoojqOgA/fZjs9i6Pk0L5WFaQLtECmJRUQ== X-Received: by 2002:a6b:e90a:0:b0:7b7:ea1:61a5 with SMTP id u10-20020a6be90a000000b007b70ea161a5mr6116575iof.20.1702314350010; Mon, 11 Dec 2023 09:05:50 -0800 (PST) Received: from localhost.localdomain (71-211-161-25.hlrn.qwest.net. [71.211.161.25]) by smtp.gmail.com with ESMTPSA id t22-20020a02ab96000000b0046856360a07sm1990385jan.13.2023.12.11.09.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 09:05:49 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Fix build with clang 16 Date: Mon, 11 Dec 2023 10:05:39 -0700 Message-ID: <20231211170539.1154291-1-tromey@adacore.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org clang 16 reports a missing declaration in new-op.cc. We believed these operators to be declared starting with C++14, but apparently that is not the case. This patch reverts the earlier change and then updates the comment to reflect the current state. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31141 --- gdbsupport/new-op.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdbsupport/new-op.cc b/gdbsupport/new-op.cc index 181fc4957fa..12bd5d263a6 100644 --- a/gdbsupport/new-op.cc +++ b/gdbsupport/new-op.cc @@ -27,6 +27,11 @@ #include "host-defs.h" #include +/* These are declared in starting C++14, but removing them + caused a build failure with clang. See PR build/31141. */ +extern void operator delete (void *p, std::size_t) noexcept; +extern void operator delete[] (void *p, std::size_t) noexcept; + /* Override operator new / operator new[], in order to internal_error on allocation failure and thus query the user for abort/core dump/continue, just like xmalloc does. We don't do this from a