From patchwork Thu Dec 7 03:59:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81575 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AD523861835 for ; Thu, 7 Dec 2023 03:59:53 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 4447C38582BD for ; Thu, 7 Dec 2023 03:59:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4447C38582BD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4447C38582BD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921580; cv=none; b=mzVbVhn0FwFLQdZuMDcxmVSZiptV/p/u7ZANCei5k+n/6zi2VsgW2LVXzxQBRWbjcDjIux88KOgjOFo0IFSp5K9OZQxX45BIeBCd8pMBG/GbSUMB1TN9uMwTwozf7kZ0IseJqXRnUeT47pGU5UOxeIGmX1EwLses+R5c4DJzJ4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921580; c=relaxed/simple; bh=P58dGrvQMkO18DIZS+mKiJJcdYsuPV/Uih8n2eFhgfs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=awC0mxWJD88ap7b7BxuheYjZwV5hsZ/OoYVcZinziMbwTodOKuiBe2N5ea8fyZfvU57VhJBhIKqJiYwxo6Pd69bQqQToI+x6iaubvublv5YBQKW4UcqohkUzZnAc3wxKHHtUZw9BEpXOA8Rt+ruLO8hJQsr4vr8QytzKIHMZ7/s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id E3E09335D6E; Thu, 7 Dec 2023 03:59:38 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 01/17] sim: arm: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:21 -0700 Message-ID: <20231207035937.14920-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/arm/armos.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sim/arm/armos.c b/sim/arm/armos.c index 9cf238ac8e25..42d1dfb4ed1f 100644 --- a/sim/arm/armos.c +++ b/sim/arm/armos.c @@ -99,7 +99,6 @@ ARMul_OSInit (ARMul_State * state) #ifndef NOOS #ifndef VALIDATE ARMword instr, i, j; - struct OSblock *OSptr = (struct OSblock *) state->OSptr; if (state->OSptr == NULL) { @@ -111,7 +110,6 @@ ARMul_OSInit (ARMul_State * state) } } - OSptr = (struct OSblock *) state->OSptr; state->Reg[13] = ADDRSUPERSTACK; /* Set up a stack for the current mode... */ ARMul_SetReg (state, SVC32MODE, 13, ADDRSUPERSTACK);/* ...and for supervisor mode... */ ARMul_SetReg (state, ABORT32MODE, 13, ADDRSUPERSTACK);/* ...and for abort 32 mode... */ From patchwork Thu Dec 7 03:59:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81576 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66235385734E for ; Thu, 7 Dec 2023 03:59:57 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 8CAE63857C69 for ; Thu, 7 Dec 2023 03:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CAE63857C69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CAE63857C69 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921582; cv=none; b=I7VAs2dsjVIo3P9Rm/crUcgfVZtznBmU+QWgfKx5eCPVPWY5QNdIUPIhggnpYhNv9ALxH7L0od97yEt7mAuiZXrd0+1pGixWmT2wAjJTqXkTV7zi4mGB4m0q5uFV41YvAXRZ+qYq8+oZOd/6dRRbQ0TTydddO2emVMAuvCNkjiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921582; c=relaxed/simple; bh=BHgjb2biVdOLRusqyfGd56y8q9+yOmvRqLTvN5Q+rII=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=JX/8lszCf5E9LtnDHQqLv97O+b+ajTnxYfSbpw9SkzGWZYrcHQDFUcnX5ShsH27wwO0WKUzb6bJXLovf06tEqTrBG/FxJhqvVRFOylvApvKfe5un3050FQVMTaUrLckejF4OtwedI9oU9L7UWD8aT42iVfaF1/wX94huxPmcWZM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id ED2FF335D6E; Thu, 7 Dec 2023 03:59:40 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 02/17] sim: bfin: gui: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:22 -0700 Message-ID: <20231207035937.14920-2-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Rework the code to use static inline functions when it's disabled rather than macros so the compiler knows the various function args are always used. The ifdef macros are a bit ugly, but get the job done without duplicating the function prototypes. --- sim/bfin/gui.h | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/sim/bfin/gui.h b/sim/bfin/gui.h index ef363b599861..daf4398694b4 100644 --- a/sim/bfin/gui.h +++ b/sim/bfin/gui.h @@ -21,7 +21,14 @@ #ifndef BFIN_GUI_H #define BFIN_GUI_H +/* These macros are ugly. */ #ifdef HAVE_SDL +# define _BFIN_GUI_INLINE +# define _BFIN_GUI_STUB(...) ; +#else +# define _BFIN_GUI_INLINE ATTRIBUTE_UNUSED static inline +# define _BFIN_GUI_STUB(val) { return val; } +#endif enum gui_color { GUI_COLOR_RGB_565, @@ -30,21 +37,24 @@ enum gui_color { GUI_COLOR_BGR_888, GUI_COLOR_RGBA_8888, }; -enum gui_color bfin_gui_color (const char *color); -int bfin_gui_color_depth (enum gui_color color); - -void *bfin_gui_setup (void *state, int enabled, int height, int width, - enum gui_color color); +_BFIN_GUI_INLINE +enum gui_color bfin_gui_color (const char *color) + _BFIN_GUI_STUB(GUI_COLOR_RGB_565) -unsigned bfin_gui_update (void *state, const void *source, unsigned nr_bytes); +_BFIN_GUI_INLINE +int bfin_gui_color_depth (enum gui_color color) + _BFIN_GUI_STUB(0) -#else +_BFIN_GUI_INLINE +void *bfin_gui_setup (void *state, int enabled, int height, int width, + enum gui_color color) + _BFIN_GUI_STUB(NULL) -# define bfin_gui_color(...) 0 -# define bfin_gui_color_depth(...) 0 -# define bfin_gui_setup(...) NULL -# define bfin_gui_update(...) 0 +_BFIN_GUI_INLINE +unsigned bfin_gui_update (void *state, const void *source, unsigned nr_bytes) + _BFIN_GUI_STUB(0) -#endif +#undef _BFIN_GUI_INLINE +#undef _BFIN_GUI_STUB #endif From patchwork Thu Dec 7 03:59:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81577 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADE08386181B for ; Thu, 7 Dec 2023 03:59:59 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 7CB7B385C6EC for ; Thu, 7 Dec 2023 03:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CB7B385C6EC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CB7B385C6EC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921585; cv=none; b=phl5VZuK6INR/Zlqv6tMYKD/pZt/RzeLrcfvIQB34Hcs1wRQtz74tnT1hzVl1fbXzNmJKlEOdcvW4dhCY3bBObI85i1x6OJoH5rr0YtUvk0PfpxZHiT1cvug+AqZj9OAyBMhkMubFFgqqCdp59TIhunJghvl4HUcYcZu1tqZyM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921585; c=relaxed/simple; bh=GB6h2PSj64rlNl2xpeQtJDb2fTTvc1T1fQs1lui8xuE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tXXv7j9tQ8K26dhtfZrCKaX40fqgUENtYEePrbjeNZhg4rZxiek6092NBPreXh4GuC6oDasxB2wkDO/DOL78dSaLHhk2s3aH1rBa+CJabM0Ju+c5NWEb8igeZZ6ZMEszZdduqjhS5nwZGR2ay+necEBRh1ko+kRulaDNN2sIvdc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 06BFC335D6E; Thu, 7 Dec 2023 03:59:43 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 03/17] sim: bfin: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:23 -0700 Message-ID: <20231207035937.14920-3-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/bfin/bfin-sim.c | 3 ++- sim/bfin/dv-bfin_emac.c | 3 --- sim/bfin/dv-bfin_mmu.c | 4 +--- sim/bfin/dv-bfin_pll.c | 2 -- sim/bfin/dv-bfin_rtc.c | 2 -- sim/bfin/dv-bfin_sic.c | 8 -------- 6 files changed, 3 insertions(+), 19 deletions(-) diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c index a9b8fd09220f..12c7827f9ec4 100644 --- a/sim/bfin/bfin-sim.c +++ b/sim/bfin/bfin-sim.c @@ -1592,7 +1592,8 @@ decode_macfunc (SIM_CPU *cpu, int which, int op, int h0, int h1, int src0, if (op != 3) { - bu8 sgn0 = (acc >> 31) & 1; + /* TODO: Figure out how the 32-bit sign is used. */ + ATTRIBUTE_UNUSED bu8 sgn0 = (acc >> 31) & 1; bu8 sgn40 = (acc >> 39) & 1; bu40 nosat_acc; diff --git a/sim/bfin/dv-bfin_emac.c b/sim/bfin/dv-bfin_emac.c index 0288b7404999..1ab7cd63554d 100644 --- a/sim/bfin/dv-bfin_emac.c +++ b/sim/bfin/dv-bfin_emac.c @@ -539,11 +539,8 @@ bfin_emac_tap_init (struct hw *me) { #if WITH_TUN struct bfin_emac *emac = hw_data (me); - const hw_unit *unit; int flags; - unit = hw_unit_address (me); - emac->tap = open ("/dev/net/tun", O_RDWR); if (emac->tap == -1) { diff --git a/sim/bfin/dv-bfin_mmu.c b/sim/bfin/dv-bfin_mmu.c index 71c7176b88bf..c14e2088c1f1 100644 --- a/sim/bfin/dv-bfin_mmu.c +++ b/sim/bfin/dv-bfin_mmu.c @@ -451,7 +451,7 @@ _mmu_check_addr (SIM_CPU *cpu, bu32 addr, bool write, bool inst, int size) { SIM_DESC sd = CPU_STATE (cpu); struct bfin_mmu *mmu; - bu32 *fault_status, *fault_addr, *mem_control, *cplb_addr, *cplb_data; + bu32 *mem_control, *cplb_addr, *cplb_data; bu32 faults; bool supv, do_excp, dag1; int i, hits; @@ -469,8 +469,6 @@ _mmu_check_addr (SIM_CPU *cpu, bu32 addr, bool write, bool inst, int size) } mmu = MMU_STATE (cpu); - fault_status = inst ? &mmu->icplb_fault_status : &mmu->dcplb_fault_status; - fault_addr = inst ? &mmu->icplb_fault_addr : &mmu->dcplb_fault_addr; mem_control = inst ? &mmu->imem_control : &mmu->dmem_control; cplb_addr = inst ? &mmu->icplb_addr[0] : &mmu->dcplb_addr[0]; cplb_data = inst ? &mmu->icplb_data[0] : &mmu->dcplb_data[0]; diff --git a/sim/bfin/dv-bfin_pll.c b/sim/bfin/dv-bfin_pll.c index dd95013f2f49..863b07f49ec3 100644 --- a/sim/bfin/dv-bfin_pll.c +++ b/sim/bfin/dv-bfin_pll.c @@ -56,7 +56,6 @@ bfin_pll_io_write_buffer (struct hw *me, const void *source, bu32 mmr_off; bu32 value; bu16 *value16p; - bu32 *value32p; void *valuep; /* Invalid access mode is higher priority than missing register. */ @@ -71,7 +70,6 @@ bfin_pll_io_write_buffer (struct hw *me, const void *source, mmr_off = addr - pll->base; valuep = (void *)((uintptr_t)pll + mmr_base() + mmr_off); value16p = valuep; - value32p = valuep; HW_TRACE_WRITE (); diff --git a/sim/bfin/dv-bfin_rtc.c b/sim/bfin/dv-bfin_rtc.c index b6ae0a537712..fdb63f3a4f9a 100644 --- a/sim/bfin/dv-bfin_rtc.c +++ b/sim/bfin/dv-bfin_rtc.c @@ -59,7 +59,6 @@ bfin_rtc_io_write_buffer (struct hw *me, const void *source, bu32 mmr_off; bu32 value; bu16 *value16p; - bu32 *value32p; void *valuep; /* Invalid access mode is higher priority than missing register. */ @@ -74,7 +73,6 @@ bfin_rtc_io_write_buffer (struct hw *me, const void *source, mmr_off = addr - rtc->base; valuep = (void *)((uintptr_t)rtc + mmr_base() + mmr_off); value16p = valuep; - value32p = valuep; HW_TRACE_WRITE (); diff --git a/sim/bfin/dv-bfin_sic.c b/sim/bfin/dv-bfin_sic.c index 5210cf0a8eeb..ac302a7f8519 100644 --- a/sim/bfin/dv-bfin_sic.c +++ b/sim/bfin/dv-bfin_sic.c @@ -147,7 +147,6 @@ bfin_sic_52x_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -162,7 +161,6 @@ bfin_sic_52x_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -261,7 +259,6 @@ bfin_sic_537_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -276,7 +273,6 @@ bfin_sic_537_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -375,7 +371,6 @@ bfin_sic_54x_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -390,7 +385,6 @@ bfin_sic_54x_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -482,7 +476,6 @@ bfin_sic_561_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -497,7 +490,6 @@ bfin_sic_561_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); From patchwork Thu Dec 7 03:59:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81578 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCF76386185C for ; Thu, 7 Dec 2023 04:00:08 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 865E1385277E for ; Thu, 7 Dec 2023 03:59:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 865E1385277E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 865E1385277E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921587; cv=none; b=EVdOaqk8uhiiQAarzh9rh42lqfJSSXH0lhQ6C7IOIpaLyLlaxtkvRU6pzRYKRNaHTkX5WZ8SKyc5mpyfmkD1Ew5IXpTli/GfL1ldsYG41yla9pf76yQvITFimFA1hzz7HZt2uLYb2C1eh/Mp7T4byL1VbQ7Ids05m9kgZA2dTzA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921587; c=relaxed/simple; bh=A4qVXAUrZEmnaQxqJ56lTXtAHvgCRDiaGL0xJK/O16w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nQgwtwVjoeZi9OkdPvPZf2qjhG3F4HRs0ZmVJxWjve/McFUpFwdKPuQZNbr0NQMmAX2wAbOmW3Xy4CFYl+Y4FQrATqqUdW3N4emqyUfcfzzAf63LyV53NrzSLoZ/jpFS+K6V6nCH1Z4rY/32cgHUYgRg370mhcE7SdIJRExGXJg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 16E2A335D76; Thu, 7 Dec 2023 03:59:45 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 04/17] sim: cris: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:24 -0700 Message-ID: <20231207035937.14920-4-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org We suppress the warning in the generated switch file because the cris cpu file has a hack to workaround a cgen bug, but that generates a set but unused variable which makes the compiler upset. --- sim/Makefile.in | 2 ++ sim/cris/local.mk | 4 ++++ sim/cris/sim-if.c | 7 +++---- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sim/cris/local.mk b/sim/cris/local.mk index 12fa86b410d2..66ebc99376c4 100644 --- a/sim/cris/local.mk +++ b/sim/cris/local.mk @@ -16,6 +16,10 @@ ## You should have received a copy of the GNU General Public License ## along with this program. If not, see . +## Some CGEN kludges are causing build-time warnings. See cris.cpu for details. +AM_CFLAGS_%C%_mloopv10f.o = -Wno-unused-but-set-variable +AM_CFLAGS_%C%_mloopv32f.o = -Wno-unused-but-set-variable + nodist_%C%_libsim_a_SOURCES = \ %D%/modules.c %C%_libsim_a_SOURCES = \ diff --git a/sim/cris/sim-if.c b/sim/cris/sim-if.c index cad71693ede9..12baafbf323d 100644 --- a/sim/cris/sim-if.c +++ b/sim/cris/sim-if.c @@ -337,7 +337,6 @@ cris_set_section_offset_iterator (bfd *abfd, asection *s, void *vp) static void cris_offset_sections (SIM_DESC sd, int offset) { - bfd_boolean ret; struct bfd *abfd = STATE_PROG_BFD (sd); asection *text; struct offsetinfo oi; @@ -350,7 +349,7 @@ cris_offset_sections (SIM_DESC sd, int offset) oi.offset = offset; bfd_map_over_sections (abfd, cris_set_section_offset_iterator, &oi); - ret = bfd_set_start_address (abfd, bfd_get_start_address (abfd) + offset); + bfd_set_start_address (abfd, bfd_get_start_address (abfd) + offset); STATE_START_ADDR (sd) = bfd_get_start_address (abfd); } @@ -516,7 +515,7 @@ cris_handle_interpreter (SIM_DESC sd, struct bfd *abfd) for (i = 0; i < n_hdrs; i++) { int interplen; - bfd_size_type interpsiz, interp_filesiz; + bfd_size_type interpsiz; struct progbounds interp_bounds; if (phdr[i].p_type != PT_INTERP) @@ -563,7 +562,7 @@ cris_handle_interpreter (SIM_DESC sd, struct bfd *abfd) perhaps should. */ interp_load_addr = 0x40000; interpsiz = interp_bounds.endmem - interp_bounds.startmem; - interp_filesiz = interp_bounds.end_loadmem - interp_bounds.startmem; + /* interp_filesiz = interp_bounds.end_loadmem - interp_bounds.startmem; */ /* If we have a non-DSO or interpreter starting at the wrong address, bail. */ From patchwork Thu Dec 7 03:59:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81583 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FBFC386D600 for ; Thu, 7 Dec 2023 04:00:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 83C6A386181B for ; Thu, 7 Dec 2023 03:59:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83C6A386181B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83C6A386181B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921588; cv=none; b=ZSh8xxUQRGADRGaK9E9swm1M7SFaOGCcSrJdzOSOWhPTOUChz8kPqG+kN7PgEtiZudvfdHo3P2TAfmx1M7Pd5XaYDF6ApFFQHD1ToEGeBvJjfI1Wx//h0bZe3Ef7En6X0bj5YXNPH/XbZEMvwZIp/JmT9Tt0h+4VM45RKuSgigY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921588; c=relaxed/simple; bh=uju+gloT67Go56s0Ulfn5gHxn3CaCtT1I6fGqTg8DM0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Zu07hQsbTt/QZawFfwzKsYI0AqjojAMZ2hxDodKNv7Yk7TWUp9q3ICnPvsIjCjh6XS4EFPInGzNZR8XK33R46ToWdUt4Iz9ktzeVbDYCFyA+Nu7yGY0sHk5kHkDWaCxMcZtLgx+SiSaE7gKP6iOGIIwab1NZo/vwxQ61lepDKlI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 24964335D6E; Thu, 7 Dec 2023 03:59:47 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 05/17] sim: d10v: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:25 -0700 Message-ID: <20231207035937.14920-5-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/d10v/interp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/d10v/interp.c b/sim/d10v/interp.c index 46d7bf274cca..d6a946185241 100644 --- a/sim/d10v/interp.c +++ b/sim/d10v/interp.c @@ -88,13 +88,13 @@ lookup_hash (SIM_DESC sd, SIM_CPU *cpu, uint32_t ins, int size) INLINE static void get_operands (struct simops *s, uint32_t ins) { - int i, shift, bits, flags; + int i, shift, bits; uint32_t mask; for (i=0; i < s->numops; i++) { shift = s->operands[3*i]; bits = s->operands[3*i+1]; - flags = s->operands[3*i+2]; + /* flags = s->operands[3*i+2]; */ mask = 0x7FFFFFFF >> (31 - bits); OP[i] = (ins >> shift) & mask; } From patchwork Thu Dec 7 03:59:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81579 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0C93385DC22 for ; Thu, 7 Dec 2023 04:00:09 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id C7608385276B for ; Thu, 7 Dec 2023 03:59:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7608385276B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7608385276B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921591; cv=none; b=I9DmETVVoVfSUz8gtK0gVgK/tFEIT0fgB0Rq7GtLJ95l0Lesi29H2drc6v+73xAUsRRumGvIvhaPM8byCloZ7MHlaGQRHPPBEE495OjRo61RI0qxjhIgq2jU6CxiMEWpr2LV4yoUcp7+dSpd6xXErNd//c717qQio0sdQzoF928= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921591; c=relaxed/simple; bh=HcWqHzXW255rKkcjEXvLXw8PxOqpbx5wvgkjOeFXQUc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=r+dWLJpGt0U9opyP7LHUihUSrl5/bWjxz/A4CFApp8j//dnPpF16TBrjuOj+bnWA+XpDGdolIsU1InjPCyUNyG6AdpGYLBSFXMMSMPwv1LLn4VjsPRtG5Gat4jz+XM4GxbmKOYN0Vl97q88MA3qxWCwYdA7ZPFmOntoTrpV8cP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 31358335D6E; Thu, 7 Dec 2023 03:59:49 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 06/17] sim: erc32: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:26 -0700 Message-ID: <20231207035937.14920-6-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/erc32/erc32.c | 8 ++------ sim/erc32/func.c | 11 ++--------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c index ec72ae070a4b..32c45bddb680 100644 --- a/sim/erc32/erc32.c +++ b/sim/erc32/erc32.c @@ -1042,10 +1042,6 @@ port_init(void) static uint32_t read_uart(uint32_t addr) { - - unsigned tmp; - - tmp = 0; switch (addr & 0xff) { case 0xE0: /* UART 1 */ @@ -1071,7 +1067,7 @@ read_uart(uint32_t addr) } #else - tmp = uarta_data; + unsigned tmp = uarta_data; uarta_data &= ~UART_DR; uart_stat_reg &= ~UARTA_DR; return tmp; @@ -1103,7 +1099,7 @@ read_uart(uint32_t addr) } #else - tmp = uartb_data; + unsigned tmp = uartb_data; uartb_data &= ~UART_DR; uart_stat_reg &= ~UARTB_DR; return tmp; diff --git a/sim/erc32/func.c b/sim/erc32/func.c index 85f71817dfdb..f1b230a8f918 100644 --- a/sim/erc32/func.c +++ b/sim/erc32/func.c @@ -687,11 +687,8 @@ int_handler(int32_t sig) void init_signals(void) { - typedef void (*PFI) (); - static PFI int_tab[2]; - - int_tab[0] = signal(SIGTERM, int_handler); - int_tab[1] = signal(SIGINT, int_handler); + signal(SIGTERM, int_handler); + signal(SIGINT, int_handler); } @@ -706,7 +703,6 @@ disp_fpu(struct pstate *sregs) { int i; - float t; printf("\n fsr: %08X\n\n", sregs->fsr); @@ -716,7 +712,6 @@ disp_fpu(struct pstate *sregs) #endif for (i = 0; i < 32; i++) { - t = sregs->fs[i]; printf(" f%02d %08x %14e ", i, sregs->fsi[i], sregs->fs[i]); if (!(i & 1)) printf("%14e\n", sregs->fd[i >> 1]); @@ -1006,7 +1001,6 @@ bfd_load (const char *fname) { asection *section; bfd *pbfd; - const bfd_arch_info_type *arch; int i; pbfd = bfd_openr(fname, 0); @@ -1020,7 +1014,6 @@ bfd_load (const char *fname) return -1; } - arch = bfd_get_arch_info (pbfd); if (sis_verbose) printf("loading %s:", fname); for (section = pbfd->sections; section; section = section->next) { From patchwork Thu Dec 7 03:59:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81580 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8872384DEDC for ; Thu, 7 Dec 2023 04:00:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id B4D8A386183F for ; Thu, 7 Dec 2023 03:59:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4D8A386183F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4D8A386183F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921593; cv=none; b=v/WZhCytLFAzDfzXarUF9IaZTVgCJwfbPBUBfPN6g2B940FUG7WmSyVkn6B0VIj+8wX8w3BM6ennPlJ54ijxY9LuQT1kpr9u5TvXYBOZpFJ7kfCAtipbMC37k7EhqnKcmPM7xO1W1eyIPM2DG1o/17/l9NtFeaeG9ZN7IlVmm/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921593; c=relaxed/simple; bh=PuQcOM9pPPjrwqI22K67aPABES83fojyo5tDE4KvziA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=DQS0w+AWZXTbXQJJH5dESR85aSsa0cd7+egEUU+K13K6qxZR3a/OJuUekAjuccEE9BTdklUZJCu5fWKPfAZVxoZrqNWqNJRUaX6RbyhazYuuOM5IlLemrJIrI6xHi/LfBgXhZZAp1DYcdyh9JBHZ994Yd6xT6w7i8ju8WtJdKyk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 51AF2335D76; Thu, 7 Dec 2023 03:59:51 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 07/17] sim: frv: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:27 -0700 Message-ID: <20231207035937.14920-7-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/frv/cache.c | 2 -- sim/frv/profile-fr400.c | 11 ----------- sim/frv/profile-fr500.c | 2 -- 3 files changed, 15 deletions(-) diff --git a/sim/frv/cache.c b/sim/frv/cache.c index 76f762fe5ee7..b4f33f1252d5 100644 --- a/sim/frv/cache.c +++ b/sim/frv/cache.c @@ -362,7 +362,6 @@ read_data_from_memory (SIM_CPU *current_cpu, SI address, char *buffer, static void fill_line_from_memory (FRV_CACHE *cache, FRV_CACHE_TAG *tag, SI address) { - PCADDR pc; int line_alignment; SI read_address; SIM_CPU *current_cpu = cache->cpu; @@ -382,7 +381,6 @@ fill_line_from_memory (FRV_CACHE *cache, FRV_CACHE_TAG *tag, SI address) tag->line = cache->data_storage + (line_index * cache->line_size); } - pc = CPU_PC_GET (current_cpu); line_alignment = cache->line_size - 1; read_address = address & ~line_alignment; read_data_from_memory (current_cpu, read_address, tag->line, diff --git a/sim/frv/profile-fr400.c b/sim/frv/profile-fr400.c index 58ad8c86c4b1..31e25178a4d4 100644 --- a/sim/frv/profile-fr400.c +++ b/sim/frv/profile-fr400.c @@ -632,7 +632,6 @@ frvbf_model_fr400_u_media_1 (SIM_CPU *cpu, const IDESC *idesc, { int cycles; FRV_PROFILE_STATE *ps; - const CGEN_INSN *insn; int busy_adjustment[] = {0, 0}; int *fr; @@ -643,7 +642,6 @@ frvbf_model_fr400_u_media_1 (SIM_CPU *cpu, const IDESC *idesc, cycles = idesc->timing->units[unit_num].done; ps = CPU_PROFILE_STATE (cpu); - insn = idesc->idata; /* The latency of the registers may be less than previously recorded, depending on how they were used previously. @@ -1673,9 +1671,7 @@ frvbf_model_fr400_u_media_4 (SIM_CPU *cpu, const IDESC *idesc, { int cycles; FRV_PROFILE_STATE *ps; - const CGEN_INSN *insn; int busy_adjustment[] = {0}; - int *fr; if (model_insn == FRV_INSN_MODEL_PASS_1) return 0; @@ -1684,7 +1680,6 @@ frvbf_model_fr400_u_media_4 (SIM_CPU *cpu, const IDESC *idesc, cycles = idesc->timing->units[unit_num].done; ps = CPU_PROFILE_STATE (cpu); - insn = idesc->idata; /* The latency of the registers may be less than previously recorded, depending on how they were used previously. @@ -1709,7 +1704,6 @@ frvbf_model_fr400_u_media_4 (SIM_CPU *cpu, const IDESC *idesc, post_wait_for_FR (cpu, out_FRk); /* Restore the busy cycles of the registers we used. */ - fr = ps->fr_busy; /* The latency of the output register will be at least the latency of the other inputs. Once initiated, post-processing will take 1 cycle. */ @@ -1751,7 +1745,6 @@ frvbf_model_fr400_u_media_4_acc_dual (SIM_CPU *cpu, const IDESC *idesc, { int cycles; FRV_PROFILE_STATE *ps; - const CGEN_INSN *insn; INT ACC40Si_1; INT FRk_1; @@ -1765,8 +1758,6 @@ frvbf_model_fr400_u_media_4_acc_dual (SIM_CPU *cpu, const IDESC *idesc, ACC40Si_1 = DUAL_REG (in_ACC40Si); FRk_1 = DUAL_REG (out_FRk); - insn = idesc->idata; - /* The post processing must wait if there is a dependency on a FR which is not ready yet. */ ps->post_wait = cycles; @@ -1802,7 +1793,6 @@ frvbf_model_fr400_u_media_6 (SIM_CPU *cpu, const IDESC *idesc, { int cycles; FRV_PROFILE_STATE *ps; - const CGEN_INSN *insn; int busy_adjustment[] = {0}; int *fr; @@ -1813,7 +1803,6 @@ frvbf_model_fr400_u_media_6 (SIM_CPU *cpu, const IDESC *idesc, cycles = idesc->timing->units[unit_num].done; ps = CPU_PROFILE_STATE (cpu); - insn = idesc->idata; /* The latency of the registers may be less than previously recorded, depending on how they were used previously. diff --git a/sim/frv/profile-fr500.c b/sim/frv/profile-fr500.c index 9d268ce7bcec..0593aefd0dfb 100644 --- a/sim/frv/profile-fr500.c +++ b/sim/frv/profile-fr500.c @@ -2043,7 +2043,6 @@ frvbf_model_fr500_u_media (SIM_CPU *cpu, const IDESC *idesc, { int cycles; FRV_PROFILE_STATE *ps; - const CGEN_INSN *insn; int is_media_s1; int is_media_s2; int busy_adjustment[] = {0, 0, 0}; @@ -2057,7 +2056,6 @@ frvbf_model_fr500_u_media (SIM_CPU *cpu, const IDESC *idesc, cycles = idesc->timing->units[unit_num].done; ps = CPU_PROFILE_STATE (cpu); - insn = idesc->idata; /* If the previous use of the registers was a media op, then their latency will be less than previously recorded. From patchwork Thu Dec 7 03:59:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81582 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F38438449F2 for ; Thu, 7 Dec 2023 04:00:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id B42B93861838 for ; Thu, 7 Dec 2023 03:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B42B93861838 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B42B93861838 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921594; cv=none; b=KGHCU/VDmfpZlJzIWBvt7IWtEobOpZ3wPkRgjxF+Vkq480Dk7U1MRAfiStvOM/Ssc/pjl6nKa7gXO6zUOmkmL1UqG2Slz5vJIG1sT3w0STlRMnel3jmTlbDnrEuAJPokE83ct6C2GR26Tw1SQtiffzjSPORRtDlWmm7XW8hvxFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921594; c=relaxed/simple; bh=R8MR1ws405T0S0uq+YcoqkBDKrccaIf47OSk+DfzF7s=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=dmC2HM+AIJeXt7ETOgl0L+kbXmhrSfi//5zGsKmx93CNbjExYqbNzqvzk7YVZRF7jjVR/scIlYlt5zXzaKSz4wi6qg03P7FTeV03mlMUGzEJJAIzrIlo2oj8pPs4RNPTjwd44nCYt2Y9y/+ZtNL4Xp8nXqQh+ndQduvbg7Cu23A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 61A4D335D7B; Thu, 7 Dec 2023 03:59:53 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 08/17] sim: ft32: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:28 -0700 Message-ID: <20231207035937.14920-8-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/ft32/interp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sim/ft32/interp.c b/sim/ft32/interp.c index e8f990d78b74..146c88a3bcd5 100644 --- a/sim/ft32/interp.c +++ b/sim/ft32/interp.c @@ -702,12 +702,8 @@ sim_engine_run (SIM_DESC sd, int nr_cpus, /* ignore */ int siggnal) /* ignore */ { - sim_cpu *cpu; - SIM_ASSERT (STATE_MAGIC (sd) == SIM_MAGIC_NUMBER); - cpu = STATE_CPU (sd, 0); - while (1) { step_once (sd); From patchwork Thu Dec 7 03:59:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81586 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A40C386181B for ; Thu, 7 Dec 2023 04:00:41 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D3CDF3861012 for ; Thu, 7 Dec 2023 03:59:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3CDF3861012 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D3CDF3861012 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921597; cv=none; b=hJQvdKX+I1cbxUbkFjcs4IOiVfN/0j1AX/vBF6FDBpZtpYZwxgiIzVx3SwFJcPsgzKMPvmVt+1g7qdUSxuu+7142Lrbd76rTj6nVSbu2N+xywBTRa4+PNWgLl4N46NRN+X2ZsGj/bjQwtoFGgUgSK6nzu0EdHp9SIrMtgn1ctBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921597; c=relaxed/simple; bh=CryiPT8nXVno5KtFrvrYFkZoc2wKIY/hLxylCDELy+0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=xTzHVu6dhqLrRjrr3yzMae+jg/LfWjohNarwZDtN4mC3FJLgz9jddUHIAC39QtAFqkUsGfPRkUh9qcdDf7irX4m6KnGO1Wq3a2vRRy9dntSRXqBLo0y1icq9ZkLg4vzMy+Ah3LBq++qpce99FeErODkL1U6tvXnPCaAxvVdBEyI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 71482335D7B; Thu, 7 Dec 2023 03:59:55 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 09/17] sim: h8300: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:29 -0700 Message-ID: <20231207035937.14920-9-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/h8300/compile.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c index a4b39ae3380c..96254ea916d5 100644 --- a/sim/h8300/compile.c +++ b/sim/h8300/compile.c @@ -2792,7 +2792,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) struct stat stat_rec; /* Stat record */ int fstat_return; /* Return value from callback to stat. */ int stat_ptr; /* Pointer to stat record. */ - char *temp_stat_ptr; /* Temporary stat_rec pointer. */ fd = (h8300hmode && !h8300_normal_mode) ? GET_L_REG (0) : GET_W_REG (0); @@ -2803,9 +2802,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) fstat_return = sim_callback->to_fstat (sim_callback, fd, &stat_rec); - /* Have stat_ptr point to starting of stat_rec. */ - temp_stat_ptr = (char *) (&stat_rec); - /* Setting up the stat structure returned. */ SET_MEMORY_W (stat_ptr, stat_rec.st_dev); stat_ptr += 2; @@ -2843,7 +2839,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) struct stat stat_rec; /* Stat record */ int stat_return; /* Return value from callback to stat */ int stat_ptr; /* Pointer to stat record. */ - char *temp_stat_ptr; /* Temporary stat_rec pointer. */ int i = 0; /* Loop Counter */ /* Setting filename_ptr to first argument of open. */ @@ -2877,9 +2872,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) stat_return = sim_callback->to_stat (sim_callback, filename, &stat_rec); - /* Have stat_ptr point to starting of stat_rec. */ - temp_stat_ptr = (char *) (&stat_rec); - /* Freeing memory used for filename. */ free (filename); From patchwork Thu Dec 7 03:59:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81588 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 718F5383E720 for ; Thu, 7 Dec 2023 04:00:43 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id E1AE1385C6FE for ; Thu, 7 Dec 2023 03:59:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1AE1385C6FE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1AE1385C6FE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921599; cv=none; b=UGHltJa1AeHID27sP6wHtXX0tJfULB1f+I8jbtzagZGulaXi6ib5ePdZpxc/PsGW3ItuQk0/UxTeqc8IDC7smpf2w3LNi0JwcM4G4+nzQYPrpIwM3CSn32tL4154+LFWJFIbu0PZ2x6wF3szbDzr2CFCs2cLpmeV9Pf7QC612r8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921599; c=relaxed/simple; bh=Q9RZbIKisVwngTwES6Ervys76UI22FrLk/OFm2dJHHU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=cdY+SEuu8x5UQaKS2vaXKkvbvxdRUnb0q3MwUc6LHp54B5kz1J1foSdSie+JirKofyOzpFseSOSp7ujdsrpaN1t+DvEujto46sFlFZvWRUm+SLm8wYHj1lq40B0vBi5FuS1gribXWiLN2Bu3GooPSQJTor7MyGJ9E17i3aXYt90= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7C46F33BDC5; Thu, 7 Dec 2023 03:59:57 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 10/17] sim: m68hc11: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:30 -0700 Message-ID: <20231207035937.14920-10-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/m68hc11/dv-m68hc11.c | 2 -- sim/m68hc11/dv-m68hc11spi.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/sim/m68hc11/dv-m68hc11.c b/sim/m68hc11/dv-m68hc11.c index 7d7931b4bb2a..ef18f0999360 100644 --- a/sim/m68hc11/dv-m68hc11.c +++ b/sim/m68hc11/dv-m68hc11.c @@ -589,13 +589,11 @@ m68hc11_info (struct hw *me) uint16_t base = 0; sim_cpu *cpu; struct m68hc11_sim_cpu *m68hc11_cpu; - struct m68hc11sio *controller; uint8_t val; sd = hw_system (me); cpu = STATE_CPU (sd, 0); m68hc11_cpu = M68HC11_SIM_CPU (cpu); - controller = hw_data (me); base = cpu_get_io_base (cpu); sim_io_printf (sd, "M68HC11:\n"); diff --git a/sim/m68hc11/dv-m68hc11spi.c b/sim/m68hc11/dv-m68hc11spi.c index 845db2ffa793..e552fd5de9a8 100644 --- a/sim/m68hc11/dv-m68hc11spi.c +++ b/sim/m68hc11/dv-m68hc11spi.c @@ -157,14 +157,10 @@ m68hc11spi_port_event (struct hw *me, int source_port, int level) { - SIM_DESC sd; struct m68hc11spi *controller; - sim_cpu *cpu; uint8_t val; controller = hw_data (me); - sd = hw_system (me); - cpu = STATE_CPU (sd, 0); switch (my_port) { case RESET_PORT: From patchwork Thu Dec 7 03:59:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81581 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 138FB384577B for ; Thu, 7 Dec 2023 04:00:25 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id D62EA3861887 for ; Thu, 7 Dec 2023 03:59:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D62EA3861887 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D62EA3861887 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921601; cv=none; b=Qh85LICL47HGh6XMiztTd3BWmAEOnVfS5zspYLuzV67J+NcaB0U4h1wThbzeHoaMs7M8Yjgo+t5qraC279K5TKuEDORromTnJyI2kj8dWVcw6MFp6ehTLAaXJZ5N4XzoV0ojHfhkXCtlz0+CxDS7rzizgUdjtL/BXa4lyHx3waY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921601; c=relaxed/simple; bh=EPx95SbFlP4SKRdBjQ6MDy7mstVLvGnkPpj7jn4xuG4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=dPe2p/yZvp7OEpWHOHatZSNmAI7BSN3+fGpchIT/xRyLTyHc22Uo2GNyebE/84uyh8TCITOczcVDkbeuwZbBqCfyOOI0CYYJvQYoCcgUjZ0yuDR8ZSEU7gQvhLurREzM5V1RW+1mBIE4x7B4L1XsBZYVEGjrV+emfLYkO5lSwJs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 8816733BDC5; Thu, 7 Dec 2023 03:59:59 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 11/17] sim: mcore: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:31 -0700 Message-ID: <20231207035937.14920-11-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/mcore/interp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c index 7561c440729d..8bfb745a11f2 100644 --- a/sim/mcore/interp.c +++ b/sim/mcore/interp.c @@ -332,8 +332,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) /* TODO: Unindent this block. */ { - int32_t oldpc; - insts ++; if (pc & 02) @@ -408,8 +406,6 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) if (tracing) fprintf (stderr, "%.4x: inst = %.4x ", pc, inst); - oldpc = pc; - pc += 2; switch (inst >> 8) From patchwork Thu Dec 7 03:59:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81585 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA0A63845BDF for ; Thu, 7 Dec 2023 04:00:39 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id F03E33861878 for ; Thu, 7 Dec 2023 04:00:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F03E33861878 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F03E33861878 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921603; cv=none; b=e+A0jWki4Odyt2cAmybe0A2h16W1rXziMvhYDxmx8ws7Jx6y4nDTGM9h5YNzQnAXk8fFlcW5xA+X1D9wsWB+XwuxGJ1Ob4JMnKae9btJIY4NVO8JZXQNpLdI5Qd9goSSPN3CJytit3iwzUPyZfPAArE09MCIKXWyb+z9zSo06bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921603; c=relaxed/simple; bh=Nw2wHTGEvILzXzo9nz2sTzn8+Y0pyskOAkIzvhgQK3o=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Xs60WXlb3y87aQWN2P1wbIqAm80F5zbYHLyQTcdjtCuq/62/sfothqrkCDlAkLqiCRf+WVGXFD45FKO3+M5YZEvuLCGS1dO5OxzwAuN89SkB4L+mmPy+20WYKgvumWCGGcLvMEe0uHXkQVFisrD1UpTvknaC5bSC80GFCP2VpIU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 95B0633BDC5; Thu, 7 Dec 2023 04:00:01 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 12/17] sim: mips: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:32 -0700 Message-ID: <20231207035937.14920-12-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/mips/interp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sim/mips/interp.c b/sim/mips/interp.c index f0c509021a41..18ccef8bb38a 100644 --- a/sim/mips/interp.c +++ b/sim/mips/interp.c @@ -1403,18 +1403,20 @@ sim_monitor (SIM_DESC sd, if (c == '%') { char tmp[40]; + /* The format logic isn't passed down. enum {FMT_RJUST, FMT_LJUST, FMT_RJUST0, FMT_CENTER} fmt = FMT_RJUST; + */ int width = 0, trunc = 0, haddot = 0, longlong = 0; while (sim_read (sd, s++, &c, 1) && c != '\0') { if (strchr ("dobxXulscefg%", c)) break; else if (c == '-') - fmt = FMT_LJUST; + /* fmt = FMT_LJUST */; else if (c == '0') - fmt = FMT_RJUST0; + /* fmt = FMT_RJUST0 */; else if (c == '~') - fmt = FMT_CENTER; + /* fmt = FMT_CENTER */; else if (c == '*') { if (haddot) From patchwork Thu Dec 7 03:59:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81590 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D172E384DEC6 for ; Thu, 7 Dec 2023 04:00:57 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1077C3861883 for ; Thu, 7 Dec 2023 04:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1077C3861883 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1077C3861883 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921605; cv=none; b=wchupa9X1iuCW80ByR572S7eoY9k9Te7nxmvI1F4dmKJfWgFj7ZOWr0utbiGqmmap7fTr+gy/eKSoZ166yNejYSvLsato8XPR7BVTTYgO+Br41XoiC5/6nxjk+INPhQnWuaH3S2miG2mEk4LBxhKy7wlEAmRdxY9UTxiBsq66+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921605; c=relaxed/simple; bh=4PUpqN1PGcrwCIsEAx0cO2N/Inay4l98Z0NBR7mc08U=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=DvjNGNDdwkoA7qHNFkPd1EzN7bNq7KazzAVGP2xFvr4xvmHf5hmBIVaJYNBBMNj6u1RuZ/spjLnrLkHLk3nup6VAKCTkTBGeGMh9VKxlN2yzQ12h5LfuWEK7m6Pm5fVxbRpp1f6Zbc8ku4PcmEX/CPmijl+0uCCXalHwz76RwnI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9B28E335DC8; Thu, 7 Dec 2023 04:00:03 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 13/17] sim: mn10300: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:33 -0700 Message-ID: <20231207035937.14920-13-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/mn10300/am33.igen | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sim/mn10300/am33.igen b/sim/mn10300/am33.igen index da8f88fa599f..60c77d47fe33 100644 --- a/sim/mn10300/am33.igen +++ b/sim/mn10300/am33.igen @@ -2688,7 +2688,7 @@ *am33 *am33_2 { - int z, c, n; + int z, n; int32_t temp; int srcreg1, srcreg2, dstreg; @@ -2698,7 +2698,6 @@ dstreg = translate_rreg (SD_, RD0); temp = State.regs[srcreg2]; - c = temp & 1; temp >>= State.regs[srcreg1]; State.regs[dstreg] = temp; @@ -2715,7 +2714,7 @@ *am33 *am33_2 { - int z, c, n; + int z, n; int srcreg1, srcreg2, dstreg; PC = cia; @@ -2723,7 +2722,6 @@ srcreg2 = translate_rreg (SD_, RN0); dstreg = translate_rreg (SD_, RD0); - c = State.regs[srcreg2] & 1; State.regs[dstreg] = State.regs[srcreg2] >> State.regs[srcreg1]; z = (State.regs[dstreg] == 0); @@ -3242,12 +3240,11 @@ *am33 *am33_2 { - int srcreg1, srcreg2, dstreg1, dstreg2; + int srcreg1, dstreg1, dstreg2; int64_t temp; PC = cia; srcreg1 = translate_rreg (SD_, RM2); - srcreg2 = translate_rreg (SD_, RN0); dstreg1 = translate_rreg (SD_, RD0); dstreg2 = translate_rreg (SD_, RD2); @@ -3265,12 +3262,11 @@ *am33 *am33_2 { - int srcreg1, srcreg2, dstreg1, dstreg2; + int srcreg1, dstreg1, dstreg2; int64_t temp; PC = cia; srcreg1 = translate_rreg (SD_, RM2); - srcreg2 = translate_rreg (SD_, RN0); dstreg1 = translate_rreg (SD_, RD0); dstreg2 = translate_rreg (SD_, RD2); @@ -8638,11 +8634,10 @@ *am33 *am33_2 { - int srcreg1, srcreg2, dstreg1, dstreg2; + int srcreg1, dstreg1, dstreg2; PC = cia; srcreg1 = translate_rreg (SD_, RM1); - srcreg2 = translate_rreg (SD_, RM2); dstreg1 = translate_rreg (SD_, RN1); dstreg2 = translate_rreg (SD_, RN2); From patchwork Thu Dec 7 03:59:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81584 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1801F3864C5B for ; Thu, 7 Dec 2023 04:00:27 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 0F2023861895 for ; Thu, 7 Dec 2023 04:00:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F2023861895 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F2023861895 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921607; cv=none; b=edp5/WqMQz6CIKpfkp/dG6ZvBd1gZDIMZZ96gGf6JfL1qhyYzptOQleWbarARfPP2xHEm3z1z06DfsBjY18LXiA97UyG4sqH2vxLDe4UgxZ7BayDYVuMfANxXp/H+WC1fGXo5s/8kYppnVHCEPgUQ4TnZ1Cton86iUWcxKJ7jl4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921607; c=relaxed/simple; bh=L+yWl/kBILEVqyDYrWFMIJF8Kxl1wiuwoHzMwtyFMWs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=bkAoK1Tda1uEBeKSOkKrtoIw5p6ZhpcO7sUGfNIFTKgVts0ZX+kccKcKWMT5kYVzuSosN0Qrvsl6RdnAAsJ7PGEKCaxS/mdnbYooBEtPetJl1zsnzUBQVftxuKdCBbdfLeQ4eSRG3GKlkQhn/2WHT/wanUuE/sBHlihYb3sqiTA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9ED35335DC8; Thu, 7 Dec 2023 04:00:05 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 14/17] sim: msp430: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:34 -0700 Message-ID: <20231207035937.14920-14-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/msp430/msp430-sim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sim/msp430/msp430-sim.c b/sim/msp430/msp430-sim.c index a4ff6a4ad3f2..b34d23e8e84d 100644 --- a/sim/msp430/msp430-sim.c +++ b/sim/msp430/msp430-sim.c @@ -202,11 +202,10 @@ sim_create_inferior (SIM_DESC sd, char * const *env) { unsigned char resetv[2]; - int c; int new_pc; /* Set the PC to the default reset vector if available. */ - c = sim_core_read_buffer (sd, STATE_CPU (sd, 0), read_map, resetv, 0xfffe, 2); + sim_core_read_buffer (sd, STATE_CPU (sd, 0), read_map, resetv, 0xfffe, 2); new_pc = resetv[0] + 256 * resetv[1]; /* If the reset vector isn't initialized, then use the ELF entry. */ From patchwork Thu Dec 7 03:59:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81589 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8616A3845743 for ; Thu, 7 Dec 2023 04:00:54 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 06C7E3860750 for ; Thu, 7 Dec 2023 04:00:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06C7E3860750 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06C7E3860750 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921609; cv=none; b=YaXXk6GtBJ4Pd0Imx9N1uW/Ien8ZEcj6qiLHra0CvcnLMbrAKRqeOrq+Ib6AQtBS6mZKbiV/IbTR03FoBsff1xZlmO08LM0R6iIkwKvV4jzIG1KKgJjpU8cADhDCcvOzC8NmH/EqFfeHj60rphK+TaUvRfqkQ3y207ylRI/MGjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921609; c=relaxed/simple; bh=FOAtYUgHSOHDNpQj3AMLMSS+iVKTFcYg2zRu0hxfYao=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=RZ0usOOegkGd9qt8ARu9O/eLiMRCItbqkAwngS/LZT7TiJvjGEaVnPcIV9ckxiiv9/h4lkUvUZz2VoEukjB3NSGTO1Z6FBYMRNGCN35H7Zd5hX7293JNxj8/L70L8UcL7OpyZKcSZN+vsl9lEIBYHZT5zc6yHHixj+7DwhCysCA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id A96A7335DCC; Thu, 7 Dec 2023 04:00:07 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 15/17] sim: sh: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:35 -0700 Message-ID: <20231207035937.14920-15-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/sh/interp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sim/sh/interp.c b/sim/sh/interp.c index 2e2e13641e43..1982b7f17a7c 100644 --- a/sim/sh/interp.c +++ b/sim/sh/interp.c @@ -1667,10 +1667,8 @@ dump_profile (void) { unsigned int minpc; unsigned int maxpc; - unsigned short *p; int i; - p = saved_state.asregs.profile_hist; minpc = 0; maxpc = (1 << sim_profile_size); From patchwork Thu Dec 7 03:59:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81587 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29C7E3845747 for ; Thu, 7 Dec 2023 04:00:42 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 084E6386182F for ; Thu, 7 Dec 2023 04:00:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 084E6386182F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 084E6386182F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921611; cv=none; b=WxCVodTAtLkBjUixTPw1pv0G0EJmY7x9ohVjKtj3IMEWvQEoaFFr0qLr+qxIZ8m86vNJ8QLabTPRhKWdh/Wuh1oDlcMGfA+w011OIQ4LmWVpIfwlk+1WLz8rlMYMS5y9pFEz1aIvlqPzzfW29tjehFK7VMFaI65rZQYLEPPtGWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921611; c=relaxed/simple; bh=UsGg0HOeQ75jPKKIBZOvKutwWo/ZVr++fDmx69imE68=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SeA/DQZVuKhySj9Bqz9gTStVdVtsaFag0POq54il7St6tr4zEWJNqrqd8dXz0MnxBO/dlgIAAdQrEYRXYrFYicGiIJYCV9feI6ld60fR+AXUg8j3XuZUR7nWPO5dVs8EuHdSalsEN9OipKHECgKKF1S8mEvJIc5tHQhWBp5qvS0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id AC5AF33BDC5; Thu, 7 Dec 2023 04:00:09 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 16/17] sim: v850: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:36 -0700 Message-ID: <20231207035937.14920-16-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/v850/simops.c | 13 ++++++------- sim/v850/v850.igen | 6 ++---- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/sim/v850/simops.c b/sim/v850/simops.c index 326745efcb26..05770a946ea1 100644 --- a/sim/v850/simops.c +++ b/sim/v850/simops.c @@ -2106,7 +2106,6 @@ divn unsigned int DBZ = als == 0 ? 1 : 0; unsigned int Q = ~(SS ^ SD) & 1; unsigned int C; - unsigned int S; unsigned int i; unsigned long alt = Q ? ~als : als; @@ -2118,7 +2117,7 @@ divn | (((alt >> 31) ^ (ald >> 31)) & (~alo >> 31))); Q = C ^ SS; R1 = (alo == 0) ? 0 : (R1 & (Q ^ (SS ^ SD))); - S = alo >> 31; + /* S = alo >> 31; */ sfi = (sfi << (32-N+1)) | Q; ald = (alo << 1) | (sfi >> 31); if ((alo >> 31) ^ (ald >> 31)) @@ -2136,7 +2135,7 @@ divn | (((alt >> 31) ^ (ald >> 31)) & (~alo >> 31))); Q = C ^ SS; R1 = (alo == 0) ? 0 : (R1 & (Q ^ (SS ^ SD))); - S = alo >> 31; + /* S = alo >> 31; */ sfi = (sfi << 1) | Q; ald = (alo << 1) | (sfi >> 31); if ((alo >> 31) ^ (ald >> 31)) @@ -3034,7 +3033,7 @@ v850_float_compare (SIM_DESC sd, int cmp, sim_fpu wop1, sim_fpu wop2, int double } else { - int gt = 0,lt = 0,eq = 0, status; + int lt = 0, eq = 0, status; status = sim_fpu_cmp (&wop1, &wop2); @@ -3049,19 +3048,19 @@ v850_float_compare (SIM_DESC sd, int cmp, sim_fpu wop1, sim_fpu wop2, int double lt = 1; break; case SIM_FPU_IS_PINF: - gt = 1; + /* gt = 1; */ break; case SIM_FPU_IS_NNUMBER: lt = 1; break; case SIM_FPU_IS_PNUMBER: - gt = 1; + /* gt = 1; */ break; case SIM_FPU_IS_NDENORM: lt = 1; break; case SIM_FPU_IS_PDENORM: - gt = 1; + /* gt = 1; */ break; case SIM_FPU_IS_NZERO: case SIM_FPU_IS_PZERO: diff --git a/sim/v850/v850.igen b/sim/v850/v850.igen index bd8de8e2790d..6b9a8bb4a5c5 100644 --- a/sim/v850/v850.igen +++ b/sim/v850/v850.igen @@ -3537,12 +3537,11 @@ rrrrr,11111100001 + wwww,010001000100:F_I:::trncf_sl { int64_t ans; sim_fpu wop; - sim_fpu_status status; sim_fpu_32to (&wop, GR[reg2]); TRACE_FP_INPUT_FPU1 (&wop); - status = sim_fpu_to64i (&ans, &wop, sim_fpu_round_zero); + sim_fpu_to64i (&ans, &wop, sim_fpu_round_zero); GR[reg3e] = ans; GR[reg3e+1] = ans >> 32L; @@ -3557,12 +3556,11 @@ rrrrr,11111110001 + wwww,010001000100:F_I:::trncf_sul { uint64_t ans; sim_fpu wop; - sim_fpu_status status; sim_fpu_32to (&wop, GR[reg2]); TRACE_FP_INPUT_FPU1 (&wop); - status = sim_fpu_to64u (&ans, &wop, sim_fpu_round_zero); + sim_fpu_to64u (&ans, &wop, sim_fpu_round_zero); GR[reg3e] = ans; GR[reg3e+1] = ans >> 32L; From patchwork Thu Dec 7 03:59:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81591 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44C473861844 for ; Thu, 7 Dec 2023 04:01:12 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 2468E3861887 for ; Thu, 7 Dec 2023 04:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2468E3861887 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2468E3861887 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921613; cv=none; b=pLE3sxG+s/ItJjDVOv6jQxm2tMlzVclUAI6WW6N0lRS8C8xEyNaS2PfRBQnUaMR1m6kecptU7nSoWUX75niun7VqGIBRS500YkkVEdFmwzMXl6gPYNaYZAwdJJ75lAVPMeN5esoO6z4fqvudoxzakBpKj63Z48eVCRjkPFdj/rM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921613; c=relaxed/simple; bh=YS1r4VfeKo6xjuMYgthjTUjQbZ6jDqKUPtdZsH0PWDE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=i1lkuGRMDswS8EtwOZ0Dj4d4Rl1/UnzrmWDkVWbE2Q4mwdpvLAJVIR7Vsrgotsb1j8aVSssIvRnLciyhZEdPOt3oQdA0de7tkG5XfW8CrXM5m+gw1PJyrmJ6wznXvF7tWzFUi1cylqjjyN5Mxk3dx4rJkuFqzfNsx36zXwIazN8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B5B8233BE18; Thu, 7 Dec 2023 04:00:11 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 17/17] sim: warnings: enable -Wunused-but-set-variable Date: Wed, 6 Dec 2023 20:59:37 -0700 Message-ID: <20231207035937.14920-17-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org --- sim/configure | 2 +- sim/m4/sim_ac_option_warnings.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/m4/sim_ac_option_warnings.m4 b/sim/m4/sim_ac_option_warnings.m4 index e453d8866ff0..2cf4a22b6494 100644 --- a/sim/m4/sim_ac_option_warnings.m4 +++ b/sim/m4/sim_ac_option_warnings.m4 @@ -39,7 +39,7 @@ dnl NB: Kept somewhat in sync with gdbsupport/warnings.m4. build_warnings="-Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts --Wempty-body -Wunused-but-set-parameter +-Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-error=maybe-uninitialized dnl C++ -Wno-mismatched-tags -Wno-error=deprecated-register