From patchwork Wed Dec 6 15:23:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cupertino Miranda X-Patchwork-Id: 81522 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D2EC3858292 for ; Wed, 6 Dec 2023 15:23:35 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id EF63C3858D20 for ; Wed, 6 Dec 2023 15:23:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF63C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF63C3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701876202; cv=pass; b=DTedy3Kd+XZ5+nFEGX6q7rcVzrnpas4h9JGgLiUoB+DbM7w9pioHuz7eMvWkyhf5ljCsaGY1tSdLlYVuV/QuE1jExciPzj7XAeA9q1BOLcE+VqXG4aBCsS4nql+3FiyH85xrUWQM1XDx7tJFQVQh84J+OOvrIf6Q69RJqD27y6o= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701876202; c=relaxed/simple; bh=sqe5v5OjgEcE/8Z0+k8E6211ybyjsSBA+zF0BUbh4yM=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=vu4oKH5hUdXv7RlzdGQwJiYCP/uZJnDdlAWOg2CHXnxK+dRMqGbRrlOlqyInGTRLtjnK4u/8BACEcuLmVvmPC8QbBYZ5HLzde/dIpKru1ey+f1oQdQA3yZ4YrLJZRVVFO461UM28xBFQgAMOCipXCYo4+QZq4/2r3XopJygj5vA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B6EYjkv014755 for ; Wed, 6 Dec 2023 15:23:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=7Tgbp99v2vdgDmCko67gnLphvjod8OD5AcJ/Zk0/JyM=; b=AuKV7jRl26t4B2aHA0DHCGMo6muql5qIi7O6X9ZGtiIh8q469PA2YAQfSQslU92aCTkv 91S08kbkEuPiNH8hNUyXUEm2QK3Nk4CobII8VxWe94JttN+gCOjEdWhUiFYqVGL4GUrw v4bgWphWa5ZMbjnhLqzmM563z9MxVyNjpVKDGpu+7/LNEMLHov4d3NpMak4sUEBMzknf wNbNPRUt28DQwfQoBdNIifSwN1Hce8y+5yK/biFWMthC3ISUlV1BL5KMUk0CH63mTRyv dhxYvldwYlc50HzxfOlzShBRtB1KSo/8TmtMcDAQ9I8DbvHTyxygoXNoWsvtDejfafRC cA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3utdda1p04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 06 Dec 2023 15:23:10 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3B6E3oES038489 for ; Wed, 6 Dec 2023 15:23:09 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3utanc1f9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 06 Dec 2023 15:23:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQh8L0Oi82gg4nxEZvtC+Pah1Ju5lZnn7DRaDDuHfyOC95bkBZZMUpRs826MG/HXdxRUzbKaWO4YdBod1oKdOPTnSNDz+49Qp6X9VdRJHpdxm28KHrLpubQr5eGdoKCTARggL5j3II1wMiTL0kU9T7WCInnftkDLv34cydcSVyZ2wNy9d4asekNnPsZ6xyinEhkSBWbVEVcf4dmjCWjSv/ZKpiJ+V7b+DRWk+9lieFJSg++ze9MtI5NcuY1e/rvXS3+y9f35sJDqAOES8erDA+tvD7t9cHYi0SNIVFgwF2RLTtLI1FvNVfC0OydL83DLyj9NiwaFOfcTfEMeslQ1+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Tgbp99v2vdgDmCko67gnLphvjod8OD5AcJ/Zk0/JyM=; b=HBsLVU3nerhQ3ttEtw8Mb7tLrktKIqyIPZLi6jbZdO/bElS9+V/kHd19qHt2fcdPZwMrNVwsljs8apOQpGo1x+5fBP5ljNBF7FZtELCBECYHl2t7bur/2MzaUaw42JGz12fTzbDEYhY15KFXGKce4E+MSKH8+aHsf/ZjdjLeMGOhw/pFpjjI4LNlJGVbQBxuJjjtKGOZYAg/Eu4iMxMnPrHj/TBlINzj2SQX3swI93/2FQ/MtMGXl42WYaq9L3rLqDqVkXDDMn1mLqQtfHbvzjQ9L821uNEctO7/UCShJr/1ISJgXfXLdcqmOPwgdd4IWH21m9gNyVZNfjp3N2Udrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Tgbp99v2vdgDmCko67gnLphvjod8OD5AcJ/Zk0/JyM=; b=lqEJrsbl4nN40BS7SVghZVY7yc/50shoQGh0TkmV8b5oG6tb8spz/MaDUxeVJmP/fNtEGoTtiK8sYTEH5quxeJ8ZV2m58MdvpNPkBd3kYDpowmcBsJ/lfSszdyZRXQhcXzBJhl5oueYogaPFw0H8wqx2HZtiSPNonth99FQB/BA= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by LV3PR10MB7819.namprd10.prod.outlook.com (2603:10b6:408:1b0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Wed, 6 Dec 2023 15:23:07 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::fec4:3a58:6118:aab2%6]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 15:23:07 +0000 From: Cupertino Miranda To: gdb-patches@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, Cupertino Miranda Subject: [PATCH] gdb/record: Support for rdtscp in i386_process_record. Date: Wed, 6 Dec 2023 15:23:01 +0000 Message-Id: <20231206152301.214669-1-cupertino.miranda@oracle.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: LO4P123CA0545.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::13) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|LV3PR10MB7819:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ecc8408-7424-4406-db34-08dbf66f3fe6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9lTng6mlEVFr5krTW3FZXroLwNRNGu6s+eV2mUy5alTEcQfytDOPvMzQyXbPVUXpf7G3MkfyVaU/eFInIROoNiIEvaDNj5Ba55q78BiU96ux2qPt0s3lKrEjJErwYxuiQ9kJVcyCo7ieG3QlRlA2/ECuQHbQ6zUSgwF1spCDeUokGgF55ga5t4VGmfX1GqjXzANMCbIaGeGWkYfaOc4Rv680MIWond1sEFHHQLGQZwcSvxzkHBbxeWq3Nq32zHNh2X/rkp8kNoufpCVHG6JUwJHFN+mve5KBCS98Pcx39XoSwkVHlxJ4NbcXGV4+By+xEmcJ2A3U5ysIrcGLaaJa5ja24Zm0iI6xGKX+ZU3LdNCbBlx0u1dGmPPl/JANZJ6cDT8DJJLPqUlpXILxt6RwYsL//G9g/woC2Xib13gGRw0ZWdXoEGRZHReppY1yRDRWGANXcSzN7O37LAnl8SPeZqXgBJJbDr4LznAy806SdlNr3S6uh2RM6y7sKp/WD/wO4ya7uieungTvdtCUmLJ7eLX50I8rLEbor6hEL77YRx2THyRIPQINWaC8hA9ZMz9E93xPV0JIMN+JDdGKOYdemBUWuIdmFFa4N5SZ3rdLr0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2340.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(107886003)(2616005)(1076003)(6506007)(6666004)(6512007)(8676002)(83380400001)(5660300002)(6486002)(41300700001)(2906002)(478600001)(8936002)(66556008)(66946007)(4326008)(66476007)(316002)(44832011)(6916009)(36756003)(86362001)(38100700002)(40753002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HDcyFXqCCPEGeswqMhajwECtU7NBxgA7sR4iG/eZJcUvrBU4UGEKgMmn6R/bym/eveTxapz9mYhsz1xH5Fti7MY4Sbxe7uSNPEvmxAgmpAMU9UcMjcLB8hoILq7BZJEsiniUwU5R2C+xZLACTDFEcQSUfGFYVTrDWd4BbETF4Ic80OgPrZn31o94gNfbwqlDwFJzA00dAqtgkYoaEyy5fxkWIqb1U6eTAVoxgTVEDqyX5bhIiK7GU4iFiCWDZ8n4H/jcWiaSsmYVzq1d2NuEIYAn4R0hf+AHtb6F1jTN2Oswr+qXodUMXEzMsgEnQFL7ozBy0XBDlJUWZYyw6jONCRFp9RPyrwEt70OgR0Qmimtzu0v7q5hwr752bmwboTqhUPxa+H63bf43nId+LEhQWYAig4M0PXjxfT9m81XemrW5i4m7+FZYjeN6hc3MwvhDpNuD+hySLRdfCi1cAS1yRW8U+AyJd4F/TFPPila77s6KV/Ov5ntL6iott6dBlxo2faLnAEeLauEuX1YM7miCRZMFEk9GJm7uU9qvrLsSXw4cReb4y9CzpKLcjnJo29/sUSWk26RGoZmNYQuSOaTNoiO8o9jDfeR1IFNBeThKFNxXRpTP5Y1w4wl5wnwA14HHZ4ikI4dK6yFiYMUSbW/Wf79vR3XBMxdaivtrErsHFmWz3vhsH83vZ22ag4I3v3AvftVvNta6TssHB6N3LwF1o2fV0WzvzC1BqOqIblKJNvWG24E+g41Iu3CeF0krbK8KuIYMecM+i3GPfwpSiHF9lxxO7/gxQtYucNWQARCGS8LQSQMKv+KUV/GRhnn0/hZbcjtFg99SywPNGeZ7D++0Otdt0pmvkQJfzXBCSt2CSWgTonlwiyUqwcM+KcAR/53xbVIu9c4N+1qK9bBjtncthnhlc9spLKvqw1zLrYSnW9HhY6wTQCJX1DoCyqfl8K6Cph76QUaRVnrJmOAknZJpKI7z5s5ehvSjx53uqYh4fhte5JkgbWYRgKq3qKsSD2Nv8F5MkQe5lYIDdsxL2mQ9/Tk7usRdyzV/QRJtfMQuAP30sHHo0+fjnYBhslFIJ2XGBu0k9u0Lmlz9eo3ORJmUM3L1IVCrXedQV9E1EJkdQ0Idg1udVIu0Y34gsxhimADzCsU3+uBMdWyXH1kS7C/fTP3vuiM2JZFDZ9X3kuUP4Sb+yjHheWg9YJSz4vF3Sl7l1KMxdUsKgjGxARxdvR3RE9GsTvbkWNIXTN29VPeyn5SkezEpif/2pktLOlpd8YSX6mJ7dBbbP9TQBEgffu5sXwXPJkJYUCtYLIkSQnnlbPnc1I5qaMsVFwaxoTkdDKJU0Ys5nalVYEoEOrJyq5blo41USlYbW7N1O1zq9f9dToU1PgdVaJDBkwNRNDf0I1gGaMasuthd+8f5mt3MBMhFRDMyxEb/593qMdtWPBPVXuNxc0JWWGVwmkxS1h68AEJxe4DQ5MXdtWg5eg9KSeMvk069Ci717kyk3deQ8AFewZHwCPujzBjDvj2B9pXZdKo1XDpOmmzLwiSKHjqlhuwmnvzj8bSHfJs179t64zvzNNtHXNUp3qMVVzFTm1qD8jKL78BzbbNOhdwog6NTD5J9AiC4vPMxUYgq5Eg8qOQnlb0Y/UYza2u45IRmNqLA2+bJ X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: s3c3LGpZuU/caKqmbjIo3Si61hgFadCf/nm0Z5CLavc5cHQUPGNnaW9CjpFBjK59FS1XWxO/LZ6BI6BkXWzcA3eVPxI71ESaDa2ITsIdMhmymBoEu2xndp/NfcLJL8M8rcmjmt58GoNR6xi7/Ahsfw+77GUr1sxhsFGztMq15MNKeKoeqD38WLl8wMJwjX/UUmYkSlCjIr7QMzpUlsWwXyd0wJZ6l4fFlli2SsaAgaqM32KjO1jqNMMOvz1xbKOECpM68lEg62YIn/KAsyA8xmLk799QgnStjX4/MmaNWnDG2tufyGX8eoV80JnLyqwu6Rfjx1h/YmgkeCiEbv5FwxEU8qKdQQNOxmld0z5+GgiVCaS57Q8HBdyYChR7RrL4v8uD8OT8l5jE45yICg1rD6t+mGV6A5HMdpH03OU+Az/UkI1ZCifu6AkZ3xIc9V65BgoKsjLtmZ0VXNrXo17DKduwwu+GuJhEZ839dXePDYfsqdvGXQsBKQVf/W21K34+7UWnvFm7a8pgF+xffc2SH4kRfh+965ttDyuUiMq9iRjK3YSOgZE93Whikq0bZS4QMGMLlDNLoUhjMTCe9pOx6Js4dWLXKKpoxIvEj5y5rQXXA5ukkWEhWR2WUSv6PZL0Bp53F6HinsJCCwbDOQ99maZJr+OXotvFNSeuHGJ5QULsYK4WgFJWf3urCIDFs9JA8JTueq7FyCwrL2xdLt2e1o8mbGF25A6QPwe5FOOxgYT3+5SFfOQxLOlq4XM0E8mn X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ecc8408-7424-4406-db34-08dbf66f3fe6 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 15:23:07.8796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OdADc4MC6PD3tNRgjGcinVzr7v4FcfMVRaB8VniNt95UJKEwNk4tyMNi5FcJOYNP7zN6nL6ZBuhy0irXiu3tZfB0aYkAoNyGWmyfLppGHlM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7819 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_13,2023-12-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxlogscore=609 phishscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312060124 X-Proofpoint-GUID: M3xB75qLjUv7G8eM-Wt9P2C7uOMNFEFb X-Proofpoint-ORIG-GUID: M3xB75qLjUv7G8eM-Wt9P2C7uOMNFEFb X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Hi everyone, Looking forward to your review. This was detected internally presumably when debugging a system compiled with intel compiler. I changed one of the tests to replicate the issue. Please advise if it is not the proper location to verify this. Best regards, Cupertino This patch adds support for process recording of the instruction rdtscp in x86 architecture. Debugging applications with "record full" fail to record with the error message "Process record does not support instruction 0xf01f9". --- gdb/i386-tdep.c | 8 ++++++++ gdb/testsuite/gdb.reverse/insn-reverse-x86.c | 13 ++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index e00c3bd9d56..e379c179885 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -7008,6 +7008,9 @@ Do you want to stop the program?"), goto no_support; break; + case 0x0f01f9: /* rdtscp */ + I386_RECORD_FULL_ARCH_LIST_ADD_REG (X86_RECORD_RECX_REGNUM); + [[fallthrough]]; case 0x0f31: /* rdtsc */ I386_RECORD_FULL_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM); I386_RECORD_FULL_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM); @@ -7117,6 +7120,11 @@ Do you want to stop the program?"), case 0x0f01: if (i386_record_modrm (&ir)) return -1; + if (ir.modrm == 0xf9) + { + opcode = (opcode << 8) | 0xf9; + goto reswitch; + } switch (ir.reg) { case 0: /* sgdt */ diff --git a/gdb/testsuite/gdb.reverse/insn-reverse-x86.c b/gdb/testsuite/gdb.reverse/insn-reverse-x86.c index 2b4fb4c10e0..23888ba7350 100644 --- a/gdb/testsuite/gdb.reverse/insn-reverse-x86.c +++ b/gdb/testsuite/gdb.reverse/insn-reverse-x86.c @@ -270,6 +270,16 @@ rdseed (void) #endif } +/* Test rdtscp support. */ + +void +rdtscp (void) +{ +#ifdef __x86_64__ + __asm__ volatile ("rdtscp"); +#endif +} + /* Initialize arch-specific bits. */ static void @@ -283,5 +293,6 @@ initialize (void) static testcase_ftype testcases[] = { rdrand, - rdseed + rdseed, + rdtscp };