From patchwork Wed Dec 6 00:42:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Moioli X-Patchwork-Id: 81459 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5CDEA384DEEB for ; Wed, 6 Dec 2023 00:44:11 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 5E35338582B1 for ; Wed, 6 Dec 2023 00:43:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E35338582B1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E35338582B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701823438; cv=none; b=FaEkJli0ex7SWHfg3/NupJQxjtkzUmOCLjQhQT7saW1f4OQoj2bdaYwGgFbiHHMXlO4eGQkQqRKWBoUzz/LK+RJ8VjlFK2BjpKerPUFVXBPOHdyAqoDH/0MQ/MYmqb9+cNvo9OM1P4nue9HloaqIppOKYhfMJG0g4DRRHFE+vKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701823438; c=relaxed/simple; bh=zQgSXgHNbmxhZ10Qvb4cS59mFw/Z1urww8Y/yrmz/WI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ULNbu7lZYUvmeAaqTKYjoCWNINkZOjQ8xIj4Vba3DkTUEPRjwVENt7VJVcroz1BdVkSS46PbSKwyjl7RAM2SC5pNg4K5bf1zKUV4P9rhPHipACjCGdCp3v7LtP34qm9ZwrQfRibIUBhEruCni1WDkFtHqeThsWHKOwj4of40pjU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40b5155e154so68319775e9.3 for ; Tue, 05 Dec 2023 16:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701823434; x=1702428234; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zuWDD2FJQau43cNdoHQN3Li6F7o39bSlcGcAnJRZwkI=; b=feTsme4IbF0CwNlD9wZ0FPappFOhLClUHZ8t/NAAnLA8r9XJo5IrJgrzGJGuH24eKV yBc+ulpRqFiML3KMokrW3Q/92jvz8HyKDUiUunU4X1Ykf7QnzW1SLbgHViG/rU+DzwS0 m2YJ5NDTekJ7Wi+es1dkWnAWIgDbfORt1dgdVZkY08ixMpnVL95MroJAb8hcq0giOqam JdogzgqJhyfWq0b2kuRgiCHCqsUEuoz87vS/HhQx0rYPKw7mu+Dk2rTbDgpqz8EyghoT OY0Rif+/5h/saACx1/YTlBbnRep5tXa65b5f8BRSkj90qNrLRUpl2IAPKoxC4RC7Rb9h JiLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701823434; x=1702428234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zuWDD2FJQau43cNdoHQN3Li6F7o39bSlcGcAnJRZwkI=; b=HbOLd/PnXn+Nla5IDHSsLPENN8fLkA6CEubK0/B+CI/ri9vG4pkdaRLp9WdGVcBk/9 uMBqusfHg5dig/eKeymjBQr6xxk2ZYJjEF+LzxLMRACWKaR8tmiLgx1FDqu09UkR/vL3 hd8fySwlKwF8Nxl3La21InwTtHtyuFiW8RWlkG1VXEGcfI72h7P0a4pxbWuHt8nHcGRk Zz7/5KBzApFqQvtn7lAWHXuYla8VxKUkRBYBx+HOqdCuzTXOY7BMbVXCFYU5Uhvhca/L SdFYxJOr/QMUHAwwcFds0+ZdeMrRB5GV5TEkvcaJMMgQ0PpT0zI6Fq4GbPd2CHS1i4iH J3ag== X-Gm-Message-State: AOJu0Yyj9T1UnNqKldOClie4JxYQIeVdMlnPIheAF6GPjBIY1CWPqWhF jYbWrCCq6I4Zd9Ywjii/gK6RrSrFkng= X-Google-Smtp-Source: AGHT+IFCqNBGriwQtvrfLC2ez1vyI7YKCw/66dM2ySIq49GRXdptmTzqLxZdTjm8UXP+TrSmmCl+Dw== X-Received: by 2002:a7b:c405:0:b0:40b:5e4a:409d with SMTP id k5-20020a7bc405000000b0040b5e4a409dmr71632wmi.189.1701823433906; Tue, 05 Dec 2023 16:43:53 -0800 (PST) Received: from localhost.localdomain ([151.20.182.203]) by smtp.gmail.com with ESMTPSA id uz14-20020a170907118e00b009e5db336137sm7399955ejb.196.2023.12.05.16.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 16:43:53 -0800 (PST) From: Stefano Moioli To: gdb-patches@sourceware.org Cc: Stefano Moioli Subject: [PATCH] gdbserver/win32: fix crash on detach Date: Wed, 6 Dec 2023 01:42:19 +0100 Message-ID: <20231206004217.21980-3-smxdev4@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org this patch fixes a crash in gdbserver whenever a process is detached. the crash is caused by `detach` calling `remove_process` before `win32_clear_inferiors` error message: Detaching from process 184 ../../gdbserver/inferiors.cc:160: A problem internal to GDBserver has been detec ted. remove_process: Assertion `find_thread_process (process) == NULL' failed. This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information. --- gdbserver/win32-low.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 3246957ec44..0ddf60c836f 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -735,9 +735,9 @@ win32_process_target::detach (process_info *process) return -1; DebugSetProcessKillOnExit (FALSE); + win32_clear_inferiors (); remove_process (process); - win32_clear_inferiors (); return 0; }