From patchwork Tue Dec 5 04:47:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 81334 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A72C93891C2A for ; Tue, 5 Dec 2023 04:48:13 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 7B491382AD75 for ; Tue, 5 Dec 2023 04:47:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B491382AD75 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B491382AD75 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701751680; cv=none; b=cj/J1m0Hchl45GE35uZM1gieyGyOQG3oeW7O9FGuRP5wkN+Am+OJ7wpr0Fu3ecdAlv5umTZwcv+4UX5YYHR0eRNIAm37RssMltSzVZshhfbsDxIxDhmDsiQXwZbLANtDHFfRtksRxekc7rC6rVZ5CNBeNu6/5LVshivxOls03/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701751680; c=relaxed/simple; bh=cTcTxfI3HBLdanuB+jj2uv5xXvXGw9tZjTcyoKZIqJA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=a0U5yU9CigF+YPqmUHkT1K001Dk7oUu2a9xtGFCWYXutRnnI7dz+r0ttA4f5FXty3WdFYkXSMWp96BmNRT5tPJmL4whnuAL6mfP7kjvt3DD4Xa1x6xrDLYn22SudvrZFvgYqmW+fHH5B854o6Mbd+WyK16qPQJ0O2VQfjnQ337M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 25D8A335D6E; Tue, 5 Dec 2023 04:47:50 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed] sim: warnings: enable only for development builds Date: Mon, 4 Dec 2023 23:47:48 -0500 Message-ID: <20231205044748.2009-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Reuse the bfd/development.sh script like most other project to determine whether the current source tree is a dev build (e.g. git) or a release build, and disable the warnings for releases. --- sim/Makefile.am | 2 ++ sim/Makefile.in | 1 + sim/configure | 8 +++++--- sim/configure.ac | 3 +++ sim/m4/sim_ac_option_warnings.m4 | 4 ++-- 5 files changed, 13 insertions(+), 5 deletions(-) diff --git a/sim/Makefile.am b/sim/Makefile.am index 3693eb18d496..b42926070dbd 100644 --- a/sim/Makefile.am +++ b/sim/Makefile.am @@ -45,6 +45,8 @@ MOSTLYCLEANFILES = core ## make sure all objects in subdirs get cleaned up. MOSTLYCLEANFILES += $(SIM_ENABLED_ARCHES:%=%/*.o) +CONFIG_STATUS_DEPENDENCIES = $(srcroot)/bfd/development.sh + AM_CFLAGS = \ $(WERROR_CFLAGS) \ $(WARN_CFLAGS) \ diff --git a/sim/Makefile.in b/sim/Makefile.in index 3dd14543450e..ec24aa196acf 100644 --- a/sim/Makefile.in +++ b/sim/Makefile.in @@ -1798,6 +1798,7 @@ MOSTLYCLEANFILES = core $(SIM_ENABLED_ARCHES:%=%/*.o) \ $(am__append_57) $(am__append_61) $(am__append_75) \ $(am__append_80) $(am__append_88) $(am__append_103) \ $(am__append_107) +CONFIG_STATUS_DEPENDENCIES = $(srcroot)/bfd/development.sh AM_CFLAGS = \ $(WERROR_CFLAGS) \ $(WARN_CFLAGS) \ diff --git a/sim/configure b/sim/configure index de67d95d4abf..32cd8fb051fc 100755 --- a/sim/configure +++ b/sim/configure @@ -3009,6 +3009,8 @@ _ACEOF ac_config_headers="$ac_config_headers config.h" +. $srcdir/../bfd/development.sh + ac_aux_dir= for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do if test -f "$ac_dir/install-sh"; then @@ -12288,7 +12290,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 12291 "configure" +#line 12293 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -12394,7 +12396,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 12397 "configure" +#line 12399 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -15811,7 +15813,7 @@ if test "${enable_werror+set}" = set; then : fi -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then +if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then ERROR_ON_WARNING=yes fi diff --git a/sim/configure.ac b/sim/configure.ac index ecda34a6b3fc..84a7e0a249e7 100644 --- a/sim/configure.ac +++ b/sim/configure.ac @@ -14,6 +14,9 @@ AC_DEFINE_UNQUOTED([REPORT_BUGS_TO], ["$REPORT_BUGS_TO"], [Bug reporting address AC_CONFIG_HEADERS([config.h]) +dnl Set the 'development' global before loading the SIM macros. +. $srcdir/../bfd/development.sh + SIM_AC_TOOLCHAIN SIM_AC_PLATFORM diff --git a/sim/m4/sim_ac_option_warnings.m4 b/sim/m4/sim_ac_option_warnings.m4 index 8ff94df03209..16d358b0bbaa 100644 --- a/sim/m4/sim_ac_option_warnings.m4 +++ b/sim/m4/sim_ac_option_warnings.m4 @@ -25,8 +25,8 @@ AC_ARG_ENABLE(werror, *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; esac]) -dnl Enable -Werror by default when using gcc -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then +dnl Enable -Werror by default when using gcc. Turn it off for releases. +if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" && $development; then ERROR_ON_WARNING=yes fi