From patchwork Mon Dec 4 20:40:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 81302 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E6933948831 for ; Mon, 4 Dec 2023 20:40:47 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id AE41D3858C41 for ; Mon, 4 Dec 2023 20:40:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE41D3858C41 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE41D3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701722433; cv=none; b=qqxa5Ou3W8uOEgRL8zELje2DDbzrdKFrLYqC6irNHH0tjyiidVoI2FEXSTW3c/NY+0LEoGhJNuljZK+89NI14RKwxoQPKK298cyuKSFzqkcqoZkhPf5/jD1oh1UulRm96NTwLhtOZPsQQAFaAU4xNMoZzbhgSGl0CpWZAADwWiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701722433; c=relaxed/simple; bh=m0YJZIv9qkfshhPWSL1wN2AxxFQy3GmulZgsI6R3l1g=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ejB1G8rQuF3NgXXkNtYnohsJVXGtV3E9R3DLEWesh0FUfKW9kM3EQlJnEjiuZ6L4NAMAspUoq4Y7l2dpBFo3g2FYbxJEKdpTXBPMkQmM3LedUEW8hpAZqGnOU1b9SjbE2Ynt2X/gGq1JqVl052n5VntgH9tQQboQN5DpaWS7GfQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B2AB11E091; Mon, 4 Dec 2023 15:40:22 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: remove casts to long in dwarf2/loc.c Date: Mon, 4 Dec 2023 15:40:19 -0500 Message-ID: <20231204204021.889415-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3496.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I spotted this while reviewing another patch, these casts to long are unnecessary. The result of subtracting two pointers is ptrdiff_t, which can be printed with the `t` length specifier. Change-Id: Idf8052b110a61007261be19137e4864ae6b37190 --- gdb/dwarf2/loc.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) base-commit: 9d8fc40eb0e611162844eb7b89f1c76875153fbe diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c index 5b2d58ab44e4..606c97c745de 100644 --- a/gdb/dwarf2/loc.c +++ b/gdb/dwarf2/loc.c @@ -3329,10 +3329,9 @@ disassemble_dwarf_expression (struct ui_file *stream, name = get_DW_OP_name (op); if (!name) - error (_("Unrecognized DWARF opcode 0x%02x at %ld"), - op, (long) (data - 1 - start)); - gdb_printf (stream, " %*ld: %s", indent + 4, - (long) (data - 1 - start), name); + error (_("Unrecognized DWARF opcode 0x%02x at %td"), op, + data - 1 - start); + gdb_printf (stream, " %*td: %s", indent + 4, data - 1 - start, name); switch (op) { @@ -3515,15 +3514,13 @@ disassemble_dwarf_expression (struct ui_file *stream, case DW_OP_skip: l = extract_signed_integer (data, 2, gdbarch_byte_order (arch)); data += 2; - gdb_printf (stream, " to %ld", - (long) (data + l - start)); + gdb_printf (stream, " to %td", data + l - start); break; case DW_OP_bra: l = extract_signed_integer (data, 2, gdbarch_byte_order (arch)); data += 2; - gdb_printf (stream, " %ld", - (long) (data + l - start)); + gdb_printf (stream, " %td", data + l - start); break; case DW_OP_call2: