From patchwork Tue Nov 28 17:35:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 80939 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 048413870939 for ; Tue, 28 Nov 2023 17:36:26 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by sourceware.org (Postfix) with ESMTPS id 856153858287 for ; Tue, 28 Nov 2023 17:36:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 856153858287 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 856153858287 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.20.55 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701192972; cv=pass; b=dfsl6Ugdhn4XzHfQsw7ZZoAfjkUEKeadjTNhzjeGaG+oCtQMBu5sSmj6xJuAd41e4XAz670PBfanwKqE0vmB2lya9IkZ+iXw6QQ85aXqzMsM1tPVzxzeZK7BL7/r5aZAqDWqnQ3UyYpxBpgVE7vYiVAIaKUk5++mI7AQxxHQUTM= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701192972; c=relaxed/simple; bh=YtDa5aXWz9o0/dPEkvbLgn6YeHuGLPIWfYbs+OrBLDc=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=tc2Ck1t+csqGu3ytQhh02vIqdgi6FPsjmEsGXDqS3rQohCBG5IBPRQtnAtWIWks5G/7x0yrRjZ1rtFKYvC12Royw5iMrms4paDFBONlpSLz+d/0JBc58QJIDem3gjyPO9pf+Ms4KGuZOm2mGOx+ythbsDLqDBO8JiZe3t3ek53k= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PbxdiUQZ5P3v9yqTxMTRtI4RnjloR3pNCPHJybrdbipTifx6hY6/xJwaiIFyPAqhRjat6RSfBNa28x5ylezIQzPjMFPkRR8w9reGhsWcCOMbi/OZXVkz5iOs3aZzH3dTxCqhIAD+AAYcMu0zMwL4gFc8uIYJmUPzCt4nwILU6ZPI6CtUzEZIezos3zN96oSK60qb+2dehg10TFB0n7qFvJPBga5RFzOanw+C69H0FV8npYBJERRZtwxPcRo+sOTHarNxzk63ACd13sPJsyh2qhtmd7pAuGVslU+VV7mnCyPzbnIJ+UTV8vawhea39PMlq3X/bsWpw0y16oH21KaYWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fh58rZB0FyLRjtonEeuhW3UVAXpUaNsaf4putUey1HM=; b=Fbisu4a8rBf+pL5KcDKmqlVYZdK573YUs6au0K1RptGPr5jCc/yPPhD9/wA4iRsIt5Q5jaIBdCovqB3euANgbLlFfXXV6zeX5UR0j4PiTqyCS0rC3qDc45/kj+4g9hP3PGUuUQ1BAGa6ZzPL2sJkqNLsNQWTojyGn8YzadWJQ8llziMIK+JNltfm6hEM0gffjqrhTcfiCAu91ti/v19gMaSr4fgzoTgPfq7sCmN5KZKtVfRJ+ZM24hTUVGzov6casp0H6vwfx6T0c6/c+yM3YObNrv040sUCB5SoKyTLePQjBXvtkbGNCXINNMPMjrCtIas1gDdDv8BPMv3SoLeyyw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fh58rZB0FyLRjtonEeuhW3UVAXpUaNsaf4putUey1HM=; b=OqTL5bAP2JfJGFeheIgo18jAJZ+jmz2vZWjpcZ/jf/z8sdmjxyfnXrG+pdeYX4B0gH96P7rLToX+EoH/vrpA6n4qsvuvxzRvrXs60BIOWsWqpHC4gaJEF0Qa+OH6dMclM5c8idib/Fc8EcaBjPyF/I9HJ+2ftTx0esz0lv3xIS8= Received: from AS9PR06CA0585.eurprd06.prod.outlook.com (2603:10a6:20b:486::16) by AS8PR08MB9814.eurprd08.prod.outlook.com (2603:10a6:20b:615::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 17:36:07 +0000 Received: from AMS0EPF000001A5.eurprd05.prod.outlook.com (2603:10a6:20b:486:cafe::ef) by AS9PR06CA0585.outlook.office365.com (2603:10a6:20b:486::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Tue, 28 Nov 2023 17:36:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001A5.mail.protection.outlook.com (10.167.16.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Tue, 28 Nov 2023 17:36:07 +0000 Received: ("Tessian outbound 7671e7ddc218:v228"); Tue, 28 Nov 2023 17:36:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cbbf65ae5da8e208 X-CR-MTA-TID: 64aa7808 Received: from d188149a2f4b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 759D4F4A-3817-4C64-AC89-8F9F276C743E.1; Tue, 28 Nov 2023 17:36:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d188149a2f4b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Nov 2023 17:36:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IItFNT3pO9diu3zxdc/JGeGsovnaNmIb3zVKZLBx0xeZSFid6F926ZpswXhYefm5wykGXECKZPhKX/UMVfKG4QK3qgO92OTolWauBeeZAYeCqBuCGb80vZc7I0ue0u67Lh3CK6Kc1587sqGiisCUuMyCZgRapP9G0mSXHzSaiP6Dmi/FjtY7ZPL5+W6zIERM5ynHJPnolHLfPQsaVxZzZUXxU8/NS+FUNzcvNmQiAxTDM/cAd9hYM/KEsvy9ZqB24jymbSoGUPBgWqht+luRKT4E4zVDZy9LYU+LCqLOBTOk2fTPlwfL5El8haweNw6jNX6hxZU0cE1cn0T3E2FcwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fh58rZB0FyLRjtonEeuhW3UVAXpUaNsaf4putUey1HM=; b=goZSUP7lXUK30v57AHk8w/3tvRich5RANSAlTj7j705smkBCpiYLVfDHfNOxi+GTkvKlOZRV3LcyTl0O7oCZ4nhRPiXducAZ/YavPL9duOd0DyFhrhU9fsTeBrQNAmOwT2QIAcnl6+WGD6qDEo/hS4V6LpgUei2NPvfXXThL3hO/gfL86o+kL/JHEcZ0xlXQAUXWpJRVezkh64acSrPp/HE7RsR3kVxubwUqw2uWyVF7RjXFTs2WAhZguQcRuHjCTV7aeXJGg36os6Rm3GnlHLngTrZgY00LTMX0g8z2Juj3+75DaP6Zi7DPnfV7f4dCbi3+uXTXVK2/YWjYqp/OUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fh58rZB0FyLRjtonEeuhW3UVAXpUaNsaf4putUey1HM=; b=OqTL5bAP2JfJGFeheIgo18jAJZ+jmz2vZWjpcZ/jf/z8sdmjxyfnXrG+pdeYX4B0gH96P7rLToX+EoH/vrpA6n4qsvuvxzRvrXs60BIOWsWqpHC4gaJEF0Qa+OH6dMclM5c8idib/Fc8EcaBjPyF/I9HJ+2ftTx0esz0lv3xIS8= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DU0PR08MB7542.eurprd08.prod.outlook.com (2603:10a6:10:321::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 17:35:57 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::2ed5:dc23:2624:df0a]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::2ed5:dc23:2624:df0a%7]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 17:35:57 +0000 From: Wilco Dijkstra To: 'GNU C Library' Subject: [PATCH 1/2] Add random benchmark Thread-Topic: [PATCH 1/2] Add random benchmark Thread-Index: AQHaIiEHjU4OUjnMdEqIhF16l2VCYA== Date: Tue, 28 Nov 2023 17:35:57 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DU0PR08MB7542:EE_|AMS0EPF000001A5:EE_|AS8PR08MB9814:EE_ X-MS-Office365-Filtering-Correlation-Id: 63702f7d-d3d7-41ac-3f27-08dbf0388113 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XKQQmR5uAmIzwhuGEL6ko7i4+xByVyoNnaoDP7aF8Rg2+J50EUohmLaXTBj+lb/9FQq0RZT49omdjydxMXQfw6m9tnlFe4HwIIe9CAXoLutAByJNLmfPr0d2pHiPN5dwkPvW5pL2qFdhNLUvVON6EOT0iuiejgwcvCtcQBSS1GgI2MRHm7yqAw77/PDxTtCgTRKDfjHMSz/v/Z6/3VqTnkkTwGJu/fIjeDhM1kANig5pckc4XGqCAqMHc9H5O+Ky4hSvS4KJUDyyGZuwM622gs6JNyQSOwwezQlGQOeZnZH8VTeosHwSrgwPz2ZOLz7ifgRpLTFVQzJdb8JiBBQgUz0FTN6NM2zUcq1kwSpZT9Vzdh/oypjHLEu6EPSflU5Mkq8m2e+kYduJuIVyfg2SwNmiZNwT8jKpGnD5Hvc7vqmKB7gG0EqcVyJ/oiCNOuiNC/3VKkB5LZL3yrJl6uM1bMHgTvwgYu8Yd9/fb7TQm8u0KCB1ec9ZQ0sov1YKzwvZz6cEV8X71G5hsCQKpB97VYWJixVH3k6w4IiAqTiGAlUQKMWvFwVzSIy+kEtKlvHSjRQjy8pCsztNBGNmY+BogAEXxxYCeOU6Xu3/LqYU5iVyE8N4aZ1CTG7amMFdUnoB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(396003)(346002)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(83380400001)(38100700002)(122000001)(8936002)(71200400001)(6506007)(8676002)(55016003)(91956017)(7696005)(66946007)(64756008)(316002)(66476007)(66556008)(66446008)(6916009)(76116006)(5660300002)(52536014)(86362001)(9686003)(478600001)(2906002)(33656002)(38070700009)(41300700001)(26005)(2004002); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7542 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A5.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81d783c6-767c-4c69-2baa-08dbf0387b20 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZ+3jSHACvXE4BxqGfB7TQ4SSqlYZ4F+5HWcmbLsVRQw2H6B6hJgwycuwiwXmt6IhzY82V6igaX1bGTou8yLI7ORRaEL/yM37Sd8zoYdwhaXAlzieYZaUyad7ud8RiVj1lvquIWprnkUHgLgahnnC1cPqcdi2ni1aJjXIITXvP6YmZU4mo2zpByT4DQkfoBK/LaFUEKRITpCd70X73a7RsndqxnbAM3JB1EzumxGFAqaNOwE8SkvQ4iMyJOfKJ8xArZkVihZYXtpfd6q/nY3yD5RiRaBLEznlWbx2VFPp4bgFGrWjtPKQPwy/T5nieMcO/UfiHLT+5wixol/SepwhSdCBb1iokkWR8m2QNO2uKtzjtvZsPoeppYR7+s4lPd7shuD6jOfHRI/SJhhebKK29iiD/F3XzNtIglHKBjzLHwPJhBZyLmjGDvaiLtv1nf7p/HwBWaYxb4aPgswmtsXBYseSpYxnRkgpon32Z0wVxBoi2b4DKted1vkZmoxC9eYDBvZFIlA3m9xbxFqSKcFOimJmoBVpx7zkVfMMXKKT0uWfSsCimfBRdAIo68ZMQoDRZ5BC8Uup5vQ0Z3l1//fXplSZeSzpeVSc+uTXKVg5+yDYyAK2LB+GptRS2PqdMkpmIgqX91D5iy+DSr9PMQ6jsqOT4XEo7nQ4W8yixgTrFP2a/JOPlWAdS9jVIsKepI2lUXDVnGIlS/Sv2wCiIDejDiuBKqFizE45TxAhUOxpjNmhfWs/GVO6s4pnayQMr+z X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(39860400002)(376002)(136003)(230922051799003)(186009)(64100799003)(451199024)(82310400011)(1800799012)(46966006)(40470700004)(36840700001)(40460700003)(26005)(336012)(9686003)(5660300002)(8936002)(52536014)(55016003)(82740400003)(316002)(478600001)(70586007)(6916009)(70206006)(36860700001)(8676002)(83380400001)(86362001)(47076005)(356005)(81166007)(40480700001)(6506007)(2906002)(33656002)(7696005)(41300700001)(2004002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 17:36:07.6945 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63702f7d-d3d7-41ac-3f27-08dbf0388113 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A5.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9814 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Add a simple benchmark to measure the overhead of internal libc locks in the random() implementation on both single- and multi-threaded cases. diff --git a/benchtests/Makefile b/benchtests/Makefile index e1346bbda125be9fc2b216f9e8be3f2ee7cb0c4d..1415d20e25798871936f3e2b87f8690517239b21 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -247,6 +247,7 @@ hash-benchset := \ stdlib-benchset := \ arc4random \ strtod \ + random-lock \ # stdlib-benchset stdio-common-benchset := sprintf diff --git a/benchtests/bench-random-lock.c b/benchtests/bench-random-lock.c new file mode 100644 index 0000000000000000000000000000000000000000..ff11f807359c05043366c855751a97a383b1b132 --- /dev/null +++ b/benchtests/bench-random-lock.c @@ -0,0 +1,108 @@ +/* Benchmark internal libc locking functions used in random. + Copyright (C) 2022-2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define TEST_MAIN +#define TEST_NAME "random-lock" + +#include +#include +#include +#include "bench-timing.h" +#include "json-lib.h" + +/* Modern cores run 20M iterations in about 1 second. */ +#define NUM_ITERS 40000000 + +json_ctx_t json_ctx; + + +/* Measure the overhead of __libc_lock_lock and __libc_lock_unlock by + calling random (). */ +static void +bench_random_lock (size_t iters) +{ + timing_t start, stop, total; + + srandom (0); + + /* Warmup to reduce variations due to frequency scaling. */ + for (int i = 0; i < iters / 4; i++) + (void) random (); + + TIMING_NOW (start); + + for (int i = 0; i < iters; i++) + (void) random (); + + TIMING_NOW (stop); + + TIMING_DIFF (total, start, stop); + + json_element_double (&json_ctx, (double) total / (double) iters); +} + +static void * +thread_start (void *p) +{ + return p; +} + +int +do_bench (void) +{ + json_init (&json_ctx, 0, stdout); + + json_document_begin (&json_ctx); + + json_attr_string (&json_ctx, "timing_type", TIMING_TYPE); + json_attr_object_begin (&json_ctx, "functions"); + json_attr_object_begin (&json_ctx, "random"); + json_attr_string (&json_ctx, "bench-variant", "single-threaded"); + json_array_begin (&json_ctx, "results"); + + /* Run benchmark single threaded. */ + bench_random_lock (NUM_ITERS); + + json_array_end (&json_ctx); + json_attr_object_end (&json_ctx); + + json_attr_object_begin (&json_ctx, "random"); + json_attr_string (&json_ctx, "bench-variant", "multi-threaded"); + json_array_begin (&json_ctx, "results"); + + /* Start a short thread to force SINGLE_THREAD_P == false. This relies on + the runtime disabling single-threaded optimizations when multiple + threads are used, even after they finish. */ + + pthread_t t; + pthread_create (&t, NULL, thread_start, NULL); + pthread_join (t, NULL); + + /* Repeat benchmark with single-threaded optimizations disabled. */ + bench_random_lock (NUM_ITERS); + + json_array_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_document_end (&json_ctx); + return 0; +} + +#define TEST_FUNCTION do_bench () + +#include "../test-skeleton.c" From patchwork Tue Nov 28 17:37:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 80941 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FAA63870F2D for ; Tue, 28 Nov 2023 17:37:59 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by sourceware.org (Postfix) with ESMTPS id 81C88384CBBD for ; Tue, 28 Nov 2023 17:37:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81C88384CBBD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81C88384CBBD Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.50 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701193064; cv=pass; b=hjOWvVBICWwBdw+SNAXoHRC3pLIrK9N+bueqDPK1PnVjS/o/gkVxBMrI1VYwIm8uH8GtOuryy8V4+OA/RMXQ6oN2KPsgzldjVC5qE+qfTH+B0A0ov8LfFFBtrROfzLaVsmv9QvL6R5KNeJLGCflxsFCtdhplvKsuMo3JJVBiXRY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701193064; c=relaxed/simple; bh=Asl6iKoWojWrzGXjx8Kf4Rv43OJjg+mVnikSF1xRt+o=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=PDHwbmdFjLQbXlVvonPNhZ5Su0G0/0zN9fajlnFQ6MC5JQ4K3QuVzsQ+jfx+8QP2HYQzxuEuCWUgEgHlTisDEbGzVUKflDSlp1+FVjCpGuIyQdfz6BJVYniYgH6IHihWHy+wexLJsiBwkdHjF748Bwmx1rtFt9nBVgtS8r2lauw= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h2d/WrJZK5qj2j8pnLCB4ia/M7JAgNqLHGw9kFkTuDddn59uj+7bnMpb8EwlU6E50XwfEdAlrLtKp9IptDfqYeoe6HvnIWKgjqYohiWDDlGR+kgAdxMsnRMlG2pkW6PvjkW03OxwRC53ggPdqnvk6T+GkA0cssVMvUJXXiT6Qp2kiC6qCuweJMqLsyLCy9yuwkDWAruildEF6gqQGjje4NqWlEghiOkgg+Ee5fZWT1jQNIdOW3rVBKIbR71x25SqmO0/of7TIzhcZHlJT013yPlHm7EpV7D+N1c6rfU4ii7EOa3EOKvIeWGFm0RWR7MGLH9ENe5xhDRJGiTcuptK8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWnYwHuUhcriDncwr8/c/JmVE1ES8HFeW6Tj5cVjICs=; b=J2GtqF2XiGoxC8vLd4hkfa/shJ54DF6rpCvImno2Ie9JFUaB5okXKGrYeRxpf9ZJDbpIaUBiHjTilaWtvMLn3tdYC/z1aVnznjJjuN0SY2PRFypOtdTL558sLIAoAN0zkkp2yDpPtL7xkYCY2Cmzz07YILHKUrLqrdnh8nrIF8n6K4lmkjJSzf7ctE+12nVXayNpHvZAnNmTRz5i2AAQ6qT42V8fq4E8eAaBlEjqoF1JhxKA6QQf7Ard5odUAUoKgwyHhs7c2xkTL/duQCLxXd4Jace0KBjhfb1jKnVh8P3zIEdgKNKAP80rqmxIit2oPhfOH3jh5TtyCwkr4owImw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWnYwHuUhcriDncwr8/c/JmVE1ES8HFeW6Tj5cVjICs=; b=cQpNAeL7zDeKNAQiRbkKZ7ldFSVAvnQm7JV2yL1zOfuEcENiB1LvkSYSSC640B0fg1Oyqq47wKu7DHz4VJKenGkPDwNnZ/e16si8YtG6esYj/BLWeszgArh7WzsGKRRokxI0/mI0W+Q5ig3jviwNiIpxnNWNREEun06DQIz4buQ= Received: from AS4P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d2::6) by PAVPR08MB9649.eurprd08.prod.outlook.com (2603:10a6:102:310::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 17:37:37 +0000 Received: from AMS1EPF0000004C.eurprd04.prod.outlook.com (2603:10a6:20b:5d2:cafe::eb) by AS4P251CA0004.outlook.office365.com (2603:10a6:20b:5d2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Tue, 28 Nov 2023 17:37:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS1EPF0000004C.mail.protection.outlook.com (10.167.16.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Tue, 28 Nov 2023 17:37:37 +0000 Received: ("Tessian outbound 7671e7ddc218:v228"); Tue, 28 Nov 2023 17:37:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e216138df97364c5 X-CR-MTA-TID: 64aa7808 Received: from e64eb1d068d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 73E38CEC-2962-4826-A198-DD399EB92A30.1; Tue, 28 Nov 2023 17:37:31 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e64eb1d068d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Nov 2023 17:37:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BojJ44roK6HOOgrdQCfFdhD43TQxQU68XZ/kubUOZwi38pPaMrsVn6tN2Q/UlhYOiYSWm1v0bwWP+I9tQlatNBfkcPMYCzPIEXSnnHK9zV6gSi1rgetmbQ97YGlF6YBARsQ6VRGh1bstRupY9XxDQerjlXHJOwXqzxFK8WTfDClXlPeZ/yAHN0lc/X2W9YrYucxn6F1Nu0Q5R6oJtXJ7JGABCO3QnsYXT41t3T8DkSRfRZXZu2cVmW7EBRNXMhE5zG8wgIb9zUbf6kAu6HwzNHS6Swom2y4W4wOW2y3QL8AwusQf2GOKL/an+5dOfM7zXbwmLWuqPlAv6+cPhQCmUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWnYwHuUhcriDncwr8/c/JmVE1ES8HFeW6Tj5cVjICs=; b=HwpY2hsHHAZ67+0ClFaPyZ4FOFm3A7CcjTb99eSdJPLTEvBHHFX+aGDNhjzEP3yK58uvGLyM0ggdD99AEV5UWqQmg5SS6Zb/1WqG4bdvqnY6iAOvnHtck6X+w976cqRGRhgB3nyj2A/Ema9X8M+tsl9SnWNTQCB1GkHNIJ+Bj4ughnI4lvsl2tR0OgyZXx/v6z2vGNZCu6tpWPqIcy5o+Ep8ghvFBKLMKcORTii618KxxOiuOpWO2+I0YXIuG3g59UaMkcW0kQ7bDAxawKb+yuEbNktbqJ5e0f4EF/9cyCj4OmXgwdAvjZuJykakfjV/RrwQd5k71JVornoj09BCXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWnYwHuUhcriDncwr8/c/JmVE1ES8HFeW6Tj5cVjICs=; b=cQpNAeL7zDeKNAQiRbkKZ7ldFSVAvnQm7JV2yL1zOfuEcENiB1LvkSYSSC640B0fg1Oyqq47wKu7DHz4VJKenGkPDwNnZ/e16si8YtG6esYj/BLWeszgArh7WzsGKRRokxI0/mI0W+Q5ig3jviwNiIpxnNWNREEun06DQIz4buQ= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DU0PR08MB7542.eurprd08.prod.outlook.com (2603:10a6:10:321::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 17:37:29 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::2ed5:dc23:2624:df0a]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::2ed5:dc23:2624:df0a%7]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 17:37:29 +0000 From: Wilco Dijkstra To: 'GNU C Library' Subject: [PATCH 2/2] Add single-threaded fast path to rand() Thread-Topic: [PATCH 2/2] Add single-threaded fast path to rand() Thread-Index: AQHaIiFnWMUwJmyaEUeSScSZLqK6Bg== Date: Tue, 28 Nov 2023 17:37:29 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DU0PR08MB7542:EE_|AMS1EPF0000004C:EE_|PAVPR08MB9649:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f5db750-d5fe-42f9-655e-08dbf038b671 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fkclRIPK/XJg/IHRiit2qzCY2wwz3A7XCqXVcTW0o9ccsOK7sd0djjC8oL33eik042cm2qdP0dROpN6WSL2AsHqxesr4uZBvoq41xxzCcBn3p82oxLICbGcZuvd9vJZg43j8ttoBM8aCn+vtriyTbuL3OoRpPgKgv0gzuBwIcWPaMB2Un+XmpolGsO2cD0mkwt7poq11zita/XCzzprtZBD+A6Nu6rUI7HmPOk6VneAcmhEOa5byd9Kgt4D32bTFPp020y1rPff7qlcPmSvNKLTYKecqteXj/gbddtGOZzsla/hDPny5eE+K+VPk8JYNfLB/zajCZpJ9xMC+cHfmcHw2wq6ICpHSI/Vr2jpOeqLH5uBIjlXnNKsxsOtKsMtDCTDQl8gcATEmkPgLGkS2LljDN7fpoay54FYj5Mewwnh/ir8gsVWLSUEPr1WxuVerSU044ktF54KK/w9V/Hs610QmvXjYlShStcURdoq9e6rVRo3TFEMsmsd4aUq204KQ/9IryjpBhD8lTKux9yj6Vp6GMYOf5yvAPiaIcAfgxtKqZDgat35teLl2AxoByAESE0t9cXqJcvAkMcmK9N8bynfmstIfRejISujJuMQmivxlY9/ZF1aLsMzs6N7dEiYM X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(396003)(346002)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(83380400001)(38100700002)(122000001)(8936002)(71200400001)(6506007)(8676002)(55016003)(91956017)(7696005)(66946007)(64756008)(316002)(66476007)(66556008)(66446008)(6916009)(76116006)(5660300002)(52536014)(86362001)(9686003)(478600001)(2906002)(4744005)(33656002)(38070700009)(41300700001)(26005); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7542 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004C.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cce72bef-ebdb-435b-0c67-08dbf038b18b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +v8XurpIOB1EWdj2unEgd6w470FIllgBXQg1BP6pnd0A3XVOCCkmsxY2dq2jpaGRKS7IWZfqYTYMS+4Wzjv58UDMFpWEu7lQvGt/IM3n6L/aNDlmSfQ0ntaMmn/YCnGhLnIKI68TWyHpALeqkJiFg5rut+Kd8TQBnwT+A3PQEWuvX14UV2Yp6ZCSXj9pjzcl6aecCKjE0eg5eT3NbJAQaTtJghkQKdTjC1EYpZgqzX0PAczA0Ya3nb91EKMMDawRrSW515aUVrXYw5/RFngv97FbkVBnasXsOh04LfnXfDV2Kf1hksW+AurHtBzSHUuG1x3fJ6hzPdTO0haBa0f4UZ8t4iOUOFqpI6MxdmFq8/SM8LYaygEIULpHQQnPzzZSQK5mVQhR2Gxei1NC1apN8bFn8aEX2p8Aom1x0ETdp9tge/lKF9HqxMTGEPLBrrjRgLdBlTTZTfZxl9gmFzZaKP07720Bt7u3Oj2bInTGshgCyVWaXgGPMUAP98btseO/yhwOAf/hp6zv2LL0Gqh3v3HAdJYCIC2pq0AZaCjduqGJ1EyIH0RdpYKxt6KYTvyDVEtoNhzWcg/01IOuimbBojQGJBHHPwae2UK0oZZQG3sprhhrk4GCodN3osT+CF4EvUdJVbqgk7iEIkrcIweZQHGsHrXouGTaWFkE0xIHQFvNFaX3EnfTZ9rQHMOqteKOU6vMTRUUY7V6fw2gjf7sFwPqu4e7i/1c+ANY9vEnpJ8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(451199024)(64100799003)(186009)(82310400011)(1800799012)(40470700004)(46966006)(36840700001)(52536014)(8936002)(8676002)(9686003)(7696005)(6506007)(70206006)(70586007)(316002)(6916009)(40460700003)(478600001)(81166007)(356005)(47076005)(55016003)(4744005)(41300700001)(33656002)(36860700001)(86362001)(26005)(2906002)(40480700001)(83380400001)(336012)(82740400003)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 17:37:37.2151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5db750-d5fe-42f9-655e-08dbf038b671 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004C.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9649 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Improve performance of rand() and __random() by adding a single-threaded fast path. Bench-random-lock shows about 5x speedup on Neoverse V1. diff --git a/stdlib/random.c b/stdlib/random.c index 62f22fac8d58c7977f09c134bf80a797750da645..a22de60a0f96031c74dd5a949b6717c2b0fc321a 100644 --- a/stdlib/random.c +++ b/stdlib/random.c @@ -51,6 +51,7 @@ SUCH DAMAGE.*/ #include +#include #include #include #include @@ -288,6 +289,12 @@ __random (void) { int32_t retval; + if (SINGLE_THREAD_P) + { + (void) __random_r (&unsafe_state, &retval); + return retval; + } + __libc_lock_lock (lock); (void) __random_r (&unsafe_state, &retval);