From patchwork Tue Nov 14 17:38:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 79852 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E6D53858C42 for ; Tue, 14 Nov 2023 17:39:16 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id E86263858417 for ; Tue, 14 Nov 2023 17:39:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E86263858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E86263858417 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699983542; cv=none; b=Wevczw+n8hWCn8uJEVAcMqFEcoIbs12j1hbDnSI5djHxMDbXaqvaFl7Rn1KlAPod1K+JViUIwUgYIfOm1EcEdmAkKBiRSiqlGf6Qd5hwi4AJltbNP62Q9tuJnTtBa5KXiLw0mNG+kAGgg3R71ADEHEr6Uv8TT0WPl8EBokx9dts= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699983542; c=relaxed/simple; bh=oM/mbMKrX06U/XpxzoKkC++LXJpyfCIpXVpP46YBVXA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fAwImAJscDjxxQ8q0eCxfLRFnazQkDpP5Hqmgbgnw+Qv/VZOitLbTs4dPEyLSovyWWWEh2f3yj637B50czJjb6VF5NQk6+n/ti93ocDAKrjGFKyQD74/q0r66rnhst88ajsZyQm1mXr4KnorlkgeQ1O2iiGvSiSVa4OfurnzmGI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7a92727934eso231720339f.3 for ; Tue, 14 Nov 2023 09:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699983540; x=1700588340; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YQwyGWJ1+JAFA5Pyi3tVj/QAd62cmnXCabksk6JpGOs=; b=Tb1Ev5ikhVurnRtj+nxcbs25FPmOzYul28Cjwb3xR7ItPmqSSVcQou2K+k8VJKWxcr BAHFra9Bo345tETeH/BGkdTBPrLrPkYqKA6ljJFPlk4CEHS0VL19BkTkKcXpjBdUWXvv SmIqRVFBzlhiVII/v+X8rU2jN7JNzS+d7cng9dJ7JgkXV+CnbQEgcdXJGyFlZtY9eIa8 thl1n5O30D+DY47T+Ied6ihjcyEEok/gKemiaw27J8peE7+v4/KU4vJ0Mp6bKGaX1EPd h7KUwwYZNkVu3LIwK+MLra2mhNGzZXaCbfaXBb3Ju8CJAUlP/lX+waj2ZugA5mfBLGm4 vZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699983540; x=1700588340; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YQwyGWJ1+JAFA5Pyi3tVj/QAd62cmnXCabksk6JpGOs=; b=GLLNdEld8AbgH9NLWHt8A2rG4yWX61BbWTgVOm+9O97yjMbmoVsOvkqvEZWkz9WJhp MA6jm0/zjTzRty0kjZWWzfJbSJFYWdxfvNtcYeubw23IAfqUiH1yeV5Q6JRrXzsV7aaV fnEWq5CvmNLAgqHEKZH8lkMofZAK0i7brcpyDkV/Ae6BN7WwtjR6dMenG973w7juvz40 mSZ1r2Z6C/rm6tvC2vePYshKxG29MJxn3CvmqXwOiBhprCfbBZWE2HWRJZcshY2YN01e JB2KNlm+cr/mReX822pQzQqOBtPLK2mxQpB1WxUzf1XygWj8YgLmRx639ApVWzfS/x77 7EzA== X-Gm-Message-State: AOJu0YzvV+7azcuYBF/lXMNnI//UNhloYSzkqGh8MjZ9N1pEvo/whliy bhh95WcO21k083NO60jD8+EVXtYn3AXb6hVzWq255w== X-Google-Smtp-Source: AGHT+IHvhZTnUejcvioGZgayx8aWZVSOXSFcwMMNPSlFZuyHeNLTNE1yX0yf6vcdFiSwbR2P4GR/8g== X-Received: by 2002:a5e:c742:0:b0:787:ff98:c38c with SMTP id g2-20020a5ec742000000b00787ff98c38cmr13593846iop.10.1699983540156; Tue, 14 Nov 2023 09:39:00 -0800 (PST) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id z18-20020a6bc912000000b007a67b8e9e34sm560586iof.32.2023.11.14.09.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 09:38:59 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Remove some redundant "break"s Date: Tue, 14 Nov 2023 10:38:50 -0700 Message-ID: <20231114173850.3612313-1-tromey@adacore.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I found some "break" statements that follow "return" or a call to a noreturn function. These aren't needed, and the compiler would warn if they were. So, this patch removes them. Tested by rebuilding. --- gdb/breakpoint.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index fe09dbcbeee..a6b9b2402ed 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -4977,13 +4977,11 @@ print_bp_stop_message (bpstat *bs) case print_it_noop: /* Nothing should be printed for this bpstat entry. */ return PRINT_UNKNOWN; - break; case print_it_done: /* We still want to print the frame, but we already printed the relevant messages. */ return PRINT_SRC_AND_LOC; - break; case print_it_normal: { @@ -4997,11 +4995,9 @@ print_bp_stop_message (bpstat *bs) /* Normal case. Call the breakpoint's print_it method. */ return b->print_it (bs); } - break; default: internal_error (_("print_bp_stop_message: unrecognized enum value")); - break; } }