From patchwork Fri Aug 20 13:51:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44722 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56120386FC0B for ; Fri, 20 Aug 2021 13:52:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56120386FC0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629467539; bh=Owd1qqLOLvagUvNDO2sn83hV0ZI6zPHlhwf7Jw4FJVM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=TMRQT6rIhyJVSp+Ljqxnau53RE0aSWDK3FgnivQR9g3VnzvCuVF6EGrP9H0gupHUD 2kAtFI5yI1YUzF7PgH47bI2OELzm+xc7tVhl1yjKk+469Z1y0s5g9YpxDAkH7Gx6C3 xt/SlX5dAXSkmGWFPFPBOvZrIR7okiiFl3uJUKWc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 30E03385783D for ; Fri, 20 Aug 2021 13:51:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30E03385783D Received: by mail-pj1-x1030.google.com with SMTP id mw10-20020a17090b4d0a00b0017b59213831so1988843pjb.0 for ; Fri, 20 Aug 2021 06:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Owd1qqLOLvagUvNDO2sn83hV0ZI6zPHlhwf7Jw4FJVM=; b=dzPbUZv/wWsDHOV/QTgr0iAhepS591vm+auS4gV5qI5v8KKuQgcYiYcJWHJINsBhrd gze3UGURslj1eEuviaUIX6ix9aJiNwm5B7CHx0oGYNsHQnOp1MZBinRoHvdnG1pPpdAU trjVEo34e4cLnPFkGs/0l88P9ER4pG60XOkm9vEIhhvN9tJOpvgaajjqxdSUpf2DhJ0l OD0biK3YluoJlDufbdeLOWgARgVC0weM9zsS7dNn2/Dg7Y/7n+Z+6czr66MOl0rhauK6 x/TUqyUtiPBCsHW0h7Jlu8yfquJSXXszxjEv04CWiPf/hZMRb9/f4ipauwAgE1JqnsOE NYdw== X-Gm-Message-State: AOAM532GL3wFfAryINHVrxn0QXdBja3e7uRufoAU2GPYS9YLBJtsVSM6 k78ZYICn3R9AuRwVyCGdtpa4po18Tgw= X-Google-Smtp-Source: ABdhPJxjOOQK61RW43ovgHFv/3f9+TIye3/SyaRTEkQgbtBaL+XliZcXt8oaQR72xEdkVTKTDk5VOg== X-Received: by 2002:a17:902:bd07:b029:12c:f4d5:fc6b with SMTP id p7-20020a170902bd07b029012cf4d5fc6bmr16587787pls.31.1629467507098; Fri, 20 Aug 2021 06:51:47 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id w145sm7129242pfc.169.2021.08.20.06.51.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 06:51:46 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 77CC6C02C6 for ; Fri, 20 Aug 2021 06:51:45 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] x86-64: Remove compiler -mavx512f check Date: Fri, 20 Aug 2021 06:51:45 -0700 Message-Id: <20210820135145.49237-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The minimum GCC requirement is GCC 6.2 which supports -mavx512f. Remove compiler -mavx512f check. Tested with GCC 6.4.1 on Linux/x86-64. --- config.h.in | 3 --- sysdeps/x86_64/Makefile | 2 -- sysdeps/x86_64/configure | 26 -------------------------- sysdeps/x86_64/configure.ac | 9 --------- sysdeps/x86_64/fpu/Makefile | 2 -- 5 files changed, 42 deletions(-) diff --git a/config.h.in b/config.h.in index 0d92504f65..3752f9a6f7 100644 --- a/config.h.in +++ b/config.h.in @@ -62,9 +62,6 @@ /* Define if _rtld_local structure should be forced into .sdata section. */ #undef HAVE_SDATA_SECTION -/* Define if compiler supports AVX512. */ -#undef HAVE_AVX512_SUPPORT - /* Define if assembler supports AVX512DQ. */ #undef HAVE_AVX512DQ_ASM_SUPPORT diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 22c5b63ab5..7a4b576356 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -134,14 +134,12 @@ CFLAGS-tst-auditmod6c.c += $(AVX-CFLAGS) CFLAGS-tst-auditmod7b.c += $(AVX-CFLAGS) CFLAGS-tst-avx-aux.c += $(AVX-CFLAGS) CFLAGS-tst-avxmod.c += $(AVX-CFLAGS) -ifeq (yes,$(config-cflags-avx512)) AVX512-CFLAGS = -mavx512f CFLAGS-tst-audit10-aux.c += $(AVX512-CFLAGS) CFLAGS-tst-auditmod10a.c += $(AVX512-CFLAGS) CFLAGS-tst-auditmod10b.c += $(AVX512-CFLAGS) CFLAGS-tst-avx512-aux.c += $(AVX512-CFLAGS) CFLAGS-tst-avx512mod.c += $(AVX512-CFLAGS) -endif $(objpfx)tst-glibc-hwcaps: $(objpfx)libmarkermod2-1.so \ $(objpfx)libmarkermod3-1.so $(objpfx)libmarkermod4-1.so diff --git a/sysdeps/x86_64/configure b/sysdeps/x86_64/configure index 75c96d60d4..d81accdc07 100755 --- a/sysdeps/x86_64/configure +++ b/sysdeps/x86_64/configure @@ -28,32 +28,6 @@ if test $libc_cv_asm_avx512dq = yes; then fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for AVX512 support" >&5 -$as_echo_n "checking for AVX512 support... " >&6; } -if ${libc_cv_cc_avx512+:} false; then : - $as_echo_n "(cached) " >&6 -else - if { ac_try='${CC-cc} -mavx512f -xc /dev/null -S -o /dev/null' - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; }; then : - libc_cv_cc_avx512=$libc_cv_asm_avx512dq -else - libc_cv_cc_avx512=no -fi - -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_cc_avx512" >&5 -$as_echo "$libc_cv_cc_avx512" >&6; } -if test $libc_cv_cc_avx512 = yes; then - $as_echo "#define HAVE_AVX512_SUPPORT 1" >>confdefs.h - -fi -config_vars="$config_vars -config-cflags-avx512 = $libc_cv_cc_avx512" - { $as_echo "$as_me:${as_lineno-$LINENO}: checking -mprefer-vector-width=128" >&5 $as_echo_n "checking -mprefer-vector-width=128... " >&6; } if ${libc_cv_cc_mprefer_vector_width+:} false; then : diff --git a/sysdeps/x86_64/configure.ac b/sysdeps/x86_64/configure.ac index 66219e7ce5..41baed6999 100644 --- a/sysdeps/x86_64/configure.ac +++ b/sysdeps/x86_64/configure.ac @@ -16,15 +16,6 @@ if test $libc_cv_asm_avx512dq = yes; then AC_DEFINE(HAVE_AVX512DQ_ASM_SUPPORT) fi -dnl Check if -mavx512f works. -AC_CACHE_CHECK(for AVX512 support, libc_cv_cc_avx512, [dnl -LIBC_TRY_CC_OPTION([-mavx512f], [libc_cv_cc_avx512=$libc_cv_asm_avx512dq], [libc_cv_cc_avx512=no]) -]) -if test $libc_cv_cc_avx512 = yes; then - AC_DEFINE(HAVE_AVX512_SUPPORT) -fi -LIBC_CONFIG_VAR([config-cflags-avx512], [$libc_cv_cc_avx512]) - dnl Check if -mprefer-vector-width=128 works. AC_CACHE_CHECK(-mprefer-vector-width=128, libc_cv_cc_mprefer_vector_width, [dnl LIBC_TRY_CC_OPTION([-mprefer-vector-width=128], diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile index 9a4bdd075c..1b4406380d 100644 --- a/sysdeps/x86_64/fpu/Makefile +++ b/sysdeps/x86_64/fpu/Makefile @@ -68,7 +68,6 @@ $(objpfx)test-float-libmvec-sincosf-avx2: \ $(objpfx)test-float-libmvec-sincosf-avx2.o \ $(objpfx)test-float-libmvec-sincosf-avx2-main.o $(libmvec) -ifeq (yes,$(config-cflags-avx512)) libmvec-tests += double-vlen8 float-vlen16 tests += test-double-libmvec-sincos-avx512 \ test-float-libmvec-sincosf-avx512 @@ -84,7 +83,6 @@ $(objpfx)test-double-libmvec-sincos-avx512: \ $(objpfx)test-float-libmvec-sincosf-avx512: \ $(objpfx)test-float-libmvec-sincosf-avx512.o \ $(objpfx)test-float-libmvec-sincosf-avx512-main.o $(libmvec) -endif double-vlen2-funcs = cos exp log pow sin sincos double-vlen4-funcs = cos exp log pow sin sincos