From patchwork Mon Oct 16 12:59:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Metzger, Markus T" X-Patchwork-Id: 77884 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D2063857026 for ; Mon, 16 Oct 2023 12:59:57 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id BEF523858D37 for ; Mon, 16 Oct 2023 12:59:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEF523858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEF523858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=134.134.136.126 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697461183; cv=none; b=lZqObSqJw/eyj1mCjD3fZe0mAJwEJ4pinZBqu6mMrz1Vtv+uUBh8h3lIvUFYcOxCpJ5hQmd1zCTQvlCFkQp537hFi+jNkFTmuNFnYY18FQS6BibKue/nsCDktMezqhUPr4NEFmkRDB8KK4x91vobsSzbir7eYmm00dd0hFO+nkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697461183; c=relaxed/simple; bh=TDw4aLHVIZbErK9p798//Na7MLpMUAqWEwS/94imV3g=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=hMtCPqKQ2mT1+UBioMLZxphPdx+s6A8gkWsnKgPyFWyOvnmXMonTKx35DtrqfI6gwKxkSeMdET3tNysg5BPKPtn2OUV6Pr7mB/MpzR6rRhIPKo9rgD2+hPBedDbBuyA2jFm4Q0lU61kMs7UyjPenFvNxJ9cXDQBnduNq0zfsOqk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697461178; x=1728997178; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=TDw4aLHVIZbErK9p798//Na7MLpMUAqWEwS/94imV3g=; b=WgHMoG6aKZm9mXpBcmgCO2WdZvBmG28jAE3VDUkyIEpPkeC7ogBllCv0 w9PODe9wCohWZhXjQYxzTfwOjn1Tf1JoKZW4auUcw1OKzMoCfOt3oBrwf FpsBCZbbOlefk33RDm8BCFc8RTTLkXchOMvn/MT8LgbhLc3Zew1Mx7P6b stf4cSR/gqfIJcdEeVRhoi22LgnIIbjj8rbPj+nmHEOmTyAFEn8nF2vXY MUBaxtYpffG1wNQQ2BZmzqULOsSD6WbR5P/WCwUCe9zPkXRxsCnc8/c4U Sc61IrUJ1HrkPV8dfF/BicsdC1iwO31fRjs3h97Uw5ZuRJF+GZXo/3eDP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="370592799" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="370592799" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 05:59:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="826003018" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="826003018" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 05:59:36 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Subject: [PATCH] gdb: include the end address in in-memory bfd filenames Date: Mon, 16 Oct 2023 12:59:28 +0000 Message-Id: <20231016125928.3268165-1-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Commit 66984afd29e gdb: include the base address in in-memory bfd filenames added the base address to in-memory bfd filenames. Also add the end address to allow dumping the in-memory bfd using the 'dump memory' command. --- gdb/gdb_bfd.c | 7 ++++--- gdb/testsuite/gdb.base/jit-bfd-name.exp | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 217753cf914..56a4c5ecc91 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -227,8 +227,9 @@ struct target_buffer : public gdb_bfd_iovec_base target_buffer (CORE_ADDR base, ULONGEST size) : m_base (base), m_size (size), - m_filename (xstrprintf ("", - core_addr_to_string_nz (m_base))) + m_filename (xstrprintf ("", + core_addr_to_string_nz (m_base), + core_addr_to_string_nz (m_base + m_size))) { } @@ -241,7 +242,7 @@ struct target_buffer : public gdb_bfd_iovec_base { return m_base; } /* Return a generated filename for the in-memory BFD file. The generated - name will include the M_BASE value. */ + name will include the begin and end address of the in-memory file. */ const char *filename () const { return m_filename.get (); } diff --git a/gdb/testsuite/gdb.base/jit-bfd-name.exp b/gdb/testsuite/gdb.base/jit-bfd-name.exp index 80f06269524..f97f42f66f2 100644 --- a/gdb/testsuite/gdb.base/jit-bfd-name.exp +++ b/gdb/testsuite/gdb.base/jit-bfd-name.exp @@ -102,7 +102,7 @@ gdb_test_multiple "maint info symtabs" "" { -re "^\\\}\\s*\r\n" { exp_continue } - -re "^\\\{ objfile \\s+\[^\r\n\]+\r\n" { + -re "^\\\{ objfile \\s+\[^\r\n\]+\r\n" { lappend bfd_name_addrs $expect_out(1,string) exp_continue }