From patchwork Tue Oct 3 09:41:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 77007 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 049673858C5E for ; Tue, 3 Oct 2023 09:41:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 049673858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696326104; bh=wCN4GNXhBiwiL2cqdy4hyWmPPHusiU0ble0MazhyQ/U=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=PMBUJm6eWCJgeg0ctgU2vo2Bu9omv0U4fA/9itjBTft9yroCaLCwh/k6oLPmd6URt VJSGfqSXWCC2jdjR7ygLjLADweybC2sOtlGmuyQH927JSyFOon4WWjeVnxKWPUpngv STLmr0iZwHhxBlomWIHnGwNuh1NkGhBObjvvs7J0= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E89453858D28 for ; Tue, 3 Oct 2023 09:41:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E89453858D28 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-Kr8wD3x7OeWUiGJWLjOtlA-1; Tue, 03 Oct 2023 05:41:35 -0400 X-MC-Unique: Kr8wD3x7OeWUiGJWLjOtlA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-65b0d19bfd0so8839026d6.1 for ; Tue, 03 Oct 2023 02:41:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696326094; x=1696930894; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCN4GNXhBiwiL2cqdy4hyWmPPHusiU0ble0MazhyQ/U=; b=RIE2LK9VVhVawMpG3/yZORlHeIXPRc8tKvMa6H7Zm1HBEsFQhxDU6vsrUFr091kbT9 zGx+apc/o/HNGchjXQnG4NvlQ9O2YtDWRMElK2QB3nSSL/BsuK4tK6A7Lr2EZjS6F2AG 75n5EXd2lcsddyptUlAhuc1VMeuqSm0YnDwkzVnosYl+ck9HJbXCNp/fbCI3KhrNeaW8 lSs7P0VZB4fgLvK5moK1VJwUNY/mxBoCLNBQvjq1F6IuHK8OriapuL9G6k2hqpKDI/MH zUmBlbt5SCMV7r/6JEgrn2zHElwF1R/WDup158qhr07RUOnPv0pMiH7HFfANwNOzwJD5 nkEg== X-Gm-Message-State: AOJu0YyG16oXDy0bLdWryABI+xh8mMsPL1wDF4fI1kEo39B8ELYpO8AL 92gNcNbIdjjl7z2gnfkX/dfyEh1Xie88mnuom1dsRg2qbtaxKdM02EJWOt44eQvoO2LIh2FuUOp xi2jmjq82cLPjByvbtHN2lY6ugN4oC8HvDWblYqthrhByy8vq0/IKAiRKQPf0K5lkReHZs3MnNW Ph X-Received: by 2002:a05:6214:5709:b0:655:d870:7306 with SMTP id qn9-20020a056214570900b00655d8707306mr16332343qvb.25.1696326094459; Tue, 03 Oct 2023 02:41:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdGfKBUjyzIK3T4Pi2KEqJUL5P3aKutpIBhgGJT8qjEv9qezN5kLHg1Kx+o9SD2BF6osI9GQ== X-Received: by 2002:a05:6214:5709:b0:655:d870:7306 with SMTP id qn9-20020a056214570900b00655d8707306mr16332330qvb.25.1696326094106; Tue, 03 Oct 2023 02:41:34 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id x8-20020a0ce0c8000000b0065cfec43097sm334617qvk.39.2023.10.03.02.41.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:41:33 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 41D08B6E87; Tue, 3 Oct 2023 11:41:32 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] comparison: Always apply filters on the diff graph Organization: Red Hat / France X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Tue, 03 Oct 2023 11:41:32 +0200 Message-ID: <87a5t0gi0j.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, When looking at something else, I noticed that diff_context::maybe_apply_filters doesn't apply the filters (i.e, the various passes) on the diff graph if all the categories of changes are allowed, typically when --harmless is passed to abidiff. This is wrong because even if all the categories are allowed, the changes carried by nodes of the diff graph should still be categorized. This was an early optimization dating back from the times where the filtering was slow. * src/abg-comparison.cc (diff_context::maybe_apply_filters): Do not get out when all the categories of diff changes are allowed. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-comparison.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc index 71710338..1cfc0952 100644 --- a/src/abg-comparison.cc +++ b/src/abg-comparison.cc @@ -1380,9 +1380,6 @@ diff_context::maybe_apply_filters(diff_sptr diff) if (!diff) return; - if (get_allowed_category() == EVERYTHING_CATEGORY) - return; - if (!diff->has_changes()) return;