From patchwork Tue Mar 23 14:35:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 42759 X-Patchwork-Delegate: azanella@linux.vnet.ibm.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6662E385BF9E; Tue, 23 Mar 2021 14:35:32 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 82679385701F for ; Tue, 23 Mar 2021 14:35:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 82679385701F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lukma@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F4YnB5WV4z1qs11; Tue, 23 Mar 2021 15:35:26 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F4YnB4gKsz1qsY7; Tue, 23 Mar 2021 15:35:26 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 4wXMCvVH0nHG; Tue, 23 Mar 2021 15:35:24 +0100 (CET) X-Auth-Info: TNyO+2oZPgctuSo+WPRhy9HukSbmLaEjqv0EJZn5nV0= Received: from localhost.localdomain (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 23 Mar 2021 15:35:24 +0100 (CET) From: Lukasz Majewski To: Joseph Myers , Adhemerval Zanella Subject: [PATCH v2] tst: Provide test for getrusage Date: Tue, 23 Mar 2021 15:35:09 +0100 Message-Id: <20210323143509.11810-1-lukma@denx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , GNU C Library Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This commit adds test to check if getrusage works correctly. As the first check - if the wrong 'who' parameter causes errno set to EINVAL. Next for the ru_{us}time.tv_usec fields it is checked if they are in microseconds range. The last check is to perform busy wait loop for 10ms and afterwards assess if ru_{us}time.tv_sec are not smaller than values read on the test start. Changes for v2: - Add check for EINVAL return value - Check if getrusage ru_{su}time.tv_usec are in correct microseconds range - Busy wait for 10ms and then compare getrusage system and user times (in seconds) if they are equal or larger than previous ones --- resource/Makefile | 2 +- resource/tst-getrusage.c | 67 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 resource/tst-getrusage.c diff --git a/resource/Makefile b/resource/Makefile index bd9e716749..e236df3d7c 100644 --- a/resource/Makefile +++ b/resource/Makefile @@ -25,6 +25,6 @@ headers := sys/resource.h bits/resource.h sys/vlimit.h \ routines := getrlimit setrlimit getrlimit64 setrlimit64 getrusage ulimit \ vlimit vtimes getpriority setpriority nice -tests = tst-getrlimit bug-ulimit1 +tests = tst-getrlimit bug-ulimit1 tst-getrusage include ../Rules diff --git a/resource/tst-getrusage.c b/resource/tst-getrusage.c new file mode 100644 index 0000000000..da721b0613 --- /dev/null +++ b/resource/tst-getrusage.c @@ -0,0 +1,67 @@ +/* Test for getrusage. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include + +static int +do_test (void) +{ + struct timespec tv_then, tv_now, r; + struct rusage ru, ru_then; + int ret; + + /* Check for invalid 'who' parameter. */ + ret = getrusage (-100, &ru); + if (! (ret == -1 && errno == EINVAL)) + FAIL_EXIT1 ("getrusage failed - EINVAL expected\n"); + + /* Check if ru_stime.tv_usec and ru_utime.tv_usec are correct. */ + ret = getrusage (RUSAGE_SELF, &ru_then); + if (ret == -1) + FAIL_EXIT1 ("getrusage failed: %m\n"); + + TEST_VERIFY (ru_then.ru_utime.tv_usec >= 0); + TEST_VERIFY (ru_then.ru_utime.tv_usec < 1000000); + + TEST_VERIFY (ru_then.ru_stime.tv_usec >= 0); + TEST_VERIFY (ru_then.ru_stime.tv_usec < 1000000); + + tv_then = xclock_now (CLOCK_REALTIME); + /* Busy wait for 10 miliseconds. */ + do + { + tv_now = xclock_now (CLOCK_REALTIME); + r = timespec_sub (tv_now, tv_then); + } + while (r.tv_nsec <= 10000000); + + ret = getrusage (RUSAGE_SELF, &ru); + if (ret == -1) + FAIL_EXIT1 ("getrusage failed: %m\n"); + + TEST_VERIFY (ru.ru_utime.tv_sec >= ru_then.ru_utime.tv_sec); + TEST_VERIFY (ru.ru_stime.tv_sec >= ru_then.ru_stime.tv_sec); + + return 0; +} + +#include