From patchwork Wed Feb 3 21:52:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Colomar X-Patchwork-Id: 41937 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7CE839DC4C4; Wed, 3 Feb 2021 22:05:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7CE839DC4C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612389939; bh=jQrGB0KLmwesqmY6ile7AdH+RI87jH2kiJYqFu8Nhc0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=hOfhSAM7PUtlqNGRomm1vuGOahtSXjF5H+nyOUssci+TLD+c2nQiVb+HBbEHR4KlD VbBhX4KcpIogfdkJzg9xXI8G1cuUkCoNFilQ0GTn3LcG3F03h8CsldumwnnV18+kpO C5Ed8pMOKgWbNKfPgUHFWHWJ43wsYmNsSH0dkiio= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 5EF3C39DA53E for ; Wed, 3 Feb 2021 22:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5EF3C39DA53E Received: by mail-wr1-x434.google.com with SMTP id q7so1007390wre.13 for ; Wed, 03 Feb 2021 14:05:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jQrGB0KLmwesqmY6ile7AdH+RI87jH2kiJYqFu8Nhc0=; b=aPDPWxV9r/8LVQWWeSuyXcYQxERwsKgwRGUTmSBOjEIKzp8G4wqGoZauZHGCUCIi04 D5P/aBh5im/sDVAQMQv4MjB87MOukarIRumOchk6MYI5kYLUtTWzZsvJlvLKo92hBRw9 0b/CAP1vbPZv7tTrEOMCJ306H0VPvfF7D6BN1eubDo7R965x1vZTanFUpsb8F5Q3G1XQ gVxZ2TQqG/9fzhviJYMQkH0jovNT8HzrE6MiccgfcYuE09A8wev9GeXnTx4btPGf9+tL CJmmizca+yjoZWD0d8fHawdShRTpm6SZkj8ZxEb+HjNl558LhLgjef39/cqeLSVkyCRy Sa3w== X-Gm-Message-State: AOAM530veGC99yhgqRpp0D6iGHnr0CIbDAjkryZGhWUDnJn+2rUwJkzO y+G8/LqM+HxAM2QH8cImvdEGqwzqez4= X-Google-Smtp-Source: ABdhPJyHHlyQrCPLP56Ieqe1RQB/0ZGufEEyo7PzQVVuJdb9CCNwMKirlgFI4saJklfb/NlIVNlh7Q== X-Received: by 2002:a05:6000:1252:: with SMTP id j18mr5723585wrx.232.1612389936461; Wed, 03 Feb 2021 14:05:36 -0800 (PST) Received: from debian.vlc ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id f14sm4096842wmc.32.2021.02.03.14.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 14:05:35 -0800 (PST) To: mtk.manpages@gmail.com Subject: [PATCH] gettimeofday.2: Use restrict in prototypes Date: Wed, 3 Feb 2021 22:52:06 +0100 Message-Id: <20210203215206.170532-1-alx.manpages@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alejandro Colomar via Libc-alpha From: Alejandro Colomar Reply-To: Alejandro Colomar Cc: Alejandro Colomar , linux-man@vger.kernel.org, libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" POSIX specifies that the parameters of gettimeofday() shall be 'restrict'. Glibc uses 'restrict' too. Let's use it here too. ...... .../glibc$ grep_syscall_wrapper gettimeofday time/sys/time.h:66: extern int gettimeofday (struct timeval *__restrict __tv, void *__restrict __tz) __THROW __nonnull ((1)); .../glibc$ function grep_syscall_wrapper() { if ! [ -v 1 ]; then >&2 echo "Usage: ${FUNCNAME[0]} "; return ${EX_USAGE}; fi find * -type f \ |grep '\.h$' \ |sort -V \ |xargs pcregrep -Mn \ "(?s)^[^\s#][\w\s]+\s+\**${1}\s*\([\w\s()[\]*,]*?(...)?\)[\w\s()]*;" \ |sed -E 's/^[^:]+:[0-9]+:/&\n/'; } Signed-off-by: Alejandro Colomar --- Hi Michael, Actually, both POSIX and Glibc specify the 2nd parameter of gettimeofday() to be 'void *restrict' and not 'struct timezone *restrict'. However, I didn't fix that for now. You may want to have a look at that. Cheers, Alex man2/gettimeofday.2 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/man2/gettimeofday.2 b/man2/gettimeofday.2 index 085b86ad0..7e2726ed9 100644 --- a/man2/gettimeofday.2 +++ b/man2/gettimeofday.2 @@ -44,9 +44,10 @@ gettimeofday, settimeofday \- get / set time .nf .B #include .PP -.BI "int gettimeofday(struct timeval *" tv ", struct timezone *" tz ); -.BI "int settimeofday(const struct timeval *" tv \ -", const struct timezone *" tz ); +.BI "int gettimeofday(struct timeval *restrict " tv , +.BI " struct timezone *restrict " tz ); +.BI "int settimeofday(const struct timeval *" tv , +.BI " const struct timezone *" tz ); .fi .PP .RS -4