From patchwork Mon Jan 16 09:11:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 63250 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B21CB3858C53 for ; Mon, 16 Jan 2023 16:28:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B21CB3858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673886506; bh=HiSvrdnqP2MfelRJNt/4BRZHV5Qh2v51BjcYV9a3Qj0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Help:List-Subscribe:From:Reply-To:From; b=cdwwzkFI3F+xrtEZJIM2C0yjn5Iav18ML4mu5EPQ29tqj7B5ebVIDR+t+op0LAxnb hoKjpOJuOJn/ANNML9ty57ayuHM+y1eg4hs+eBQUoFG6zVIOgs3GFX/2duIj64KPDw cCbZxe5SQr01EGjC3gyohQFUvq9/E+RFXuEZO0Ns= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 055B73858D32 for ; Mon, 16 Jan 2023 16:28:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 055B73858D32 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-164-VLYordvUPAi45vXcc8JqyQ-1; Mon, 16 Jan 2023 11:28:19 -0500 X-MC-Unique: VLYordvUPAi45vXcc8JqyQ-1 Received: by mail-qt1-f197.google.com with SMTP id ez10-20020a05622a4c8a00b003ab6c16856fso13110886qtb.17 for ; Mon, 16 Jan 2023 08:28:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HiSvrdnqP2MfelRJNt/4BRZHV5Qh2v51BjcYV9a3Qj0=; b=KX6sMaQfALVtEFRV9dITol3PXc65jCKE+hquUNzWrffVuZ77dyxi9Pnc62sBmgFb3n jNu5s8KzIns/KrxO95qcKJmGeHnZe6uZZRNUud764TwevsGc9u1aVo+FlgzOLQZi1hSZ uyaEXq5xijakbDSNq7f+2CIMF7uWTQNIPRMz02QQQm/OSlOofauJeV5BIjZA3BHhm1rn LAPRavou4kEyYDLdxc/ycsoUMQ9vt8Pw7EZbnQcSIRXcWEOjmXXcU8BYcYNIZ457yJW0 k0Dh7Ue8iEr/dMZ1B5f0lBb7vBjV7ePVMnzeEz3p2Rs5ztWzcD/Yb3CFAqZgGPxj6b88 zU6Q== X-Gm-Message-State: AFqh2koi1kyvB2wzu8im9UTyjwgCtOY8/JxSkNh5tiKHy2/Z3J2cOZNz cQqbkKnRN/veQWI257kegTIINBnPdsnGtIJBdYg50s34Pwc8u44U4+jFlXTjtsA1Ll/vX/W0C9r hcK1Pp/9/hSPYLYSGoRCN X-Received: by 2002:a05:622a:1e8c:b0:3ad:14d0:e8b8 with SMTP id bz12-20020a05622a1e8c00b003ad14d0e8b8mr44888257qtb.26.1673886498994; Mon, 16 Jan 2023 08:28:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXshZDqm1P4bdo5sGWD2ynoi+Bhxw/5VpHxJF/tysWNO+keTpEkeIPbt3LzrBdnv43S0YDhXkQ== X-Received: by 2002:a05:622a:1e8c:b0:3ad:14d0:e8b8 with SMTP id bz12-20020a05622a1e8c00b003ad14d0e8b8mr44888239qtb.26.1673886498745; Mon, 16 Jan 2023 08:28:18 -0800 (PST) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id x14-20020ac86b4e000000b003a816011d51sm14729087qts.38.2023.01.16.08.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 08:28:18 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id E3050B507F; Mon, 16 Jan 2023 10:11:08 +0100 (CET) To: "Guillermo E. Martinez" Cc: libabigail@sourceware.org Subject: [PATCH, request-for-review] Update CTF's ctf_dict_t detection Organization: Red Hat / France X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Mon, 16 Jan 2023 10:11:08 +0100 Message-ID: <87mt6ivo7n.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, As ctf_dict_t can be an opaque type depending on the version of ctf-api.h, using AC_CHECK_TYPE won't work to detect it because that macro invokes sizeof(ctf_dict_t). With this change, we don't require that ctf_dict_t be fully defined. * configure.ac: Use AC_COMPILE_IFELSE to try and compile a code snippet that doesn't need that ctf_dict_t be fully defined. Would this be OK to commit? Thanks. Signed-off-by: Dodji Seketeli --- configure.ac | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d19c2f96..4d214b1c 100644 --- a/configure.ac +++ b/configure.ac @@ -334,11 +334,12 @@ if test x$ENABLE_CTF != xno; then fi if test x$LIBCTF = xyes; then - dnl Test if struct btf_enum64 is present. - AC_CHECK_TYPE([struct ctf_dict_t], - [HAVE_CTF_DICT_T=yes], - [HAVE_CTF_DICT_T=no], - [#include ]) + dnl Test if struct struct ctf_dict_t is present. + AC_LANG(C++) + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[#include + ctf_dict_t* c;]])], + [HAVE_CTF_DICT_T=yes], + [HAVE_CTF_DICT_T=no]) if test x$HAVE_CTF_DICT_T = xyes; then AC_DEFINE([HAVE_CTF_DICT_T], 1, [struct ctf_dict_t is present])