From patchwork Sun Dec 13 14:51:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 41372 X-Patchwork-Delegate: carlos@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46ECD3851C1F; Sun, 13 Dec 2020 14:51:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46ECD3851C1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607871111; bh=PwmMv8/2+/6vNJs7gAN1kdoqytfv3kqVyJ5EyJigL+g=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cfwMtY/2+MaAkm/2F+acTuY9a7vu5tUCYM22bUH/GeGkCbL6LWHK/LaQCirnPstcI dcGk56iGca62AGlUQcY3IAKP1ID3xoFJHjvXhFjWLUep80ssFwVxHUhSyUC+Qrvzjc GG2xC4Jhcy7u1yJ86Q1D0MdjTQYuwSYf00zkjNn0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id AD4DB385800E for ; Sun, 13 Dec 2020 14:51:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD4DB385800E Received: by mail-pl1-x62d.google.com with SMTP id v3so7234763plz.13 for ; Sun, 13 Dec 2020 06:51:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=PwmMv8/2+/6vNJs7gAN1kdoqytfv3kqVyJ5EyJigL+g=; b=t96Cfo+hK3FFNQQuu/Q9YMbtUoJGig+Fq1HIVVGRkg53tAXPM11X88nWButHzqp2Rj UZ6dtd2n5X0DnQp9KcC8TG32wIkou21H9DixUicDz96PpQFnN3tGIXMwg66ukcH72z50 FjmSoGI9cYylQ1MITMdI0sP31TAItoHTQSBu1PQfKhOfDx75yR+KPH1ujzBiZ/nJnkIB RXiy4ZiW/iq0QEwlwgGKRPA+CQQHkG/67O5K/vCwEAxwx+s3ei1ZlmzHC/6YnVtJuROz +sfUVHzlPFXIlCPUsIIr4Uy0loWoFcml+/ZWLvPeqn7i4QXPsEPHa5I3YunpReDxS3qd xvGA== X-Gm-Message-State: AOAM530DVnqH/mfFDbIRSy8FRZGSS83jGIk09Vu9cztqD+0X0VF12rrj vtjmrJeKYcFnfQnyts+0W4mSFaRER6s= X-Google-Smtp-Source: ABdhPJxlpNKoUrzojtFtkHxdVRo3zAB5SblunAtF8kxhvgRbTmC35n1fDOQyXqyPAB/NE7WMPBQvLg== X-Received: by 2002:a17:90b:1a86:: with SMTP id ng6mr21544427pjb.12.1607871107403; Sun, 13 Dec 2020 06:51:47 -0800 (PST) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id t1sm16439658pfg.212.2020.12.13.06.51.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Dec 2020 06:51:46 -0800 (PST) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id 7B6901A0156 for ; Sun, 13 Dec 2020 06:51:45 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] x86: Remove the default REP MOVSB threshold tunable value [BZ #27061] Date: Sun, 13 Dec 2020 06:51:43 -0800 Message-Id: <20201213145143.809557-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Spam-Status: No, score=-3040.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Since the default REP MOVSB threshold is 2048 * (vector size / 16), remove its default tunable value so that the correct default value will be set correctly by init_cacheinfo (). Reviewed-by: Carlos O'Donell --- sysdeps/x86/dl-tunables.list | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86/dl-tunables.list b/sysdeps/x86/dl-tunables.list index 1a4a93a070..348616fb69 100644 --- a/sysdeps/x86/dl-tunables.list +++ b/sysdeps/x86/dl-tunables.list @@ -39,9 +39,10 @@ glibc { # REP MOVSB. Since larger register size can move more data with a # single load and store, the threshold is higher with larger register # size. Note: Since the REP MOVSB threshold must be greater than 8 - # times of vector size, the minium value must be updated at run-time. + # times of vector size and the default value is 2048 * (vector size + # / 16), the default value and the minium value must be updated at + # run-time. minval: 1 - default: 2048 } x86_rep_stosb_threshold { type: SIZE_T