From patchwork Wed Dec 9 18:23:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 41349 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0C48396EC74; Wed, 9 Dec 2020 18:24:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0C48396EC74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607538264; bh=Qe9lszv0V17h8xDYlJrhwlx9ilXu+pqLtP6m7cQbQ6k=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PDkN301i3v0FZDlt/qNl8SdLLHDGhBupl1tavIDDnjJE0JCr5ugmm0N445h+M45mk 7k3hX5iXR6SZUt+G8gsszjqZY+abEVi8lDYYo1fQC9+NV4Mbej3rjde4dTii1X/Hvt T8tvADPFxp7LWznBBg9poXnkBTedhQebDY/Ejm+Y= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 9595F396EC74 for ; Wed, 9 Dec 2020 18:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9595F396EC74 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-Ax7dP_78NLelig7T0ut0xw-1; Wed, 09 Dec 2020 13:24:17 -0500 X-MC-Unique: Ax7dP_78NLelig7T0ut0xw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 838B19045C0 for ; Wed, 9 Dec 2020 18:23:39 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-115-2.ams2.redhat.com [10.36.115.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD9135D978 for ; Wed, 9 Dec 2020 18:23:38 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH] elf: Fix incorrect comparison in sort_priorities_by_name Date: Wed, 09 Dec 2020 19:23:37 +0100 Message-ID: <87360e6dp2.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Reported-By: Stefan Liebler --- elf/dl-hwcaps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-hwcaps.c b/elf/dl-hwcaps.c index 5a71f80154..000e3c0eb9 100644 --- a/elf/dl-hwcaps.c +++ b/elf/dl-hwcaps.c @@ -153,7 +153,7 @@ sort_priorities_by_name (void) else to_compare = previous->name_length; int cmp = memcmp (current->name, previous->name, to_compare); - if (cmp >= 0 + if (cmp > 0 || (cmp == 0 && current->name_length >= previous->name_length)) break;